root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

fixing TODOs 

git-svn-id: https://src.springframework.org/svn/spring-framework/trunk@68 50f2f4bb-b051-0410-bef5-90022cba6387
This commit is contained in:
Andy Clement 2008-08-17 01:25:43 +00:00
parent 6fa7cc5f92
commit e1d71a30fd
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardEvaluationContext.java
View File

@ -170,7 +170,7 @@ public class StandardEvaluationContext implements EvaluationContext {
rootObject = o; rootObject = o;
} }
// TODO 3 have a variant that adds at position (same for ctor/propOrField) // TODO have a variant that adds at position (same for ctor/propOrField)
public void addMethodResolver(MethodResolver resolver) { public void addMethodResolver(MethodResolver resolver) {
methodResolvers.add(resolver); methodResolvers.add(resolver);
} }

4
org.springframework.expression/src/main/java/org/springframework/expression/spel/standard/StandardTypeConverter.java
View File

@ -93,7 +93,7 @@ public class StandardTypeConverter implements TypeConverter {
return false; return false;
} }
// TODO 3 Q In case of a loss in information with coercion to a narrower type, should we throw an exception? // TODO In case of a loss in information with coercion to a narrower type, should we throw an exception?
public Object convertValue(Object value, Class<?> targetType) throws SpelException { public Object convertValue(Object value, Class<?> targetType) throws SpelException {
if (value == null || value.getClass() == targetType) if (value == null || value.getClass() == targetType)
return value; return value;
@ -201,7 +201,7 @@ public class StandardTypeConverter implements TypeConverter {
try { try {
Double.parseDouble((String) value); Double.parseDouble((String) value);
} catch (NumberFormatException nfe) { } catch (NumberFormatException nfe) {
// TODO 3 Q throw something or leave the caller to throw a conversion exception? // returning null will mean the caller throws a type conversion related exception
} }
} else if (value instanceof Integer) { } else if (value instanceof Integer) {
return new Double(((Integer) value).intValue()); return new Double(((Integer) value).intValue());