root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

Use constants when caching empty arrays 

Reduce cache memory consumption by using a single constant for empty
arrays.
This commit is contained in:
Phillip Webb 2015-11-09 09:38:48 -08:00
parent 760bc719f2
commit e6b1f0a139
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
spring-core/src/main/java/org/springframework/util/ReflectionUtils.java
View File

@ -51,6 +51,10 @@ public abstract class ReflectionUtils {
*/ */
private static final String CGLIB_RENAMED_METHOD_PREFIX = "CGLIB$"; private static final String CGLIB_RENAMED_METHOD_PREFIX = "CGLIB$";
private static final Method[] NO_METHODS = {};
private static final Field[] NO_FIELDS = {};
/** /**
* Cache for {@link Class#getDeclaredMethods()} plus equivalent default methods * Cache for {@link Class#getDeclaredMethods()} plus equivalent default methods
* from Java 8 based interfaces, allowing for fast iteration. * from Java 8 based interfaces, allowing for fast iteration.
@ -617,7 +621,7 @@ public abstract class ReflectionUtils {
else { else {
result = declaredMethods; result = declaredMethods;
} }
declaredMethodsCache.put(clazz, result); declaredMethodsCache.put(clazz, (result.length == 0 ? NO_METHODS : result));
} }
return result; return result;
} }
@ -705,7 +709,7 @@ public abstract class ReflectionUtils {
Field[] result = declaredFieldsCache.get(clazz); Field[] result = declaredFieldsCache.get(clazz);
if (result == null) { if (result == null) {
result = clazz.getDeclaredFields(); result = clazz.getDeclaredFields();
declaredFieldsCache.put(clazz, result); declaredFieldsCache.put(clazz, (result.length == 0 ? NO_FIELDS : result));
} }
return result; return result;
} }