root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

reuse a shared UrlPathHelper instance in order to avoid reinstantiation overhead (SPR-7269)

This commit is contained in:
Juergen Hoeller 2010-06-08 14:14:08 +00:00
parent e12fbd3e2b
commit eb3a3a6de2
1 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
org.springframework.web.servlet/src/main/java/org/springframework/web/servlet/DispatcherServlet.java
View File

@ -198,14 +198,17 @@ public class DispatcherServlet extends FrameworkServlet {
public static final String PAGE_NOT_FOUND_LOG_CATEGORY = "org.springframework.web.servlet.PageNotFound"; public static final String PAGE_NOT_FOUND_LOG_CATEGORY = "org.springframework.web.servlet.PageNotFound";
/** /**
* Name of the class path resource (relative to the DispatcherServlet class) that defines DispatcherServlet's default * Name of the class path resource (relative to the DispatcherServlet class)
* strategy names. * that defines DispatcherServlet's default strategy names.
*/ */
private static final String DEFAULT_STRATEGIES_PATH = "DispatcherServlet.properties"; private static final String DEFAULT_STRATEGIES_PATH = "DispatcherServlet.properties";
/** Additional logger to use when no mapped handler is found for a request. */ /** Additional logger to use when no mapped handler is found for a request. */
protected static final Log pageNotFoundLogger = LogFactory.getLog(PAGE_NOT_FOUND_LOG_CATEGORY); protected static final Log pageNotFoundLogger = LogFactory.getLog(PAGE_NOT_FOUND_LOG_CATEGORY);
private static final UrlPathHelper urlPathHelper = new UrlPathHelper();
private static final Properties defaultStrategies; private static final Properties defaultStrategies;
static { static {
@ -686,7 +689,7 @@ public class DispatcherServlet extends FrameworkServlet {
@Override @Override
protected void doService(HttpServletRequest request, HttpServletResponse response) throws Exception { protected void doService(HttpServletRequest request, HttpServletResponse response) throws Exception {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
String requestUri = new UrlPathHelper().getRequestUri(request); String requestUri = urlPathHelper.getRequestUri(request);
logger.debug("DispatcherServlet with name '" + getServletName() + "' processing " + request.getMethod() + logger.debug("DispatcherServlet with name '" + getServletName() + "' processing " + request.getMethod() +
" request for [" + requestUri + "]"); " request for [" + requestUri + "]");
} }
@ -838,7 +841,7 @@ public class DispatcherServlet extends FrameworkServlet {
@Override @Override
protected long getLastModified(HttpServletRequest request) { protected long getLastModified(HttpServletRequest request) {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
String requestUri = new UrlPathHelper().getRequestUri(request); String requestUri = urlPathHelper.getRequestUri(request);
logger.debug( logger.debug(
"DispatcherServlet with name '" + getServletName() + "' determining Last-Modified value for [" + "DispatcherServlet with name '" + getServletName() + "' determining Last-Modified value for [" +
requestUri + "]"); requestUri + "]");
@ -854,7 +857,7 @@ public class DispatcherServlet extends FrameworkServlet {
HandlerAdapter ha = getHandlerAdapter(mappedHandler.getHandler()); HandlerAdapter ha = getHandlerAdapter(mappedHandler.getHandler());
long lastModified = ha.getLastModified(request, mappedHandler.getHandler()); long lastModified = ha.getLastModified(request, mappedHandler.getHandler());
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
String requestUri = new UrlPathHelper().getRequestUri(request); String requestUri = urlPathHelper.getRequestUri(request);
logger.debug("Last-Modified value for [" + requestUri + "] is: " + lastModified); logger.debug("Last-Modified value for [" + requestUri + "] is: " + lastModified);
} }
return lastModified; return lastModified;
@ -958,7 +961,7 @@ public class DispatcherServlet extends FrameworkServlet {
*/ */
protected void noHandlerFound(HttpServletRequest request, HttpServletResponse response) throws Exception { protected void noHandlerFound(HttpServletRequest request, HttpServletResponse response) throws Exception {
if (pageNotFoundLogger.isWarnEnabled()) { if (pageNotFoundLogger.isWarnEnabled()) {
String requestUri = new UrlPathHelper().getRequestUri(request); String requestUri = urlPathHelper.getRequestUri(request);
pageNotFoundLogger.warn("No mapping found for HTTP request with URI [" + requestUri + pageNotFoundLogger.warn("No mapping found for HTTP request with URI [" + requestUri +
"] in DispatcherServlet with name '" + getServletName() + "'"); "] in DispatcherServlet with name '" + getServletName() + "'");
} }