root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

Merge pull request #30157 from srivatsa-cfp:main 

* gh-30157:
  Add non-null assertions in DefaultServerResponseBuilder
This commit is contained in:
Arjen Poutsma 2023-04-04 12:42:39 +02:00
parent 69c8f8e9c7 6c8ebc7f7e
commit f0eb43a6af
2 changed files with 13 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
spring-webflux/src/main/java/org/springframework/web/reactive/function/server/DefaultServerResponseBuilder.java
View File

@ -91,6 +91,7 @@ class DefaultServerResponseBuilder implements ServerResponse.BodyBuilder {
@Override @Override
public ServerResponse.BodyBuilder header(String headerName, String... headerValues) { public ServerResponse.BodyBuilder header(String headerName, String... headerValues) {
Assert.notNull(headerName, "HeaderName must not be null");
for (String headerValue : headerValues) { for (String headerValue : headerValues) {
this.headers.add(headerName, headerValue); this.headers.add(headerName, headerValue);
} }
@ -99,6 +100,7 @@ class DefaultServerResponseBuilder implements ServerResponse.BodyBuilder {
@Override @Override
public ServerResponse.BodyBuilder headers(Consumer<HttpHeaders> headersConsumer) { public ServerResponse.BodyBuilder headers(Consumer<HttpHeaders> headersConsumer) {
Assert.notNull(headersConsumer, "HeadersConsumer must not be null");
headersConsumer.accept(this.headers); headersConsumer.accept(this.headers);
return this; return this;
} }
@ -112,18 +114,21 @@ class DefaultServerResponseBuilder implements ServerResponse.BodyBuilder {
@Override @Override
public ServerResponse.BodyBuilder cookies(Consumer<MultiValueMap<String, ResponseCookie>> cookiesConsumer) { public ServerResponse.BodyBuilder cookies(Consumer<MultiValueMap<String, ResponseCookie>> cookiesConsumer) {
Assert.notNull(cookiesConsumer, "CookiesConsumer must not be null");
cookiesConsumer.accept(this.cookies); cookiesConsumer.accept(this.cookies);
return this; return this;
} }
@Override @Override
public ServerResponse.BodyBuilder allow(HttpMethod... allowedMethods) { public ServerResponse.BodyBuilder allow(HttpMethod... allowedMethods) {
Assert.notNull(allowedMethods, "Http allowedMethod must not be null");
this.headers.setAllow(new LinkedHashSet<>(Arrays.asList(allowedMethods))); this.headers.setAllow(new LinkedHashSet<>(Arrays.asList(allowedMethods)));
return this; return this;
} }
@Override @Override
public ServerResponse.BodyBuilder allow(Set<HttpMethod> allowedMethods) { public ServerResponse.BodyBuilder allow(Set<HttpMethod> allowedMethods) {
Assert.notNull(allowedMethods, "Http allowedMethod must not be null");
this.headers.setAllow(allowedMethods); this.headers.setAllow(allowedMethods);
return this; return this;
} }
@ -142,6 +147,7 @@ class DefaultServerResponseBuilder implements ServerResponse.BodyBuilder {
@Override @Override
public ServerResponse.BodyBuilder eTag(String etag) { public ServerResponse.BodyBuilder eTag(String etag) {
Assert.notNull(etag, "etag must not be null");
if (!etag.startsWith("\"") && !etag.startsWith("W/\"")) { if (!etag.startsWith("\"") && !etag.startsWith("W/\"")) {
etag = "\"" + etag; etag = "\"" + etag;
} }

7
spring-webmvc/src/main/java/org/springframework/web/servlet/function/DefaultServerResponseBuilder.java
View File

@ -70,6 +70,7 @@ class DefaultServerResponseBuilder implements ServerResponse.BodyBuilder {
@Override @Override
public ServerResponse.BodyBuilder header(String headerName, String... headerValues) { public ServerResponse.BodyBuilder header(String headerName, String... headerValues) {
Assert.notNull(headerName, "HeaderName must not be null");
for (String headerValue : headerValues) { for (String headerValue : headerValues) {
this.headers.add(headerName, headerValue); this.headers.add(headerName, headerValue);
} }
@ -78,6 +79,7 @@ class DefaultServerResponseBuilder implements ServerResponse.BodyBuilder {
@Override @Override
public ServerResponse.BodyBuilder headers(Consumer<HttpHeaders> headersConsumer) { public ServerResponse.BodyBuilder headers(Consumer<HttpHeaders> headersConsumer) {
Assert.notNull(headersConsumer, "HeaderConsumer must not be null");
headersConsumer.accept(this.headers); headersConsumer.accept(this.headers);
return this; return this;
} }
@ -91,18 +93,21 @@ class DefaultServerResponseBuilder implements ServerResponse.BodyBuilder {
@Override @Override
public ServerResponse.BodyBuilder cookies(Consumer<MultiValueMap<String, Cookie>> cookiesConsumer) { public ServerResponse.BodyBuilder cookies(Consumer<MultiValueMap<String, Cookie>> cookiesConsumer) {
Assert.notNull(cookiesConsumer, "CookiesConsumer must not be null");
cookiesConsumer.accept(this.cookies); cookiesConsumer.accept(this.cookies);
return this; return this;
} }
@Override @Override
public ServerResponse.BodyBuilder allow(HttpMethod... allowedMethods) { public ServerResponse.BodyBuilder allow(HttpMethod... allowedMethods) {
Assert.notNull(allowedMethods, "Http AllowedMethods must not be null");
this.headers.setAllow(new LinkedHashSet<>(Arrays.asList(allowedMethods))); this.headers.setAllow(new LinkedHashSet<>(Arrays.asList(allowedMethods)));
return this; return this;
} }
@Override @Override
public ServerResponse.BodyBuilder allow(Set<HttpMethod> allowedMethods) { public ServerResponse.BodyBuilder allow(Set<HttpMethod> allowedMethods) {
Assert.notNull(allowedMethods, "Http AllowedMethods must not be null");
this.headers.setAllow(allowedMethods); this.headers.setAllow(allowedMethods);
return this; return this;
} }
@ -115,12 +120,14 @@ class DefaultServerResponseBuilder implements ServerResponse.BodyBuilder {
@Override @Override
public ServerResponse.BodyBuilder contentType(MediaType contentType) { public ServerResponse.BodyBuilder contentType(MediaType contentType) {
Assert.notNull(contentType, "ContentType must not be null");
this.headers.setContentType(contentType); this.headers.setContentType(contentType);
return this; return this;
} }
@Override @Override
public ServerResponse.BodyBuilder eTag(String etag) { public ServerResponse.BodyBuilder eTag(String etag) {
Assert.notNull(etag, "etag must not be null");
if (!etag.startsWith("\"") && !etag.startsWith("W/\"")) { if (!etag.startsWith("\"") && !etag.startsWith("W/\"")) {
etag = "\"" + etag; etag = "\"" + etag;
} }