root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions Packages Projects Releases Wiki Activity

MutablePropertySources log statements guarded by isDebugEnabled 

Issue: SPR-9670
This commit is contained in:
Juergen Hoeller 2012-09-10 11:05:53 +02:00 committed by unknown
parent a90f25668b
commit f29b791c85
1 changed files with 23 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
spring-core/src/main/java/org/springframework/core/env/MutablePropertySources.java vendored
View File

@ -91,8 +91,10 @@ public class MutablePropertySources implements PropertySources {
* Add the given property source object with highest precedence. * Add the given property source object with highest precedence.
*/ */
public void addFirst(PropertySource<?> propertySource) { public void addFirst(PropertySource<?> propertySource) {
logger.debug(String.format("Adding [%s] PropertySource with highest search precedence", if (logger.isDebugEnabled()) {
propertySource.getName())); logger.debug(String.format("Adding [%s] PropertySource with highest search precedence",
propertySource.getName()));
}
removeIfPresent(propertySource); removeIfPresent(propertySource);
this.propertySourceList.addFirst(propertySource); this.propertySourceList.addFirst(propertySource);
} }
@ -101,8 +103,10 @@ public class MutablePropertySources implements PropertySources {
* Add the given property source object with lowest precedence. * Add the given property source object with lowest precedence.
*/ */
public void addLast(PropertySource<?> propertySource) { public void addLast(PropertySource<?> propertySource) {
logger.debug(String.format("Adding [%s] PropertySource with lowest search precedence", if (logger.isDebugEnabled()) {
propertySource.getName())); logger.debug(String.format("Adding [%s] PropertySource with lowest search precedence",
propertySource.getName()));
}
removeIfPresent(propertySource); removeIfPresent(propertySource);
this.propertySourceList.addLast(propertySource); this.propertySourceList.addLast(propertySource);
} }
@ -112,8 +116,10 @@ public class MutablePropertySources implements PropertySources {
* than the named relative property source. * than the named relative property source.
*/ */
public void addBefore(String relativePropertySourceName, PropertySource<?> propertySource) { public void addBefore(String relativePropertySourceName, PropertySource<?> propertySource) {
logger.debug(String.format("Adding [%s] PropertySource with search precedence immediately higher than [%s]", if (logger.isDebugEnabled()) {
propertySource.getName(), relativePropertySourceName)); logger.debug(String.format("Adding [%s] PropertySource with search precedence immediately higher than [%s]",
propertySource.getName(), relativePropertySourceName));
}
assertLegalRelativeAddition(relativePropertySourceName, propertySource); assertLegalRelativeAddition(relativePropertySourceName, propertySource);
removeIfPresent(propertySource); removeIfPresent(propertySource);
int index = assertPresentAndGetIndex(relativePropertySourceName); int index = assertPresentAndGetIndex(relativePropertySourceName);
@ -125,8 +131,10 @@ public class MutablePropertySources implements PropertySources {
* than the named relative property source. * than the named relative property source.
*/ */
public void addAfter(String relativePropertySourceName, PropertySource<?> propertySource) { public void addAfter(String relativePropertySourceName, PropertySource<?> propertySource) {
logger.debug(String.format("Adding [%s] PropertySource with search precedence immediately lower than [%s]", if (logger.isDebugEnabled()) {
propertySource.getName(), relativePropertySourceName)); logger.debug(String.format("Adding [%s] PropertySource with search precedence immediately lower than [%s]",
propertySource.getName(), relativePropertySourceName));
}
assertLegalRelativeAddition(relativePropertySourceName, propertySource); assertLegalRelativeAddition(relativePropertySourceName, propertySource);
removeIfPresent(propertySource); removeIfPresent(propertySource);
int index = assertPresentAndGetIndex(relativePropertySourceName); int index = assertPresentAndGetIndex(relativePropertySourceName);
@ -145,7 +153,9 @@ public class MutablePropertySources implements PropertySources {
* @param name the name of the property source to find and remove * @param name the name of the property source to find and remove
*/ */
public PropertySource<?> remove(String name) { public PropertySource<?> remove(String name) {
logger.debug(String.format("Removing [%s] PropertySource", name)); if (logger.isDebugEnabled()) {
logger.debug(String.format("Removing [%s] PropertySource", name));
}
int index = this.propertySourceList.indexOf(PropertySource.named(name)); int index = this.propertySourceList.indexOf(PropertySource.named(name));
return index == -1 ? null : this.propertySourceList.remove(index); return index == -1 ? null : this.propertySourceList.remove(index);
} }
@ -158,8 +168,10 @@ public class MutablePropertySources implements PropertySources {
* @see #contains * @see #contains
*/ */
public void replace(String name, PropertySource<?> propertySource) { public void replace(String name, PropertySource<?> propertySource) {
logger.debug(String.format("Replacing [%s] PropertySource with [%s]", if (logger.isDebugEnabled()) {
name, propertySource.getName())); logger.debug(String.format("Replacing [%s] PropertySource with [%s]",
name, propertySource.getName()));
}
int index = assertPresentAndGetIndex(name); int index = assertPresentAndGetIndex(name);
this.propertySourceList.set(index, propertySource); this.propertySourceList.set(index, propertySource);
} }