root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 2 Packages Projects Releases Wiki Activity

Optimize find[Getter|Setter]ForProperty() in ReflectivePropertyAccessor

This commit is contained in:
Sam Brannen 2023-03-06 14:38:17 +01:00
parent 74f6725a37
commit f3cb331e4e
1 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectivePropertyAccessor.java
View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2022 the original author or authors. * Copyright 2002-2023 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -349,9 +349,11 @@ public class ReflectivePropertyAccessor implements PropertyAccessor {
@Nullable @Nullable
private Method findGetterForProperty(String propertyName, Class<?> clazz, Object target) { private Method findGetterForProperty(String propertyName, Class<?> clazz, Object target) {
Method method = findGetterForProperty(propertyName, clazz, target instanceof Class); boolean targetIsaClass = (target instanceof Class);
if (method == null && target instanceof Class) { Method method = findGetterForProperty(propertyName, clazz, targetIsaClass);
method = findGetterForProperty(propertyName, target.getClass(), false); if (method == null && targetIsaClass) {
// Fallback for getter instance methods in java.lang.Class.
method = findGetterForProperty(propertyName, Class.class, false);
} }
return method; return method;
} }
@ -359,9 +361,8 @@ public class ReflectivePropertyAccessor implements PropertyAccessor {
@Nullable @Nullable
private Method findSetterForProperty(String propertyName, Class<?> clazz, Object target) { private Method findSetterForProperty(String propertyName, Class<?> clazz, Object target) {
Method method = findSetterForProperty(propertyName, clazz, target instanceof Class); Method method = findSetterForProperty(propertyName, clazz, target instanceof Class);
if (method == null && target instanceof Class) { // In contrast to findGetterForProperty(), we do not look for setters in
method = findSetterForProperty(propertyName, target.getClass(), false); // java.lang.Class as a fallback, since Class doesn't have any public setters.
}
return method; return method;
} }