Merge pull request #34 from marschall/warnings

* warnings:
  Fix compiler warnings
This commit is contained in:
Chris Beams 2012-05-17 14:38:49 +03:00
commit f667db56b1
11 changed files with 12 additions and 30 deletions

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2009 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -93,7 +93,6 @@ public class ProxyFactory extends ProxyCreatorSupport {
* (if necessary for proxy creation). * (if necessary for proxy creation).
* @return the proxy object * @return the proxy object
*/ */
@SuppressWarnings("unchecked")
public Object getProxy() { public Object getProxy() {
return createAopProxy().getProxy(); return createAopProxy().getProxy();
} }
@ -107,7 +106,6 @@ public class ProxyFactory extends ProxyCreatorSupport {
* (or <code>null</code> for the low-level proxy facility's default) * (or <code>null</code> for the low-level proxy facility's default)
* @return the proxy object * @return the proxy object
*/ */
@SuppressWarnings("unchecked")
public Object getProxy(ClassLoader classLoader) { public Object getProxy(ClassLoader classLoader) {
return createAopProxy().getProxy(classLoader); return createAopProxy().getProxy(classLoader);
} }

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2011 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -59,7 +59,6 @@ public class DestructionAwareAttributeHolder implements Serializable {
* the name of the attribute to be returned * the name of the attribute to be returned
* @return the attribute value or <code>null</code> if not available * @return the attribute value or <code>null</code> if not available
*/ */
@SuppressWarnings("unchecked")
public Object getAttribute(String name) { public Object getAttribute(String name) {
return attributes.get(name); return attributes.get(name);
} }
@ -75,7 +74,6 @@ public class DestructionAwareAttributeHolder implements Serializable {
* @return any previously object stored under the same name, if any, * @return any previously object stored under the same name, if any,
* <code>null</code> otherwise * <code>null</code> otherwise
*/ */
@SuppressWarnings("unchecked")
public Object setAttribute(String name, Object value) { public Object setAttribute(String name, Object value) {
return attributes.put(name, value); return attributes.put(name, value);
} }
@ -101,7 +99,6 @@ public class DestructionAwareAttributeHolder implements Serializable {
* @return the removed object, or <code>null</code> if no object was present * @return the removed object, or <code>null</code> if no object was present
* @see #registerDestructionCallback * @see #registerDestructionCallback
*/ */
@SuppressWarnings("unchecked")
public Object removeAttribute(String name) { public Object removeAttribute(String name) {
Object value = attributes.remove(name); Object value = attributes.remove(name);

View File

@ -168,7 +168,6 @@ public class JobDetailFactoryBean
} }
@SuppressWarnings("unchecked")
public void afterPropertiesSet() { public void afterPropertiesSet() {
if (this.name == null) { if (this.name == null) {
this.name = this.beanName; this.name = this.beanName;
@ -196,7 +195,7 @@ public class JobDetailFactoryBean
this.jobDetail = jdi; this.jobDetail = jdi;
*/ */
Class jobDetailClass; Class<?> jobDetailClass;
try { try {
jobDetailClass = getClass().getClassLoader().loadClass("org.quartz.impl.JobDetailImpl"); jobDetailClass = getClass().getClassLoader().loadClass("org.quartz.impl.JobDetailImpl");
} }

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2009 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -88,7 +88,6 @@ public class SourceFilteringListener implements SmartApplicationListener {
* <p>The default implementation invokes the specified delegate, if any. * <p>The default implementation invokes the specified delegate, if any.
* @param event the event to process (matching the specified source) * @param event the event to process (matching the specified source)
*/ */
@SuppressWarnings("unchecked")
protected void onApplicationEventInternal(ApplicationEvent event) { protected void onApplicationEventInternal(ApplicationEvent event) {
if (this.delegate == null) { if (this.delegate == null) {
throw new IllegalStateException( throw new IllegalStateException(

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2011 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -91,12 +91,11 @@ class WebSphereClassLoaderAdapter {
} }
} }
@SuppressWarnings("unchecked")
public ClassLoader getThrowawayClassLoader() { public ClassLoader getThrowawayClassLoader() {
try { try {
ClassLoader loader = (ClassLoader) cloneConstructor.newInstance(getClassLoader()); ClassLoader loader = (ClassLoader) cloneConstructor.newInstance(getClassLoader());
// clear out the transformers (copied as well) // clear out the transformers (copied as well)
List list = (List) transformerList.get(loader); List<?> list = (List<?>) transformerList.get(loader);
list.clear(); list.clear();
return loader; return loader;
} }

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2011 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -20,7 +20,7 @@ import org.springframework.aop.framework.AbstractSingletonProxyFactoryBean;
import org.springframework.beans.factory.BeanFactory; import org.springframework.beans.factory.BeanFactory;
import org.springframework.beans.factory.BeanFactoryAware; import org.springframework.beans.factory.BeanFactoryAware;
@SuppressWarnings({ "serial", "deprecation" }) @SuppressWarnings("serial")
public class TestProxyFactoryBean extends AbstractSingletonProxyFactoryBean implements BeanFactoryAware { public class TestProxyFactoryBean extends AbstractSingletonProxyFactoryBean implements BeanFactoryAware {
@Override @Override

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2010 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -77,7 +77,6 @@ public class LocalVariableTableParameterNameDiscoverer implements ParameterNameD
return null; return null;
} }
@SuppressWarnings("unchecked")
public String[] getParameterNames(Constructor ctor) { public String[] getParameterNames(Constructor ctor) {
Class<?> declaringClass = ctor.getDeclaringClass(); Class<?> declaringClass = ctor.getDeclaringClass();
Map<Member, String[]> map = this.parameterNamesCache.get(declaringClass); Map<Member, String[]> map = this.parameterNamesCache.get(declaringClass);

View File

@ -281,7 +281,6 @@ public class MethodParameter {
* @param annotationType the annotation type to look for * @param annotationType the annotation type to look for
* @return the annotation object, or <code>null</code> if not found * @return the annotation object, or <code>null</code> if not found
*/ */
@SuppressWarnings("unchecked")
public <T extends Annotation> T getMethodAnnotation(Class<T> annotationType) { public <T extends Annotation> T getMethodAnnotation(Class<T> annotationType) {
return getAnnotatedElement().getAnnotation(annotationType); return getAnnotatedElement().getAnnotation(annotationType);
} }

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2009 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -67,7 +67,6 @@ public class ColumnMapRowMapper implements RowMapper<Map<String, Object>> {
* @return the new Map instance * @return the new Map instance
* @see org.springframework.util.LinkedCaseInsensitiveMap * @see org.springframework.util.LinkedCaseInsensitiveMap
*/ */
@SuppressWarnings("unchecked")
protected Map<String, Object> createColumnMap(int columnCount) { protected Map<String, Object> createColumnMap(int columnCount) {
return new LinkedCaseInsensitiveMap<Object>(columnCount); return new LinkedCaseInsensitiveMap<Object>(columnCount);
} }

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2009 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -159,7 +159,6 @@ public class ServletRequestAttributes extends AbstractRequestAttributes {
} }
} }
@SuppressWarnings("unchecked")
public String[] getAttributeNames(int scope) { public String[] getAttributeNames(int scope) {
if (scope == SCOPE_REQUEST) { if (scope == SCOPE_REQUEST) {
if (!isRequestActive()) { if (!isRequestActive()) {

View File

@ -1,5 +1,5 @@
/* /*
* Copyright 2002-2011 the original author or authors. * Copyright 2002-2012 the original author or authors.
* *
* Licensed under the Apache License, Version 2.0 (the "License"); * Licensed under the Apache License, Version 2.0 (the "License");
* you may not use this file except in compliance with the License. * you may not use this file except in compliance with the License.
@ -87,12 +87,10 @@ public class ServletWebRequest extends ServletRequestAttributes implements Nativ
return getResponse(); return getResponse();
} }
@SuppressWarnings("unchecked")
public <T> T getNativeRequest(Class<T> requiredType) { public <T> T getNativeRequest(Class<T> requiredType) {
return WebUtils.getNativeRequest(getRequest(), requiredType); return WebUtils.getNativeRequest(getRequest(), requiredType);
} }
@SuppressWarnings("unchecked")
public <T> T getNativeResponse(Class<T> requiredType) { public <T> T getNativeResponse(Class<T> requiredType) {
return WebUtils.getNativeResponse(getResponse(), requiredType); return WebUtils.getNativeResponse(getResponse(), requiredType);
} }
@ -102,13 +100,11 @@ public class ServletWebRequest extends ServletRequestAttributes implements Nativ
return getRequest().getHeader(headerName); return getRequest().getHeader(headerName);
} }
@SuppressWarnings("unchecked")
public String[] getHeaderValues(String headerName) { public String[] getHeaderValues(String headerName) {
String[] headerValues = StringUtils.toStringArray(getRequest().getHeaders(headerName)); String[] headerValues = StringUtils.toStringArray(getRequest().getHeaders(headerName));
return (!ObjectUtils.isEmpty(headerValues) ? headerValues : null); return (!ObjectUtils.isEmpty(headerValues) ? headerValues : null);
} }
@SuppressWarnings("unchecked")
public Iterator<String> getHeaderNames() { public Iterator<String> getHeaderNames() {
return CollectionUtils.toIterator(getRequest().getHeaderNames()); return CollectionUtils.toIterator(getRequest().getHeaderNames());
} }
@ -121,12 +117,10 @@ public class ServletWebRequest extends ServletRequestAttributes implements Nativ
return getRequest().getParameterValues(paramName); return getRequest().getParameterValues(paramName);
} }
@SuppressWarnings("unchecked")
public Iterator<String> getParameterNames() { public Iterator<String> getParameterNames() {
return CollectionUtils.toIterator(getRequest().getParameterNames()); return CollectionUtils.toIterator(getRequest().getParameterNames());
} }
@SuppressWarnings("unchecked")
public Map<String, String[]> getParameterMap() { public Map<String, String[]> getParameterMap() {
return getRequest().getParameterMap(); return getRequest().getParameterMap();
} }