root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

PropertySourcesPropertyResolver does not log retrieved value by default 

Issue: SPR-14709
This commit is contained in:
Juergen Hoeller 2016-09-13 23:43:52 +02:00
parent 55c37d2a57
commit fbe7ddb640
1 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
spring-core/src/main/java/org/springframework/core/env/PropertySourcesPropertyResolver.java vendored
View File

@ -137,8 +137,10 @@ public class PropertySourcesPropertyResolver extends AbstractPropertyResolver {
/** /**
* Log the given key as found in the given {@link PropertySource}, resulting in * Log the given key as found in the given {@link PropertySource}, resulting in
* the given value. * the given value.
* <p>The default implementation writes a debug log message, including the value. * <p>The default implementation writes a debug log message with key and source.
* Subclasses may override this to change the log level and/or the log message. * As of 4.3.3, this does not log the value anymore in order to avoid accidental
* logging of sensitive settings. Subclasses may override this method to change
* the log level and/or log message, including the property's value if desired.
* @param key the key found * @param key the key found
* @param propertySource the {@code PropertySource} that the key has been found in * @param propertySource the {@code PropertySource} that the key has been found in
* @param value the corresponding value * @param value the corresponding value
@ -146,8 +148,8 @@ public class PropertySourcesPropertyResolver extends AbstractPropertyResolver {
*/ */
protected void logKeyFound(String key, PropertySource<?> propertySource, Object value) { protected void logKeyFound(String key, PropertySource<?> propertySource, Object value) {
if (logger.isDebugEnabled()) { if (logger.isDebugEnabled()) {
logger.debug(String.format("Found key '%s' in [%s] with type [%s] and value '%s'", logger.debug(String.format("Found key '%s' in [%s] with type [%s]",
key, propertySource.getName(), value.getClass().getSimpleName(), value)); key, propertySource.getName(), value.getClass().getSimpleName()));
} }
} }