root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Disable equals in JsonPath~ and XPathAssertions 

Issue: SPR-17091
This commit is contained in:
Rossen Stoyanchev 2018-07-27 08:14:07 -04:00
parent f5ff1dc3f9
commit fcbf06f050
2 changed files with 14 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
spring-test/src/main/java/org/springframework/test/web/reactive/server/JsonPathAssertions.java
View File

@ -176,4 +176,11 @@ public class JsonPathAssertions {
return this.bodySpec; return this.bodySpec;
} }
@Override
public boolean equals(Object obj) {
throw new AssertionError("Object#equals is disabled " +
"to avoid being used in error instead of JsonPathAssertions#isEqualTo(String).");
}
} }

8
spring-test/src/main/java/org/springframework/test/web/reactive/server/XpathAssertions.java
View File

@ -163,7 +163,6 @@ public class XpathAssertions {
}); });
} }
private WebTestClient.BodyContentSpec assertWith(CheckedExceptionTask task) { private WebTestClient.BodyContentSpec assertWith(CheckedExceptionTask task) {
try { try {
task.run(); task.run();
@ -190,6 +189,13 @@ public class XpathAssertions {
} }
@Override
public boolean equals(Object obj) {
throw new AssertionError("Object#equals is disabled " +
"to avoid being used in error instead of XPathAssertions#isEqualTo(String).");
}
/** /**
* Lets us be able to use lambda expressions that could throw checked exceptions, since * Lets us be able to use lambda expressions that could throw checked exceptions, since
* {@link XpathExpectationsHelper} throws {@link Exception} on its methods. * {@link XpathExpectationsHelper} throws {@link Exception} on its methods.