root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 8 Packages Projects Releases Wiki Activity

Polish ReflectionUtils 

This commit removes dead code in ReflectionUtils and improves the
exception message for field access errors.
This commit is contained in:
Sam Brannen 2019-09-21 15:29:03 +02:00
parent 4882dfcc0d
commit fccdb8cf60
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
spring-core/src/main/java/org/springframework/util/ReflectionUtils.java
View File

@ -90,8 +90,9 @@ public abstract class ReflectionUtils {
// Exception handling // Exception handling
/** /**
* Handle the given reflection exception. Should only be called if no * Handle the given reflection exception.
* checked exception is expected to be thrown by the target method. * <p>Should only be called if no checked exception is expected to be thrown
* by a target method, or if an error occurs while accessing a method or field.
* <p>Throws the underlying RuntimeException or Error in case of an * <p>Throws the underlying RuntimeException or Error in case of an
* InvocationTargetException with such a root cause. Throws an * InvocationTargetException with such a root cause. Throws an
* IllegalStateException with an appropriate message or * IllegalStateException with an appropriate message or
@ -103,7 +104,7 @@ public abstract class ReflectionUtils {
throw new IllegalStateException("Method not found: " + ex.getMessage()); throw new IllegalStateException("Method not found: " + ex.getMessage());
} }
if (ex instanceof IllegalAccessException) { if (ex instanceof IllegalAccessException) {
throw new IllegalStateException("Could not access method: " + ex.getMessage()); throw new IllegalStateException("Could not access method or field: " + ex.getMessage());
} }
if (ex instanceof InvocationTargetException) { if (ex instanceof InvocationTargetException) {
handleInvocationTargetException((InvocationTargetException) ex); handleInvocationTargetException((InvocationTargetException) ex);
@ -622,8 +623,6 @@ public abstract class ReflectionUtils {
} }
catch (IllegalAccessException ex) { catch (IllegalAccessException ex) {
handleReflectionException(ex); handleReflectionException(ex);
throw new IllegalStateException(
"Unexpected reflection exception - " + ex.getClass().getName() + ": " + ex.getMessage());
} }
} }
@ -644,9 +643,8 @@ public abstract class ReflectionUtils {
} }
catch (IllegalAccessException ex) { catch (IllegalAccessException ex) {
handleReflectionException(ex); handleReflectionException(ex);
throw new IllegalStateException(
"Unexpected reflection exception - " + ex.getClass().getName() + ": " + ex.getMessage());
} }
throw new IllegalStateException("Should never get here");
} }
/** /**