diff --git a/spring-beans/src/main/java/org/springframework/beans/factory/xml/BeanDefinitionParserDelegate.java b/spring-beans/src/main/java/org/springframework/beans/factory/xml/BeanDefinitionParserDelegate.java index d8e34b3cbad..4fd5ccdd601 100644 --- a/spring-beans/src/main/java/org/springframework/beans/factory/xml/BeanDefinitionParserDelegate.java +++ b/spring-beans/src/main/java/org/springframework/beans/factory/xml/BeanDefinitionParserDelegate.java @@ -643,6 +643,9 @@ public class BeanDefinitionParserDelegate { parentName, className, this.readerContext.getBeanClassLoader()); } + /** + * Parse the meta elements underneath the given element, if any. + */ public void parseMetaElements(Element ele, BeanMetadataAttributeAccessor attributeAccessor) { NodeList nl = ele.getChildNodes(); for (int i = 0; i < nl.getLength(); i++) { @@ -658,23 +661,27 @@ public class BeanDefinitionParserDelegate { } } + /** + * Parse the given autowire attribute value into + * {@link AbstractBeanDefinition} autowire constants. + */ @SuppressWarnings("deprecation") - public int getAutowireMode(String attValue) { - String att = attValue; - if (isDefaultValue(att)) { - att = this.defaults.getAutowire(); + public int getAutowireMode(String attrValue) { + String attr = attrValue; + if (isDefaultValue(attr)) { + attr = this.defaults.getAutowire(); } int autowire = AbstractBeanDefinition.AUTOWIRE_NO; - if (AUTOWIRE_BY_NAME_VALUE.equals(att)) { + if (AUTOWIRE_BY_NAME_VALUE.equals(attr)) { autowire = AbstractBeanDefinition.AUTOWIRE_BY_NAME; } - else if (AUTOWIRE_BY_TYPE_VALUE.equals(att)) { + else if (AUTOWIRE_BY_TYPE_VALUE.equals(attr)) { autowire = AbstractBeanDefinition.AUTOWIRE_BY_TYPE; } - else if (AUTOWIRE_CONSTRUCTOR_VALUE.equals(att)) { + else if (AUTOWIRE_CONSTRUCTOR_VALUE.equals(attr)) { autowire = AbstractBeanDefinition.AUTOWIRE_CONSTRUCTOR; } - else if (AUTOWIRE_AUTODETECT_VALUE.equals(att)) { + else if (AUTOWIRE_AUTODETECT_VALUE.equals(attr)) { autowire = AbstractBeanDefinition.AUTOWIRE_AUTODETECT; } // Else leave default value. @@ -953,6 +960,12 @@ public class BeanDefinitionParserDelegate { } } + /** + * Parse a value, ref or collection sub-element of a property or + * constructor-arg element. + * @param ele subelement of property element; we don't know which yet + * @param bd the current bean definition (if any) + */ @Nullable public Object parsePropertySubElement(Element ele, @Nullable BeanDefinition bd) { return parsePropertySubElement(ele, bd, null); @@ -962,6 +975,7 @@ public class BeanDefinitionParserDelegate { * Parse a value, ref or collection sub-element of a property or * constructor-arg element. * @param ele subelement of property element; we don't know which yet + * @param bd the current bean definition (if any) * @param defaultValueType the default type (class name) for any * {@code } tag that might be created */ @@ -1347,11 +1361,22 @@ public class BeanDefinitionParserDelegate { return TRUE_VALUE.equals(value); } + /** + * Parse a custom element (outside of the default namespace). + * @param ele the element to parse + * @return the resulting bean definition + */ @Nullable public BeanDefinition parseCustomElement(Element ele) { return parseCustomElement(ele, null); } + /** + * Parse a custom element (outside of the default namespace). + * @param ele the element to parse + * @param containingBd the containing bean definition (if any) + * @return the resulting bean definition + */ @Nullable public BeanDefinition parseCustomElement(Element ele, @Nullable BeanDefinition containingBd) { String namespaceUri = getNamespaceURI(ele); @@ -1366,14 +1391,27 @@ public class BeanDefinitionParserDelegate { return handler.parse(ele, new ParserContext(this.readerContext, this, containingBd)); } - public BeanDefinitionHolder decorateBeanDefinitionIfRequired(Element ele, BeanDefinitionHolder definitionHolder) { - return decorateBeanDefinitionIfRequired(ele, definitionHolder, null); + /** + * Decorate the given bean definition through a namespace handler, if applicable. + * @param ele the current element + * @param originalDef the current bean definition + * @return the decorated bean definition + */ + public BeanDefinitionHolder decorateBeanDefinitionIfRequired(Element ele, BeanDefinitionHolder originalDef) { + return decorateBeanDefinitionIfRequired(ele, originalDef, null); } + /** + * Decorate the given bean definition through a namespace handler, if applicable. + * @param ele the current element + * @param originalDef the current bean definition + * @param containingBd the containing bean definition (if any) + * @return the decorated bean definition + */ public BeanDefinitionHolder decorateBeanDefinitionIfRequired( - Element ele, BeanDefinitionHolder definitionHolder, @Nullable BeanDefinition containingBd) { + Element ele, BeanDefinitionHolder originalDef, @Nullable BeanDefinition containingBd) { - BeanDefinitionHolder finalDefinition = definitionHolder; + BeanDefinitionHolder finalDefinition = originalDef; // Decorate based on custom attributes first. NamedNodeMap attributes = ele.getAttributes(); @@ -1393,6 +1431,14 @@ public class BeanDefinitionParserDelegate { return finalDefinition; } + /** + * Decorate the given bean definition through a namespace handler, + * if applicable. + * @param node the current child node + * @param originalDef the current bean definition + * @param containingBd the containing bean definition (if any) + * @return the decorated bean definition + */ public BeanDefinitionHolder decorateIfRequired( Node node, BeanDefinitionHolder originalDef, @Nullable BeanDefinition containingBd) { @@ -1473,10 +1519,16 @@ public class BeanDefinitionParserDelegate { return desiredName.equals(node.getNodeName()) || desiredName.equals(getLocalName(node)); } + /** + * Determine whether the given URI indicates the default namespace. + */ public boolean isDefaultNamespace(@Nullable String namespaceUri) { return (!StringUtils.hasLength(namespaceUri) || BEANS_NAMESPACE_URI.equals(namespaceUri)); } + /** + * Determine whether the given node indicates the default namespace. + */ public boolean isDefaultNamespace(Node node) { return isDefaultNamespace(getNamespaceURI(node)); } diff --git a/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/TransactionAwareDataSourceProxy.java b/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/TransactionAwareDataSourceProxy.java index 05e4d36d0d0..97a2fdc9518 100644 --- a/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/TransactionAwareDataSourceProxy.java +++ b/spring-jdbc/src/main/java/org/springframework/jdbc/datasource/TransactionAwareDataSourceProxy.java @@ -1,5 +1,5 @@ /* - * Copyright 2002-2018 the original author or authors. + * Copyright 2002-2019 the original author or authors. * * Licensed under the Apache License, Version 2.0 (the "License"); * you may not use this file except in compliance with the License. @@ -203,6 +203,10 @@ public class TransactionAwareDataSourceProxy extends DelegatingDataSource { return true; } } + else if (method.getName().equals("getWarnings") || method.getName().equals("clearWarnings")) { + // Avoid creation of target Connection on pre-close cleanup (e.g. in Hibernate Session) + return null; + } else if (method.getName().equals("close")) { // Handle close method: only close if not within a transaction. DataSourceUtils.doReleaseConnection(this.target, this.targetDataSource);