40efcc933c
Polishing
2018-06-28 14:51:33 +02:00
81cb740e0a
New postProcessProperties variant on InstantiationAwareBeanPostProcessor
...
Allows for skipping the now-deprecated postProcessPropertyValues callback with its expensive PropertyDescriptor retrieval requirement. RequiredAnnotationBeanPostProcessor (which is dependent on postProcessPropertyValues) and the @Required annotation itself are also deprecated now: in favor of constructor injection (or afterPropertiesSet).
Issue: SPR-16918
2018-06-28 14:15:16 +02:00
a89e716cc7
Use tabs rather than spaces in tests
...
Update tests to ensure that tabs are used instead of spaces. Also
consistently apply a new line at the end of each file.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
1c25cec44f
Polish test code
...
Polish a few issue identified when adding checkstyle to the
build. Although checkstyle is not enforcing rules on tests,
these are a few minor changes that are still worth making.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
81451aa800
Organize imports
...
Reorganize imports to ensure consistent ordering. This commit also
expands any `.*` static imports in favor of using fully-qualified
method references.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
b220d94cc2
Never use parenthesis for single lambda arguments
...
Update all lambdas that take a single argument so that parenthesis
are never used.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
5cedd0d5d4
Consistently use tabs rather than spaces
...
Update code that has accidentally used spaces instead of tabs.
Also remove all trailing whitespace.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
9de3689f63
Never use 'this.' when accessing loggers
...
Ensure that `this.` is never used when accessing loggers.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
0b53c1096a
Always use 'this.' when accessing fields
...
Ensure that `this.` is used consistently when accessing class
fields.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
eeebd51f57
Use consistent class design
...
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
0ad0f341bd
Don't use single letter catch variables
...
Update existing catch blocks to ensure that `ex` is always used
in preference to `e` or `t` as the variable name.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
866e9d702e
Use consistent block style
...
Update all code to use a consistent block style.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
c3a17dfd47
Ensure all files end with a newline
...
Update all files to ensure that they always end with a new line.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
e0480f75ac
Fix javadoc checkstyle issues
...
Fix checkstyle violations for javadoc.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
4184ebe799
Polish profile expression support
...
Issue: SPR-12458
2018-06-16 21:40:22 +03:00
1f3b4f1863
Polish "Add profile expression support"
...
Issue: SPR-12458
2018-06-15 16:01:16 +02:00
0dc434b35e
Polishing
2018-06-13 22:04:10 +02:00
9aed9bf823
Allow for custom ScheduledTaskRegistrar and/or ScheduledMethodRunnable
...
Issue: SPR-16834
Issue: SPR-16812
2018-06-13 22:03:01 +02:00
b71795ba36
Restore original DefaultLifecycleProcessor behavior for the time being
...
Issue: SPR-16901
2018-06-10 23:52:27 +02:00
0092653d42
Fix JDK9 build after Groovy 2.5 upgrade
...
After the Groovy 2.5 upgrade, the Spring Framework build on JDK9 hit
GROOVY-8631. Adding the relevant `jax-api` dependency to the module
didn't fix this issue. The Groovy release notes mention the use of the
`--add-modules` JVM flag, but this is not an option for this build which
should run on JDK8 -> JDK11.
This commit changes the dependency from `groovy-all` to more focused
dependencies on Groovy in the `spring-beans` and `spring-context`
modules. This change seems to avoid the automatic loading of Groovy
enhancements to JAXB (shipped with `groovy-xml`).
See:
* http://groovy-lang.org/releasenotes/groovy-2.5.html#Groovy2.5releasenotes-Knownissues
* https://issues.apache.org/jira/browse/GROOVY-8631
Issue: SPR-15407
2018-06-08 13:37:44 +02:00
6cf197864c
DefaultLifecycleProcessor properly handles count for dependent beans
...
Issue: SPR-16901
2018-06-06 21:25:26 +02:00
f1871f9e3f
Fix faulty BeanPostProcessorChecker logs with @EnableCaching
...
Issue: SPR-16896
2018-06-04 14:51:14 +02:00
b71d0eeec9
Fix Kotlin bean DSL conditional handling
...
Issue: SPR-16412
2018-06-01 14:40:27 +02:00
356bfe6e2e
Upgrade to Joda-Time 2.10
2018-05-31 23:35:15 +02:00
a7a29a8226
Revisit PropertyResolver Kotlin extensions
...
Issue: SPR-16883
2018-05-31 12:20:37 +02:00
1b728fb244
Polishing
2018-05-30 11:10:37 +02:00
b39ce80c87
Doc: @EnableScheduling needs to be declared per application context
...
Issue: SPR-16852
2018-05-29 21:52:51 +02:00
46a89d9534
Restore lenient null return value for ConditionContext.getBeanFactory()
...
Includes nullable return value for getClassLoader() with corresponding notes in applicable javadoc.
Issue: SPR-16866
2018-05-29 21:51:06 +02:00
5bbeadec0c
Detect nested configuration classes even for empty outer classes
...
Issue: SPR-16839
2018-05-29 21:47:53 +02:00
be416ef9c4
Polish BeanDefinitionDsl
...
Issue: SPR-16412
2018-05-29 09:34:35 +02:00
5b3bbad6a0
ConcurrentModel.addAttribute javadoc: null value not supported
...
Issue: SPR-16831
2018-05-18 22:20:08 +02:00
795e5d306c
Upgrade to JSR-354 Money & Currency API 1.0.3 and Moneta 1.2.1
2018-05-05 20:38:28 +02:00
fb898e1727
Remove inconsistent spaces
2018-05-05 11:07:35 +02:00
9281f820f1
Expose FactoryBean's raw object on retrieval during post-processing
...
Issue: SPR-16783
2018-05-02 15:21:40 +02:00
c8b6233bd0
Introspect originating bean definition as configuration class candidate
...
Issue: SPR-16756
2018-05-02 15:20:42 +02:00
ad0d79a97b
Lenient fallback to plain getBundle call without Control handle
...
Includes defaultEncoding variant for platform default encoding.
Issue: SPR-16776
2018-05-01 23:50:34 +02:00
d5aedac6db
Avoid custom ResourceBundle.Control on Jigsaw (as far as possible)
...
Issue: SPR-16776
2018-04-27 18:24:31 +02:00
eaff2c28a7
Consistent target method resolution for event and caching expressions
...
Issue: SPR-16779
2018-04-27 18:23:42 +02:00
aa11721ff0
AopUtils.getMostSpecificMethod exposes dynamic proxy class methods
...
Includes efficient canApply check for IntroductionAwareMethodMatcher.
Issue: SPR-16757
2018-04-27 18:23:34 +02:00
a2a8d0c754
Workaround for generic parameter types on inner class constructors
...
Issue: SPR-16734
2018-04-17 12:58:32 +02:00
d4a55a257b
OperatorMatches flags misguided evaluation attempts as FLAWED_PATTERN
...
Issue: SPR-16731
2018-04-17 11:10:15 +02:00
b95e05db04
AspectJExpressionPointcut consistently resolves superinterface methods
...
Includes efficient check for same ClassLoader in ClassUtils.isVisible, efficient MethodMatchers check for IntroductionAwareMethodMatcher, and supertype method resolution in MethodMapTransactionAttributeSource.
Issue: SPR-16723
2018-04-14 15:10:05 +02:00
97ee94f4ca
Expose env and context in Kotlin beans DSL
...
This commit introduces a deferred initialization of the declared beans
in order to make it possible to access to the environment (and even
to the context for advanced use-cases) in the beans { } Kotlin DSL.
Issues: SPR-16269, SPR-16412
2018-04-12 11:31:37 +02:00
61c3db0869
MethodHandles.Lookup.defineClass for CGLIB class definition purposes
...
Spring's CGLIB fork is patched with local copies of affected files here, introducing the notion of a "contextClass" (e.g. the proxy superclass) which gets passed through to ReflectUtils.defineClass for delegating to MethodHandles.Lookup.defineClass eventually, against a privateLookupIn(contextClass) lookup context on JDK 9/10/11.
Issue: SPR-15859
2018-04-11 12:47:55 +02:00
cdaa247861
Unwind _TestTypes to top-level public test classes in AOP test suite
2018-04-11 12:43:49 +02:00
6102715b8d
Consistent treatment of proxy classes and interfaces for introspection
...
Issue: SPR-16675
Issue: SPR-16677
2018-04-03 02:42:41 +02:00
cc379f1cc7
Polishing
2018-04-01 12:57:19 +02:00
bc07a54075
Clear AnnotationUtils cache after context refresh (along with others)
...
Issue: SPR-16675
2018-03-31 23:08:30 +02:00
912c270f2b
Polishing
2018-03-31 17:49:21 +02:00
4da27c2a73
Avoid unnecessary introspection on methods and meta-annotations
...
Issue: SPR-16667
2018-03-31 00:18:14 +02:00
78681c6369
JndiRmiServiceExporter still calls PortableRemoteObject when available
...
Issue: SPR-16670
2018-03-30 15:19:38 +02:00
d553ddc5b3
Nullability refinements (based on IntelliJ IDEA 2018.1 introspection)
...
Issue: SPR-15756
2018-03-29 23:50:17 +02:00
e6020ed377
avoid unnecessary autoboxing
2018-03-28 23:48:12 +02:00
d1a0b8d53f
Clarify the format supported by @PropertySource
...
Issue: SPR-16563
2018-03-28 11:03:53 +02:00
4aae6a6dda
Use Map.forEach instead of manual Map.Entry iteration wherever possible SPR-16646
2018-03-28 01:09:03 +02:00
e3d0ef6015
Use Map.forEach instead of manual Map.Entry iteration wherever possible
...
Issue: SPR-16646
2018-03-27 00:38:32 +02:00
8d5587fe4f
Consistent thread-safe iteration in DefaultSingletonBeanRegistry
...
Issue: SPR-16620
2018-03-24 16:30:51 +01:00
d3a0a8e007
Use Collection.removeIf() where possible ( #1747 )
...
Use Collection.removeIf() where possible
Issue: SPR-16622
2018-03-22 11:36:11 +01:00
99399084a6
Consistent Future check (even if typically encountering RunnableFuture)
...
Issue: SPR-16607
2018-03-19 12:42:49 +01:00
3c1adf7f6a
ThreadPoolTaskExecutor/Scheduler cancels remaining Futures on shutdown
...
Issue: SPR-16607
2018-03-19 01:45:22 +01:00
4fef1fe820
Polishing
2018-03-16 18:49:12 +01:00
914b2470dc
Scope annotation in class hierarchies vs XML bean definition inheritance
...
Issue: SPR-16602
2018-03-16 18:49:00 +01:00
c4e9ce8d0e
Clarified repeatable PropertySource annotation vs use as meta-annotation
...
Issue: SPR-16592
2018-03-14 18:53:50 +01:00
3988dd9ebb
Polishing
2018-03-14 17:24:58 +01:00
cc12afdea2
Add support for deferred import selector group
...
This commit allows several DeferredImportSelector instances to be
grouped and managed in a centralized fashion. This typically allows
different instances to provide a consistent ordered set of imports to
apply.
Issue: SPR-16589
2018-03-13 16:52:26 -04:00
04a8f81710
Polishing
2018-03-12 20:42:03 +01:00
50e980c02f
Validate declared annotations before deciding between reflection and ASM
...
Issue: SPR-16564
2018-03-12 13:40:26 +01:00
fb7c4a3066
Polish
2018-03-11 10:26:41 +01:00
6163f2d32f
use more modern java API for empty collections
2018-03-08 21:41:57 +01:00
139dc1d373
Polishing (collapsed if checks, consistent downcasts, refined javadoc)
2018-03-08 18:11:57 +01:00
0f7485b01d
Polish: reorder the modifiers to comply with the Java Language Specification.
2018-03-08 17:57:47 +01:00
0f5a3e2647
Polish formatting in Groovy scripts
2018-03-07 16:09:04 +01:00
df0b39e8ac
Add missing packages to Groovy scripts
2018-03-07 16:09:03 +01:00
f57fcdee3c
Polishing
2018-03-07 15:49:58 +01:00
129530f792
Polish
...
Closes gh-1715
2018-03-03 12:12:15 +01:00
ed936cbd89
Polish: Overriding methods should do more than simply call the same method in the super class
2018-03-02 00:06:27 +01:00
33cd160861
Upgrade to Reactor Bismuth SR7, Hibernate ORM 5.2.14, Common Annotations 1.3.2
2018-02-28 14:01:04 +01:00
7bce04c06c
Polish: combine catches block with same body
2018-02-27 12:51:28 +01:00
c2d5ca9811
Proper nullable return declaration for AbstractValueAdaptingCache.lookup
...
Issue: SPR-15540
2018-02-26 13:05:12 +01:00
7d89de06e3
Enforce GMT timezone for testBindInstantFromJavaUtilDate
...
Issue: SPR-16534
2018-02-26 13:02:17 +01:00
c782075a13
Polish: Array designators "[]" should be on the type, not the variable
2018-02-25 13:14:20 +01:00
3531c104b0
Prefer Collections.addAll call with array over Set.addAll(Arrays.asList)
2018-02-25 00:21:39 +01:00
a5cbf5fe24
Consistent use of Collection.toArray with zero-sized array argument
...
Includes consistent use of ClassUtils.toClassArray (as non-null variant)
Issue: SPR-16523
2018-02-22 11:29:46 +01:00
d7cab23e6d
Consistent use of StringUtils.toStringArray
...
(cherry picked from commit 6d11b40
2018-02-16 20:49:17 +01:00
8d3264f680
Prefer List.sort(Comparator) over Collections.sort(List, Comparator)
2018-02-16 10:23:18 +01:00
3b810f3544
Consistent Class array vs vararg declarations (and related polishing)
2018-02-14 14:44:00 +01:00
7826567df6
Polish: lamdbas containing only one statement should not nest this statement in a block
2018-02-14 01:22:01 +01:00
37609e4ede
Object/FieldError exposes source object through unwrap/contains methods
...
Issue: SPR-16372
2018-02-13 17:58:31 +01:00
d3cee45f30
Polishing
2018-02-13 13:15:29 +01:00
d5cabca2f7
Internal adaptation to Deque semantics
2018-02-12 15:55:09 +01:00
711b0f50f2
Polish: replace the synchronized class "Stack" by an unsynchronized one such as "Deque".
2018-02-11 21:15:46 +01:00
d00e1c5e4f
Polishing
2018-02-10 21:35:46 +01:00
55ee250659
Object/FieldError stores source object as transient (not serialized)
...
Issue: SPR-16372
2018-02-10 17:41:30 +01:00
0ee505b73e
Polish: assertion arguments should be passed in the correct order,
...
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
2018-02-10 17:17:28 +01:00
d3a1d44864
Polish: Maps with keys that are enum values should be replaced with EnumMap
2018-02-10 12:09:33 +01:00
9bb7fcd997
Object/FieldError provides access to source object (exception/violation)
...
Issue: SPR-16372
2018-02-09 18:42:56 +01:00
c8b860c4b8
Streamlined BeanFactory access within DefaultLifecycleProcessor
2018-02-09 13:31:31 +01:00
991eb4858e
Update copyright header
2018-02-09 10:16:58 +01:00
c0b4b5787f
Change this "try" to a try-with-resources
...
Closes gh-1671
2018-02-09 10:12:55 +01:00
e381514b07
Collection.isEmpty() should be used to test for emptiness
...
Closes gh-1670
2018-02-09 10:11:44 +01:00
5c0ddf3c69
Polishing
2018-02-07 10:59:10 +01:00
5c813a366b
Consistent use of @throws instead of @exception
2018-02-05 22:51:51 +01:00
7f96827ade
Polishing
2018-02-02 11:34:03 +01:00
4a1cc9ced7
Constructor-provided field values get recorded for failed binding result
...
Also, TypeMismatchExceptions get registered via BindingErrorProcessor.
Issue: SPR-16449
2018-02-02 11:33:56 +01:00
9c069f6cb1
Avoid String concatenation for not-null assertion in BeanProperty/DirectFieldBindingResult
...
Issue: SPR-16455
2018-02-02 11:33:39 +01:00
637e09f995
Polishing
2018-01-30 16:00:30 +01:00
ef2e16912d
Formatting support for java.time.Year and java.time.Month
...
Issue: SPR-16437
2018-01-30 15:54:47 +01:00
89d2bd954a
Properly analyze Java 9 class cast messages for lambda event listeners
...
Issue: SPR-16435
2018-01-30 15:53:58 +01:00
0e734d83d5
@EnableAspectJAutoProxy: per application context, requires aspectjweaver
...
Issue: SPR-14753
Issue: SPR-15801
2018-01-26 10:38:43 +01:00
37ab8a700b
Doc: no "useCodeAsDefaultMessage" for setValidationMessageSource
...
Issue: SPR-15986
2018-01-26 10:35:37 +01:00
13c735442c
@Scheduled supports java.time.Duration format for its delay attributes
...
Issue: SPR-15455
2018-01-25 19:11:18 +01:00
97894a1c22
Improve logging dependencies for tests
2018-01-23 10:42:41 -05:00
9d0e62ef68
Javadoc format and related polishing
2018-01-22 11:43:21 +01:00
572c668726
Polishing
2018-01-19 21:30:37 +01:00
d31767eab8
Fix an exception message in ScheduledAnnotationBeanPostProcessor
...
Closes gh-1636
2018-01-15 15:19:02 +01:00
b160f93495
CacheProxyFactoryBean exposes all relevant CacheInterceptor callbacks
...
Issue: SPR-16295
2018-01-14 23:48:21 +01:00
06e6386dc9
CollectionUtils.lastElement for common Set/List extraction
...
Issue: SPR-16374
2018-01-12 18:23:52 +01:00
13a8f90e08
ScheduledAnnotationBeanPostProcessor properly deals with nested proxies
...
Issue: SPR-16196
2018-01-12 16:48:17 +01:00
c8bdb3c602
Polishing
2018-01-09 22:20:22 +01:00
d9af4d6599
ResourceBundleMessageSource uses ConcurrentHashMaps instead of synchronization
...
Issue: https://jira.spring.io/browse/SPR-16235
2018-01-09 22:12:03 +01:00
4adc820714
Warning instead of error for non-present type filter class
...
Issue: SPR-16356
2018-01-08 13:41:23 +01:00
d187cbce73
LoadTimeWeaver detection differentiates between WebSphere and Liberty
...
Issue SPR-16248
2018-01-07 23:29:16 +01:00
977550f956
Properly handle null bean instance in getLifecycleBeans
...
Issue: SPR-16343
2018-01-07 23:23:08 +01:00
18d90ec140
Properly handle null FactoryBean instance
...
Issue: SPR-16250
2018-01-07 23:22:56 +01:00
4577a19190
Upgrade to Commons Pool 2.5 (and Jackson Kotlin Module 2.9.3)
2017-12-21 13:52:00 +01:00
591429e538
Fix exception message
...
initialDelayString is parsed into long, not integer.
Closes gh-1615
2017-12-09 15:46:28 -08:00
773cd3241b
Polishing
2017-11-28 14:11:21 +01:00
9f1d8517ba
Polish Kotlin source code style
2017-11-21 15:59:23 +01:00
5843173567
Polishing
2017-11-21 13:42:57 +01:00
08c95fbcb3
Unit tests for configuration superclass inclusion
...
Issue: SPR-16217
2017-11-21 13:42:01 +01:00
40dacd3c1c
Polishing
2017-11-20 22:27:07 +01:00
84699c8b9b
Document common use cases for @Order vs @Priority vs @DependsOn
...
Issue: SPR-16213
2017-11-20 12:53:37 +01:00
85baba33bf
Accessors for PeriodicTrigger properties
...
Issue: SPR-15982
2017-11-14 17:09:19 +01:00
edf8232555
Avoid implicit autowiring with Kotlin secondary ctors
...
Autowiring implicitely Kotlin primary constructors
when there are secondary constructors has side effects
on ConstructorResolver. It seems reasonable to
require explicit @Autowired annotation in such case.
With this commit, implicit autowiring of Kotlin
primary constructors is only performed when there
is a primary constructor defined alone or with
a default constructor (define explicitly or
generated via the kotlin-noarg compiler plugin
or via optional constructor parameters with default
values).
Issue: SPR-16022
2017-11-14 09:25:46 +01:00
e2bb06edbd
Unit tests for unresolvable generics with partial mismatch
...
Issue: SPR-16179
2017-11-13 21:51:02 +01:00
3091feee23
SpringValidatorAdapter skips value retrieval for Set field without index
...
Issue: SPR-16177
2017-11-13 21:50:55 +01:00
ffd6eff369
Scheduled task introspection through ScheduledTaskHolder interface
...
Issue: SPR-15982
2017-11-06 18:36:39 +01:00
9511d29adb
Updated bean count expectations in ClassPathBeanDefinitionScannerTests
...
Issue: SPR-16152
2017-11-06 18:36:29 +01:00
1838ddb95d
Support Ant-style package name with component index
...
This commit improves the component index so that it supports ant-style
package name (i.e. com.example.**.foo).
Issue: SPR-16152
2017-11-06 15:19:30 +01:00
996d747aed
Upgrade to Mockito 2.11
...
Includes fixes for invalid exception declarations in Mockito-based unit tests. Also includes FreeMarker 2.3.27, Commons Pool 2.4.3, JSON-P 1.1.2.
Issue: SPR-16157
2017-11-04 01:06:59 +01:00
1611ce7180
AbstractApplicationContext silently ignores non-initialized ApplicationEventMulticaster/LifecycleProcessor on destruction
...
Issue: SPR-16149
2017-11-02 16:07:12 +01:00
e5c8dc0d65
MessageSource.getMessage returns null default message as-is (again)
...
Issue: SPR-16127
2017-10-31 11:06:42 +01:00
159da04eed
Fix wrong javadoc example
...
Closes gh-1575
2017-10-23 09:20:19 +02:00
c7100f771c
Explicit notes on advice mode proxy vs aspectj
...
Issue: SPR-16092
2017-10-22 20:34:34 +02:00
e17ad551f3
Latest dependency updates (RxJava 1.3.3, Hibernate ORM 5.2.12, Hibernate Validator 5.4.2 & 6.0.3)
2017-10-20 16:16:06 +02:00
d1fac36e3e
SchedulingConfigurer and JmsListenerConfigurer respect @Order
...
Issue: SPR-16090
2017-10-20 16:10:12 +02:00
c3378fda33
AbstractMessageSource properly interacts with non-AbstractMessageSource parent
...
Issue: SPR-16047
2017-10-18 20:21:12 +02:00
d1b5b5d2f7
Clarify destroy method suppression for DisposableBean vs (Auto)Closeable
...
Issue: SPR-16078
(cherry picked from commit dff2c84
2017-10-16 23:53:02 +02:00
43b5e21947
Consistent alias declarations for value attribute on stereotypes
...
Issue: SPR-16066
2017-10-13 18:18:12 +02:00
625737f90a
Controller/Repository/Service declare value attribute as alias for Component
...
Issue: SPR-16066
2017-10-13 14:24:12 +02:00
Juergen Hoeller
Phillip Webb
Sam Brannen
Stephane Nicoll
Brian Clozel
Sebastien Deleuze
Johnny Lim
igor-suhorukov
Christoph Dreis
Rossen Stoyanchev
Masahiro Ide
Philipp Grogg
Haruki Okada