417354da8a
Remove dependency management noise from POMs
...
Prior to this commit, the generated POMs for Spring Framework modules
would contain unneeded/harmful information from the Spring Framework
build:
1. The BOM imports applied to each module by the dependency
management plugin, for example for Netty or Reactor Netty.
Spring should not export that opinion to its POMs.
2. The exclusion of "org.slf4:jcl-over-slf4j" from *all* dependencies,
which made the POMs much larger than necessary and suggested to
developers that they should exclude it as well when using all those
listed dependencies. In fact, only Apache Tiles currently brings that
transitively.
This commit removes that information from the POMs.
The dependencyManagement Gradle plugin is disabled for POM generation
and we manually resolve the dependency versions during the generation
phase.
The Gradle build is streamlined to exclude "org.slf4:jcl-over-slf4j"
only when necessary.
Issue: SPR-16893
2018-06-11 15:57:54 +02:00
86c861516d
Accept Predicate instead of HandlerTypePredicate
...
Issue: SPR-16336
2018-06-08 15:32:07 -04:00
ac37b678a3
Remove JSONP support
...
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914
2018-06-08 12:15:48 +02:00
19dc981685
Path prefixes for groups of controllers
...
Issue: SPR-16336
2018-06-07 18:18:42 -04:00
3acb96efd0
CachingResourceResolver varies by known codings only
...
Issue: SPR-16381
2018-06-04 23:30:35 -04:00
356bfe6e2e
Upgrade to Joda-Time 2.10
2018-05-31 23:35:15 +02:00
f3e860e8f1
Resource handler tests expect status 404 for directory in jar file
...
Issue: SPR-16832
2018-05-30 00:31:35 +02:00
69f14a2038
ClassPathResource.isReadable() checks InputStream (for jar directories)
...
Resource.isReadable() is defined to semantically imply exists() now.
Issue: SPR-16832
2018-05-29 21:47:33 +02:00
8593fec22c
Avoid ConstantConditions warnings suppression (plus related polishing)
...
Issue: SPR-15756
2018-05-29 21:47:10 +02:00
836a09d5c0
Upgrade to Woodstox 5.1, XMLUnit 2.6, Gson 2.8.5
2018-05-25 00:18:06 +02:00
85e8634810
Properly initialize URI/Matrix vars w/ urlDecode=false
...
Issue: SPR-16867
2018-05-24 15:08:39 -04:00
b472d192f4
Improve support for caching encoded resources
...
The key in CachingResourceResolver now includes the "Accept-Encoding"
request header cleaned to exclude "*", "identity", and parameters, and
also sorted alphabetically.
For encoded resources the response now includes a response header with
"Vary: Accept-Encoding".
Issue: SPR-16381
2018-05-23 09:17:21 -04:00
9274de390a
Polish resource handling tests
2018-05-23 09:17:21 -04:00
f121aa5e31
Immutable Resource[Resolver|Transformer]Chains
...
Issue: SPR-16862
2018-05-23 09:17:21 -04:00
5207672b3f
Configurable support for static resource encodings
...
The new EncodedResourceResolver is a generalized version of
GzipResourceResolver that can be configured to support different
content codings, by "br" and "gzip".
GzipResourceResolver is now deprecated.
Issue: SPR-16381
2018-05-23 09:17:21 -04:00
285eb94a03
Upgrade to Hibernate Validator 6.0.10
2018-05-18 22:22:12 +02:00
395792b302
Produces media types cleared prior to error handling
...
Issue: SPR-16318
2018-05-14 23:16:36 -04:00
6cf6d8834c
List OPTIONS in OPTIONS responses for @RequestMapping
...
Issue: SPR-16513
2018-05-14 09:05:03 -04:00
4da43de7e1
Remove individual detection of forwarded headers
...
This commit removes all places where forwarded headers are checked
implicitly, on an ad-hoc basis.
ForwardedHeaderFilter is expected to be used instead providing
centralized control over using or discarding such headers.
Issue: SPR-16668
2018-05-11 09:31:39 -04:00
1aadf2c3a6
Refine compareTo for param and header conditions
...
Issue: SPR-16674
2018-05-08 18:12:51 -04:00
c238fb441b
Polishing
...
(cherry picked from commit 2da02cc
2018-05-08 00:58:58 +02:00
a200df6c8d
Explicit coverage of root vs cause exception matching in MVC ref docs
...
Issue: SPR-16743
2018-05-07 22:30:26 +02:00
53aa9cc4cd
Upgrade to Servlet API 4.0.1 (aligned with Tomcat 9 and Undertow 2)
...
Issue: SPR-16470
2018-05-07 14:17:28 +02:00
321d7b0b06
Put CacheControl.empty() in else part.
...
Make sure the constructor of `CacheControl` being invoked only once.
2018-05-07 13:13:44 +02:00
d0bd57b100
Polishing
...
(cherry picked from commit 0795ae5
2018-05-05 17:04:24 +02:00
c9f488363d
Fine-tuned assertions and related polishing
2018-05-05 14:39:43 +02:00
7b894fe73b
ResponseEntityExceptionHandler rethrows unknown exception (for further processing in DispatcherServlet's HandlerExceptionResolver chain)
...
Issue: SPR-16743
2018-05-05 12:46:58 +02:00
fb898e1727
Remove inconsistent spaces
2018-05-05 11:07:35 +02:00
6519e7b22a
Polish
2018-04-27 14:06:48 -04:00
de18d96413
Validate contextPath in RedirectView
...
Issue: SPR-16752
2018-04-23 15:26:18 -04:00
e9a8a5065b
Disable HTTP Range support for InputStreamResource
...
Prior to this commit, the `AbstractMessageConverterMethodProcessor`
would fail to convert `InputStreamResource` to `ResourceRegion` as
expected, since the content length cannot be read without consuming the
stream. This is enforced by the `HttpRange` class.
Now the method processor would still try to output HTTP range response
headers to provide range support information. This step is using the
resource content length and reads the input stream, leading to
exceptions such as "IllegalStateException: InputStream has already been
read".
This commit improves the return type detection and excludes early
`InputStreamResource` return types. With those types, HTTP range support
is now completely disabled.
Issue: SPR-16754
2018-04-23 18:39:05 +02:00
1d6540b1c2
Enable KotlinScriptTemplateTests after KT-18833 fix
2018-04-23 14:49:22 +02:00
0754833b37
Local XMLUnit dependency declarations with consistent version 2.5.1
2018-04-14 21:03:20 +02:00
7ee6130680
Revised reference example for linkable controller method signature
...
Issue: SPR-16710
2018-04-12 14:45:11 +02:00
f28a5d0cf7
Proper exception for controller method return types that do not work with MvcUriComponentsBuilder (e.g. final classes)
...
Includes direct use of ControllerMethodInvocationInterceptor for return type Object, avoiding the attempt to generate an Object subclass.
Issue: SPR-16710
2018-04-11 16:05:54 +02:00
aba882af4c
Clean up warnings in spring-webmvc
2018-04-04 14:04:54 +02:00
2c648379ab
Delete dead code in spring-webmvc
2018-04-04 14:01:24 +02:00
aa0face9a1
Upgrade to RxJava 1.3.8 and Rhino 1.7.9
2018-04-03 15:18:25 +02:00
8a9321652d
Refined javadoc
2018-03-31 23:07:08 +02:00
912c270f2b
Polishing
2018-03-31 17:49:21 +02:00
6393e5ce0c
Consistent Ordered.LOWEST_PRECEDENCE declarations for default order
2018-03-31 00:20:44 +02:00
b1048975d2
Minor updates based on PR#1058
...
The original repo no longer exists:
https://github.com/spring-projects/spring-framework/pull/1058
2018-03-30 13:36:20 -04:00
240d6f52c9
Replaces rather than prepend contextPath
...
Issue: SPR-16650
2018-03-29 18:17:29 -04:00
dd96c873e3
Improve docs on forwarded headers
...
Issue: SPR-16660
2018-03-29 16:11:01 -04:00
b165475eb6
Polishing
2018-03-29 16:05:52 +02:00
695bf2961f
Consistent trace logging in PathResourceResolver
...
Issue: SPR-16616
2018-03-29 16:04:33 +02:00
e6020ed377
avoid unnecessary autoboxing
2018-03-28 23:48:12 +02:00
4aae6a6dda
Use Map.forEach instead of manual Map.Entry iteration wherever possible SPR-16646
2018-03-28 01:09:03 +02:00
f3994467c4
Refine ContentNegotiationStrategy contract
...
Consistently return "*/*" if no media types were requested rather than
an empty list. Existing code has to check for both in any case to see
if nothing was requested.
Issue: SPR-16624
2018-03-27 16:54:19 -04:00
9a27bc9b3e
Upgrade to Jackson 2.9.5 and Hibernate Validator 6.0.9
2018-03-27 17:33:34 +02:00
98ad23bef8
Consistent logging of encoded path evaluation failure
...
Issue: SPR-16616
2018-03-27 17:04:59 +02:00
e3d0ef6015
Use Map.forEach instead of manual Map.Entry iteration wherever possible
...
Issue: SPR-16646
2018-03-27 00:38:32 +02:00
f59ea610df
Simplified separator check within isInvalidEncodedPath
...
Issue: SPR-16616
2018-03-27 00:23:36 +02:00
c1405ef140
Polishing
2018-03-21 16:12:42 +01:00
91b803a231
Consistent encoded path evaluation in ResourceHttpRequestHandler and co
...
Issue: SPR-16616
2018-03-21 12:02:13 +01:00
0e28bee0f1
Clean duplicate separators in resource URLs
...
Most Servlet containers do this anyway, but not all, and not
consistently for forward and backslashes.
Issue: SPR-16616
2018-03-19 17:16:03 -04:00
f8588e364a
AcceptHeaderLocaleResolver keeps language match among supported locales
...
Issue: SPR-16599
2018-03-16 14:17:50 +01:00
2096676b3f
Upgrade to Apache Johnzon 1.1.7 and JRuby 9.1.16
2018-03-15 15:43:45 +01:00
58011f71e9
Consistent assertions for template method result vs servlet registration
2018-03-14 18:55:50 +01:00
2a3f90dc7b
Upgrade to Hibernate ORM 5.2.15 and Hibernate Validator 6.0.8
2018-03-09 09:40:12 +01:00
ed7684d2b2
Don't implicitly check preconditions on PUT requests
...
Prior to this commit, the `HttpEntityMethodProcessor` would check HTTP
conditions on non-safe requests (i.e. not GET/HEAD). This would prevent
Controllers from returning `ResponseEntity` containing response headers
with updated values of `"Last-Modified"` or `ETag` once the resource has
been updated.
This commit avoids those checks for non GET/HEAD requests - this code
can still be leveraged from Controllers themselves using
`ServletWebRequest::checkNotModified` methods.
Issue: SPR-15780
2018-03-08 19:43:01 +01:00
139dc1d373
Polishing (collapsed if checks, consistent downcasts, refined javadoc)
2018-03-08 18:11:57 +01:00
0f7485b01d
Polish: reorder the modifiers to comply with the Java Language Specification.
2018-03-08 17:57:47 +01:00
568c93457a
Improve ResponseBodyEmitter error handling
...
After send error, ignore calls to complete or completeWithError by the
application in the same thread (e.g. try-catch block), to avoid a
competing with an error callback from servlet container during which
the same action is taken.
Issue: SPR-16548
2018-03-07 15:25:31 -05:00
e20652009d
Improve docs on SseEmitter onComplete/onError
...
Issue: SPR-16548
2018-03-07 14:59:18 -05:00
934a995acb
Strong recommendation for OpenPDF 1.0.5 instead of iText 2.1.7
...
Issue: SPR-16107
(cherry picked from commit b70d400
2018-03-07 17:08:45 +01:00
f57fcdee3c
Polishing
2018-03-07 15:49:58 +01:00
6f4d25a6e6
Polish "Use Java 8 forEach method on Map"
2018-03-07 15:39:58 +01:00
6d26e61ac7
Guard against invalid paths in ResourceUrlProvider
...
This commit makes sure that no `StringIndexOutOfBoundsException` is
thrown when `getForRequestUrl` is called with a URL that's shorter than
the expected context path.
Issue: SPR-16526
2018-03-05 15:26:56 +01:00
cd4f0935c5
Revised deprecation markers
2018-03-01 23:43:06 +01:00
36cfdf68b1
Correct log level
...
Issue: SPR-16528
2018-03-01 15:52:59 -05:00
bfddbbe731
Polishing
2018-03-01 01:39:06 +01:00
83300c4b27
Polish: follow naming convention
2018-03-01 00:22:29 +01:00
8080f56db8
Polish: "@Override" should be used on overriding and implementing methods
2018-03-01 00:15:18 +01:00
d1ccecd021
Polish: to get rid unnecessary array creation
2018-02-27 23:37:54 +01:00
7bce04c06c
Polish: combine catches block with same body
2018-02-27 12:51:28 +01:00
49fd724d8f
Polish: String function use should be optimized for single characters
2018-02-25 20:48:47 +01:00
a5cbf5fe24
Consistent use of Collection.toArray with zero-sized array argument
...
Includes consistent use of ClassUtils.toClassArray (as non-null variant)
Issue: SPR-16523
2018-02-22 11:29:46 +01:00
0de36d2883
Consistent HttpMethod identity comparisons
2018-02-18 22:01:22 +01:00
d7cab23e6d
Consistent use of StringUtils.toStringArray
...
(cherry picked from commit 6d11b40
2018-02-16 20:49:17 +01:00
8d3264f680
Prefer List.sort(Comparator) over Collections.sort(List, Comparator)
2018-02-16 10:23:18 +01:00
2be4985b8f
Polish: anonymous inner classes containing only one method should become lambdas,
...
use getOrDefault instead of ternary operator
2018-02-16 09:38:19 +01:00
9801afb85d
Fix compile error
...
Update places that call UriUtils to catch the right exception that is
now raised as a result of using Charet.forName.
2018-02-15 15:59:21 -05:00
cd8a1bdb8b
AcceptHeaderLocaleContextResolver leniently handles invalid header value
...
Also falls back to language-only match among its supported locales now.
Issue: SPR-16500
Issue: SPR-16457
2018-02-15 13:14:49 +01:00
6d7573262e
FormTag skips rendering of hidden fields in case of empty Map
...
Issue: SPR-16498
2018-02-14 17:41:45 +01:00
3b810f3544
Consistent Class array vs vararg declarations (and related polishing)
2018-02-14 14:44:00 +01:00
46cbdff5c3
Consistent ControllerAdvice applicability against user-declared class
...
Issue: SPR-16496
2018-02-14 14:41:16 +01:00
711b0f50f2
Polish: replace the synchronized class "Stack" by an unsynchronized one such as "Deque".
2018-02-11 21:15:46 +01:00
0ee505b73e
Polish: assertion arguments should be passed in the correct order,
...
use assertNull instead of assertEquals(null, value),
declare delta as double value in assertEquals
2018-02-10 17:17:28 +01:00
991eb4858e
Update copyright header
2018-02-09 10:16:58 +01:00
e381514b07
Collection.isEmpty() should be used to test for emptiness
...
Closes gh-1670
2018-02-09 10:11:44 +01:00
4c888d0f32
Polish
...
Closes gh-1669
2018-02-09 10:10:05 +01:00
4dc964544f
AcceptHeaderLocaleResolver falls back to language-only match among its supported locales
...
Issue: SPR-16457
2018-02-02 12:41:59 +01:00
7f96827ade
Polishing
2018-02-02 11:34:03 +01:00
4a1cc9ced7
Constructor-provided field values get recorded for failed binding result
...
Also, TypeMismatchExceptions get registered via BindingErrorProcessor.
Issue: SPR-16449
2018-02-02 11:33:56 +01:00
0ded239453
[doc] Update Spring MVC exception handling content
...
Issue: SPR-16394
2018-01-31 23:03:10 -05:00
b6c78452b2
Update and improve script templating documentation
...
Issue: SPR-16447
2018-01-31 17:57:41 +01:00
8d42888476
Upgrade to RxJava 1.3.5 and WebJars Locator 0.35
...
Includes Rhino 1.7.8 and JRuby 9.1.15 as well.
2018-01-29 21:31:27 +01:00
97894a1c22
Improve logging dependencies for tests
2018-01-23 10:42:41 -05:00
91e6274b7d
Upgrade to Apache HttpClient 4.5.5 and Tomcat 8.5.27
2018-01-22 22:11:00 +01:00
61579ffe7b
Polishing
2018-01-22 21:34:44 +01:00
9d0e62ef68
Javadoc format and related polishing
2018-01-22 11:43:21 +01:00
36d42bcda4
Polish InterceptorRegistration
...
Closes gh-1647
2018-01-20 10:15:12 +01:00
ea5f8f5a7c
Consistently handle NoClassDefFoundError in BeanUtils and related places
...
Issue: SPR-16369
2018-01-17 20:24:57 +01:00
121f9e3734
BridgeMethodResolver properly resolves all declared interfaces
...
Issue: SPR-16288
2018-01-11 10:18:27 +01:00
ea73ec5c41
ResourceUrlProvider handles sanitizes double slashes
...
Issue: SPR-16296
2018-01-10 17:48:43 -05:00
846636f2b9
Polish
2018-01-08 17:35:30 -05:00
cb8ad46564
Overloaded methods in InterceptorRegistration
...
Issue: SPR-16324
2018-01-08 17:31:06 -05:00
446e7ed25c
Links from @RequestMapping to reference docs
...
Issue: SPR-16266
2018-01-08 09:29:52 -05:00
7a55d932f9
Build against OpenPDF 1.0.5 instead of outdated iText 2.1.7
...
Issue: SPR-16352
2018-01-08 00:26:10 +01:00
9d27e86951
Upgrade to Hibernate Validator 6.0.7
2017-12-21 17:00:06 +01:00
3a51b5a9d2
Upgrade to Hibernate Validator 6.0.6
2017-12-15 15:58:12 +01:00
fda08852ba
Take content-type from ResponseEntity unconditionally
...
From #9a894a we began using the content-type from the ResponseEntity
but cross-checking it still against the requested content type.
Arguably there isn't any purpose in cross-checking. The only possible
outcomes are: a) it's compatible or b) it's not, which would result in
406 (NOT_ACCEPTABLE). As we've been given explicitly the media type to
use, it makes little sense to send 406, ignoring the wish to use that
content type.
Issue: SPR-16251
2017-12-02 00:43:43 -05:00
3650ecc3bb
Polish
2017-11-28 22:16:07 -05:00
a8323f6a27
Latest dependency updates (OkHttp 3.9.1, JRuby 9.1.14, Rome 1.9)
2017-11-26 16:03:48 +01:00
652e5c5584
Disable CORS credentials by default
...
Access-Control-Allow-Credentials CORS header, used to
allow cookies with CORS requests, is not set to true
anymore by default when enabling CORS with
@CrossOrigin or global CORS configuration in order to
provide a more secured default CORS configuration.
The related allowCredentials property now requires to
be set to true explicitly in order to support cookies
with CORS requests.
Issue: SPR-16130
2017-11-22 22:46:44 +01:00
0cc644f61f
Polishing
2017-11-21 16:34:08 +01:00
bc8e525e60
Add shared instance of ReactiveAdapterRegistry
...
Issue: SPR-16218
2017-11-20 17:02:22 -05:00
40dacd3c1c
Polishing
2017-11-20 22:27:07 +01:00
27bbb73583
Expose all HttpResource header values (even if commonly not multi-value)
...
Issue: SPR-14264
2017-11-20 15:31:34 +01:00
20fcefc647
ResourceHttpRequestHandler uses EmbeddedValueResolverAware
2017-11-19 21:16:29 +01:00
14a7da8183
Upgrade to Hibernate Validator 6.0.5
2017-11-19 21:16:10 +01:00
b1b5353b7f
Revise charset by location support for static resources
2017-11-17 12:33:58 -05:00
cc7c90cca5
Polishing
2017-11-16 10:52:56 +01:00
7af9910244
Restored support for placeholders in mvc namespace resource locations
...
With the recent charset mechanism in place, we cannot rely on implicit placeholder parsing during String-to-Resource conversion anymore.
2017-11-16 09:36:23 +01:00
7697b398d5
Polishing
2017-11-14 17:11:16 +01:00
b5cedd43eb
Consistent and efficient access to BeanDefinition argument values
...
Issue: SPR-16192
2017-11-13 21:51:11 +01:00
72f20e8d4f
Polishing
2017-11-11 00:37:50 +01:00
9a894ab61e
Use ResponseEntity Content-Type as producible media type
...
Issue: SPR-16172
2017-11-10 15:05:03 -05:00
780993ce75
Polishing
2017-11-10 20:21:26 +01:00
369d33c3d0
Support charset config by (static) resource location
...
This commit adds support for configuring static resource locations
with a charset to be applied to relative paths.
2017-11-09 13:15:06 -05:00
a75dd2dd3e
Consistent getDateHeader checks in spring-webmvc unit tests
...
Issue: SPR-16160
2017-11-05 17:00:18 +01:00
e5c8dc0d65
MessageSource.getMessage returns null default message as-is (again)
...
Issue: SPR-16127
2017-10-31 11:06:42 +01:00
9bab7a2708
Upgrade to Java Activation Framework 1.2 for test runtime
...
Includes upgrade to Hibernate Validator 6.0.4 (where applicable)
Issue: SPR-16115
2017-10-25 19:18:10 +02:00
9efdadcdca
Compatibility with OpenPDF as alternative to iText 2.1.7
...
Issue: SPR-16107
2017-10-24 13:14:53 +02:00
1cc5afe24b
Fix lines over 120 characters
...
https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Code-Style#line-wrapping
2017-10-20 16:42:26 -04:00
e17ad551f3
Latest dependency updates (RxJava 1.3.3, Hibernate ORM 5.2.12, Hibernate Validator 5.4.2 & 6.0.3)
2017-10-20 16:16:06 +02:00
d1fac36e3e
SchedulingConfigurer and JmsListenerConfigurer respect @Order
...
Issue: SPR-16090
2017-10-20 16:10:12 +02:00
ab92754a2e
@MatrixVariable resolvers for WebFlux
...
The information was already parsed and available in a request attribute
but until now there were no argument resolvers to expose it.
Issue: SPR-16005
2017-10-19 21:01:38 -04:00
9df6f3e6b8
Polishing
2017-10-18 20:21:49 +02:00
bec1fc1852
ModelAttributeMethodProcessor detects re-enabled binding declaration
...
Issue: SPR-16083
2017-10-18 12:31:22 +02:00
32d78e60b6
Update information on WebApplicationContext hierarchy
...
Issue: SPR-16041
2017-10-17 21:49:57 -04:00
cd634633d8
MockMvc re-uses response instance on async dispatch
...
MockMvc now properly detects the presence of an AsyncContext and
re-uses the response instance used to start it.
This commit also includes a minor fix in
ResponseBodyEmitterReturnValueHandler to ensure it does not disable
ETag related content buffering for reactive return values that do not
result in streaming (e.g. single value or collections).
Issue: SPR-16067
2017-10-17 16:57:35 -04:00
3d1023be8c
Polishing
2017-10-17 11:56:30 +02:00
ef6aef9107
Allow PropertyEditor conversion as fallback for enums
...
Issue: SPR-16082
2017-10-17 11:49:54 +02:00
c3cf0840b7
Polishing
2017-10-16 15:34:39 +02:00
d611486978
HandlerMappingIntrospector.getHandlerMappings() never returns null
2017-10-12 15:31:11 +02:00
1356bd4359
Share HandlerInterceptors in ResourceHandlerMapping
...
Prior to this commit, the Resource `HandlerMapping` configured by
`@EnableSpringMvc` would be set up with only one custom
`HandlerInterceptor` (the one exposing the `ResourceUrlProvider` for
resolving URLs of static resources).
This behavior is not consistent with the rest of the default
configuration which leverages the interceptors configured against the
interceptor registry (with possible user-provided ones).
This change allows to register interceptors against resource handling;
this can be useful for metrics purposes, as in
spring-projects/spring-boot#10335 .
Issue: SPR-16034
2017-10-10 22:57:52 +02:00
699fde91db
Polishing
2017-10-10 22:18:09 +02:00
cc6e6490d2
Polishing
2017-10-09 13:59:29 +02:00
Brian Clozel
Rossen Stoyanchev
Sebastien Deleuze
Juergen Hoeller
nkjackzhang
Johnny Lim
Sam Brannen
igor-suhorukov
Patrick0308
Stephane Nicoll
Aleksey Voronenkov