Juergen Hoeller
65e5c14245
Polishing
Backport Bot / build (push) Waiting to run
Details
Build and Deploy Snapshot / Build and Deploy Snapshot (push) Waiting to run
Details
Build and Deploy Snapshot / Verify (push) Blocked by required conditions
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:false version:17], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:true version:21], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:true version:23], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
Deploy Docs / Dispatch docs deployment (push) Waiting to run
Details
2025-07-04 18:20:27 +02:00
Juergen Hoeller
9596b70b2a
Consistent nullability and exception declarations
...
Closes gh-35159
2025-07-04 18:20:19 +02:00
Sam Brannen
5da8d5e795
Remove unnecessary `final` declarations in JmsTemplate
...
Backport Bot / build (push) Waiting to run
Details
Build and Deploy Snapshot / Build and Deploy Snapshot (push) Waiting to run
Details
Build and Deploy Snapshot / Verify (push) Blocked by required conditions
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:false version:17], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:true version:21], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:true version:23], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
Deploy Docs / Dispatch docs deployment (push) Waiting to run
Details
This commit removes unnecessary `final` declarations for parameters that
are "effectively final".
2025-07-04 11:38:30 +02:00
Sam Brannen
133f330850
Declare remaining messageSelector parameters in JmsOperations as @Nullable
...
Closes gh-35151
2025-07-04 11:35:49 +02:00
Jiandong Ma
b6675edb92
Declare messageSelector parameters in JmsOperations as @Nullable
...
See gh-35151
Signed-off-by: Jiandong Ma <jiandong.ma.cn@gmail.com>
2025-07-03 19:17:49 +02:00
Spring Builds
aee29b7f30
Update copyright headers in source files
...
This commit updates Java, Kotlin, and Groovy source files to use the
"<year>-present" pattern in copyright headers.
Closes gh-35070
2025-06-17 15:54:58 +02:00
Sam Brannen
18d6a55e3e
Polishing and removal of "this." for method invocations
Backport Bot / build (push) Waiting to run
Details
Build and Deploy Snapshot / Build and Deploy Snapshot (push) Waiting to run
Details
Build and Deploy Snapshot / Verify (push) Blocked by required conditions
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:false version:17], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:true version:21], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:true version:23], map[id:ubuntu-latest name:Linux]) (push) Waiting to run
Details
Deploy Docs / Dispatch docs deployment (push) Waiting to run
Details
2025-06-09 14:10:30 +02:00
Sam Brannen
9fd1d0c6a3
Polish Javadoc
...
Backport Bot / build (push) Has been cancelled
Details
Build and Deploy Snapshot / Build and Deploy Snapshot (push) Has been cancelled
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:false version:17], map[id:ubuntu-latest name:Linux]) (push) Has been cancelled
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:true version:21], map[id:ubuntu-latest name:Linux]) (push) Has been cancelled
Details
CI / ${{ matrix.os.name}} | Java ${{ matrix.java.version}} (map[toolchain:true version:23], map[id:ubuntu-latest name:Linux]) (push) Has been cancelled
Details
Deploy Docs / Dispatch docs deployment (push) Has been cancelled
Details
Build and Deploy Snapshot / Verify (push) Has been cancelled
Details
This commit also reverts the change to ASM's SymbolTable class.
See gh-34679
2025-03-29 12:57:08 +01:00
Tran Ngoc Nhan
30fcaef813
Remove unnecessary closing curly brackets in Javadoc
...
Closes gh-34679
Signed-off-by: Tran Ngoc Nhan <ngocnhan.tran1996@gmail.com>
2025-03-29 12:37:48 +01:00
Juergen Hoeller
20736bd06f
Introduce acknowledgeAfterListener flag for custom acknowledge handling
...
Closes gh-34635
2025-03-25 17:06:28 +01:00
Sam Brannen
208d52d852
Introduce Checkstyle rule for separator symbol location
2025-03-19 15:35:44 +01:00
Sam Brannen
dd92eac3ad
Refer to message "receipt" instead of "reception"
2024-11-19 13:18:12 +01:00
Brian Clozel
ab2f1f8885
Merge branch '6.1.x'
2024-10-21 16:20:57 +02:00
Brian Clozel
84e762b470
Fix double accounting of JMS process observations
...
Prior to this commit, the instrumentation of the processing of JMS
messages would happen a different levels of the hierarchy, accounting
for alli known implementations, `SimpleMessageListenerContainer` and
`DefaultMessageListenerContainer` as well as various use cases and
`MessageListener` variants.
Unfortunately, this instrumentation could lead to observing JMS
processing twice in some cases, and would not be consistent about the
scope of what's observed.
This commit moves the instrumentation basics into the
`AbstractMessageListenerContainer` but leaves the actual observation
calls to the public implementations.
Fixes gh-33758
2024-10-21 16:09:58 +02:00
Juergen Hoeller
e89218b39a
Merge branch '6.1.x'
2024-10-16 13:46:22 +02:00
Juergen Hoeller
11d4272ff4
Use Locale.ROOT consistently for toLower/toUpperCase
...
Closes gh-33708
2024-10-16 13:36:23 +02:00
Brian Clozel
9be3d85a06
Merge branch '6.1.x'
2024-10-14 15:04:58 +02:00
Brian Clozel
32962894a0
Add runtime hints for JMS connection factories proxies
...
Prior to this commit, the JMS connection factories would proxy various
interfaces. This typically requires runtime hints for GraalVM native
applications and spring-jms is missing those.
This commit adds a new `ConnectionFactoriesRuntimeHints` that
contributes such hints with type conditions.
Fixes gh-33590
2024-10-14 14:54:24 +02:00
Yanming Zhou
8941e2876e
Replace 'e.g.' with 'for example' in documentation and comments
...
Closes gh-33515
2024-09-26 14:11:17 +02:00
Sam Brannen
d749d2949d
Use new features from JUnit Jupiter 5.11
...
This commit primarily migrates to the new argumentSet() feature but also
applies additional polishing to our use of parameterized tests.
See gh-33395
2024-08-16 13:48:19 +02:00
Stéphane Nicoll
65faca8236
Consistently using credentials for creating the JMSContext
...
This commit updates UserCredentialsConnectionFactoryAdapter to apply
the same handling of credentials for creating the JMSContext.
Closes gh-33270
2024-07-25 09:41:43 +02:00
Brian Clozel
b701b26b07
Merge branch '6.1.x'
2024-07-19 17:23:14 +02:00
Brian Clozel
0bb309f433
Instrument @JmsListener session for response messages
...
Prior to this commit, the observation instrumentation for `@JmsListener`
annotated methods (implemented in `AbstractMessageListenerContainer`
would not instrument the JMS session using the Micrometer JMS support.
This means that response messages returned from the listener method
would be sent but no observation would be recorded. As a result, tracing
message properties would be also missing.
This commit ensures that the session provided to the listener method is
instrumented beforehand, if Micrometer is on the classpath and an
observation registry has been configured.
Fixes gh-33221
2024-07-19 17:17:18 +02:00
Sam Brannen
932ce04541
Stop referring to old Spring versions in Javadoc
2024-07-01 17:50:52 +02:00
Sam Brannen
b105fdc87a
Polishing
2024-06-30 14:41:43 +02:00
Juergen Hoeller
b2d43f54e0
Merge branch '6.1.x'
2024-05-10 12:29:49 +02:00
Juergen Hoeller
bf08e0c1b4
Polishing
2024-05-10 12:27:29 +02:00
Brian Clozel
ccf9ba86a0
Merge branch '6.1.x'
2024-04-18 21:45:23 +02:00
Brian Clozel
0268180799
Rethrow unhandled JMS listener exceptions
...
Fixes gh-32666
2024-04-18 21:44:44 +02:00
Stéphane Nicoll
330dcf15bc
Polish "Use try-with-resources when applicable"
...
See gh-32610
2024-04-10 09:49:35 +02:00
ali dandach
82b51479d5
Use try-with-resources when applicable
...
See gh-32610
2024-04-10 09:49:17 +02:00
Brian Clozel
c3aa0cd815
Merge branch '6.1.x'
2024-04-09 18:36:53 +02:00
Brian Clozel
ac74116d76
Instrument JmsTemplate#sendAndReceive
...
Prior to this commit, the `JmsTemplate#sendAndReceive` method would not
instrument the JMS session. This means that no metric would be recorded
when sending the message and no trace would be propagated downstream.
This commit ensures that the JMS session is instrumented in this case as
well. Note, the reception of the response message does not create a
`"jms.message.process"` observation as the session is only receiving the
message, no listener has been configured on the message consumer.
Fixes gh-32606
2024-04-09 18:34:09 +02:00
Sébastien Deleuze
8b51b36729
Perform NullAway build-time checks in more modules
...
This commit enables null-safety build-time checks in
all remaining modules except spring-test.
See gh-32475
2024-03-26 15:53:01 +01:00
Sébastien Deleuze
88e26a9570
Merge branch '6.1.x'
2024-03-25 11:28:43 +01:00
Sébastien Deleuze
06b91c4ea5
Refine null-safety in spring-jms
...
See gh-32475
2024-03-25 11:28:00 +01:00
Sébastien Deleuze
2fc78dfb69
Perform NullAway build-time checks in spring-jms
...
See gh-32475
2024-03-25 11:27:04 +01:00
Juergen Hoeller
6df27644eb
Merge branch '6.1.x'
2024-03-18 16:04:26 +01:00
Juergen Hoeller
cd7ba1835c
Propagate JMS IllegalStateException from commit/rollbackIfNecessary
...
Closes gh-32473
2024-03-18 16:03:13 +01:00
Brian Clozel
ae5cff1705
Merge branch '6.1.x'
2024-03-18 14:37:21 +01:00
Brian Clozel
521d4f24d0
Remove flaky test in JMS observation
...
There is no way to consistently test this use case because listener
container implementations have different behavior for unhandled errors
and might retry or close the container altogether.
See gh-32458
2024-03-18 14:35:42 +01:00
Brian Clozel
9cd4d32195
Merge branch '6.1.x'
2024-03-18 12:18:29 +01:00
Brian Clozel
c1424acb94
Fix flaky test in JMS observability
...
See gh-32458
2024-03-18 12:17:57 +01:00
Brian Clozel
10e8039de8
Merge branch '6.1.x'
2024-03-15 22:48:12 +01:00
Brian Clozel
a78704af24
Record unhanlded JMS exceptions as observation errors
...
Prior to this commit, when using the `DefaultMessageListenerContainer`
as a backing listener container for JMS messages, the instrumentation
would not record JMS exceptions as observation errors when they were not
handled by configured `ErrorHandler`.
This commit ensures that this is the case.
Fixes gh-32458
2024-03-15 22:45:36 +01:00
Sam Brannen
20be9e150c
Polishing
2024-03-09 14:28:01 +01:00
Juergen Hoeller
4d206f79d0
Merge branch '6.1.x'
...
# Conflicts:
# spring-jms/src/main/java/org/springframework/jms/listener/DefaultMessageListenerContainer.java
2024-02-26 13:42:00 +01:00
Juergen Hoeller
479879c53a
Polishing
2024-02-26 13:40:21 +01:00
Juergen Hoeller
5c589833d7
Revise idleReceivesPerTaskLimit for surplus tasks on default/simple executor
...
Closes gh-32260
2024-02-25 19:00:56 +01:00
Sam Brannen
122372c580
Spring cleaning: update copyright headers
2024-02-23 12:21:22 +01:00