d250a5155a
Consistent dependency declarations
2023-08-02 00:56:50 +02:00
ae279eaced
Polishing
2023-08-01 23:52:48 +02:00
3b1af692cc
Merge branch '6.0.x'
...
# Conflicts:
# spring-beans/spring-beans.gradle
# spring-context/spring-context.gradle
# spring-orm/spring-orm.gradle
# spring-test/spring-test.gradle
# spring-web/spring-web.gradle
# spring-webflux/spring-webflux.gradle
2023-08-02 01:04:31 +02:00
b9ae996dfc
Merge branch '6.0.x'
...
# Conflicts:
# spring-context/spring-context.gradle
# spring-context/src/main/java/org/springframework/context/event/SimpleApplicationEventMulticaster.java
# spring-context/src/test/java/org/springframework/scheduling/annotation/EnableSchedulingTests.java
# spring-orm/src/main/java/org/springframework/orm/hibernate5/SpringBeanContainer.java
# spring-test/spring-test.gradle
# spring-webmvc/spring-webmvc.gradle
2023-08-02 00:16:55 +02:00
dde8f4489f
Polish MappedInterceptor
2023-08-01 16:19:26 +03:00
f9f7a7cd78
Polish contribution
...
See gh-30971
2023-08-01 16:19:26 +03:00
6de95a2b37
Provide methods for obtaining include/exclude patterns in MappedInterceptor
...
Prior to this commit, MappedInterceptor had a getPathPatterns() method
that returned the include patterns.
This commit introduces getIncludePathPatterns() (which effectively
replaces getPathPatterns()) and getExcludePathPatterns(). In addition,
this commit deprecates getPathPatterns().
Closes gh-30971
2023-08-01 15:57:43 +03:00
f00756bc7c
Update copyright headers
2023-08-01 14:55:04 +03:00
78d0dbb519
Ensure handling of 404 errors for static resources
...
Closes gh-30930
2023-07-27 22:13:10 +03:00
bbde68c49e
Polishing
2023-07-25 19:12:07 +02:00
67e3d86bd8
Support declarativeBinding mode in DataBinder
...
Closes gh-30948
2023-07-25 18:04:21 +03:00
37eaded63d
Support BindParam annotation
...
Allows customizing the name of the request parameter to bind a
constructor parameter to.
Closes gh-30947
2023-07-25 16:15:55 +03:00
5ebbb3ff3e
Merge branch '6.0.x'
...
# Conflicts:
# spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcOperations.java
# spring-jdbc/src/main/java/org/springframework/jdbc/core/JdbcTemplate.java
# spring-jdbc/src/main/java/org/springframework/jdbc/core/namedparam/NamedParameterJdbcTemplate.java
2023-07-25 19:13:33 +02:00
05956d4028
Change MvcSimpleAsyncTaskExecutor.taskExecutorWarning to primitive boolean
2023-07-19 13:21:57 +03:00
25ea1f4c0f
Merge branch '6.0.x'
...
# Conflicts:
# spring-context/src/main/java/org/springframework/scheduling/support/CronSequenceGenerator.java
2023-07-19 00:37:06 +02:00
2f33e77ab4
Consistent equals/hashCode style (and related polishing)
2023-07-19 00:35:19 +02:00
73c06347be
Update WebMvc docs on use of AsyncTaskExecutor
...
Closes gh-30905
2023-07-18 10:42:27 +01:00
4becce1c2b
Consolidate default WebMvc executor log warnings
...
Closes gh-30902
2023-07-18 10:22:45 +01:00
30d6ec3398
Update copyright headers
2023-07-15 16:01:15 +02:00
ab83972c3e
Add missing @Nullable annotations in AbstractResourceResolver subclasses
...
See gh-30601
Closes gh-30893
2023-07-15 16:00:32 +02:00
8a283e39ff
Update DefaultHandlerExceptionResolver logging
...
Reduce logging for NoResourceFoundException and NoHandlerFoundException.
Closes gh-30884
2023-07-14 15:11:19 +01:00
bcd09d7ad8
Merge branch '6.0.x'
2023-07-15 16:01:47 +02:00
0611192dac
Enable KotlinScriptTemplateTests in Spring MVC on Java 20
...
See gh-29249
Closes gh-30896
2023-07-15 13:36:11 +02:00
63fe45d92a
Update copyright headers
2023-07-15 13:11:29 +02:00
70cf754a2f
Suppress warnings in tests
2023-07-15 13:02:16 +02:00
16b9640af2
Merge branch '6.0.x'
2023-07-12 11:50:11 +02:00
68f2b0ca59
Rely on auto-boxing in tests
2023-07-12 11:49:02 +02:00
39e74d89e1
Merge branch '6.0.x'
2023-07-11 11:17:41 +01:00
20afa3265a
Encapsulate full path initialization
2023-07-11 11:10:20 +01:00
d04d7b2e57
Add request binding to functional endpoints
...
This commit introduces form binding to ServerRequest in both WebMVC.fn
and WebFlux.fn's, in the form of a bind(Class) method.
Closes gh-25943
2023-07-11 09:52:39 +02:00
372282457f
Use Collections.emptyEnumeration() where appropriate
...
Closes gh-30803
2023-07-05 13:47:11 +02:00
b77d4d01c5
Adapt no-arg value from interface-based InvocationHandler callback
...
Closes gh-30756
2023-06-26 19:28:19 +02:00
f86a69ebfb
Update copyright headers and polish
2023-06-24 14:14:02 +02:00
39bc7566df
Stop printing to System.out in tests
2023-06-24 14:10:12 +02:00
299b86bae3
Merge branch '6.0.x'
2023-07-05 14:02:49 +02:00
496155525c
Allow built ServerResponse to throw exception
...
This commit ensures that ServerResponse.HeadersBuilder::build can throw
an exception, by introducing a separate functional interface that does
allow for exceptions to be thrown.
Closes gh-30818
2023-07-05 12:01:55 +02:00
6fa09e1783
Extract AnnotatedMethod base class for consistent annotation exposure
...
As a consequence, the spring-messaging HandlerMethod detects interface parameter annotations as well, and the same is available for other HandlerMethod variants.
Closes gh-30801
2023-07-04 20:42:30 +02:00
deaa493644
Add Visitor to HandlerMethodValidationException
...
Closes gh-30813
2023-07-04 17:19:58 +01:00
1fc020cf92
Fix checkstyle violations
2023-07-03 15:31:35 +01:00
592ab0f350
Add ~.validation.method package
...
Extract classes from ~.validation.beanvalidation without a direct
dependency on beanvalidation.
See gh-30644
2023-07-03 15:05:51 +01:00
7a79da589a
Add default web handling of method validation errors
...
Closes gh-30644
2023-07-03 12:08:11 +01:00
a481c7649f
Refactor to prepare for method validation handling
...
To handle method validation errors in ResponseEntityExceptionHandler,
MethodValidationException and associated types should not depend on
Bean Validation. To that effect:
1. MethodValidationResult and ParameterValidationResult no longer make
the underlying ConstraintViolation set available, and instead expose
only the adapted validation errors (MessageSourceResolvable, Errors),
analogous to what SpringValidatorAdapter does. And likewise
MethodValidationException no longer extends ConstraintViolationException.
2. MethodValidationPostProcessor has a new property
adaptConstraintViolations to decide whether to simply raise
ConstraintViolationException, or otherwise to adapt the ConstraintViolations
and raise MethodValidationException instead, with the former is the default
for compatibility.
3. As a result, the MethodValidator contract can now expose methods that
return MethodValidationResult, which provided more flexibility for handling,
and it allows MethodValidationAdapter to implement MethodValidator directly.
4. Update Javadoc in method validation classes to reflect this shift, and
use terminology consistent with Spring validation in classes without an
explicit dependency on Bean Validation.
See gh-30644
2023-07-03 12:08:11 +01:00
d4ac90dae0
Support nested constructors in DataBinder
...
Closes gh-20806
2023-06-26 17:01:44 +01:00
11a416156b
Use ResolvableType to create WebDataBinder
...
This provides more flexibility to pass a targetType even if
a MethodParameter is not available.
See gh-26721
2023-06-26 13:11:05 +01:00
ea398d7b7e
Support constructing target object in DataBinder
...
See gh-26721
2023-06-22 20:36:28 +01:00
3f40452511
Merge branch '6.0.x'
2023-06-26 19:36:20 +02:00
854715d9a7
Update copyright headers
2023-06-25 15:39:16 +02:00
19686adc01
Merge branch '6.0.x'
2023-06-24 14:15:05 +02:00
f06cf21341
Support Kotlin parameter default values in handler methods
...
This commit adds support for Kotlin parameter default values
in handler methods. It allows to write:
@RequestParam value: String = "default"
as an alternative to:
@RequestParam(defaultValue = "default") value: String
Both Spring MVC and WebFlux are supported, including on
suspending functions.
Closes gh-21139
2023-06-22 16:08:48 +02:00
06b6c4bcf9
Update copyright headers
2023-06-22 14:56:09 +02:00
0605172d4d
Merge branch '6.0.x'
...
# Conflicts:
# spring-webmvc/src/main/java/org/springframework/web/servlet/mvc/support/DefaultHandlerExceptionResolver.java
2023-06-20 13:29:06 +02:00
67798a7b52
Fix CSS classes in Javadoc HTML tables due to upgrade to Java 17
...
Closes gh-30701
2023-06-20 13:24:03 +02:00
089d938e15
Set throwExceptionIfNoHandlerFound=true and deprecate
...
Closes gh-29491
2023-06-19 17:18:09 +01:00
c00508d6cf
Raise and handle NoResourceFoundException
...
See gh-29491
2023-06-19 17:18:08 +01:00
83b0f4f394
Merge branch '6.0.x'
2023-06-19 15:47:26 +02:00
294cdba80c
Update copyright year of changed file
...
See gh-30601
2023-06-19 15:44:04 +02:00
072a86149d
Flag PathResourceResolver#resolve*Internal as @Nullable
...
See gh-30601
2023-06-19 15:37:16 +02:00
a2072de391
Update copyright headers
2023-06-15 16:21:13 +02:00
526d9eae7f
Merge branch '6.0.x'
2023-06-15 16:20:19 +02:00
f22f439a68
Suppress deprecation warning due to upgrade to context-propagation 1.0.3
...
See gh-30657
2023-06-15 16:18:38 +02:00
220995b830
Move HandlerMethodValidator to web.method.annotation package
...
Avoiding cycle between web.method.support and web.method.annotation packages.
See gh-29825
2023-06-14 21:52:55 +02:00
61eaa9333b
Polishing in ErrorResponse
...
See gh-30566
2023-06-14 16:30:15 +01:00
9c7b5cb3f5
Add ProblemDetail "type" message code
...
See gh-30566
2023-06-14 16:30:15 +01:00
8a29bfba3f
Polishing external contribution
2023-06-14 13:44:50 +02:00
0c817f0441
Add non-null assertions in DefaultEntityResponseBuilder
...
This commit adds various non-null assertions to
DefaultEntityResponseBuilder, in Spring MVC.
Closes gh-30433
2023-06-14 13:44:50 +02:00
a268203832
Merge branch '6.0.x'
2023-06-13 16:27:20 +02:00
6cfb11a360
Upgrade to Micrometer BOM 1.10.8 and context-propagation 1.0.3
...
Cloes gh-30657
2023-06-13 16:21:26 +02:00
6a26db80b6
Refine RouterFunctionMapping ordering consistency
...
This commit changes the order of RouterFunctionMapping defined
in WebMvcConfigurationSupport from 3 to -1 in order to achieve
better consistency between WebMVC and WebFlux. It also reduces
the surprise factor. That way, functional routes are always
before annotation-based ones.
Closes gh-30278
2023-06-13 08:17:54 +02:00
ccf68878c7
Merge branch '6.0.x'
2023-06-12 16:12:03 +01:00
bbab4faf7a
Method level only, empty RequestMapping matches "" and "/"
...
Closes gh-30293
2023-06-12 16:11:42 +01:00
6501176081
Merge branch '6.0.x'
2023-06-12 12:59:55 +02:00
cc8c852c2b
Specific check for parent of MethodInvocationInfo ClassLoader
...
See gh-30389
2023-06-12 12:57:10 +02:00
bd054a4918
Add method validation to Spring MVC
...
See gh-29825
2023-06-12 11:37:55 +01:00
0093d6e34d
Polish contribution
...
See gh-30587
2023-06-07 19:13:05 +02:00
324c6057fd
Remove duplicate code in RequestResponseBodyMethodProcessor
...
Closes gh-30587
2023-06-07 19:13:05 +02:00
66a1be2d86
Enable KotlinScriptTemplateTests with Java 19
...
No support yet for Java 21.
Closes gh-29249
2023-06-06 15:49:04 +02:00
05eab703cc
Polishing
2023-06-06 11:29:25 +02:00
8c6287ef7b
Expose parameter/field name for non-JavaBeans type conversion
...
Supports name-bound PropertyEditor registrations on data classes.
Includes consistent support for field-aware method parameters.
Closes gh-28284
2023-06-02 20:42:05 +02:00
67f88482e6
Merge branch '6.0.x'
2023-05-30 17:36:08 +01:00
938dff7bbe
Remove (recently committed) erroneous character in test
2023-05-30 17:35:50 +01:00
b3f5d20ad8
Merge branch '6.0.x'
2023-05-30 17:18:01 +01:00
7629ea5672
Update docs to mention Boot's HttpMessageConverters
...
Closes gh-30538
2023-05-30 17:17:31 +01:00
454a85978f
Allow fallback on subclass of ProblemDetail
...
Closes gh-30533
2023-05-30 17:17:31 +01:00
3f14ebc4cf
Polish ReactiveTypeHandler when checking wildcard ndjson subtype
...
This commit polishes the previous change, ensuring that if the request
uses a wildcard subtype with an ndjson suffix then the wildcard isn't
present in the response's Content-Type.
Insteand, in that case we would fall back to `applicatin/x-ndjson` (the
base ndjson media type), assuming that the requester is only interested
in the ndjson nature of the underlying representation and not in the
specific semantics of any subtype.
See commit 9332b3f
2023-05-26 15:23:09 +02:00
9332b3f690
Have ReactiveTypeHandler consider +x-ndjson suffix as streaming
...
This commit adds `application/*+x-ndjson`, a wildcard media type which
covers all types that can be parsed as nd-json, to the list of media
types the ReactiveTypeHandler considers for a streaming response in
WebMVC.
As a result, a request which for example `Accept` the
`application/vnd.myapp.v1+x-ndjson` media type will generate a response
with the same `Content-Type`, with newline-delimited json objects being
streamed in the response body.
Closes gh-26817
2023-05-25 16:00:34 +02:00
a91effcd86
Ignore some FreeMarker tests for JDK21
...
This reverts commit 07a5d8c91
2023-05-11 18:00:23 +02:00
07a5d8c91c
Fix FreeMarker tests for JDK21 build
...
Prior to this commit, some FreeMarker tests would fail when involving
property lookup in a template file, where this bean property is linked
with a method implemented as a default method on an interface.
While I did not manage to reproduce this behavior in an independent test
case, this is most likely related to a change in JDK 21:
https://bugs.openjdk.org/browse/JDK-8071693
This commit changes the template expression to using the default method
directly.
2023-05-11 17:10:26 +02:00
5e52259fb3
Suppress warnings in tests
2023-05-10 14:27:43 +02:00
c1014f5989
Relax relative path existence assertion for parsed URIs
...
See gh-29481
See gh-28522
2023-05-01 00:01:49 +02:00
d39e44c209
Deprecate AutowireCapableBeanFactory.createBean(Class, int, boolean)
...
Includes consistent usage of createBean(Class) in SpringBeanJobFactory and SpringBeanContainer.
Closes gh-30345
See gh-29855
See gh-30041
2023-04-30 23:07:29 +02:00
9342317291
Avoid use of java.net.URL constructors (for JDK 20 compatibility)
...
Explicit path computation also leads to consistent relative path semantics for resource URLs.
Closes gh-29481
Closes gh-28522
2023-04-30 23:03:39 +02:00
ce3e9b0c29
Polishing
2023-04-26 11:21:34 +02:00
cef597bedd
Update copyright headers
2023-04-07 14:24:22 +02:00
01fabfe66d
Suppress warnings in tests
2023-04-07 14:23:55 +02:00
b5b115e52c
Fix SSE with indenting serializer in WebMvc.fn
...
This commit ensures that HTTP headers like "text/event-stream"
are correctly forwarded to the converter used in
SseServerResponse for proper pretty print handling.
Close gh-30277
2023-04-07 11:25:47 +02:00
1734deca1e
Refactor AssertJ assertions into more idiomatic ones
...
This commit refactors some AssertJ assertions into more idiomatic and
readable ones. Using the dedicated assertion instead of a generic one
will produce more meaningful error messages.
For instance, consider collection size:
```
// expected: 5 but was: 2
assertThat(collection.size()).equals(5);
// Expected size: 5 but was: 2 in: [1, 2]
assertThat(collection).hasSize(5);
```
Closes gh-30104
2023-04-04 17:34:07 +02:00
6c8ebc7f7e
Add non-null assertions in DefaultServerResponseBuilder
...
This commit adds various non-null assertions to
DefaultServerResponseBuilder, in both Spring MVC and WebFlux.
Closes gh-30157
2023-04-04 12:36:46 +02:00
491ae1e3be
Use MethodInvocationInfo class loader in case of JDK platform loader as well
...
Closes gh-30210
2023-03-29 13:46:18 +02:00
ce2689eead
Use MethodInvocationInfo class loader in case of core JDK interface type
...
Closes gh-30210
2023-03-28 13:20:49 +02:00
0ca02ce677
Disable affected tests on Java 18+/19+
...
See gh-30185
2023-03-24 16:05:40 +01:00
202fa5cdb3
Polishing and minor refactoring in HandlerMappingIntrospector
...
Closes gh-30127
2023-03-20 08:36:40 +00:00
e17f5c50a8
Update copyright headers
2023-03-13 21:53:40 +01:00
00be19c647
Consistently declare Object::equals argument as @Nullable
2023-03-13 21:43:21 +01:00
9cf7b0e230
Polishing
2023-03-12 18:38:50 +01:00
d8fbd35467
Add non-null assertions in DefaultServerRequestBuilder
...
This commit adds various non-null assertions to
DefaultServerRequestBuilder, in both Spring MVC and WebFlux.
Closes gh-30046
2023-03-08 12:50:02 +01:00
ffe7ec4a99
Apply "instanceof pattern matching" in remainder of spring-webmvc module
...
See gh-30067
2023-03-07 18:23:15 +01:00
2d56505ea9
Polishing
2023-02-20 16:49:27 +01:00
6d24e62e83
Polishing
2023-02-19 17:43:31 +01:00
2e1374b459
Update copyright headers
2023-02-19 13:41:36 +01:00
88e6544d9d
Fix regression in WebFlux support for WebDAV methods
...
This commit ensures that WebFlux's RequestMethodsRequestCondition
supports HTTP methods that are not in the RequestMethod enum.
- RequestMethod::resolve is introduced, to convert from a HttpMethod
(name) to enum values.
- RequestMethod::asHttpMethod is introduced, to convert from enum value
to HttpMethod.
- HttpMethod::valueOf replaced Map-based lookup to a switch statement
- Enabled tests that check for WebDAV methods
See gh-27697
Closes gh-29981
2023-02-17 12:46:26 +01:00
ce3be72e7f
Polish
2023-02-15 22:22:58 +09:00
3e3f046dc9
Polishing
2023-02-15 12:57:44 +01:00
f87a87e29d
Consistent ordering of Resource methods
...
See gh-24651
2023-02-15 10:13:03 +01:00
9a4df5a97d
DefaultHandlerExceptionResolver respects custom ModelAndView
...
Closes gh-29971
2023-02-14 20:13:15 +00:00
ac429a4ef7
Restore fallback to request attributes in FreeMarker template model
...
Closes gh-29787
2023-02-14 16:36:07 +01:00
12d4dc1bae
Polishing external contribution
...
This commit makes several changes to PR #24651 .
- Add byte[] getContentAsByteArray() on Resource.
- Remove getContentAsString() from Resource, as it relied on the default
charset which is not reliable.
- Add getContentAsString() to EncodedResource, as a charset is provided
through the constructor.
See gh-24651
2023-02-14 14:56:34 +01:00
dc843adb45
Improve docs on {@code Accept-Language} negotiation
...
Closes gh-28673
2023-02-13 18:39:19 +00:00
e5ff54955f
ProblemDetail XML support via Jackson
...
Closes gh-29927
2023-02-08 10:39:41 +00:00
ce85fdc5c7
Always use application/problem+json with ProblemDetail
...
See gh-gh-29588
2023-02-07 08:57:24 +00:00
7851994a17
Refine empty path handling in MvcUriComponentsBuilder
...
Return "" from methods that obtain controller or method mapping to
avoid side effect of a trailing slash appearing.
Closes gh-29897
2023-02-07 08:57:24 +00:00
c0c9ba5c2c
Polishing
2023-01-31 16:14:32 +01:00
4d6249811e
Explicit target ClassLoader for interface-based infrastructure proxies
...
Includes direct JDK Proxy usage instead of ProxyFactory where possible.
Closes gh-29913
2023-01-31 16:11:34 +01:00
64b89429cb
Update copyright headers
2023-01-31 11:52:25 +01:00
d5b0782700
Polishing
2023-01-31 10:10:44 +01:00
9c6fd3ed06
Consistently list supported media types
...
Add constructors to HttpMediaTypeNotSupportedException and
UnsupportedMediaTypeStatusException for a parse error that also accept
the list of supported media types to include in the response headers.
Closes gh-28062
2023-01-30 17:46:08 +00:00
e564a0de46
Provide access to interceptors in AbstractHandlerMapping
...
Closes gh-28985
2023-01-30 17:46:08 +00:00
f9884e08af
Polish external contribution
2023-01-30 14:19:41 +01:00
9819cb3eb5
Update HandlerFunctionAdapter::setAsyncRequestTimeout Javadoc
...
Closes gh-29882
2023-01-30 14:19:41 +01:00
ab9bea1d93
Polish RouterFunctionDsl KDoc
2023-01-23 13:28:10 +01:00
58872c79ee
Update copyright headers
2023-01-20 14:17:53 +01:00
24f18275dd
Stop referring to "Spring 3.x" features in documentation and code
2023-01-20 14:13:18 +01:00
86a40716bd
Polishing
2023-01-20 10:28:25 +01:00
7f48d1b55a
Remove obsolete Tiles documentation from Javadoc
...
See gh-29852
2023-01-20 10:27:48 +01:00
1ace42f245
Enable JRubyScriptTemplateTests
2023-01-19 16:20:03 +01:00
0502d18e3d
Update copyright headers
2023-01-19 16:20:03 +01:00
c4c786596f
Migrate to Mockito.mock(T...) where feasible
2023-01-19 16:20:02 +01:00
9ebd1e8d64
Fix IllegalStateException in empty ProducesRequestCondition
...
When comparing empty ProducesRequestCondition, compareTo would throw an
IllegalStateException if the Accept header was invalid. This commit
fixes that behavior.
Closes gh-29794
2023-01-18 10:38:09 +01:00
312db36849
Combined, empty RequestMapping matches both "" and "/"
...
Closes gh-29625
2023-01-13 14:58:11 +00:00
a4956dfe26
Update copyright headers
2023-01-11 13:52:20 +01:00
0415975dd1
Polish contribution and related code
2023-01-11 13:52:20 +01:00
afb8a0d1b1
Use new Java features (switch expressions, text blocks, new JDK methods)
...
Closes gh-29747
2023-01-11 13:51:28 +01:00
254c3725e2
Polishing
2022-12-23 15:14:11 +01:00
ab571e3562
Revert incorrect change to ParamAware Javadoc
2022-12-18 14:14:40 +01:00
d4623a393b
Update copyright headers
2022-12-18 12:16:19 +01:00
5c28b56823
Remove duplicated words in Javadoc
2022-12-18 12:05:18 +01:00
6fe5652783
Support non-standard HTTP methods in FrameworkServlet
...
This commit ensures that HTTP methods not supported by HttpServlet, for
instance WebDAV methods, are still supported in FrameworkServlet.
Closes gh-29689
2022-12-14 12:54:41 +01:00
c7bdfbea4f
Add missing Javadoc
...
See gh-29574
2022-12-13 13:46:31 +01:00
7fe78b745f
Polish Javadoc
2022-12-13 13:44:03 +01:00
46fc28fd1a
Clean up Javadoc and source code regarding " ." typos
2022-12-12 16:31:14 +01:00
284cb12f8f
Use URI#create instead of URI constructor where feasible in spring-webmvc
2022-12-09 13:27:13 -05:00
Juergen Hoeller
Sam Brannen
graceyu
rstoyanchev
Johnny Lim
Arjen Poutsma
Patrick Strawderman
Sébastien Deleuze
Stephane Nicoll
cwatzl
Vatsa
luohongtu
Simon Baslé
Brian Clozel
Krzysztof Krasoń
Sam Brannen