Sam Brannen
fae75cb238
Polish contribution
...
See gh-23237
2019-07-07 16:29:03 +02:00
Сергей Цыпанов
9f81ffa5ae
Use StringJoiner where possible to simplify String joining
...
Closes gh-23237
2019-07-07 16:19:01 +02:00
Juergen Hoeller
a5cb8799fa
Merge branch '5.1.x'
2019-07-05 18:22:02 +02:00
Juergen Hoeller
56cc0d02e9
Bean destruction exceptions consistently logged at warn level
...
Closes gh-23200
2019-07-05 17:07:22 +02:00
Johnny Lim
77aa17fe75
Polish YamlProcessorTests.flattenedMapIsSameAsPropertiesButOrdered()
...
See gh-23158
2019-06-20 08:34:44 +02:00
Juergen Hoeller
0a77477d32
Merge branch '5.1.x'
2019-06-12 18:16:30 +02:00
Juergen Hoeller
fc46abf0b7
Polishing
2019-06-12 18:04:06 +02:00
stsypanov
49873a30c5
Simplify String concatenation
2019-06-12 17:32:35 +02:00
Juergen Hoeller
33b5bc2aae
Polishing
2019-06-11 23:50:29 +02:00
Juergen Hoeller
a89bfffd8c
Merge branch '5.1.x'
2019-06-11 23:16:03 +02:00
Juergen Hoeller
7dc92aa05d
Polishing
2019-06-11 20:57:27 +02:00
Juergen Hoeller
fd159ad082
Custom init/destroy methods get invoked through interface is possible
...
Closes gh-22939
2019-06-11 20:56:30 +02:00
Juergen Hoeller
859923b732
Support for fine-grained by-type references and autowired properties
...
Closes gh-23032
2019-06-11 18:27:46 +02:00
Juergen Hoeller
662541a48e
Fix formatting
...
See gh-23068
2019-06-08 14:26:39 +02:00
陈其苗
ab8e388412
Fix duplicate invoke method of transformedBeanName
2019-06-07 22:48:19 +02:00
Sebastien Deleuze
098ac0bbb8
Annotate Object#equals parameter with @Nullable
...
Closes gh-23093
2019-06-06 14:18:30 +02:00
Sam Brannen
e92ace7301
Merge branch '5.1.x'
2019-06-04 16:22:08 +03:00
Sam Brannen
6eac141160
Restore non-null check for requiredType in BeanFactory methods
...
Beginning with Spring Framework 5.0, non-null checks for the
requiredType in the following methods were inadvertently removed with
the internal switch to ResolvableType.forRawClass(requiredType).
- BeanFactory.getBean(Class<T>, Object...)
- BeanFactory.getBeanProvider(Class<T>)
- AutowireCapableBeanFactory.resolveNamedBean(Class<T>)
This commit restores those non-null checks.
Closes gh-23045
2019-06-04 16:00:01 +03:00
Sam Brannen
410f204168
Support consistent ordering of string adapting properties
...
This commit introduces support for consistent ordering of Properties
created by CollectionFactory.createStringAdaptingProperties().
Specifically, the created Properties instance sorts properties
alphanumerically based on their keys.
Closes gh-23081
2019-06-04 14:47:43 +03:00
Sam Brannen
7c9c8220d8
Polish YAML tests
2019-05-28 15:27:11 +02:00
Phillip Webb
9d74da006c
Migrate JUnit 4 assertions to AssertJ
...
Migrate all existing JUnit 4 `assert...` based assertions to AssertJ
and add a checkstyle rule to ensure they don't return.
See gh-23022
2019-05-23 15:52:49 -07:00
Phillip Webb
95a9d46a87
Migrate Hamcrest assertions to AssertJ
...
Migrate all existing `assertThat(..., Matcher)` assertions to AssertJ
and add checkstyle rules to ensure they don't return.
See gh-23022
2019-05-23 15:49:59 -07:00
Juergen Hoeller
75d751d968
Polishing
2019-05-20 22:19:11 +02:00
stsypanov
6f07a504b8
A couple of trivial simplifications
2019-05-20 21:41:15 +02:00
Phillip Webb
02850f357f
Migrate exception checking tests to use AssertJ
...
Migrate tests that use `@Test(expectedException=...)` or
`try...fail...catch` to use AssertJ's `assertThatException`
instead.
2019-05-20 10:47:53 -07:00
Juergen Hoeller
a363fed209
Merge branch '5.1.x'
2019-05-20 17:21:07 +02:00
Juergen Hoeller
7edf8aca8e
Drop DefaultNamespaceHandlerResolverTests.testResolveInvalidHandler
...
Closes gh-22994
2019-05-20 17:19:18 +02:00
Juergen Hoeller
9755b59197
Merge branch '5.1.x'
2019-05-13 18:05:07 +02:00
Juergen Hoeller
4af94dfc5d
Clarify AbstractBeanDefinition.getBeanClass() return semantics
...
Closes gh-22960
2019-05-13 18:03:12 +02:00
Sam Brannen
deecab6311
Use assertThat from Hamcrest instead of JUnit 4
...
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894
2019-05-12 14:46:55 +02:00
Sam Brannen
9e1ed6c771
Fix build on JDK 9+
2019-05-12 13:46:14 +02:00
Sam Brannen
6ef7d7124e
Clean up warnings
2019-05-11 15:51:06 +02:00
Phillip Webb
798b51f4a3
Migrate to BDD Mockito
...
Migrate all tests to consistently use BDD Mockito. Also add
checksyle rule to enforce going forwards.
2019-05-08 13:46:13 -07:00
Phillip Webb
816bbee8de
Remove '.*' imports from tests
...
Organize test imports to expand all '.*' static imports into
fully qualified imports.
This update will allow us to use additional checkstyle rules in
the future, and will also help if we migrate fully to AssertJ.
2019-05-08 09:55:09 -07:00
Phil Webb
d7320de871
Migrate away from ExpectedException ( #22922 )
...
* Add limited checkstyles to test code
Add a limited set of checkstyle rules to the test codebase to improve
code consistency.
* Fix checksyle violations in test code
* Organize imports to fix checkstyle for test code
* Migrate to assertThatExceptionOfType
Migrate aware from ExpectedException rules to AssertJ exception
assertions. Also include a checkstyle rules to ensure that the
the ExpectedException is not accidentally used in the future.
See gh-22894
2019-05-08 16:25:52 +02:00
Phillip Webb
7031964e49
Deprecate StandardMetadata constructors
...
Deprecate the public `StandardMetadata` constructors to make it clearer
that these classes should not be instantiated directly. A new
`AnnotationMetadata.introspect` factory method has been added which
can now be used to obtain instances.
This change will allow use to make the constructors package private
and drop the `nestedAnnotationsAsMap` parameter in a future release.
Closes gh-22906
2019-05-07 23:12:42 +02:00
Sam Brannen
ccb01e663a
Merge branch '5.1.x'
2019-05-07 13:03:45 +02:00
Sam Brannen
4aaec942c4
Introduce HTTPS mappings in spring.schemas files
...
Closes gh-22903
2019-05-07 12:56:42 +02:00
Juergen Hoeller
4b06d8e511
Merge branch '5.1.x'
2019-05-07 00:59:56 +02:00
Juergen Hoeller
379d81da74
Consistent thread-safe handling of manualSingletonNames Set
...
Closes gh-22896
2019-05-07 00:47:59 +02:00
Sam Brannen
d616e10dca
Use assertThat from Hamcrest instead of JUnit 4
...
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894
2019-05-05 19:26:04 +02:00
Sam Brannen
c79fdfb668
Use assertThat from Hamcrest instead of JUnit 4
...
org.junit.Assert.assertThat() is deprecated as of JUnit 4.13.
See gh-22894
2019-05-05 18:09:11 +02:00
Juergen Hoeller
ce9162065c
Merge branch '5.1.x'
2019-05-02 17:52:12 +02:00
Juergen Hoeller
8158b6fd86
Update postProcessBeforeInstantiation comment on factory methods
...
Closes gh-22867
2019-05-02 17:28:11 +02:00
Yanming Zhou
900abfce47
Temporal should be simple value type like Date
2019-04-23 12:55:18 +02:00
水木今山
574dffb60b
Some trivial optimization in method populateBean() ( #22792 )
...
Optimize the number of getResolvedAutowireMode() method calls
2019-04-23 12:48:21 +02:00
stsypanov
604361ee1f
Use concatenation instead of torn StringBuilder::append chain
2019-04-09 13:23:22 +02:00
Sam Brannen
80ad60e91b
Fix Javadoc for @Value
2019-04-09 11:30:59 +02:00
Sam Brannen
df15b64e86
Document @Autowired support on parameters
...
Closes gh-21118
2019-04-04 18:31:04 +02:00
Sam Brannen
e1080f8b5f
Polish Javadoc for @Autowired
2019-04-04 18:18:35 +02:00