713795cc34
Polish
...
See gh-27827
2021-12-21 09:36:08 +01:00
3600644ed1
Require type-level @Controller annotation
...
Closes gh-22154
2021-12-14 07:09:08 +00:00
61601de250
Polish formatting
...
See gh-27801
2021-12-13 15:57:58 +01:00
4453102e85
Polish ExceptionHandlerMethodResolver mapping
...
See gh-27801
2021-12-13 15:57:45 +01:00
a15393836c
Merge branch '5.3.x' into main
2021-12-09 15:35:21 +00:00
e9083d7d20
Apply LogFormatUtils in more places
2021-12-09 14:53:52 +00:00
ce253041c5
Merge branch '5.3.x'
2021-12-07 13:57:40 +01:00
9261766677
Fix for ModelAndView.status not working with RedirectView
2021-12-07 13:39:57 +01:00
14f24f43d7
Polishing
2021-12-03 22:36:31 +01:00
24cb1def7d
Polish
...
Closes gh-27754
2021-12-02 14:23:16 +01:00
a0ba808217
Use HttpHeaders.ALLOW instead of String constant
...
This commit changes "Allow" strings into HttpHeaders.ALLOW.
See gh-27356
2021-12-02 12:28:36 +01:00
32359c52b4
Remove transitive dependency on Java EE 8 JAX-B
...
Closes gh-27754
2021-12-02 09:37:48 +00:00
7a4207cd7b
Changes because HttpMethod changed to class
...
This commit contains changes made because HttpMethod changed from enum
to class.
See gh-27697
2021-11-30 13:44:36 +01:00
dcc342ccc5
Merge branch '5.3.x' into main
2021-11-24 13:14:55 +00:00
829bed03af
Polishing contribution
...
Closes gh-27723
2021-11-24 13:05:05 +00:00
ce0aed216b
Add getter for RequestMappingInfo.BuilderConfiguration
...
This improves support for programmatic registration of mappings to
use the same config as that of the RequestMappingHandlerMapping.
See gh-27723
2021-11-24 13:05:05 +00:00
0d7c562693
Polishing contribution
...
Closes gh-910
2021-11-24 13:05:05 +00:00
913cc079af
TagWriter can write empty attribute
...
See gh-910
2021-11-24 13:05:05 +00:00
259bcd60fb
Change deprecated MimeType specificity usages
...
This commit changes all code that uses now deprecated methods in
MimeType and MediaType.
See gh-27580
2021-11-23 11:49:01 +01:00
4750a9430c
Early removal of 5.x-deprecated code
...
Closes gh-27686
2021-11-18 09:18:06 +01:00
17cdd97c37
Merge branch '5.3.x'
2021-11-17 16:57:02 +01:00
5fbdd6dcfe
Throw exception using capturing patterns in AntPathMatcher
...
Closes gh-27688
2021-11-17 16:52:17 +01:00
b88ed7f4bb
Update API version and package references for Jakarta EE 9
...
Closes gh-27689
See gh-25354
2021-11-17 12:39:23 +01:00
5c972fcc54
Use Charset variants of URLEncoder and URLDecoder methods
2021-11-10 16:12:11 +01:00
75036fa0ad
Merge branch '5.3.x'
2021-11-10 14:22:58 +01:00
2a268701c4
Introduce optimizeLocations flag for resource location filtering on startup
...
This flag is off by default since it requires jar files with directory entries.
Closes gh-27624
2021-11-10 14:21:48 +01:00
22f75d9ea9
Merge branch '5.3.x' into main
2021-10-19 12:35:37 +01:00
05ea991d62
Removing locations logging in ResourceHttpRequestHandler
...
See gh-27575
2021-10-19 12:25:33 +01:00
1f248b34f6
Apply "instanceof pattern matching" in spring-webmvc
...
This commit also applies additional clean-up tasks such as the following.
- final fields
- diamond operator (<>) for anonymous inner classes
- try with resources
- multi-catch
This has only been applied to `src/main/java`.
2021-10-17 18:49:02 +02:00
9b9906cfc4
Merge branch '5.3.x' into main
2021-10-14 17:22:29 +01:00
76c9306dda
Adjust logging of resource locations
2021-10-14 17:18:34 +01:00
0705454ce0
Fix typo in Javadoc
...
See gh-27484
2021-10-14 09:42:40 +01:00
ca999fb38c
fix Javadoc typo in PathMatchConfigurer#setUseSuffixPatternMatch
2021-10-14 09:40:49 +01:00
28a497f3b3
Merge branch '5.3.x' into main
2021-10-13 14:58:07 +01:00
4dac8339ff
Filter non-existing static resource locations
...
Same as a2c52a97ba
2021-10-13 14:40:34 +01:00
627fc7612d
Merge branch '5.3.x'
...
# Conflicts:
# build.gradle
2021-10-13 13:06:44 +02:00
0f36569d75
Remove dead fallback code
2021-10-13 12:38:39 +02:00
da457abd5b
Merge branch '5.3.x'
2021-10-12 15:19:40 +02:00
b53275f2d2
Add efficient existence check to ClassPathResource.isReadable()
...
Includes reduced isReadable() check in PathResourceLookupFunction, aligned with PathResourceResolver.
Closes gh-27538
See gh-21372
2021-10-12 15:13:05 +02:00
1490d27d75
Decouple urlResourceWithCharset test from existence of tmp directory
...
See gh-25738
2021-10-12 15:10:19 +02:00
7957b9cc0f
Merge branch '5.3.x' into main
2021-10-12 12:00:55 +01:00
a2c52a97ba
Filter non-existing static resource locations
...
See gh-27538
2021-10-12 11:59:55 +01:00
bd85cb8bac
Merge branch '5.3.x' into main
2021-10-11 11:20:14 +01:00
e8f6cd10a5
Apply value formatting to resolved exceptions
2021-10-11 11:14:02 +01:00
22f0f9f3df
Merge branch '5.3.x'
2021-10-08 21:31:03 +02:00
bdfd983bb4
Fix example code formatting in @EnableWebMvc
2021-10-08 21:30:39 +02:00
56eefe2a13
Merge branch '5.3.x'
2021-10-08 20:42:54 +02:00
87aaf5049b
Polishing
2021-10-08 20:41:51 +02:00
f14bd50033
Prune empty method adapter classes
2021-10-08 18:20:09 +01:00
2d1e0d5e38
Merge branch '5.3.x'
2021-10-06 12:13:21 +02:00
41ae9632d1
Upgrade to Checkstyle 9.0 and spring-javaformat 0.0.29
...
This commit upgrades the Gradle build to use Checkstyle 9.0 and
spring-javaformat 0.0.29 (which internally uses Checkstyle 8.45.1).
Closes gh-27520
2021-10-06 12:11:19 +02:00
381b7d035a
Merge branch '5.3.x'
2021-10-05 14:55:22 +02:00
48a507a993
Clean up warnings
2021-10-05 14:35:32 +02:00
030ba52805
Merge branch '5.3.x'
2021-09-29 16:56:33 +02:00
96e4d3a530
Fail Gradle build for Javadoc warnings
...
In order to catch Javadoc errors in the build, we now enable the
`Xwerror` flag for the `javadoc` tool. In addition, we now use
`Xdoclint:syntax` instead of `Xdoclint:none` in order to validate
syntax within our Javadoc.
This commit fixes all resulting Javadoc errors and warnings.
This commit also upgrades to Undertow 2.2.12.Final and fixes the
artifact names for exclusions for the Servlet and annotations APIs.
The incorrect exclusion of the Servlet API resulted in the Servlet API
being on the classpath twice for the javadoc task, which resulted in the
following warnings in previous builds.
javadoc: warning - Multiple sources of package comments found for package "javax.servlet"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.http"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.descriptor"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.annotation"
Closes gh-27480
2021-09-29 14:02:37 +02:00
93efb20a53
Fix broken links in Javadoc
...
This commit removes several links that were broken due to the removal
of various APIs in 6.0.
See gh-27480
2021-09-28 13:34:33 +02:00
3dc84c2d92
Merge branch '5.3.x'
2021-09-28 11:48:50 +02:00
bfdc99ab79
Fix Javadoc errors
...
See gh-27480
2021-09-28 11:44:12 +02:00
16bf39ea1b
Merge branch '5.3.x'
2021-09-28 10:35:18 +02:00
2567b20949
Upgrade to spring-javaformat 0.0.28 and downgrade to Checkstyle 8.41
...
In order to be able to use text blocks and other new Java language
features, we are upgrading to a recent version of Checkstyle.
The latest version of spring-javaformat-checkstyle (0.0.28) is built
against Checkstyle 8.32 which does not include support for language
features such as text blocks. Support for text blocks was added in
Checkstyle 8.36.
In addition, there is a binary compatibility issue between
spring-javaformat-checkstyle 0.0.28 and Checkstyle 8.42. Thus we cannot
use Checkstyle 8.42 or higher.
In this commit, we therefore upgrade to spring-javaformat-checkstyle
0.0.28 and downgrade to Checkstyle 8.41.
This change is being applied to `5.3.x` as well as `main` in order to
benefit from the enhanced checking provided in more recent versions of
Checkstyle.
Closes gh-27481
2021-09-28 10:29:31 +02:00
50f2016293
Fix timezone specific failing test
...
Update `MvcNamespaceTests` so that the asserted time is in UTC.
2021-09-24 16:52:51 -07:00
f440fb8baf
Unit tests for record binding
...
See gh-27437
2021-09-23 16:13:20 +02:00
8b5f5d9f65
Fix multipart request test with Jetty server
...
See gh-27424
2021-09-17 14:53:45 +01:00
d84ca2ba90
Jakarta EE 9 migration
...
Upgrades many dependency declarations; removes old EJB 2.x support and outdated Servlet-based integrations (Commons FileUpload, FreeMarker JSP support, Tiles).
Closes gh-22093
Closes gh-25354
Closes gh-26185
Closes gh-27423
See gh-27424
2021-09-17 09:14:07 +02:00
674dc2f203
Do not log request parameters for multipart requests
...
Closes gh-27350
2021-09-14 13:40:44 +01:00
52b03e3326
Migrate CoroutinesUtils to Java
...
Migrate `CoroutinesUtils` from Kotlin code to Java and drop the
`kotlin-coroutines` module.
This update removes the need for Kotlin tooling IDE plugins to be
installed.
Closes gh-27379
2021-09-13 17:39:45 +02:00
04e6b233ca
Upgrade to JUnit 5.8
...
Closes gh-27392
2021-09-13 16:38:30 +02:00
cecc0849a8
Upgrade to Gradle 7.2
...
This commit upgrades Gradle to 7.2.
Gradle configuration names are updated accordingly.
This also upgrades Gradle build plugins.
See gh-26870
2021-09-13 09:37:35 +02:00
b6037d0d07
Correctly format class name in default package
...
Closes gh-27247
2021-09-10 10:38:48 +01:00
b6c2c11805
Polishing
2021-09-02 22:21:27 +02:00
9f7a94058a
Update copyright date
...
See gh-27298
2021-08-19 16:23:38 +02:00
caf6760ddd
Fix grammatical errors in Javadoc
...
Closes gh-27298
2021-08-19 16:21:15 +02:00
af6fd6c303
Polish "Fix duplicate "the" in Javadoc and XSD"
...
See gh-27291
2021-08-19 08:54:38 +02:00
ac72277258
Fix duplicate "the" in Javadoc and XSD
...
See gh-27291
2021-08-19 08:44:03 +02:00
eaf9deedfd
Polish tests
...
See gh-27248
2021-08-07 18:53:47 +02:00
55e17ef306
Polishing contribution
...
Closes gh-27203
2021-07-29 14:49:02 +01:00
f2be4e9320
Use MessageSource for @ExceptionHandler methods
...
Follow-up for commit bb816c123c
2021-07-29 14:49:02 +01:00
c2f91765b4
Fix typo in Javadoc in AbstractHandlerMapping
...
Closes gh-27218
2021-07-28 15:19:59 +02:00
bb816c123c
Use MessageSource in HandlerMethod for error reason
...
Closes gh-27156
2021-07-13 19:38:58 +01:00
95d7f883ae
Deprecate LastModified
...
See gh-27075
2021-07-13 12:11:20 +01:00
25131ebf6f
Resource handler initialized only once
...
Closes gh-27153
2021-07-13 11:44:06 +01:00
0267b00a65
Minor update to Javadoc for HandlerInterceptor#postHandle
...
Closes gh-27122
2021-07-13 08:44:54 +01:00
ed27ea7aa0
Restrict fallback multipart binding to POST requests with multipart/form-data
...
Closes gh-26999
See gh-26826
2021-07-12 17:55:49 +02:00
a2ef6badc4
Use StringBuilder.append(char) where possible
...
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098
2021-06-25 10:44:28 +02:00
4e8828dc10
Suppress warnings in ServletAnnotationControllerHandlerMethodTests
2021-06-21 18:55:52 +02:00
df588e030f
Avoid duplicated documentation of validation annotations
...
See gh-27042, gh-27043, gh-27050
2021-06-15 17:30:41 +02:00
b677206159
Polish Javadoc
2021-06-15 17:22:11 +02:00
e04ca3d671
Improve RequestPartMethodArgumentResolver Javadoc
...
Closes gh-27043
2021-06-15 17:06:53 +02:00
2fc47d8752
Improve RequestResponseBodyMethodProcessor Javadoc
...
Closes gh-27042
2021-06-15 17:04:18 +02:00
23f396a231
Nullability refinements
2021-06-08 14:23:06 +02:00
708e61a7ef
Fix WebMvcConfigurationSupport javadoc
2021-06-08 12:50:22 +02:00
f0f450a18d
Polishing
2021-06-07 13:24:46 +02:00
746b1b2fe1
Polishing
2021-05-23 18:27:31 +02:00
ab2c78a9d5
Fix broken Javadoc tags
...
Closes gh-26967
2021-05-23 18:09:34 +02:00
ac0e71745b
Set best matching pattern attribute in WebMvc.fn
...
Prior to this commit, the `RouterFunctionMapping` WebFlux.fn variant
would set the `HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE` as an
exchange attribute. This is useful for instrumentation purposes.
The WebMvc.fn variant would not do the same; this would lead to
"UNKNOWN" path metrics tags.
This commit ensures that the `RouterFunctionMapping` WebMvc.fn variant
does set the `BEST_MATCHING_PATTERN_ATTRIBUTE` and
`BEST_MATCHING_HANDLER_ATTRIBUTE` request attributes.
Closes gh-26963
2021-05-21 11:54:06 +02:00
1469bdbc70
Nullability refinements and related polishing
2021-05-11 16:50:19 +02:00
aa51ed1940
Fix failing tests
...
This commit ensures that if an Origin is returned as it was provided,
possibly with a trailing slash.
See gh-26892
2021-05-10 14:15:16 +01:00
07ba95739b
Fix parameter bug of handler inside the filterFunction DSL
...
Co-authored-by: hojongs <hojong.jjh@gmail.com>
Co-authored-by: bjh970913 <bjh970913@gmail.com>
Closes gh-26838
2021-05-10 09:35:56 +02:00
443c34cc90
CorsRegistry implements combine correctly
...
Closes gh-26877
2021-05-05 21:02:25 +01:00
55faf6e320
Use HttpMethod enums
...
See gh-26855
2021-05-04 12:09:35 +01:00
6f4fb08bf8
Invoke WebMvc.fn error handlers for async errors
...
This commit makes sure that any error handlers registered on the route
are also applied when an error occurs asynchronously. This commit
applies to asynchronous bodies with both CompletableFuture and Reactive
Streams, as well as completely asynchronous responses.
Closes gh-26831
2021-04-30 11:43:40 +02:00
98770b15e7
Polishing
...
Closes gh-26878
2021-04-29 16:53:53 +02:00
86123de883
HandlerMappingIntrospector handles attribute changes properly
...
Closes gh-26833
2021-04-26 17:16:33 +01:00
e7cbe23771
Avoid exceptions when evaluating validation hints
...
Prior to this commit, evaluating validation hints for
@javax.validation.Valid caused exceptions being raised when getting the
value of this annotation, which does not exist. Bypassing
AnnotationUtils.getValue() in those cases can improve performance by
avoiding the cost incurred by raising exceptions.
See gh-26787
2021-04-22 11:19:30 +02:00
69bbdce826
HandlerMappingIntrospector ensures initialized RequestPath
...
Closes gh-26814
2021-04-16 19:56:03 +01:00
27c4e74e24
Update CORS Javadoc in spring-websocket
...
Closes gh-26753
2021-04-13 17:43:40 +01:00
f31933e67e
Nullability refinements
2021-04-13 12:26:52 +02:00
f03ccd5cc9
Fix Javadoc in AcceptHeaderLocaleResolver
...
Closes gh-26793
2021-04-13 11:36:28 +02:00
04ce8e0ac4
Make URL path tests compatible with Windows
...
See gh-26775
2021-04-13 09:52:23 +02:00
29955a2898
Polishing
2021-04-12 22:41:00 +02:00
0a6a6d48e2
Avoid CI failures with UTF-8 chars in test filenames
...
See gh-26775
2021-04-12 20:14:48 +01:00
a08593b44b
Correct matching of static resources with parsed patterns
...
Closes gh-26775
2021-04-12 19:54:20 +01:00
a2d91a562d
Support "Accept-Patch" for unsupported media type
...
This commit introduces support in both servlet and webflux for the
"Accept-Patch" header, which is sent when the client sends unsupported
data in PATCH requests.
See section 2.2 of RFC 5789.
Closes gh-26759
2021-04-08 14:46:59 +02:00
97f3846971
Support "Accept-Patch" for OPTIONS requests
...
This commit introduces support in both servlet and webflux for the
"Accept-Patch" header in OPTIONS requests, as defined in section 3.1 of
RFC 5789.
See gh-26759
2021-04-08 14:43:49 +02:00
7adac25e7e
Update copyright year of changed file
...
See gh-26776
2021-04-08 14:24:18 +02:00
7dca6a36a6
Fix javadoc link syntax
...
See gh-26776
2021-04-08 14:21:11 +02:00
b651c10e83
Fix error messages to match commit #1a9556
...
See gh-26679
2021-03-29 18:30:49 +01:00
5651695fd1
Fix typo in Javadoc
...
Closes gh-26740
2021-03-29 17:59:19 +01:00
1a9556925d
missingAfterConversion flag for missing request values
...
Closes gh-26679
2021-03-29 15:23:29 +01:00
a931ff12f6
MappedInterceptor falls back on PathMatcher
...
Closes gh-26690
2021-03-22 07:12:10 +00:00
530fb0808d
Polishing
2021-03-08 23:45:56 +01:00
b9a612b637
Add RouterFunctionMapping to Javadoc for WebMvcConfigurationSupport
...
Closes gh-26635
2021-03-03 14:44:40 +01:00
7efb4eade6
Delete unnecessary @SuppressWarnings declaration
2021-03-02 14:10:40 +01:00
e89cc9934f
Delete unused method
2021-03-02 14:00:36 +01:00
010b7375fc
Fix typo in Javadoc
2021-03-02 14:00:21 +01:00
01c2e12fef
Polish contribution
...
See gh-26619
2021-03-02 13:54:01 +01:00
90de1ab6d1
Ensure local @CrossOrigin maxAge overrides global value
...
Prior to this commit, a method-level @CrossOrigin maxAge value did not
override a class-level @CrossOrigin maxAge value. This contradicts the
Javadoc for @CrossOrgin which states the following.
For those attributes where only a single value can be accepted such
as allowCredentials and maxAge, the local overrides the global
value.
This commit ensures that a method-level @CrossOrigin maxAge value
overrides a class-level @CrossOrigin maxAge value.
Closes gh-26619
2021-03-02 13:21:35 +01:00
8c9c59eba0
Fix typo
...
See gh-24539
2021-02-25 18:33:35 +00:00
e04269cadd
Consistently check DispatcherType to avoid NPE in tests
...
Closes gh-26602
2021-02-25 18:20:34 +00:00
aa73f6733e
Lenient treatment of malformed Accept header for @ExceptionHandler
...
Closes gh-24539
2021-02-25 17:58:32 +00:00
3ec0452fed
Dedicated, "_"-prefixed log category for request mappings
...
Closes gh-26539
2021-02-24 09:36:43 +00:00
947387b4cd
Fix ResourceUrlProvider handler auto-detection
...
Prior to this commit, `ResourceUrlProvider` would listen and consider
all `ContextRefreshedEvent` and use the given context to detect
`SimpleUrlHandlerMapping`.
This could lead to situations where a `ResourceUrlProvider` uses another
application context than its own (in a parent/child context setup) and
detect the wrong set of handlers.
Because `ResourceUrlProvider` locks itself once the auto-detection is
done, we need to ensure that it considers only events sent by its
application context.
Fixes gh-26561
2021-02-17 22:04:39 +01:00
729535d36c
Ensure presence of cached lookupPath
...
Closes gh-26546
2021-02-15 12:24:07 +00:00
df977a2fd2
Nullability refinements and related polishing
2021-02-14 17:57:32 +01:00
9a4164c4a8
Polish
...
See gh-26538
2021-02-11 08:57:32 +01:00
ab94c7c016
Update WebMvcConfigurer Javadoc for message converters
...
Closes gh-26388
2021-02-05 13:04:44 +00:00
f4c9f6b860
Media types by Class for HttpMessageConverter
...
See gh-26212
2021-02-04 16:12:57 +00:00
c52526ad42
Fix in MockMultipartHttpServletRequest#getMultipartHeaders
...
Previously this method returned headers only when a Content-Type part header
was present. Now it is guaranteed to return headers (possibly empty) as long
as there is a MultipartFile or Part with the given name.
Closes gh-26501
2021-02-03 21:55:42 +00:00
6fde28be98
Fix checkstyle violations
2021-02-03 12:24:45 +00:00
df4ba742cb
Apply global CORS settings to static resources in WebFlux
...
Closes gh-26495
2021-02-03 11:17:59 +00:00
996c86f448
Suppress PREFLIGHT_AMBIGUOUS_MATCH if matches have no CORS config
...
Closes gh-26490
2021-02-03 10:43:08 +00:00
30cdeb23fe
Fix order of headers in DefaultHandlerExceptionResolver
...
Closes gh-26470
2021-01-29 20:30:55 +00:00
355aca7665
Fix DelegatingWebMvcConfigurationTests.configurePathPatternParser()
2021-01-26 16:15:46 +00:00
ec5f99f981
Add mutate() to RequestMappingInfo
...
Closes gh-26428
2021-01-26 11:44:20 +00:00
5a640bb635
Expose mvcPatternParser bean in WebMvcConfigurationSupport
...
See gh-26427
2021-01-22 17:31:59 +00:00
5c1cbb769c
Check that PathPatternParser is not set too late
...
This commit ensures the PathPatternParser cannot be set after request mappings
have been initialized when it is too late.
See gh-26427
2021-01-22 17:31:59 +00:00
e4566c11b8
Apply PathPatternParser also to BeanNameUrlHandlerMapping
...
Closes gh-26414
2021-01-22 15:22:51 +00:00
daa5465003
Checkstyle fix
2021-01-21 15:55:28 +01:00
5a4a677fbd
Fix contextPath request matching with PathPatterns
...
Prior to this commit, `SimpleUrlHandlerMapping` and other
implementations of `AbstractUrlHandlerMapping` would not strip the
Servlet context path from the request path before performing path
matching with PathPattern instances.
This resulted in requests not matching as expected if the application
was configured with a Servlet context path.
This commit ensures that the `RequestPath` "path whithin the
application" is used for matching against path patterns.
Fixes gh-26411
2021-01-21 10:09:49 +01:00
d1a7fed16c
Clean up content type in ContentNegotiatingViewResolver
...
This commit removes the quality value of the selected media type before
setting it in the request attribute.
Closes gh-26315
2021-01-14 14:30:07 +01:00
izeye
Rossen Stoyanchev
Stephane Nicoll
Adam Ostrožlík
Arjen Poutsma
Katada, Junya
Juergen Hoeller
Brian Clozel
ydh6226
liuzhifei
Andreas Grub
/usr/local/ΕΨΗΕΛΩΝ
Arjen Poutsma
Christoph Dreis
Sam Brannen
Phillip Webb
LEE Juchan
Sanghyuk Jung
Syuziko
Yanming Zhou
Sviatoslav Hryb
Sviatoslav Hryb
ShindongLee
Bryce Yang
Hyeonmin Park
Taemin Shin
GungnirLaevatain