Juergen Hoeller
b88ed7f4bb
Update API version and package references for Jakarta EE 9
...
Closes gh-27689
See gh-25354
2021-11-17 12:39:23 +01:00
Christoph Dreis
5c972fcc54
Use Charset variants of URLEncoder and URLDecoder methods
2021-11-10 16:12:11 +01:00
Juergen Hoeller
75036fa0ad
Merge branch '5.3.x'
2021-11-10 14:22:58 +01:00
Juergen Hoeller
2a268701c4
Introduce optimizeLocations flag for resource location filtering on startup
...
This flag is off by default since it requires jar files with directory entries.
Closes gh-27624
2021-11-10 14:21:48 +01:00
Rossen Stoyanchev
22f75d9ea9
Merge branch '5.3.x' into main
2021-10-19 12:35:37 +01:00
Rossen Stoyanchev
05ea991d62
Removing locations logging in ResourceHttpRequestHandler
...
See gh-27575
2021-10-19 12:25:33 +01:00
Sam Brannen
1f248b34f6
Apply "instanceof pattern matching" in spring-webmvc
...
This commit also applies additional clean-up tasks such as the following.
- final fields
- diamond operator (<>) for anonymous inner classes
- try with resources
- multi-catch
This has only been applied to `src/main/java`.
2021-10-17 18:49:02 +02:00
Rossen Stoyanchev
9b9906cfc4
Merge branch '5.3.x' into main
2021-10-14 17:22:29 +01:00
Rossen Stoyanchev
76c9306dda
Adjust logging of resource locations
2021-10-14 17:18:34 +01:00
Rossen Stoyanchev
0705454ce0
Fix typo in Javadoc
...
See gh-27484
2021-10-14 09:42:40 +01:00
liuzhifei
ca999fb38c
fix Javadoc typo in PathMatchConfigurer#setUseSuffixPatternMatch
2021-10-14 09:40:49 +01:00
Rossen Stoyanchev
28a497f3b3
Merge branch '5.3.x' into main
2021-10-13 14:58:07 +01:00
Rossen Stoyanchev
4dac8339ff
Filter non-existing static resource locations
...
Same as a2c52a97ba
, on the WebFlux side.
See gh-27538
2021-10-13 14:40:34 +01:00
Juergen Hoeller
627fc7612d
Merge branch '5.3.x'
...
# Conflicts:
# build.gradle
2021-10-13 13:06:44 +02:00
Juergen Hoeller
0f36569d75
Remove dead fallback code
2021-10-13 12:38:39 +02:00
Juergen Hoeller
da457abd5b
Merge branch '5.3.x'
2021-10-12 15:19:40 +02:00
Juergen Hoeller
b53275f2d2
Add efficient existence check to ClassPathResource.isReadable()
...
Includes reduced isReadable() check in PathResourceLookupFunction, aligned with PathResourceResolver.
Closes gh-27538
See gh-21372
2021-10-12 15:13:05 +02:00
Juergen Hoeller
1490d27d75
Decouple urlResourceWithCharset test from existence of tmp directory
...
See gh-25738
2021-10-12 15:10:19 +02:00
Rossen Stoyanchev
7957b9cc0f
Merge branch '5.3.x' into main
2021-10-12 12:00:55 +01:00
Rossen Stoyanchev
a2c52a97ba
Filter non-existing static resource locations
...
See gh-27538
2021-10-12 11:59:55 +01:00
Rossen Stoyanchev
bd85cb8bac
Merge branch '5.3.x' into main
2021-10-11 11:20:14 +01:00
Rossen Stoyanchev
e8f6cd10a5
Apply value formatting to resolved exceptions
2021-10-11 11:14:02 +01:00
Sam Brannen
22f0f9f3df
Merge branch '5.3.x'
2021-10-08 21:31:03 +02:00
Sam Brannen
bdfd983bb4
Fix example code formatting in @EnableWebMvc
2021-10-08 21:30:39 +02:00
Juergen Hoeller
56eefe2a13
Merge branch '5.3.x'
2021-10-08 20:42:54 +02:00
Juergen Hoeller
87aaf5049b
Polishing
2021-10-08 20:41:51 +02:00
Rossen Stoyanchev
f14bd50033
Prune empty method adapter classes
2021-10-08 18:20:09 +01:00
Sam Brannen
2d1e0d5e38
Merge branch '5.3.x'
2021-10-06 12:13:21 +02:00
Sam Brannen
41ae9632d1
Upgrade to Checkstyle 9.0 and spring-javaformat 0.0.29
...
This commit upgrades the Gradle build to use Checkstyle 9.0 and
spring-javaformat 0.0.29 (which internally uses Checkstyle 8.45.1).
Closes gh-27520
2021-10-06 12:11:19 +02:00
Sam Brannen
381b7d035a
Merge branch '5.3.x'
2021-10-05 14:55:22 +02:00
Sam Brannen
48a507a993
Clean up warnings
2021-10-05 14:35:32 +02:00
Sam Brannen
030ba52805
Merge branch '5.3.x'
2021-09-29 16:56:33 +02:00
Sam Brannen
96e4d3a530
Fail Gradle build for Javadoc warnings
...
In order to catch Javadoc errors in the build, we now enable the
`Xwerror` flag for the `javadoc` tool. In addition, we now use
`Xdoclint:syntax` instead of `Xdoclint:none` in order to validate
syntax within our Javadoc.
This commit fixes all resulting Javadoc errors and warnings.
This commit also upgrades to Undertow 2.2.12.Final and fixes the
artifact names for exclusions for the Servlet and annotations APIs.
The incorrect exclusion of the Servlet API resulted in the Servlet API
being on the classpath twice for the javadoc task, which resulted in the
following warnings in previous builds.
javadoc: warning - Multiple sources of package comments found for package "javax.servlet"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.http"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.descriptor"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.annotation"
Closes gh-27480
2021-09-29 14:02:37 +02:00
Sam Brannen
93efb20a53
Fix broken links in Javadoc
...
This commit removes several links that were broken due to the removal
of various APIs in 6.0.
See gh-27480
2021-09-28 13:34:33 +02:00
Sam Brannen
3dc84c2d92
Merge branch '5.3.x'
2021-09-28 11:48:50 +02:00
Sam Brannen
bfdc99ab79
Fix Javadoc errors
...
See gh-27480
2021-09-28 11:44:12 +02:00
Sam Brannen
16bf39ea1b
Merge branch '5.3.x'
2021-09-28 10:35:18 +02:00
Sam Brannen
2567b20949
Upgrade to spring-javaformat 0.0.28 and downgrade to Checkstyle 8.41
...
In order to be able to use text blocks and other new Java language
features, we are upgrading to a recent version of Checkstyle.
The latest version of spring-javaformat-checkstyle (0.0.28) is built
against Checkstyle 8.32 which does not include support for language
features such as text blocks. Support for text blocks was added in
Checkstyle 8.36.
In addition, there is a binary compatibility issue between
spring-javaformat-checkstyle 0.0.28 and Checkstyle 8.42. Thus we cannot
use Checkstyle 8.42 or higher.
In this commit, we therefore upgrade to spring-javaformat-checkstyle
0.0.28 and downgrade to Checkstyle 8.41.
This change is being applied to `5.3.x` as well as `main` in order to
benefit from the enhanced checking provided in more recent versions of
Checkstyle.
Closes gh-27481
2021-09-28 10:29:31 +02:00
Phillip Webb
50f2016293
Fix timezone specific failing test
...
Update `MvcNamespaceTests` so that the asserted time is in UTC.
2021-09-24 16:52:51 -07:00
Juergen Hoeller
f440fb8baf
Unit tests for record binding
...
See gh-27437
2021-09-23 16:13:20 +02:00
Rossen Stoyanchev
8b5f5d9f65
Fix multipart request test with Jetty server
...
See gh-27424
2021-09-17 14:53:45 +01:00
Juergen Hoeller
d84ca2ba90
Jakarta EE 9 migration
...
Upgrades many dependency declarations; removes old EJB 2.x support and outdated Servlet-based integrations (Commons FileUpload, FreeMarker JSP support, Tiles).
Closes gh-22093
Closes gh-25354
Closes gh-26185
Closes gh-27423
See gh-27424
2021-09-17 09:14:07 +02:00
Rossen Stoyanchev
674dc2f203
Do not log request parameters for multipart requests
...
Closes gh-27350
2021-09-14 13:40:44 +01:00
Sam Brannen
04e6b233ca
Upgrade to JUnit 5.8
...
Closes gh-27392
2021-09-13 16:38:30 +02:00
Rossen Stoyanchev
b6037d0d07
Correctly format class name in default package
...
Closes gh-27247
2021-09-10 10:38:48 +01:00
Juergen Hoeller
b6c2c11805
Polishing
2021-09-02 22:21:27 +02:00
Sam Brannen
9f7a94058a
Update copyright date
...
See gh-27298
2021-08-19 16:23:38 +02:00
LEE Juchan
caf6760ddd
Fix grammatical errors in Javadoc
...
Closes gh-27298
2021-08-19 16:21:15 +02:00
Stephane Nicoll
af6fd6c303
Polish "Fix duplicate "the" in Javadoc and XSD"
...
See gh-27291
2021-08-19 08:54:38 +02:00
Sanghyuk Jung
ac72277258
Fix duplicate "the" in Javadoc and XSD
...
See gh-27291
2021-08-19 08:44:03 +02:00
Syuziko
eaf9deedfd
Polish tests
...
See gh-27248
2021-08-07 18:53:47 +02:00
Rossen Stoyanchev
55e17ef306
Polishing contribution
...
Closes gh-27203
2021-07-29 14:49:02 +01:00
Yanming Zhou
f2be4e9320
Use MessageSource for @ExceptionHandler methods
...
Follow-up for commit bb816c123c
See gh-27203
2021-07-29 14:49:02 +01:00
DongHyuk
c2f91765b4
Fix typo in Javadoc in AbstractHandlerMapping
...
Closes gh-27218
2021-07-28 15:19:59 +02:00
Rossen Stoyanchev
bb816c123c
Use MessageSource in HandlerMethod for error reason
...
Closes gh-27156
2021-07-13 19:38:58 +01:00
Rossen Stoyanchev
95d7f883ae
Deprecate LastModified
...
See gh-27075
2021-07-13 12:11:20 +01:00
Rossen Stoyanchev
25131ebf6f
Resource handler initialized only once
...
Closes gh-27153
2021-07-13 11:44:06 +01:00
Rossen Stoyanchev
0267b00a65
Minor update to Javadoc for HandlerInterceptor#postHandle
...
Closes gh-27122
2021-07-13 08:44:54 +01:00
Juergen Hoeller
ed27ea7aa0
Restrict fallback multipart binding to POST requests with multipart/form-data
...
Closes gh-26999
See gh-26826
2021-07-12 17:55:49 +02:00
Sam Brannen
a2ef6badc4
Use StringBuilder.append(char) where possible
...
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098
2021-06-25 10:44:28 +02:00
Sam Brannen
4e8828dc10
Suppress warnings in ServletAnnotationControllerHandlerMethodTests
2021-06-21 18:55:52 +02:00
Sam Brannen
df588e030f
Avoid duplicated documentation of validation annotations
...
See gh-27042, gh-27043, gh-27050
2021-06-15 17:30:41 +02:00
Sam Brannen
b677206159
Polish Javadoc
2021-06-15 17:22:11 +02:00
Sviatoslav Hryb
e04ca3d671
Improve RequestPartMethodArgumentResolver Javadoc
...
Closes gh-27043
2021-06-15 17:06:53 +02:00
Sviatoslav Hryb
2fc47d8752
Improve RequestResponseBodyMethodProcessor Javadoc
...
Closes gh-27042
2021-06-15 17:04:18 +02:00
Juergen Hoeller
23f396a231
Nullability refinements
2021-06-08 14:23:06 +02:00
Sviatoslav Hryb
708e61a7ef
Fix WebMvcConfigurationSupport javadoc
2021-06-08 12:50:22 +02:00
Sam Brannen
f0f450a18d
Polishing
2021-06-07 13:24:46 +02:00
Sam Brannen
746b1b2fe1
Polishing
2021-05-23 18:27:31 +02:00
izeye
ab2c78a9d5
Fix broken Javadoc tags
...
Closes gh-26967
2021-05-23 18:09:34 +02:00
Brian Clozel
ac0e71745b
Set best matching pattern attribute in WebMvc.fn
...
Prior to this commit, the `RouterFunctionMapping` WebFlux.fn variant
would set the `HandlerMapping.BEST_MATCHING_PATTERN_ATTRIBUTE` as an
exchange attribute. This is useful for instrumentation purposes.
The WebMvc.fn variant would not do the same; this would lead to
"UNKNOWN" path metrics tags.
This commit ensures that the `RouterFunctionMapping` WebMvc.fn variant
does set the `BEST_MATCHING_PATTERN_ATTRIBUTE` and
`BEST_MATCHING_HANDLER_ATTRIBUTE` request attributes.
Closes gh-26963
2021-05-21 11:54:06 +02:00
Juergen Hoeller
1469bdbc70
Nullability refinements and related polishing
2021-05-11 16:50:19 +02:00
Rossen Stoyanchev
aa51ed1940
Fix failing tests
...
This commit ensures that if an Origin is returned as it was provided,
possibly with a trailing slash.
See gh-26892
2021-05-10 14:15:16 +01:00
ShindongLee
07ba95739b
Fix parameter bug of handler inside the filterFunction DSL
...
Co-authored-by: hojongs <hojong.jjh@gmail.com>
Co-authored-by: bjh970913 <bjh970913@gmail.com>
Closes gh-26838
2021-05-10 09:35:56 +02:00
Rossen Stoyanchev
443c34cc90
CorsRegistry implements combine correctly
...
Closes gh-26877
2021-05-05 21:02:25 +01:00
Bryce Yang
55faf6e320
Use HttpMethod enums
...
See gh-26855
2021-05-04 12:09:35 +01:00
Arjen Poutsma
6f4fb08bf8
Invoke WebMvc.fn error handlers for async errors
...
This commit makes sure that any error handlers registered on the route
are also applied when an error occurs asynchronously. This commit
applies to asynchronous bodies with both CompletableFuture and Reactive
Streams, as well as completely asynchronous responses.
Closes gh-26831
2021-04-30 11:43:40 +02:00
Johnny Lim
98770b15e7
Polishing
...
Closes gh-26878
2021-04-29 16:53:53 +02:00
Rossen Stoyanchev
86123de883
HandlerMappingIntrospector handles attribute changes properly
...
Closes gh-26833
2021-04-26 17:16:33 +01:00
Christoph Dreis
e7cbe23771
Avoid exceptions when evaluating validation hints
...
Prior to this commit, evaluating validation hints for
@javax.validation.Valid caused exceptions being raised when getting the
value of this annotation, which does not exist. Bypassing
AnnotationUtils.getValue() in those cases can improve performance by
avoiding the cost incurred by raising exceptions.
See gh-26787
2021-04-22 11:19:30 +02:00
Rossen Stoyanchev
69bbdce826
HandlerMappingIntrospector ensures initialized RequestPath
...
Closes gh-26814
2021-04-16 19:56:03 +01:00
Rossen Stoyanchev
27c4e74e24
Update CORS Javadoc in spring-websocket
...
Closes gh-26753
2021-04-13 17:43:40 +01:00
Juergen Hoeller
f31933e67e
Nullability refinements
2021-04-13 12:26:52 +02:00
Sam Brannen
f03ccd5cc9
Fix Javadoc in AcceptHeaderLocaleResolver
...
Closes gh-26793
2021-04-13 11:36:28 +02:00
Juergen Hoeller
04ce8e0ac4
Make URL path tests compatible with Windows
...
See gh-26775
2021-04-13 09:52:23 +02:00
Juergen Hoeller
29955a2898
Polishing
2021-04-12 22:41:00 +02:00
Rossen Stoyanchev
0a6a6d48e2
Avoid CI failures with UTF-8 chars in test filenames
...
See gh-26775
2021-04-12 20:14:48 +01:00
Rossen Stoyanchev
a08593b44b
Correct matching of static resources with parsed patterns
...
Closes gh-26775
2021-04-12 19:54:20 +01:00
Arjen Poutsma
a2d91a562d
Support "Accept-Patch" for unsupported media type
...
This commit introduces support in both servlet and webflux for the
"Accept-Patch" header, which is sent when the client sends unsupported
data in PATCH requests.
See section 2.2 of RFC 5789.
Closes gh-26759
2021-04-08 14:46:59 +02:00
Arjen Poutsma
97f3846971
Support "Accept-Patch" for OPTIONS requests
...
This commit introduces support in both servlet and webflux for the
"Accept-Patch" header in OPTIONS requests, as defined in section 3.1 of
RFC 5789.
See gh-26759
2021-04-08 14:43:49 +02:00
Stephane Nicoll
7adac25e7e
Update copyright year of changed file
...
See gh-26776
2021-04-08 14:24:18 +02:00
Hyeonmin Park
7dca6a36a6
Fix javadoc link syntax
...
See gh-26776
2021-04-08 14:21:11 +02:00
Rossen Stoyanchev
b651c10e83
Fix error messages to match commit #1a9556
...
See gh-26679
2021-03-29 18:30:49 +01:00
Rossen Stoyanchev
5651695fd1
Fix typo in Javadoc
...
Closes gh-26740
2021-03-29 17:59:19 +01:00
Rossen Stoyanchev
1a9556925d
missingAfterConversion flag for missing request values
...
Closes gh-26679
2021-03-29 15:23:29 +01:00
Rossen Stoyanchev
a931ff12f6
MappedInterceptor falls back on PathMatcher
...
Closes gh-26690
2021-03-22 07:12:10 +00:00
Juergen Hoeller
530fb0808d
Polishing
2021-03-08 23:45:56 +01:00
Taemin Shin
b9a612b637
Add RouterFunctionMapping to Javadoc for WebMvcConfigurationSupport
...
Closes gh-26635
2021-03-03 14:44:40 +01:00
Sam Brannen
7efb4eade6
Delete unnecessary @SuppressWarnings declaration
2021-03-02 14:10:40 +01:00
Sam Brannen
e89cc9934f
Delete unused method
2021-03-02 14:00:36 +01:00