9837ec5904
Fix Javadoc typos
...
Closes #22261
2019-01-17 18:01:08 -05:00
605e2477b9
Polishing
2019-01-08 21:57:13 +01:00
d289befa2b
Fix assertions
2019-01-03 14:20:57 +01:00
556656b35a
Polish "Add missing [ in toString of WebSocketMessageBrokerStats"
...
Closes gh-2068
2019-01-03 13:55:03 +01:00
74630a1b0c
Add missing [ in toString of WebSocketMessageBrokerStats
...
See gh-2068
2019-01-03 13:54:16 +01:00
14e87d2733
Add reference to ConcurrentWebSocketSessionDecorator in the docs.
...
Issue: SPR-12886
2018-12-12 11:57:51 -05:00
38ae282c3b
Update log category precision for all tests
...
Replace the full category capped at 36 chars with the class name only
and 1 char per package, e.g. org.apache.commons.Foo -> o.a.c.Foo
2018-12-12 11:40:33 -05:00
bf272b0b21
Nullability fine-tuning based on IntelliJ IDEA 2018.3 inspection
...
Issue: SPR-15540
2018-11-22 16:12:38 +01:00
d6a5c3428b
Improve docs on STOMP / WebSocket frame max size
...
Issue: SPR-17514
2018-11-20 21:59:47 -05:00
7b6f2f8fb3
Polish contribution
...
Closes gh-2019
2018-11-19 08:45:33 +01:00
bfb49c7249
Fix typos
...
See gh-2019
2018-11-19 08:41:21 +01:00
7aa933437c
Update links to http://java.net/jira
2018-10-01 12:01:28 -04:00
c385a1de83
Polishing
2018-09-17 15:17:39 +02:00
34663300a6
Avoid regex pattern matching for simple String replacement steps
...
Issue: SPR-17279
2018-09-17 14:22:19 +02:00
cf9641686b
StompSubProtocolHandler allows version 1.0
...
Issue: SPR-17258
2018-09-13 20:59:22 -04:00
3302798e2f
Use random id for WebSocket sessions
...
Issue: SPR-17228
2018-09-05 19:48:28 -04:00
a8fbac8472
Polish JavaDoc
...
Issue: SPR-17174
2018-08-18 18:15:05 +02:00
84300b796c
Fix recent javadoc errors
...
Issue: SPR-17174
2018-08-16 18:51:31 +02:00
2ec8fa9cac
SmartLifecycle default methods for auto-startup in default phase
...
Issue: SPR-17188
2018-08-16 12:08:02 +02:00
430065c31d
Order property for SimpUserRegistry
...
Issue:SPR-17142
2018-08-13 11:56:34 +03:00
cfb1ed1009
Clean up warnings and delete dead code
2018-08-12 15:55:11 +02:00
309ffc6d0d
OverflowStrategy in ConcurrentWebSocketSessionDecorator
...
Issue: SPR-17140
2018-08-10 16:15:21 +03:00
61c52d64c5
Polish ConcurrentWebSocketSessionDecoratorTests
2018-08-10 16:15:21 +03:00
be211ceead
Fix typos detected by github.com/client9/misspell
2018-08-08 12:50:46 +02:00
2474c48749
Polishing
2018-08-02 16:55:53 +02:00
b5c691bdac
SPR-17074 Replace pointless wrapping with Arrays.asList with iteration over array
2018-08-02 12:07:00 +02:00
9b671f8408
Polishing
2018-07-31 23:57:19 +02:00
f8340838b3
Use lambda expressions for lazy instantiation ( #1911 )
...
Issue: SPR-17074
2018-07-31 13:03:18 +02:00
3881a4aded
Polishing
2018-07-25 14:16:02 +02:00
d3b244a81b
Optimize class detection by sharing the ClassLoader
...
Issue: SPR-17083
2018-07-25 11:09:42 +02:00
02403f6a34
Polishing
2018-07-24 21:44:43 +02:00
11881ff211
Polishing
2018-07-24 18:45:52 +02:00
23c379d5c0
Order setter for DefaultSimpUserRegistry
...
Issue: SPR-17023
2018-07-24 12:23:13 -04:00
7500b144ae
Option to preserve publish order
...
Issue: SPR-13989
2018-07-23 23:24:39 -04:00
9a43d2ec20
Revised log levels: less WARN and INFO, fine-tuned DEBUG vs TRACE
...
Issue: SPR-16946
2018-07-20 15:05:16 +02:00
3d6e38bb43
Conditional registration of task scheduler for SockJS
...
Issue: SPR-16189
2018-07-11 11:10:03 -04:00
6aa6d91ea9
Remove deprecated constructors in WebSocket config
...
In preparation for SPR-16189.
2018-07-11 11:10:03 -04:00
4ff1e3e74b
Consistent abstract declaration for utility classes (plus polishing)
...
Issue: SPR-16968
2018-07-01 02:31:20 +02:00
a89e716cc7
Use tabs rather than spaces in tests
...
Update tests to ensure that tabs are used instead of spaces. Also
consistently apply a new line at the end of each file.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
81451aa800
Organize imports
...
Reorganize imports to ensure consistent ordering. This commit also
expands any `.*` static imports in favor of using fully-qualified
method references.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
5cedd0d5d4
Consistently use tabs rather than spaces
...
Update code that has accidentally used spaces instead of tabs.
Also remove all trailing whitespace.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
0b53c1096a
Always use 'this.' when accessing fields
...
Ensure that `this.` is used consistently when accessing class
fields.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
eeebd51f57
Use consistent class design
...
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
c3a17dfd47
Ensure all files end with a newline
...
Update all files to ensure that they always end with a new line.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
e0480f75ac
Fix javadoc checkstyle issues
...
Fix checkstyle violations for javadoc.
Issue: SPR-16968
2018-06-28 10:28:44 +02:00
ac37b678a3
Remove JSONP support
...
CORS is now widely supported and should be used instead for cross-domain
requests.
Issue: SPR-16914
2018-06-08 12:15:48 +02:00
fbf25c536d
ChannelInterceptor default methods + deprecate adapter
2018-05-23 21:48:19 -04:00
592dc628d5
Use specific XSD types in spring-websocket.xsd
...
Issue: SPR-16531
2018-05-18 21:32:46 -04:00
37b0ed9fcb
Improve TCP connection info logging.
...
After the recent changes to expose configuring TcpOperations, it no
longer makes sense to automatically log the relayHost/Port since that's
mutually exclusive with a custom TcpOperations.
Instead we delegate to TcpOperations.toString().
Issue: SPR-16801
2018-05-16 11:40:51 -04:00
020c6c0102
Polish: remove Javadoc tags from spring-websocket.xsd
2018-05-16 10:18:01 -04:00
29158aa79a
Expose timeToFirstMessage in Java/XML config
...
Issue: SPR-16531
2018-05-16 10:03:57 -04:00
fb898e1727
Remove inconsistent spaces
2018-05-05 11:07:35 +02:00
0e776d4e77
Add more detail to ISE in ServerEndpointExporter
...
Issue: SPR-16655
2018-04-23 17:03:09 -04:00
ff2228fdaf
Selector header name is exposed for configuration
...
Issue: SPR-16732
2018-04-16 23:56:30 -04:00
4aae6a6dda
Use Map.forEach instead of manual Map.Entry iteration wherever possible SPR-16646
2018-03-28 01:09:03 +02:00
e3d0ef6015
Use Map.forEach instead of manual Map.Entry iteration wherever possible
...
Issue: SPR-16646
2018-03-27 00:38:32 +02:00
d4a8f76bf9
Consistent volatile access to running flag in Lifecycle implementations
...
Issue: SPR-16488
2018-03-15 15:17:55 +01:00
407ecf7334
to get rid of "magic" time constants
2018-03-08 20:37:48 +01:00
139dc1d373
Polishing (collapsed if checks, consistent downcasts, refined javadoc)
2018-03-08 18:11:57 +01:00
0f7485b01d
Polish: reorder the modifiers to comply with the Java Language Specification.
2018-03-08 17:57:47 +01:00
cec7204fca
Polishing
2018-03-02 13:53:17 +01:00
ed936cbd89
Polish: Overriding methods should do more than simply call the same method in the super class
2018-03-02 00:06:27 +01:00
bfddbbe731
Polishing
2018-03-01 01:39:06 +01:00
8080f56db8
Polish: "@Override" should be used on overriding and implementing methods
2018-03-01 00:15:18 +01:00
a5cbf5fe24
Consistent use of Collection.toArray with zero-sized array argument
...
Includes consistent use of ClassUtils.toClassArray (as non-null variant)
Issue: SPR-16523
2018-02-22 11:29:46 +01:00
0de36d2883
Consistent HttpMethod identity comparisons
2018-02-18 22:01:22 +01:00
37f19a4b43
Polish Javadoc
...
WebSocketMessageBrokerStats's Javadoc now states the correct default
logging period.
Closes gh-1691
2018-02-18 08:57:08 +01:00
d7cab23e6d
Consistent use of StringUtils.toStringArray
...
(cherry picked from commit 6d11b40
2018-02-16 20:49:17 +01:00
b35274f5a7
WebSocket callbacks need to remain inner classes (retaining generics)
2018-02-16 10:22:05 +01:00
2be4985b8f
Polish: anonymous inner classes containing only one method should become lambdas,
...
use getOrDefault instead of ternary operator
2018-02-16 09:38:19 +01:00
45e520ed86
Polish: remove unused private fields, remove empty operator
2018-02-13 23:00:18 +01:00
3c631f8ea0
SubProtocolWebSocketHandler closes sessions outside of lifecycle monitor
...
Issue: SPR-16488
2018-02-13 00:04:55 +01:00
d00e1c5e4f
Polishing
2018-02-10 21:35:46 +01:00
39201adca4
Consistent handling of InterruptedException
...
Issue: SPR-16479
2018-02-10 13:03:33 +01:00
d3a1d44864
Polish: Maps with keys that are enum values should be replaced with EnumMap
2018-02-10 12:09:33 +01:00
9a6fbf59c5
Polish: follow name convention - make immutable fields final
2018-02-10 12:09:19 +01:00
5c813a366b
Consistent use of @throws instead of @exception
2018-02-05 22:51:51 +01:00
cf100d4d03
AbstractClientSockJsSession.close propagates IOException from disconnect
...
Issue: SPR-16415
2018-01-25 12:24:46 +01:00
8e2be91353
Fine-tuned logging of WebSocket close exceptions
...
Issue: SPR-16409
2018-01-25 12:24:40 +01:00
0e6f8df0a8
ServletServerHttpRequest.getURI() ignores malformed query string
...
The resolved URI instance is also being cached now. This should not make a difference in a real Servlet environment but does affect tests which assumed they could modify an HttpServletRequest path behind a pre-created ServletServerHttpRequest instance. Our WebSocket test base class has been revised accordingly, re-creating the ServletServerHttpRequest in such a case.
Issue: SPR-16414
2018-01-24 22:13:40 +01:00
43d3abdfd5
Fix SockJs CorsConfiguration for forbidden origins
...
After this commit, AbstractSockJsService uses the configured allowed
origins when generating the CorsConfiguration instead of "*".
As a consequence, forbidden origin requests still result in a 403
response but now with no CORS headers in order to improve consistency
between the status code and the headers.
Issue: SPR-16304
2018-01-15 18:07:24 +01:00
61352fe85b
Fix compile error
2018-01-15 10:28:12 -05:00
dd09c08cdf
Replace use of AbstractWebSocketMessageBrokerConfigurer
2018-01-15 10:01:14 -05:00
d6591a6329
Default methods in WebSocketMessageBrokerConfigurer
...
+ deprecate AbstractWebSocketMessageBrokerConfigurer
2018-01-15 09:54:55 -05:00
7406f5993a
Polishing
2017-11-13 22:39:39 +01:00
b5cedd43eb
Consistent and efficient access to BeanDefinition argument values
...
Issue: SPR-16192
2017-11-13 21:51:11 +01:00
9fab208fdd
Reduce access on headers for STOMP messaging
...
Issue: SPR-16165
2017-11-06 20:19:00 +01:00
5809f5b8eb
SubProtocolWebSocketHandler provides protected decorateSession method
...
Issue: SPR-16089
2017-10-21 23:02:54 +02:00
1cc5afe24b
Fix lines over 120 characters
...
https://github.com/spring-projects/spring-framework/wiki/Spring-Framework-Code-Style#line-wrapping
2017-10-20 16:42:26 -04:00
a4537b1b6d
Accessors for configured send-time and buffer-size limit
...
Issue: SPR-16089
2017-10-20 16:02:26 +02:00
16a08cb465
Upgrade to Jackson 2.9.2
2017-10-16 23:53:23 +02:00
efce7902c4
Polishing
2017-09-27 01:34:11 +02:00
7ae59d0c2a
Nullability refinements on private and static methods
...
Based on IntelliJ IDEA 2017.3 introspection results.
Issue: SPR-15756
2017-09-22 18:22:14 +02:00
4cbef27f90
Consistent tolerance of unknown HTTP status codes behind RestTemplate
...
Issue: SPR-15978
2017-09-20 10:54:58 +02:00
1bc93e3d0f
Revisit nullability annotations
...
This commit introduces the following changes.
1) It adds a new Spring @NonNull annotation which allows to apply
@NonNullApi semantic on a specific element, like @Nullable does.
Combined with @Nullable, it allows partial null-safety support when
package granularity is too broad.
2) @Nullable and @NonNull can apply to ElementType.TYPE_USE in order
to be used on generic type arguments (SPR-15942).
3) Annotations does not apply to ElementType.TYPE_PARAMETER anymore
since it is not supported yet (applicability for such use case is
controversial and need to be discussed).
4) @NonNullApi does not apply to ElementType.FIELD anymore since in a
lot of use cases (private, protected) it is not part for the public API
+ its usage should remain opt-in. A dedicated @NonNullFields annotation
has been added in order to set fields default to non-nullable.
5) Updated Javadoc and reference documentation.
Issue: SPR-15756
2017-09-15 13:26:41 +02:00
fd0132c7e6
Polishing
2017-09-08 16:56:22 +02:00
73cf07e9a4
Fix overridden methods nullability
...
Issue: SPR-15869
2017-08-17 15:02:59 +02:00
25e6a2da64
StompSubProtocolHandler consistently accesses current user
...
Issue: SPR-15822
2017-07-27 11:32:32 +02:00
7e232f989b
Improve check for "Broken pipe" error message
...
Issue: SPR-15802
2017-07-25 10:30:11 +02:00
46eba3dbfa
Nullability fine-tuning around declaration inconsistencies
...
Issue: SPR-15720
Issue: SPR-15792
2017-07-19 22:22:20 +02:00
Rossen Stoyanchev
Juergen Hoeller
Stephane Nicoll
Niconal
Hanope
Sam Brannen
Kazuhiro Sera
stsypanov
Sebastien Deleuze
Phillip Webb
Johnny Lim
igor-suhorukov
Alexander Münch
Sergey
Christoph Dreis