Rossen Stoyanchev
583435d068
Consistent ordering in MethodNotAllowedException
...
This caused random failures in a newly added test. Also remove defensive
check in ResponseStatusExceptionResolver.
See gh-24944
2020-04-25 07:33:30 +01:00
Rossen Stoyanchev
18474c921d
Document IAE in HttpHeaders methods that parse ETags
...
See gh-24950
2020-04-24 13:02:12 +01:00
Brian Clozel
dc4cda1b13
WARN against invalid patterns with PathPatternParser
...
As of gh-24952, `PathPatternParser` will strictly reject patterns with
`"**"` in the middle of them. `"**"` is only allowed at the end of the
pattern for matching multiple path segments until the end of the path.
Currently, if `"**"` is used in the middle of a pattern it will be
considered as a single `"*"` instead. Rejecting such cases should
clarify the situation.
This commit prepares for that upcoming change and:
* logs a warning message if such a case is used by an application
* expands the MVC and WebFlux documentation about URI matching in
general
Closes gh-24958
2020-04-23 13:03:05 +02:00
Rossen Stoyanchev
8d31dcaa29
Clarification on path extension deprecations
...
Closes gh-24642
2020-04-20 14:43:07 +01:00
Deycoesr
87f28ce48e
Simplify some control flow code
...
Closes gh-24925
2020-04-17 18:32:02 +02:00
Sam Brannen
b8835c9f32
Copy MockHttpServletRequest changes to spring-web
...
See gh-24916
2020-04-17 16:20:42 +02:00
Oliver Degener
df291a39b1
Fix Javadoc link in DefaultCorsProcessor
...
Closes gh-24921
2020-04-17 09:26:53 +02:00
Sébastien Deleuze
67955dfb35
Prevent duplicated Vary headers in CORS processing
...
Closes gh-24829
2020-04-15 11:23:59 +02:00
Juergen Hoeller
de0d06fab5
Polishing
2020-04-09 11:49:35 +02:00
Lars Grefer
8682a5d89a
Honor overriden AccepptHeaderLocaleContextResolver.getDefaultLocale()
2020-04-09 11:37:50 +02:00
Sam Brannen
9f0ce09cf0
Update copyright date
2020-04-02 16:33:50 +02:00
Sam Brannen
c9e13d448a
Revert change to PathPattern Javadoc
2020-04-02 16:28:26 +02:00
Gurps Bassi
4aca91c3b0
corrected javadoc
2020-04-01 22:05:53 +01:00
Rossen Stoyanchev
7d0f48289b
Improve error handling in WebAsyncManager
...
See gh-24835
2020-04-01 18:35:22 +01:00
陈其苗
13970ae528
Use autoboxing instead of explicit wrapping in tests
...
Closes gh-24801
2020-04-01 14:34:20 +02:00
Sam Brannen
d8567749b8
Fix Javadoc
2020-03-31 19:14:56 +02:00
Sam Brannen
89d282125a
Ensure logPrefix is not null or blank in AbstractListenerWriteProcessor
2020-03-31 18:49:05 +02:00
Sam Brannen
e87ab6f4ee
Update Javadoc for AbstractListenerWriteProcessor.write()
...
Co-authored-by: Rossen Stoyanchev <rstoyanchev@pivotal.io>
2020-03-31 18:47:06 +02:00
Sam Brannen
ddaf0029ae
Polishing
2020-03-31 16:31:34 +02:00
Sam Brannen
329f08ad08
Suppress warnings in Gradle build
2020-03-31 12:17:58 +02:00
Sam Brannen
e26764d249
Remove duplicate words in documentation and polish Javadoc
2020-03-31 12:17:58 +02:00
Sam Brannen
9e30620ac2
Polish contribution
...
See gh-24805
2020-03-30 13:47:00 +02:00
Сергей Цыпанов
e63d1cf12d
Improve usage of ByteArrayOutputStream/ByteArrayInputStream
...
Closes gh-24805
2020-03-30 13:22:21 +02:00
Qimiao Chen
f8ff4e42b9
Use try-with-resource to close resources
...
Closes gh-24807
2020-03-30 12:05:29 +02:00
Qimiao Chen
7c831d2ef4
Replace anonymous inner classes with lambdas in tests
...
Closes gh-24808
2020-03-30 12:02:23 +02:00
Rossen Stoyanchev
3175f0771e
Remove dumpString from DataBufferTestUtils
...
See gh-24786
2020-03-26 21:42:12 +00:00
Rossen Stoyanchev
7aa06b8610
Polishing contribution
...
See gh-24786
2020-03-26 21:42:12 +00:00
Сергей Цыпанов
f17b0125ff
Simplify conversion of DataBuffer to String
...
See gh-24786
2020-03-26 21:42:12 +00:00
Rossen Stoyanchev
dd3dd5d67d
UriComponentsBuilder.cloneBuilder copies uriVariables
...
Closes gh-24772
2020-03-26 16:31:25 +00:00
Johnny Lim
0f50a9a60a
Fix empty domain handling in ResponseCookie
...
This commit also updates its test to use its intended inputs.
2020-03-25 08:18:03 +00:00
Juergen Hoeller
1800b10717
Expose parameter annotations from interfaces across entire class hierarchy
...
Closes gh-24127
2020-03-23 17:57:44 +01:00
Juergen Hoeller
7ebd850b85
Mark MediaTypeNotSupportedStatusException as deprecated
...
Closes gh-24743
2020-03-23 17:56:28 +01:00
Rossen Stoyanchev
e11373fe69
Unwrap XMLStreamException from cause
...
Closes: gh-24622
2020-03-23 12:22:43 +00:00
Rossen Stoyanchev
a7fe6b8f5c
Avoid NPE in ResponseCookie on null domain
...
See gh-24663
2020-03-19 12:18:29 +00:00
Rossen Stoyanchev
b121c0e2ea
Avoid ClassCastException in TomcatHttpHandlerAdapter
...
Closes gh-24707
2020-03-19 12:17:24 +00:00
Sam Brannen
17140c8d4b
Polish contribution
...
See gh-24595
2020-03-17 17:15:12 +01:00
Andrew Woodbury
2fb13d410d
Include response body in UnknownHttpStatusCodeException
...
Spring Framework 5.2.2 introduced a regression in
DefaultResponseErrorHandler.handleError(ClientHttpResponse)
Specifically, for use cases where the InputStream had already been
consumed by the first invocation of getResponseBody(), the second
invocation of getResponseBody() resulted in the response body being
absent in the created UnknownHttpStatusCodeException.
This commit fixes this by invoking getResponseBody() only once in
DefaultResponseErrorHandler.handleError(ClientHttpReponse) in order to
reuse the retrieved response body for creating the exception message
and as a separate argument to the UnknownHttpStatusCodeException
constructor.
Closes gh-24595
2020-03-17 17:06:57 +01:00
Sam Brannen
a8feb792da
Fix broken Javadoc links
2020-03-16 16:30:27 +01:00
Rossen Stoyanchev
a599859595
ServerCookie ignores empty domain with double quotes
...
Closes gh-24663
2020-03-12 12:21:19 +00:00
Juergen Hoeller
6df80a8f70
Restore original JsonMappingException handling (assuming invalid input)
...
Closes gh-24610
Closes gh-24630
Closes gh-24646
2020-03-11 14:51:36 +01:00
Rossen Stoyanchev
a98bf30ee6
ShallowEtagHeaderFilter checks for pre-existing eTag
...
The filter now checks for an explicitly set eTag and uses it instead of
generating one, and also suppresses caching.
Closes gh-24635
2020-03-04 19:17:56 +00:00
Rossen Stoyanchev
d3da7a50ec
Polishing and minor refactoring
...
See gh-24635
2020-03-04 19:17:56 +00:00
Rossen Stoyanchev
2afae430eb
Update list of support multipart media types
...
See gh-24582
2020-03-03 15:38:00 +00:00
Johnny Lim
8285666ee8
Polish ReactorResourceFactory
...
Closes gh-24620
2020-03-02 13:48:19 +01:00
Adrian Cole
7f5395a216
Fix typos in AbstractClientHttpRequest
...
Closes gh-24623
2020-03-02 13:36:47 +01:00
ZhangT
c5fb7b9fb7
Simplify some redundant code
...
Closes gh-24586
Co-authored-by: Sam Brannen <sbrannen@pivotal.io>
2020-02-26 12:29:09 +01:00
Juergen Hoeller
d72c90cd7a
Assign TokenBuffer field with createToken() result
2020-02-25 15:21:28 +01:00
Rossen Stoyanchev
b6f502db4e
Polishing
2020-02-25 10:07:29 +00:00
Brian Clozel
f1680e5cee
Configure quiet period for shutting down Reactor resources
...
This commit adds two new properties to the `ReactorResourceFactory`.
This allows to configure the quiet and timeout periods when shutting
down Reactor resources. While we'll retain Reactor Netty's default for
production use, this option is useful for tests and developement
environments when developers want to avoid long waiting times when
shutting down resources.
Fixes gh-24538
2020-02-24 18:15:59 +01:00
Rossen Stoyanchev
de608a08ed
Polishing contribution
...
See gh-24518
2020-02-20 15:56:13 +00:00