root
/
spring-framework
mirror of https://github.com/spring-projects/spring-framework.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity
16,805 Commits 18 Branches 337 Tags 367 MiB
Commit Graph

698 Commits

Author SHA1 Message Date
Juergen Hoeller 4ff1e3e74b Consistent abstract declaration for utility classes (plus polishing) 
Issue: SPR-16968
 2018-07-01 02:31:20 +02:00
Phillip Webb a89e716cc7 Use tabs rather than spaces in tests 
Update tests to ensure that tabs are used instead of spaces. Also
consistently apply a new line at the end of each file.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb 81451aa800 Organize imports 
Reorganize imports to ensure consistent ordering. This commit also
expands any `.*` static imports in favor of using fully-qualified
method references.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb 5cedd0d5d4 Consistently use tabs rather than spaces 
Update code that has accidentally used spaces instead of tabs.
Also remove all trailing whitespace.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb 0b53c1096a Always use 'this.' when accessing fields 
Ensure that `this.` is used consistently when accessing class
fields.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb eeebd51f57 Use consistent class design 
Update all classes so that inner classes are always last. Also
ensure that utility classes are always final and have a private
constructor and make exceptions final whenever possible.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb c3a17dfd47 Ensure all files end with a newline 
Update all files to ensure that they always end with a new line.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Phillip Webb e0480f75ac Fix javadoc checkstyle issues 
Fix checkstyle violations for javadoc.

Issue: SPR-16968
 2018-06-28 10:28:44 +02:00
Sebastien Deleuze ac37b678a3 Remove JSONP support 
CORS is now widely supported and should be used instead for cross-domain
requests.

Issue: SPR-16914
 2018-06-08 12:15:48 +02:00
Rossen Stoyanchev fbf25c536d ChannelInterceptor default methods + deprecate adapter 2018-05-23 21:48:19 -04:00
Rossen Stoyanchev 592dc628d5 Use specific XSD types in spring-websocket.xsd 
Issue: SPR-16531
 2018-05-18 21:32:46 -04:00
Rossen Stoyanchev 37b0ed9fcb Improve TCP connection info logging. 
After the recent changes to expose configuring TcpOperations, it no
longer makes sense to automatically log the relayHost/Port since that's
mutually exclusive with a custom TcpOperations.

Instead we delegate to TcpOperations.toString().

Issue: SPR-16801
 2018-05-16 11:40:51 -04:00
Rossen Stoyanchev 020c6c0102 Polish: remove Javadoc tags from spring-websocket.xsd 2018-05-16 10:18:01 -04:00
Rossen Stoyanchev 29158aa79a Expose timeToFirstMessage in Java/XML config 
Issue: SPR-16531
 2018-05-16 10:03:57 -04:00
Johnny Lim fb898e1727 Remove inconsistent spaces 2018-05-05 11:07:35 +02:00
Rossen Stoyanchev 0e776d4e77 Add more detail to ISE in ServerEndpointExporter 
Issue: SPR-16655
 2018-04-23 17:03:09 -04:00
Rossen Stoyanchev ff2228fdaf Selector header name is exposed for configuration 
Issue: SPR-16732
 2018-04-16 23:56:30 -04:00
igor-suhorukov 4aae6a6dda Use Map.forEach instead of manual Map.Entry iteration wherever possible SPR-16646 2018-03-28 01:09:03 +02:00
Juergen Hoeller e3d0ef6015 Use Map.forEach instead of manual Map.Entry iteration wherever possible 
Issue: SPR-16646
 2018-03-27 00:38:32 +02:00
Juergen Hoeller d4a8f76bf9 Consistent volatile access to running flag in Lifecycle implementations 
Issue: SPR-16488
 2018-03-15 15:17:55 +01:00
igor-suhorukov 407ecf7334 to get rid of "magic" time constants 2018-03-08 20:37:48 +01:00
Juergen Hoeller 139dc1d373 Polishing (collapsed if checks, consistent downcasts, refined javadoc) 2018-03-08 18:11:57 +01:00
igor-suhorukov 0f7485b01d Polish: reorder the modifiers to comply with the Java Language Specification. 2018-03-08 17:57:47 +01:00
Juergen Hoeller cec7204fca Polishing 2018-03-02 13:53:17 +01:00
igor-suhorukov ed936cbd89 Polish: Overriding methods should do more than simply call the same method in the super class 2018-03-02 00:06:27 +01:00
Juergen Hoeller bfddbbe731 Polishing 2018-03-01 01:39:06 +01:00
igor-suhorukov 8080f56db8 Polish: "@Override" should be used on overriding and implementing methods 2018-03-01 00:15:18 +01:00
Juergen Hoeller a5cbf5fe24 Consistent use of Collection.toArray with zero-sized array argument 
Includes consistent use of ClassUtils.toClassArray (as non-null variant)

Issue: SPR-16523
 2018-02-22 11:29:46 +01:00
Juergen Hoeller 0de36d2883 Consistent HttpMethod identity comparisons 2018-02-18 22:01:22 +01:00
Alexander Münch 37f19a4b43 Polish Javadoc 
WebSocketMessageBrokerStats's Javadoc now states the correct default
logging period.

Closes gh-1691
 2018-02-18 08:57:08 +01:00
Juergen Hoeller d7cab23e6d Consistent use of StringUtils.toStringArray 
(cherry picked from commit 6d11b40)
 2018-02-16 20:49:17 +01:00
Juergen Hoeller b35274f5a7 WebSocket callbacks need to remain inner classes (retaining generics) 2018-02-16 10:22:05 +01:00
igor-suhorukov 2be4985b8f Polish: anonymous inner classes containing only one method should become lambdas, 
use getOrDefault instead of ternary operator
 2018-02-16 09:38:19 +01:00
igor-suhorukov 45e520ed86 Polish: remove unused private fields, remove empty operator 2018-02-13 23:00:18 +01:00
Juergen Hoeller 3c631f8ea0 SubProtocolWebSocketHandler closes sessions outside of lifecycle monitor 
Issue: SPR-16488
 2018-02-13 00:04:55 +01:00
Juergen Hoeller d00e1c5e4f Polishing 2018-02-10 21:35:46 +01:00
Juergen Hoeller 39201adca4 Consistent handling of InterruptedException 
Issue: SPR-16479
 2018-02-10 13:03:33 +01:00
igor-suhorukov d3a1d44864 Polish: Maps with keys that are enum values should be replaced with EnumMap 2018-02-10 12:09:33 +01:00
igor-suhorukov 9a6fbf59c5 Polish: follow name convention - make immutable fields final 2018-02-10 12:09:19 +01:00
Juergen Hoeller 5c813a366b Consistent use of @throws instead of @exception 2018-02-05 22:51:51 +01:00
Juergen Hoeller cf100d4d03 AbstractClientSockJsSession.close propagates IOException from disconnect 
Issue: SPR-16415
 2018-01-25 12:24:46 +01:00
Juergen Hoeller 8e2be91353 Fine-tuned logging of WebSocket close exceptions 
Issue: SPR-16409
 2018-01-25 12:24:40 +01:00
Juergen Hoeller 0e6f8df0a8 ServletServerHttpRequest.getURI() ignores malformed query string 
The resolved URI instance is also being cached now. This should not make a difference in a real Servlet environment but does affect tests which assumed they could modify an HttpServletRequest path behind a pre-created ServletServerHttpRequest instance. Our WebSocket test base class has been revised accordingly, re-creating the ServletServerHttpRequest in such a case.

Issue: SPR-16414
 2018-01-24 22:13:40 +01:00
sdeleuze 43d3abdfd5 Fix SockJs CorsConfiguration for forbidden origins 
After this commit, AbstractSockJsService uses the configured allowed
origins when generating the CorsConfiguration instead of "*".

As a consequence, forbidden origin requests still result in a 403
response but now with no CORS headers in order to improve consistency
between the status code and the headers.

Issue: SPR-16304
 2018-01-15 18:07:24 +01:00
Rossen Stoyanchev 61352fe85b Fix compile error 2018-01-15 10:28:12 -05:00
Rossen Stoyanchev dd09c08cdf Replace use of AbstractWebSocketMessageBrokerConfigurer 2018-01-15 10:01:14 -05:00
Sergey d6591a6329 Default methods in WebSocketMessageBrokerConfigurer 
+ deprecate AbstractWebSocketMessageBrokerConfigurer
 2018-01-15 09:54:55 -05:00
Juergen Hoeller 7406f5993a Polishing 2017-11-13 22:39:39 +01:00
Juergen Hoeller b5cedd43eb Consistent and efficient access to BeanDefinition argument values 
Issue: SPR-16192
 2017-11-13 21:51:11 +01:00
Christoph Dreis 9fab208fdd Reduce access on headers for STOMP messaging 
Issue: SPR-16165
 2017-11-06 20:19:00 +01:00