d39e44c209
Deprecate AutowireCapableBeanFactory.createBean(Class, int, boolean)
...
Includes consistent usage of createBean(Class) in SpringBeanJobFactory and SpringBeanContainer.
Closes gh-30345
See gh-29855
See gh-30041
2023-04-30 23:07:29 +02:00
1734deca1e
Refactor AssertJ assertions into more idiomatic ones
...
This commit refactors some AssertJ assertions into more idiomatic and
readable ones. Using the dedicated assertion instead of a generic one
will produce more meaningful error messages.
For instance, consider collection size:
```
// expected: 5 but was: 2
assertThat(collection.size()).equals(5);
// Expected size: 5 but was: 2 in: [1, 2]
assertThat(collection).hasSize(5);
```
Closes gh-30104
2023-04-04 17:34:07 +02:00
6cd67412cc
Avoid lock contention in CaffeineCacheManager
...
Prior to this commit, using a dynamic `CaffeineCacheManager` would rely
on `ConcurrentHashMap#computeIfAbsent` for retrieving and creating cache
instances as needed. It turns out that using this method concurrently
can cause lock contention even when all known cache instances are
instantiated.
This commit avoids using this method if the cache instance already
exists and avoid storing `null` entries in the map. This change reduces
lock contention and the overall HashMap size in the non-dynamic case.
Fixes gh-30066
2023-03-08 16:23:32 +01:00
162c09d036
Apply "instanceof pattern matching" in remainder of spring-context-support module
...
See gh-30067
2023-03-05 19:09:32 +01:00
f8cb0fa2a0
Custom resolution of preferred constructors for createBean(Class)
...
Avoids side effects of traditional AUTOWIRE_CONSTRUCTOR algorithm.
Closes gh-30041
2023-03-02 12:54:26 +01:00
2e1374b459
Update copyright headers
2023-02-19 13:41:36 +01:00
431ae03447
Polish
...
Closes gh-29928
2023-02-09 09:54:19 +01:00
0e8838db90
Flexible constructor resolution in AutowireCapableBeanFactory.createBean(Class)
...
Closes gh-29855
See gh-29823
2023-01-19 17:10:42 +01:00
0502d18e3d
Update copyright headers
2023-01-19 16:20:03 +01:00
c4c786596f
Migrate to Mockito.mock(T...) where feasible
2023-01-19 16:20:02 +01:00
a4956dfe26
Update copyright headers
2023-01-11 13:52:20 +01:00
afb8a0d1b1
Use new Java features (switch expressions, text blocks, new JDK methods)
...
Closes gh-29747
2023-01-11 13:51:28 +01:00
ad60164911
Update copyright headers for source code changed since August 2022
...
The changes in this commit were performed using the newly introduced
update_copyright_headers.sh script.
2022-11-29 19:38:42 +01:00
7fcd1de8e3
Use AssertJ's isEmpty() instead of hasSize(0)
...
Achieved via global search-and-replace.
2022-11-22 17:11:50 +01:00
d5b0b2b1a1
User AssertJ's hasSize() for arrays
...
Achieved via global search-and-replace.
2022-11-22 17:03:45 +01:00
36f7597f25
Use AssertJ's hasSize() for collections and maps
...
Achieved via a global search-and-replace.
2022-11-22 16:50:10 +01:00
43f8d9e084
Apply 'instanceof pattern matching'
2022-11-22 16:27:34 +01:00
abf3400c07
Use Assert.state() where appropriate
2022-11-15 12:31:10 +01:00
eb91d21ada
Polishing
2022-11-13 18:21:56 +01:00
9d73f81e9c
Avoid String allocations with Assert.notNull()
2022-11-08 14:23:22 +01:00
c091bbdeaa
Merge branch '5.3.x'
2022-11-02 12:18:15 +01:00
fded79d807
Make SimpleMailMessage setters parameters nullable
...
Closes gh-29139
2022-11-02 12:18:03 +01:00
321092ce6f
Consistent use of @Deprecated(since = "6.0")
2022-09-20 14:34:24 +02:00
b87d48b99b
Merge branch '5.3.x'
2022-09-14 17:18:00 +02:00
ce49068ff9
Fix links in Javadoc and reference docs
...
- Fix broken links (by using a new URL, an alternative URL, or a
Wayback Machine link)
- Use HTTPS where possible
- Remove https://issuetracker.springsource.com/browse/EBR-349 : this
link is dead and is also mentioned in
https://jira.spring.io/browse/SPR-8093
- Clean up nohttp allowlist.lines
Closes gh-28876
2022-09-14 17:00:11 +02:00
505da5c602
Migrate hint registration to shortcuts
...
Migrate code to make use of the `MemberCategory` and `FieldMode`
shortcuts.
See gh-29011
2022-09-01 17:26:06 -07:00
08f636b691
Introduce TypeHint.Builder#onReachableType(Class<?>)
...
Closes gh-29017
2022-08-26 08:34:54 +02:00
d6afa8df2d
Improve registration of the same hint for multiple classes
...
Based on the feedback in #28977 an easy way to create a list of
type references based on a vararg of classes is helpful when
registering the same hints for several types.
2022-08-18 06:52:34 +02:00
5c68a278b5
Add SchedulerFactoryBean runtime hints
...
Also require oracle/graalvm-reachability-metadata#19 .
Closes gh-28725
2022-08-11 15:42:53 +02:00
2aa74c9121
Deprecate ListenableFuture in favor of CompletableFuture
...
This commit deprecates ListenableFuture in favor of CompletableFuture.
ListenableFuture was introduced in Spring Framework 4.0, when
CompletableFuture was not yet available. Spring now requires JDK 17, so
having our own type no longer seems necessary.
Major changes in this commit include:
- Deprecation of ListenableFuture and related types
(ListenableFutureCallback, SettableListenableFuture, etc.)
- Deprecation of AsyncListenableTaskExecutor in favor of default methods
in AsyncTaskExecutor (submitCompletable).
- AsyncHandlerMethodReturnValueHandler now has toCompletableFuture
instead of toListenableFuture.
- WebSocketClient now has execute methods, which do the same as
doHandshake, but return CompletableFutures (cf. the reactive
WebSocketClient).
All other changes
- add an overloaded method that takes a CompletableFuture parameter
instead of ListenableFuture, and/or
- add a method with a 'Async' suffix that returns a CompletableFuture
instead of a ListenableFuture (connectAsync, sendAsync).
Closes gh-27780
2022-07-27 12:41:35 +02:00
aae9050351
Merge branch '5.3.x'
...
# Conflicts:
# spring-context/src/main/java/org/springframework/scheduling/annotation/Async.java
# spring-context/src/testFixtures/java/org/springframework/context/testfixture/jndi/SimpleNamingContextBuilder.java
# spring-core/src/main/java/org/springframework/core/BridgeMethodResolver.java
# spring-core/src/main/java/org/springframework/util/MimeType.java
2022-07-13 14:55:30 +02:00
c48c5e7691
Fix and improve Javadoc in spring-context
...
Closes gh-28802
2022-07-13 14:45:23 +02:00
2c92d7da8f
Harmonize RuntimeHintsRegistrar implementations
...
Closes gh-28801
2022-07-12 18:30:23 +02:00
16c43c2041
Add resource hints for Javamail mime.types
...
Closes gh-28690
2022-06-23 19:04:10 +02:00
ee209de9cf
Merge branch '5.3.x'
...
# Conflicts:
# spring-beans/src/test/java/org/springframework/beans/factory/support/security/CallbacksSecurityTests.java
# spring-context/src/test/java/org/springframework/ejb/access/LocalSlsbInvokerInterceptorTests.java
# spring-context/src/test/java/org/springframework/ejb/access/SimpleRemoteSlsbInvokerInterceptorTests.java
# spring-web/src/test/java/org/springframework/remoting/jaxws/JaxWsSupportTests.java
# spring-webmvc/src/test/java/org/springframework/web/servlet/config/annotation/ViewResolutionIntegrationTests.java
2022-05-31 14:15:36 +02:00
1beb7068f6
Use new AssertJ exception assertions
2022-05-31 14:08:28 +02:00
35de7e19ee
Introduce initializer callback for Bean Validation Configuration
...
Closes gh-27956
2022-04-08 14:39:36 +02:00
c8d0146bcc
Polish contribution
...
See gh-28075
2022-03-29 13:39:40 +02:00
7f7fb58dd0
Deprecate SerializationUtils#deserialize
...
Since SerializationUtils#deserialize is based on Java's serialization
mechanism, it can be the source of Remote Code Execution (RCE)
vulnerabilities.
Closes gh-28075
2022-03-29 13:07:36 +02:00
8c6d59aaaf
Polish contribution
...
See gh-28014
2022-02-19 14:43:26 +01:00
c5c926726d
Use enhanced switch expressions where feasible
...
Closes gh-28014
2022-02-19 14:34:05 +01:00
3eb9886724
Merge branch '5.3.x'
...
# Conflicts:
# spring-context-support/src/main/java/org/springframework/scheduling/commonj/WorkManagerTaskExecutor.java
# spring-core/src/main/java/org/springframework/core/task/SimpleAsyncTaskExecutor.java
# spring-expression/src/main/java/org/springframework/expression/spel/support/ReflectivePropertyAccessor.java
# spring-tx/src/main/java/org/springframework/jca/work/SimpleTaskWorkManager.java
# spring-tx/src/main/java/org/springframework/jca/work/WorkManagerTaskExecutor.java
2022-02-04 23:24:21 +01:00
a71a45e719
Deprecate AsyncTaskExecutor.execute(Runnable task, long startTimeout)
...
Closes gh-27959
2022-02-04 23:21:00 +01:00
54565e95b5
Merge branch '5.3.x'
2022-02-03 14:58:36 +01:00
f8a5a8d7be
Use modern language features in tests
2022-02-03 14:50:10 +01:00
d57bc176f2
Merge branch '5.3.x'
2022-01-10 14:21:25 +01:00
df263d01b9
Use idiomatic AssertJ assertions for true, false, and null
2022-01-10 14:15:55 +01:00
f0125afb5e
Remove references to JCacheConfigurerSupport and CachingConfigurerSupport
...
See gh-27863
2021-12-29 10:53:56 +01:00
2f3a9dbc68
Deprecate CachingConfigurerSupport and AsyncConfigurerSupport
...
Closes gh-27813
2021-12-15 12:03:39 +01:00
b6faaf1fc1
Merge branch '5.3.x'
2021-12-15 10:59:50 +01:00
c7642422c3
Stop resolving CachingConfigurer instances eagerly
...
Closes gh-27751
2021-12-15 10:52:09 +01:00
bdbcc4f98c
Merge branch '5.3.x'
...
# Conflicts:
# build.gradle
2021-12-14 18:37:46 +01:00
f191cf4eb3
Revised comment on explicit LocalDataSourceJobStore configuration
...
See gh-27709
2021-12-14 18:32:32 +01:00
bfdb93b406
Merge branch '5.3.x'
...
# Conflicts:
# build.gradle
# src/docs/asciidoc/integration.adoc
2021-12-14 16:51:00 +01:00
d7b9270672
Clarify SchedulerFactoryBean's LocalDataSourceJobStore overriding
...
Includes clarification of interface-level cache annotations for target-class proxies.
Closes gh-27709
See gh-27726
2021-12-14 16:46:13 +01:00
8d93dc4abb
Merge branch '5.3.x'
2021-12-14 14:05:18 +01:00
8422d9d22f
Add default methods to CachingConfigurer
...
This commit adds default methods to CachingConfigurer and
JCacheConfigurer and removes the reference to their respective support
classes as they are now irrelevant.
Closes gh-27811
2021-12-14 13:49:57 +01:00
7f43128a0e
Merge branch '5.3.x'
...
# Conflicts:
# build.gradle
# spring-web/src/main/java/org/springframework/web/server/MediaTypeNotSupportedStatusException.java
# spring-web/src/main/java/org/springframework/web/util/ContentCachingRequestWrapper.java
# spring-webmvc/src/main/java/org/springframework/web/servlet/handler/HandlerMappingIntrospector.java
2021-12-03 22:42:05 +01:00
14f24f43d7
Polishing
2021-12-03 22:36:31 +01:00
1e36518182
Merge branch '5.3.x'
2021-10-23 16:08:43 +02:00
995aaa6159
Polishing
2021-10-23 16:08:00 +02:00
2c89ff934d
Update copyright date
...
See gh-27560
2021-10-23 15:59:46 +02:00
c58853f5e5
Use LocalDataSourceJobStore only if one is not set via Quartz properties
...
Prior to this commit, Spring's SchedulerFactoryBean always set the
"org.quartz.jobStore.class" property to LocalDataSourceJobStore even if
the user had already specified a custom JobStore implementation via the
Quartz properties file or Properties object, thereby effectively
ignoring the user configuration.
This commit addresses this by configuring Quartz to use Spring's
LocalDataSourceJobStore only if a JobStore has not already been
specified via user configuration.
Closes gh-27560
2021-10-23 15:22:42 +02:00
b3473a3e81
Apply "instanceof pattern matching" Eclipse clean-up in spring-context-support
...
This has only been applied to `src/main/java`.
2021-10-14 17:45:56 +02:00
030ba52805
Merge branch '5.3.x'
2021-09-29 16:56:33 +02:00
96e4d3a530
Fail Gradle build for Javadoc warnings
...
In order to catch Javadoc errors in the build, we now enable the
`Xwerror` flag for the `javadoc` tool. In addition, we now use
`Xdoclint:syntax` instead of `Xdoclint:none` in order to validate
syntax within our Javadoc.
This commit fixes all resulting Javadoc errors and warnings.
This commit also upgrades to Undertow 2.2.12.Final and fixes the
artifact names for exclusions for the Servlet and annotations APIs.
The incorrect exclusion of the Servlet API resulted in the Servlet API
being on the classpath twice for the javadoc task, which resulted in the
following warnings in previous builds.
javadoc: warning - Multiple sources of package comments found for package "javax.servlet"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.http"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.descriptor"
javadoc: warning - Multiple sources of package comments found for package "javax.servlet.annotation"
Closes gh-27480
2021-09-29 14:02:37 +02:00
d84ca2ba90
Jakarta EE 9 migration
...
Upgrades many dependency declarations; removes old EJB 2.x support and outdated Servlet-based integrations (Commons FileUpload, FreeMarker JSP support, Tiles).
Closes gh-22093
Closes gh-25354
Closes gh-26185
Closes gh-27423
See gh-27424
2021-09-17 09:14:07 +02:00
cecc0849a8
Upgrade to Gradle 7.2
...
This commit upgrades Gradle to 7.2.
Gradle configuration names are updated accordingly.
This also upgrades Gradle build plugins.
See gh-26870
2021-09-13 09:37:35 +02:00
a2ef6badc4
Use StringBuilder.append(char) where possible
...
To slightly improve performance, this commit switches to
StringBuilder.append(char) instead of StringBuilder.append(String)
whenever we append a single character to a StringBuilder.
Closes gh-27098
2021-06-25 10:44:28 +02:00
90af2d5794
Log delegate service initialization at debug level (instead of info)
...
Closes gh-26810
2021-05-11 15:46:41 +02:00
e02d3f32b4
Requalify tests as LONG_RUNNING
...
Prior to this commit, some tests would belong to the PERFORMANCE
`TestGroup`, while they were not testing for performance but rather
performing functional tests that involve long running operations or
timeouts.
This commit moves those tests to the LONG_RUNNING `TestGroup`.
See gh-24830
2020-09-25 13:43:38 +02:00
bbe74635eb
Merge branch '5.2.x'
2020-09-18 18:16:33 +02:00
9dfef59af2
Construct StringWriter instances with appropriate initial size
...
Closes gh-25789
2020-09-18 18:14:57 +02:00
6e3ed6038b
MimeMessageHelper does not encode attachment filenames by default anymore
...
Closes gh-25770
2020-09-14 22:31:05 +02:00
07b3e92bae
Merge branch '5.2.x'
...
# Conflicts:
# build.gradle
# src/docs/asciidoc/core/core-aop-api.adoc
2020-09-14 22:22:02 +02:00
49d65d5c41
Configurable filename encoding in MimeMessageHelper
...
Closes gh-25755
2020-09-14 22:15:44 +02:00
3aae0fc91b
Merge branch '5.2.x'
2020-09-03 19:21:44 +02:00
670b9fd60b
Retry SQLErrorCodesFactory retrieval if DatabaseMetaData access failed
...
Includes deprecation of JdbcUtils.extractDatabaseMetaData(DataSource, String) in favor of the now generified version of extractDatabaseMetaData(DataSource, DatabaseMetaDataCallback).
Closes gh-25681
Closes gh-25686
2020-09-03 19:16:14 +02:00
1f3e52d932
gh-25650 Replace remaining usage of LinkedList with ArrayList in tests
2020-08-31 14:33:14 +02:00
874574513c
Replace remaining usage of LinkedList with ArrayList/ArrayDeque
...
Closes gh-25650
2020-08-26 18:32:08 +02:00
ff11467a0c
Avoid resizing of fixed-size HashMap/LinkedHashMap variants
...
Closes gh-25349
2020-08-25 19:26:18 +02:00
4d446f9659
Polish
2020-08-07 10:40:00 +02:00
f3cedf268b
Consistently support LoadingCache
...
This commits make sure that CaffeineCache handles consistently the
contract of LoadingCache.
Closes gh-25173
2020-08-07 10:38:27 +02:00
cdc234d7db
Polish contribution
...
See gh-25446
2020-07-22 14:06:29 +02:00
c547809e89
Use instanceof instead of Class#isInstance where feasible
...
Closes gh-25446
2020-07-22 14:06:29 +02:00
17cab9660c
Deprecate TransactionSynchronizationAdapter
...
Closes gh-21725
2020-06-17 11:02:31 +02:00
8099fc8178
Use try-with-resources language construct where feasible
...
Closes gh-2063
Co-authored-by: igor-suhorukov <igor.suhorukov@gmail.com>
2020-06-16 22:57:45 +02:00
1279b3b822
Merge branch '5.2.x'
...
# Conflicts:
# spring-beans/src/main/java/org/springframework/beans/factory/support/AbstractBeanFactory.java
# spring-context-support/src/main/java/org/springframework/cache/jcache/config/AbstractJCacheConfiguration.java
2020-06-11 23:53:27 +02:00
e46ccd74b1
Consistent abstract declaration of "Abstract" base classes
...
Closes gh-25240
2020-06-11 23:43:41 +02:00
663f2e8afd
Merge branch '5.2.x'
2020-06-10 22:53:06 +02:00
ae1ed9d458
Document exception handling limitations in TaskDecorator implementations
...
Closes gh-25231
2020-06-10 22:52:01 +02:00
8697026987
Support for custom cache registration in CaffeineCacheManager
...
Closes gh-25230
2020-06-10 22:50:11 +02:00
399453d9f1
Merge branch '5.2.x'
...
# Conflicts:
# spring-jdbc/src/test/java/org/springframework/jdbc/core/JdbcTemplateQueryTests.java
# spring-jdbc/src/test/java/org/springframework/jdbc/core/namedparam/NamedParameterJdbcTemplateTests.java
2020-05-22 17:16:09 +02:00
d7161f5e5e
Polishing
2020-05-22 16:23:46 +02:00
3c1ee64b7f
Explicit nullability declarations for all AOP Alliance methods
...
Includes consistent declarations in AOP Alliance related Spring AOP code.
Closes gh-24117
2020-05-13 23:33:47 +02:00
f09093132e
Use proxyBeanMethods=false on remaining internal configuration classes
...
Closes gh-24511
2020-05-12 22:19:44 +02:00
12e05280ad
Upgrade to AssertJ 3.16
2020-05-06 15:22:23 +02:00
1f9fa3bab8
Remove useless .gitignore files
...
Closes gh-24790
2020-03-26 15:53:39 +01:00
16e49bf0c9
Simplify getCache() implementation in CaffeineCacheManager
...
Closes gh-24376
2020-01-16 15:07:14 +01:00
5581f3b77b
Use Gradle test fixture support for spring-tx
...
See gh-23550
2020-01-02 16:01:35 +01:00
Juergen Hoeller
Krzysztof Krasoń
Brian Clozel
Sam Brannen
Johnny Lim
Sébastien Deleuze
Steve Gerhardt
Sam Brannen
Marc Wrobel
Phillip Webb
Stephane Nicoll
Arjen Poutsma
Loïc Ledoyen
a.yazychyan
Daniil Pozdeev
Сергей Цыпанов
Stephane Nicoll
XenoAmess
Juergen Hoeller
Qimiao Chen
Sam Brannen