102dc8a4dd
Polishing
2016-07-06 15:29:15 +02:00
e4b0486c5a
Add @FunctionalInterface on candidate interfaces
...
Issue: SPR-14432
2016-07-06 14:32:13 +02:00
bc2c22d51e
Streamline XML namespace support towards unversioned schemas
...
This commit also removes support code for outdated options which were only available in older schema versions.
Issue: SPR-13499
2016-07-05 20:50:03 +02:00
acdb43f470
Remove remaining JRuby and Commons Pool test resources
...
Issue: SPR-14429
2016-07-05 20:47:39 +02:00
1391248ea6
Introduce log4j 2 for Spring's test suite
...
This commit adds a test runtime dependency on log4j 2 for every project
and migrates all log4j.properties files to log4j2-test.xml files.
Issue: SPR-14431
2016-07-05 19:19:09 +02:00
00d2606b00
Explicit type can be replaced by <>
...
Issue: SPR-13188
2016-07-05 17:00:34 +02:00
3096888c7d
Better synchronization in ConcurrentMapCache
...
Issue: SPR-13810
2016-07-05 16:44:07 +02:00
b5db5d3aac
Broadly remove deprecated core classes and methods
...
Issue: SPR-14430
2016-07-05 15:52:49 +02:00
0fc0ce78ae
Drop deprecated dependencies on Log4j, JRuby, JExcel, Burlap, Commons Pool/DBCP
...
This commit also removes outdated support classes for Oracle, GlassFish, JBoss.
Issue: SPR-14429
2016-07-05 15:46:53 +02:00
51252ebbca
Avoid defensive checks against Java 8 API (java.util.Optional etc)
...
This commit also fixes broken javadoc links and code references.
Issue: SPR-13188
2016-07-05 02:09:00 +02:00
54004e0d78
Upgrade to JPA 2.1+ and Bean Validation 1.1+; remove native support for Hibernate 3.6 and 4.x
...
Issue: SPR-13481
Issue: SPR-13827
2016-07-04 23:37:23 +02:00
2b3445df81
Drop Portlet MVC support
...
This commit also removes the corresponding deprecated Servlet MVC variant and updates DispatcherServlet.properties to point to RequestMappingHandlerMapping/Adapter by default.
Issue: SPR-14129
2016-07-04 23:33:47 +02:00
0900808820
Method-level @SuppressWarnings("unchecked") for generic varargs
2016-07-04 23:20:41 +02:00
037746da44
Polish
...
Closes gh-1097
2016-07-01 14:26:48 +02:00
d9993243b6
Polish
...
Closes gh-1096
2016-07-01 10:43:54 +02:00
66ec1c1618
Add missing package-info files for common packages
...
Issue: SPR-14420
2016-06-30 21:39:06 +02:00
e15f7efff8
InjectionPoint propagated for shortcut bean name resolution as well
...
Issue: SPR-14400
2016-06-26 00:18:54 +02:00
a2aa82eb31
Polishing
2016-06-22 11:55:33 +02:00
981d4494c6
AspectJWeavingEnabler registered with well-defined bean name (and therefore once only)
...
Issue: SPR-14373
2016-06-22 11:55:24 +02:00
8cb9d5ebae
EnableAspectJAutoProxy features exposeProxy flag (analogous to XML namespace)
...
Issue: SPR-10454
2016-06-20 13:50:04 +02:00
d41178c75a
Polish contribution
...
Closes gh-1080
2016-06-16 12:12:42 +02:00
9656015d26
Fix typo in javadoc
...
See gh-1080
2016-06-16 12:11:14 +02:00
d51c22a789
Consistent processing of empty values and catching of RuntimeExceptions for Formatters
...
Issue: SPR-14345
2016-06-09 10:49:15 +02:00
c6f63bdb30
Assertions for error codes in case of formatting failures
...
Issue: SPR-14345
2016-06-08 15:54:00 +02:00
8c4bc3656b
Polishing
2016-06-07 15:42:16 +02:00
f657952cee
EventListenerMethodProcessor defensively handles unresolvable method signatures
...
Issue: SPR-14330
2016-06-04 00:15:52 +02:00
ae11387b4a
Removal of @Ignore'd tests
...
Issue: SPR-6310
Issue: SPR-6327
2016-06-02 11:47:22 +02:00
3576ff051c
ScheduledAnnotationBeanPostProcessor properly registers multiple tasks per bean
...
Issue: SPR-14286
2016-05-30 22:47:31 +02:00
24f5f368b0
Consistent meta-annotation attributes lookup through ASM
...
Issue: SPR-14257
2016-05-30 22:39:27 +02:00
86557f25af
ConcurrentMapCacheManager recreates caches when initializing ClassLoader
...
Issue: SPR-14314
2016-05-30 17:13:45 +02:00
98eaf05c8f
@Bean's "autowire" attribute does not affect annotation-driven autowiring
...
Issue: SPR-14282
2016-05-29 13:19:09 +02:00
03affa02db
ConfigurationClassParser detects @Bean methods in interface hierarchies as well
...
Issue: SPR-14288
2016-05-27 22:34:09 +02:00
d651ebfd2d
Fix CacheManager example in Javadoc
...
Closes gh-1052
2016-05-12 15:23:40 +02:00
66bab2a9fc
Revert "Manage asynchronous EventListener with replies"
...
This reverts commit bee1b77af5
2016-05-06 13:38:03 +02:00
1b1aac9172
Unit tests for AsyncResult callback behavior
...
Issue: SPR-14249
2016-05-05 20:40:30 +02:00
7dc181261e
Polishing
2016-05-05 20:35:34 +02:00
a1a87679da
Support test annotations on interfaces
...
Prior to Java 8 it never really made much sense to author integration
tests using interfaces. Consequently, the Spring TestContext Framework
has never supported finding test-related annotations on interfaces in
its search algorithms.
However, Java 8's support for interface default methods introduces new
testing use cases for which it makes sense to declare test
configuration (e.g., @ContextConfiguration, etc.) on an interface
containing default methods instead of on an abstract base class.
This commit ensures that all non-repeatable, class-level test
annotations in the Spring TestContext Framework can now be declared on
test interfaces. The only test annotations that cannot be declared on
interfaces are therefore @Sql and @SqlGroup.
Issue: SPR-14184
2016-05-05 19:54:44 +02:00
ab478d14fa
ScheduledAnnotationBeanPostProcessor tracks individual bean instances of any scope
...
Issue: SPR-12216
Issue: SPR-12872
2016-05-04 17:06:08 +02:00
162aedccbe
Polishing
2016-05-04 17:02:16 +02:00
7b13311f03
Delete unused imports
2016-05-03 20:12:37 +02:00
7737c3c7e5
Warn about non-static BeanDefinitionRegistryPostProcessor declarations on @Configuration classes
...
Issue: SPR-14234
2016-05-02 15:19:05 +02:00
fdb31cd715
Check actual cache value for unwrapped Optional
...
Issue: SPR-14230
2016-04-29 10:56:26 +02:00
240f254bfc
Allow @Cacheable method to return java.util.Optional variant of cached value
...
Includes renaming of internal delegate to CacheOperationExpressionEvaluator.
Issue: SPR-14230
2016-04-28 23:16:43 +02:00
9412f7a094
InstantFormatter accepts RFC-1123 values as well
...
Issue: SPR-14201
2016-04-28 14:35:33 +02:00
e0734aede8
ApplicationListenerDetector explicitly prevents serialization of its ApplicationContext reference
...
Issue: SPR-14214
2016-04-27 21:30:46 +02:00
b331ad5b2a
Explicit note on scheduled methods with a return value
...
Issue: SPR-14195
2016-04-27 15:45:30 +02:00
4a4cd5bde8
Polish CronSequenceGenerator and tests
2016-04-23 18:05:54 +02:00
31d634e6bf
Added cron expression validation method for CronSequenceGenerator
...
It's handy to know in advance whether or not expression that is
passed to CronSequenceGenerator or CronTrigger constructor would
not results in IllegalArgumentException. The only way to do it
now is to try\catch an instance creation but it's kinda ugly.
2016-04-23 17:56:29 +03:00
44e652f99e
Remove duplicate words
...
Closes gh-1039
2016-04-19 08:24:21 +02:00
bee1b77af5
Manage asynchronous EventListener with replies
...
This commit makes sure to reject an `@EventListener` annotated method
that also uses `@Async`. In such scenario, the method is invoked in a
separate thread and the infrastructure has no handle on the actual reply,
if any.
The documentation has been improved to refer to that scenario.
Issue: SPR-14113
2016-04-15 13:22:11 +02:00
b28d96af7d
ScheduledAnnotationBeanPostProcessor accepts non-void methods as well
...
Issue: SPR-14175
2016-04-14 21:59:02 +02:00
999112216d
AopUtils.canApply properly matches package-visible methods (aligned with advice matching within proxies)
...
Also, AbstractAutoProxyCreator considers Pointcut as infrastructure class, analogous to Advice and Advisor.
Issue: SPR-14174
2016-04-14 21:46:25 +02:00
3b44c47dcd
Polishing
2016-04-14 16:39:36 +02:00
dcfa4740ee
Polishing
...
(cherry picked from commit 09b7735
2016-04-13 13:56:37 +02:00
da112611a5
SpringCacheAnnotationParser properly accepts empty @Caching annotation
...
Issue: SPR-14162
2016-04-12 23:19:51 +02:00
10554a85c9
Polish
2016-04-12 08:34:38 +02:00
b6f1afd471
Polishing
2016-04-11 21:20:31 +02:00
537193a4e0
Consistent license header
2016-04-11 20:49:38 +02:00
550a3209f7
Fixed XML example for setup of scheduled tasks
...
Issue: SPR-14145
2016-04-11 19:27:06 +02:00
b82df144e4
LoadTimeWeaver.getThrowawayClassLoader() decorated for exclude support (if necessary)
...
Issue: SPR-13886
2016-04-11 19:19:37 +02:00
437ffa6067
Detect LoadTimeWeaver bean when declared through @Bean method as well
...
Issue: SPR-10856
2016-04-11 17:43:23 +02:00
4407bd794d
Polishing
2016-04-10 05:40:35 +02:00
cb9549655c
AbstractApplicationContext registers default embedded value resolver
...
Issue: SPR-14140
2016-04-09 20:49:22 +02:00
157dcab56c
Cleanup of remaining direct BeanWrapper usage
...
Issue: SPR-14121
2016-04-07 14:27:22 +02:00
1bccc8f1cd
Fix typo
...
Closes gh-1027
2016-04-04 17:36:17 +02:00
13f889e914
SimpleApplicationEventMulticaster leniently handles ClassCastException
...
Issue: SPR-14109
2016-04-04 14:54:38 +02:00
696dcb72a5
SpringValidatorAdapter allows for custom field name resolution
...
Issue: SPR-14104
2016-04-01 10:29:56 +02:00
739ae8c045
LocalValidatorFactoryBean supports custom ValidationProviderResolver
...
Issue: SPR-14100
2016-03-31 16:52:26 +02:00
14bf6509ec
Consistent cache key implementation across transaction and cache attribute sources
...
Includes consistent applicability of class-level metadata to user-level methods only.
Issue: SPR-14017
Issue: SPR-14095
2016-03-30 14:13:04 +02:00
ea09e578b9
Document support for @Cache* as merged composed annotations
...
Issue: SPR-13475
2016-03-29 20:04:43 +02:00
2ed3382a60
Document composed support for @Scheduled, @JmsListener, & @Sql
...
Issue: SPR-13973
2016-03-29 19:53:58 +02:00
3597879608
Revert merged support for @ManagedNotification & @ManagedOperationParameter
...
This commit reverts the recently added merged annotation support for
Spring's JMX annotations by once again using the simpler searches for
repeatable annotations in AnnotationUtils.
Issue: SPR-13973
2016-03-29 17:51:47 +02:00
4fa11e334f
Test @ManagedNotification as a merged, composed annotation
...
Issue: SPR-13973
2016-03-26 20:10:20 +01:00
54aeb7a5d6
Cache key classes implement Comparable and consistently provide a toString representation
...
Issue: SPR-14017
2016-03-26 14:32:10 +01:00
a8b5ea1c51
Polishing
2016-03-26 01:27:37 +01:00
4836d06704
Test @Scheduled as a merged composable annotation
...
Issue: SPR-13973
2016-03-26 00:47:02 +01:00
c6ff0951fc
Polishing
2016-03-25 23:46:18 +01:00
94cb7786c8
Polishing
2016-03-25 23:28:45 +01:00
c6b1f38651
Support @Scheduled as a merged composable annotation
...
Issue: SPR-13973
2016-03-25 00:49:59 +01:00
b6d9fd39e6
Support @ManagedNotification & @ManagedOperationParameter as merged annotations
...
Issue: SPR-13973
2016-03-25 00:49:21 +01:00
517ebd1d3e
Consistent formatting
2016-03-24 19:22:50 +01:00
9af12d290e
Polishing
2016-03-23 18:39:29 +01:00
5025c615b1
Consistent use of AnnotatedElementUtils.findMergedAnnotation/hasAnnotation
...
Issue: SPR-13440
2016-03-23 18:39:20 +01:00
3c18a4533a
Ignored test removed (not intended to work)
...
Issue: SPR-14058
2016-03-23 18:15:29 +01:00
59c88eb3c0
Support @Cache* as merged composed annotations
...
Prior to this commit, @Cacheable, @CacheEvict, @CachePut, and @Caching
could be used to create custom stereotype annotations with hardcoded
values for their attributes; however, it was not possible to create
composed annotations with attribute overrides.
This commit addresses this issue by refactoring
SpringCacheAnnotationParser to use the newly introduced
findAllMergedAnnotations() method in AnnotatedElementUtils. As a
result, @Cacheable, @CacheEvict, @CachePut, and @Caching can now be
used to create custom composed annotations with attribute overrides
configured via @AliasFor.
Issue: SPR-13475
2016-03-21 12:54:09 +01:00
4cd7ba12bb
Polishing
2016-03-19 14:39:01 +01:00
a1a06cd665
@EnableScheduling tests do not expect exception in case of scheduler ambiguity anymore
...
Issue: SPR-14030
2016-03-19 13:18:24 +01:00
5045579028
Revise EnableSchedulingTests
...
- Fast tests now always run (i.e., are no longer limited to the
performance build
- Failing tests have been @Ignore'd
Issue: SPR-14030
2016-03-19 12:38:47 +01:00
6e3fac85f3
AnnotationAwareOrderComparator uses DecoratingProxy interface for target class introspection
...
Issue: SPR-13884
2016-03-18 22:12:10 +01:00
431ca9314a
Leniently allow constructor argument matches if required name is not resolvable
...
Issue: SPR-13987
2016-03-18 18:51:33 +01:00
a95bf6e0fc
Current InjectionPoint/DependencyDescriptor as factory method argument
...
Issue: SPR-14033
2016-03-18 15:30:33 +01:00
d2c0885e29
StandardServletEnvironment supports "spring.jndi.ignore" flag for efficient property lookups
...
Issue: SPR-14026
2016-03-16 18:14:44 +01:00
b1121fba70
Polish
2016-03-16 17:14:03 +01:00
30d457c622
Deprecate addCache
2016-03-16 17:13:06 +01:00
e904ce4ead
Polish QualifierAnnotationAutowireContextTests
2016-03-15 18:17:50 +01:00
e83e3ec9de
Add failing test for @Qualifier as composed annotation
...
Issue: SPR-14058
2016-03-15 18:13:59 +01:00
33a4e9e57f
Prevent non public bean to be exposed to JMX
...
Previously, a package private `@ManagedResource` annotated bean was
registered to the JMX domain even if any attempt to invoke an operation
on it will fail since it has to be public.
This commit validates that any `@ManagedResource` annotated bean is
public and throws an InvalidMetadataException otherwise. Note that the
actual bean type does not have to be public as long as the class
annotated with `@ManagedResource` in the hierarchy is pubic and no extra
operations or attributes are defined on the child.
Issue: SPR-14042
2016-03-15 09:51:20 +01:00
155fa3754b
Consistent lazy resolution of default executor/scheduler for Async/ScheduledAnnotationBeanPostProcessor
...
Issue: SPR-14030
2016-03-11 23:23:58 +01:00
094cf6cafb
Support *Aware for @ComponentScan custom filters
...
Support a limited set of *Aware interfaces for TypeFilters created
via the @ComponentScan annotation.
Issue: SPR-14009
2016-03-11 12:40:42 -08:00
b4de66ff9a
Test for placeholder-specified default value within @Value
...
Issue: SPR-14025
2016-03-11 15:00:01 +01:00
0597ff109e
Bsh/GroovyScriptFactory reset script cache in case of compilation error
...
Issue: SPR-14007
2016-03-11 12:55:20 +01:00
b944283354
ConstructorResolver exposes parameter signature from user-declared class (in case of a CGLIB-generated subclass)
...
Issue: SPR-14015
2016-03-11 12:52:40 +01:00
8e24a4153c
Support ResolvableTypeProvider on simple event pojo
...
Previously, the generic type of a simple pojo event implementing
ResolvableTypeProvider wasn't detected properly. This commit fixes the
logic when the generic type is not provided to reuse what
PayloadApplicationEvent is already doing anyway.
Issue: SPR-14029
2016-03-09 11:55:20 +01:00
e086a5d58b
Polish
...
Add period unit in the description so that it shows up in the summary
description.
2016-03-06 09:04:59 +01:00
ffbf264976
Polish Javadoc
2016-03-01 13:34:25 -08:00
61824b1ade
Remove trailing whitespace from source code
2016-02-29 18:52:57 +01:00
8e5e384de7
Test for constructor with unresolvable parameter name
...
Issue: SPR-13987
2016-02-29 11:18:23 +01:00
7b1fcfc7c3
Consistently strict parsing of date overflows (using java.time's strict resolution style)
...
Issue: SPR-13567
2016-02-23 16:12:26 +01:00
a3789120c9
Support for @PropertySource annotations with custom implementation types
...
Issue: SPR-8963
2016-02-22 23:25:50 +01:00
b9fe6d89da
Avoid NPE in case of @Lazy @Autowired(required=false)
...
Issue: SPR-13967
2016-02-22 23:21:59 +01:00
700ab2fc98
DataBinder test for java.util.Optional property
...
Issue: SPR-13933
2016-02-19 19:21:09 +01:00
a7ad49adcf
Placeholder configurers allow for trimming of property values
...
Issue: SPR-5839
2016-02-19 19:19:39 +01:00
5ed9046886
BeanMethodInterceptor does not pass on null arguments for singleton beans
...
Issue: SPR-13887
2016-02-19 14:00:52 +01:00
65d144b1e5
Consistent descriptions for ConfigurationClass
...
Previously, a ConfigurationClass created from AnnotationMetadata
and a ConfigurationClass created from a class would have subtly
different descriptions. Given a class named com.example.Foo, the
former’s description would be “com.example.Foo”, whereas the latter’s
description would be “class com.example.Foo”.
This commit updates ConfigurationClass to make the description
consistent, preferring the description without “class” in it.
Closes gh-970
2016-02-19 09:08:55 +01:00
7fcb277de9
Consistent behavior for unwrap(null) on JPA and Bean Validation wrappers
...
Includes a fix for Query unwrapping before passing it to addNamedQuery.
Issue: SPR-13960
Issue: SPR-13957
2016-02-18 16:19:09 +01:00
ea4a766df7
Consistent support for SpEL next to placeholders in annotation attributes
...
Issue: SPR-13625
2016-02-17 23:00:07 +01:00
25be5e060c
TaskDecorator callback supported by common TaskExecutor implementations
...
Issue: SPR-13930
2016-02-17 16:58:02 +01:00
ac44f9edd9
Consistent equals implementations across class hierarchies
...
Issue: SPR-13951
2016-02-17 16:57:29 +01:00
513c1ea3d9
Update @author tag
2016-02-17 14:50:29 +01:00
37b3b24578
Polish contribution
...
Closes gh-957
2016-02-17 13:30:48 +01:00
c73e52412a
Decrease allocation rate for CacheOperation
2016-02-17 13:15:05 +01:00
5c87afc51d
Polishing
2016-02-16 22:28:46 +01:00
51c35bf81c
SpringValidatorAdapter exposes String attributes as MessageSourceResolvable
...
Issue: SPR-13406
2016-02-16 22:16:19 +01:00
b79e8a5cbc
Support for Common Annotations 1.1 Resource.lookup() attribute
...
Issue: SPR-13941
2016-02-12 17:41:10 +01:00
0dff782402
Fixed addProtocolResolver signature in ConfigurableApplicationContext
...
Issue: SPR-12857
Issue: SPR-13905
2016-02-11 22:47:41 +01:00
37de0b241d
ProtocolResolver SPI allows for custom resource resolution
...
Issue: SPR-12857
Issue: SPR-13905
2016-02-11 22:21:26 +01:00
26edc674ed
Polish Javadoc for resource-based MessageSources
2016-02-04 21:32:37 +01:00
f108deb114
(Reloadable)ResourceBundleMessageSource allows for adding resources
...
This turned into the extraction of a common AbstractResourceBasedMessageSource base class which not only features addBasenames but also getBasenameSet and setCacheMillis.
Issue: SPR-10314
2016-02-04 19:57:40 +01:00
a3a5a03ee3
PropertySource annotation allows for custom encoding
...
Issue: SPR-13874
2016-01-26 18:00:05 +01:00
4a0fa69ce4
Injection support for Collection/Map beans and self references
...
Issue: SPR-13585
Issue: SPR-12180
Issue: SPR-7915
Issue: SPR-8450
2016-01-25 21:25:48 +01:00
64ce8a81c3
Polishing
2016-01-25 20:33:48 +01:00
d18b3f049a
Tests for @Enable/@ComponentScan without @Configuration
...
Issue: SPR-10660
2016-01-25 20:32:45 +01:00
837cb752a4
Clarify component scan include-filter semantics
...
Issue: SPR-13844
2016-01-25 20:24:26 +01:00
cd903e26de
Polish
2016-01-22 04:35:33 +01:00
a12f23936c
Allow use of '&' prefix to access factory bean in SpEL
...
Prior to this change SpEL did not have an syntactic
construct enabling easy access to a FactoryBean. With this
change it is now possible to use &foo in an expression when
the factory bean should be returned.
Issue: SPR-9511
2016-01-21 16:14:16 -08:00
eb49f3c225
Add interface-based detection test
...
Add a test that explicitely validates that `@ManagedResource` and friends
can be set on an interface.
Issue: SPR-13138
2016-01-18 14:14:17 +01:00
182b1e99e3
TODO marker for test which fails as of AspectJ 1.9 beta 3
...
Issue: SPR-13839
2016-01-15 17:43:59 +01:00
2fc2c29e9a
Update copyright header
2016-01-15 10:51:11 +01:00
3dae3fd8a9
Refine ListenableFutureCallback policy for exceptions
...
This change updates all cases where callbacks are invoked to catch and
suppress errors (since there is not match to do with and error from
a callback be it success or failure).
Also updated is the contract itself to clarify this and emphasize the
callbacks are really notifications for the outcome of the
ListenableFuture not the callbacks themselves.
Issue: SPR-13785
2016-01-14 17:49:01 -05:00
773d175681
Polishing
2016-01-13 12:52:05 +01:00
e14c2de1d2
ImportStack extends ArrayDeque instead of Stack and relies on standard contains implementation
...
Issue: SPR-13852
2016-01-13 12:46:28 +01:00
27c2e8c80d
Polishing
2015-12-29 21:40:20 +01:00
388bd87ef0
ComponentScan annotation is repeatable now
...
Issue: SPR-13151
2015-12-29 21:40:08 +01:00
4f955932a7
@Value can be used as aliased meta-annotation
...
Issue: SPR-13603
2015-12-29 18:02:16 +01:00
470ea977e1
Consistent validation of annotated methods behind AOP proxies
...
Issue: SPR-13816
2015-12-23 20:47:28 +01:00
1cfeb07fa5
Consistent use of varargs plus related polishing
...
(cherry picked from commit deae872
2015-12-23 00:31:11 +01:00
bb0bc3d415
Polishing
2015-12-22 16:19:26 +01:00
0194988425
Store by value support for ConcurrentMapCacheManager
...
ConcurrentMapCacheManager and ConcurrentMapCache now support the
serialization of cache entries via a new `storeByValue` attribute. If it is
explicitly enabled, the cache value is first serialized and that content
is stored in the cache.
The net result is that any further change made on the object returned
from the annotated method is not applied on the copy held in the cache.
Issue: SPR-13758
2015-12-22 13:50:23 +01:00
d444ef4871
Support for bean refs in event SpEL condition
...
Issue: SPR-13814
2015-12-22 11:30:40 +01:00
9b5e47026c
Support for bean refs in caching SpEL expressions
...
Issue: SPR-13182
2015-12-22 11:05:24 +01:00
Juergen Hoeller
Stephane Nicoll
Sam Brannen
nkjackzhang
Stefan Ferstl
Ruslan Sibgatullin
Johnny Lim
youmoo
Phillip Webb
Andy Wilkinson
soldierkam
Andy Clement
Rossen Stoyanchev