Juergen Hoeller
fa8f08391f
Consistent use of annotation-api dependency instead of tomcat-embed-core
2019-12-12 17:21:41 +01:00
Juergen Hoeller
9af8dc0980
Polishing
2019-12-11 17:04:49 +01:00
Johnny Lim
8ac222467b
Short-circuit boolean logic in AbstractBeanDefinition.equals()
...
Closes gh-24185
2019-12-11 16:46:47 +01:00
stsypanov
484006ce90
Hoist Class.getName() from String concatenation to dodge an issue related to profile pollution
2019-12-06 17:36:07 +01:00
Juergen Hoeller
32e7adfa32
Polishing
2019-12-01 02:00:40 +01:00
Juergen Hoeller
91b557eb4b
Polishing
2019-12-01 01:21:53 +01:00
Sam Brannen
d9ebc3bbc4
Polish StringArrayPropertyEditor[Tests]
2019-11-29 14:55:18 +01:00
stsypanov
62ca7c4e8f
Hoist constant byte[] out of loop
2019-11-27 19:19:36 +01:00
Sam Brannen
59e250c93c
Consistent use of SCOPE_PROTOTYPE and SCOPE_SINGLETON constants
...
Closes gh-19905
2019-11-24 13:49:43 +01:00
Juergen Hoeller
b5529f3f2b
Restore short-circuiting in equals implementation
...
Closes gh-24048
2019-11-21 18:20:17 +01:00
stsypanov
1f3b595a03
Use String.isEmpty() instead of String.equals("")
2019-11-21 16:42:01 +01:00
Qimiao Chen
bb2e3ce6d1
Polish AbstractBeanDefinition
...
Closes gh-24048
2019-11-21 15:26:42 +01:00
Sam Brannen
d397baa559
Polish Javadoc for AutowiredAnnotationBeanPostProcessor
2019-11-15 12:43:55 +01:00
SchutzeHades
834ebc44f8
Fix inappropriate eager init.
2019-11-14 10:13:55 +01:00
Juergen Hoeller
22211a01ce
Polishing
2019-11-13 17:23:23 +01:00
GungnirLaevatain
4bbf2d5785
polish
2019-11-12 17:40:28 +01:00
stsypanov
92efe95069
Simplify ConstructorResolver: do not sort intermediate array
2019-11-11 15:42:35 +01:00
Qimiao Chen
9b8da04e64
Delete unnecessary variable assignment
...
Closes gh-23955
2019-11-08 13:39:02 +01:00
Juergen Hoeller
6a48bb7b4d
Polishing
2019-11-07 22:08:29 +01:00
stsypanov
f5ae3c77c6
Use Method::getParameterCount where possible
2019-11-07 18:00:15 +01:00
Sam Brannen
29b31cad48
Align implementations of StringToUUIDConverter and UUIDEditor
...
Closes gh-23940
2019-11-06 14:21:52 +01:00
Sam Brannen
9f00eb68e9
Clean up warnings
2019-10-30 19:14:58 +01:00
Juergen Hoeller
248ad0fa79
Expose primary flag on BeanDefinitionBuilder
...
Closes gh-23794
2019-10-30 01:04:41 +01:00
Sam Brannen
2482209437
Polish Javadoc @param order
2019-10-29 12:49:05 +01:00
Sam Brannen
26ee9c68eb
Document [Priority]Ordered support for Bean[Factory]PostProcessor
...
Prior to this commit, it was not clear from the Javadoc for
BeanPostProcess and BeanFactoryPostProcessor that such components can
be ordered by implementing Ordered or PriorityOrdered.
This commit improves the documentation for BPP and BFPP to make this
support explicit.
Closes gh-23636
2019-09-26 14:24:33 +02:00
Juergen Hoeller
47a24ac378
Upgrade to Aalto 1.2.2, Protobuf 3.10, Apache Johnzon 1.2, SnakeYAML 1.25, OpenPDF 1.3.11, FreeMarker 2.3.29
2019-09-25 23:49:15 +02:00
Juergen Hoeller
07df1ce7d2
Update genericBeanDefinitionEquality test to AssertJ usage on master
...
See gh-23593
2019-09-25 13:07:27 +02:00
Juergen Hoeller
bd70f10d2b
Merge branch '5.1.x'
...
# Conflicts:
# build.gradle
# spring-aop/src/main/java/org/springframework/aop/framework/CglibAopProxy.java
# spring-aspects/spring-aspects.gradle
# spring-beans/src/main/java/org/springframework/beans/factory/annotation/AutowiredAnnotationBeanPostProcessor.java
# spring-beans/src/main/java/org/springframework/beans/factory/support/GenericBeanDefinition.java
# spring-beans/src/test/java/org/springframework/beans/factory/DefaultListableBeanFactoryTests.java
# spring-orm/spring-orm.gradle
# spring-test/spring-test.gradle
2019-09-25 12:43:24 +02:00
Juergen Hoeller
bb6f9bb6d4
Polishing
2019-09-25 12:14:48 +02:00
Juergen Hoeller
da44a247cb
Efficient concurrency in MethodOverrides through CopyOnWriteArraySet
...
Also restores immediate MethodOverrides instance in AbstractBeanDefinition, avoiding potential lazy-init race condition.
Closes gh-23448
2019-09-25 12:09:16 +02:00
Juergen Hoeller
20fc7e178a
Consistent equality check for parent name and indexed arguments
...
Closes gh-23593
2019-09-25 12:07:29 +02:00
Juergen Hoeller
e68132686d
Restore lenient target type handling for FactoryBean definitions
...
Closes gh-23561
2019-09-20 21:54:32 +02:00
Sam Brannen
a51dc84cb1
Fix Checkstyle violation
2019-09-17 13:29:22 +02:00
Sam Brannen
9517372e5f
Re-enable DLBFTests.prototypeCreationWithConstructorArgumentsIsFastEnough()
2019-09-17 13:24:53 +02:00
Sam Brannen
a93f3ddfe4
Polish DefaultListableBeanFactoryTests
2019-09-17 13:17:22 +02:00
Sam Brannen
c8e47f578f
Merge branch '5.1.x'
2019-09-17 13:13:02 +02:00
Sam Brannen
b2aad1c3b1
Ensure bean definitions can be removed concurrently
...
Prior to this commit, concurrent invocations of
DefaultListableBeanFactory.removeBeanDefinition() could result in a
NullPointerException.
This commit fixes this by adding an appropriate not-null check in
resetBeanDefinition().
Closes gh-23542
2019-09-17 13:09:08 +02:00
Sam Brannen
7a1a8e1623
Polish DefaultListableBeanFactoryTests
2019-09-17 10:44:45 +02:00
Phillip Webb
d945ae9191
Add blank line between java and javax imports
...
See gh-23539
Co-authored-by: Sam Brannen <sbrannen@pivotal.io>
2019-09-16 13:41:59 +02:00
Sam Brannen
e62cb6bc56
Merge branch '5.1.x'
2019-09-12 14:03:12 +02:00
GungnirLaevatain
9db4118180
Fix DefaultListableBeanFactory#copyConfigurationFrom
...
Prior to this commit, the copyConfigurationFrom(ConfigurableBeanFactory)
method in DefaultListableBeanFactory cloned its own AutowireCandidateResolver
type instead of the resolver type from the supplied ConfigurableBeanFactory.
This commit fixes that by cloning the resolver type from the supplied
ConfigurableBeanFactory.
Closes gh-23569
2019-09-12 13:58:24 +02:00
Sam Brannen
591995ecc8
Polish and revive disabled tests
...
This commit revives some previously disabled tests and converts
some usage of @Disabled to @EnabledForTestGroups(...).
2019-09-06 15:57:27 +02:00
Sam Brannen
c80705a708
Polishing
2019-09-05 13:20:20 +02:00
Sam Brannen
ce178f76eb
Add missing Temporal tests in BeanUtilsTests
...
This change will help to serve as a regression test.
2019-09-05 13:14:39 +02:00
Phillip Webb
deba2ed1b3
Add blank line between java and javax imports
...
See gh-23539
2019-09-04 22:05:46 -07:00
Sam Brannen
f54395b261
Polish BeanUtilsTests
2019-09-04 16:53:29 +02:00
Sam Brannen
803643559a
Merge branch '5.1.x'
2019-09-04 16:24:44 +02:00
Sam Brannen
d036b5a283
Do not treat void and Void as simple types in BeanUtils
...
Prior to this commit, the isSimpleProperty() and isSimpleValueType()
methods in BeanUtils treated void and Void as simple types; however,
doing so does not make sense in this context, since void implies the
lack of a property or value.
This commit addresses this by explicitly excluding void and Void in the
logic in isSimpleValueType().
This commit also simplifies the implementation of
ViewResolutionResultHandler.supports(HandlerResult) to take advantage
of this change.
Closes gh-23573
2019-09-04 15:48:40 +02:00
Juergen Hoeller
48934cba1b
Polishing
2019-09-04 12:19:08 +02:00
Juergen Hoeller
3bc27e8d14
Streamline AnnotationFilter usage with the MergedAnnotations API
...
MergedAnnotations provides 'from' variants with RepeatableContainers but without AnnotationFilter argument now, avoiding the need to refer to AnnotationFilter.PLAIN as a default at call sites.
2019-09-04 12:18:49 +02:00