Merge 832689925c into 7e6874ad80

Closes gh-35580

framework-docs/modules/ROOT/pages/core/beans/annotation-config/autowired.adoc

@@ -37,18 +37,18 @@ Kotlin::
 ----
 ======
 
-[NOTE]
+[TIP]
 ====
-As of Spring Framework 4.3, an `@Autowired` annotation on such a constructor is no longer
-necessary if the target bean defines only one constructor to begin with. However, if
-several constructors are available and there is no primary/default constructor, at least
-one of the constructors must be annotated with `@Autowired` in order to instruct the
-container which one to use. See the discussion on
-xref:core/beans/annotation-config/autowired.adoc#beans-autowired-annotation-constructor-resolution[constructor resolution] for details.
+An `@Autowired` annotation on such a constructor is not necessary if the target bean
+defines only one constructor. However, if several constructors are available and there is
+no primary or default constructor, at least one of the constructors must be annotated
+with `@Autowired` in order to instruct the container which one to use. See the discussion
+on xref:core/beans/annotation-config/autowired.adoc#beans-autowired-annotation-constructor-resolution[constructor resolution]
+for details.
 ====
 
-You can also apply the `@Autowired` annotation to _traditional_ setter methods,
-as the following example shows:
+You can apply the `@Autowired` annotation to _traditional_ setter methods, as the
+following example shows:
 
 [tabs]
 ======
@@ -84,8 +84,8 @@ Kotlin::
 ----
 ======
 
-You can also apply the annotation to methods with arbitrary names and multiple
-arguments, as the following example shows:
+You can apply `@Autowired` to methods with arbitrary names and multiple arguments, as the
+following example shows:
 
 [tabs]
 ======
@@ -176,14 +176,15 @@ Kotlin::
 ====
 Make sure that your target components (for example, `MovieCatalog` or `CustomerPreferenceDao`)
 are consistently declared by the type that you use for your `@Autowired`-annotated
-injection points. Otherwise, injection may fail due to a "no type match found" error at runtime.
+injection points. Otherwise, injection may fail due to a "no type match found" error at
+runtime.
 
 For XML-defined beans or component classes found via classpath scanning, the container
 usually knows the concrete type up front. However, for `@Bean` factory methods, you need
 to make sure that the declared return type is sufficiently expressive. For components
 that implement several interfaces or for components potentially referred to by their
-implementation type, consider declaring the most specific return type on your factory
-method (at least as specific as required by the injection points referring to your bean).
+implementation type, declare the most specific return type on your factory method (at
+least as specific as required by the injection points referring to your bean).
 ====
 
 .[[beans-autowired-annotation-self-injection]]Self Injection
@@ -312,8 +313,8 @@ through `@Order` values in combination with `@Primary` on a single bean for each
 ====
 
 Even typed `Map` instances can be autowired as long as the expected key type is `String`.
-The map values contain all beans of the expected type, and the keys contain the
-corresponding bean names, as the following example shows:
+The map values are all beans of the expected type, and the keys are the corresponding
+bean names, as the following example shows:
 
 [tabs]
 ======
@@ -431,7 +432,7 @@ annotated constructor does not have to be public.
 ====
 
 Alternatively, you can express the non-required nature of a particular dependency
-through Java 8's `java.util.Optional`, as the following example shows:
+through Java's `java.util.Optional`, as the following example shows:
 
 [source,java,indent=0,subs="verbatim,quotes"]
 ----
@@ -445,8 +446,8 @@ through Java 8's `java.util.Optional`, as the following example shows:
 ----
 
 You can also use a parameter-level `@Nullable` annotation (of any kind in any package --
-for example, `javax.annotation.Nullable` from JSR-305) or just leverage Kotlin built-in
-null-safety support:
+for example, `org.jspecify.annotations.Nullable` from JSpecify) or just leverage Kotlin's
+built-in null-safety support:
 
 [tabs]
 ======
@@ -477,13 +478,6 @@ Kotlin::
 ----
 ======
 
-[NOTE]
-====
-A type-level `@Nullable` annotation such as from JSpecify is not supported in Spring
-Framework 6.2 yet. You need to upgrade to Spring Framework 7.0 where the framework
-detects type-level annotations and consistently declares JSpecify in its own codebase.
-====
-
 You can also use `@Autowired` for interfaces that are well-known resolvable
 dependencies: `BeanFactory`, `ApplicationContext`, `Environment`, `ResourceLoader`,
 `ApplicationEventPublisher`, and `MessageSource`. These interfaces and their extended
@@ -528,5 +522,6 @@ class MovieRecommender {
 The `@Autowired`, `@Inject`, `@Value`, and `@Resource` annotations are handled by Spring
 `BeanPostProcessor` implementations. This means that you cannot apply these annotations
 within your own `BeanPostProcessor` or `BeanFactoryPostProcessor` types (if any).
+
 These types must be 'wired up' explicitly by using XML or a Spring `@Bean` method.
 ====

spring-core/src/main/java/org/springframework/core/env/MapPropertySource.java

@@ -16,6 +16,8 @@
 
 package org.springframework.core.env;
 
+import java.util.ArrayList;
+import java.util.List;
 import java.util.Map;
 
 import org.jspecify.annotations.Nullable;
@@ -44,10 +46,43 @@ public class MapPropertySource extends EnumerablePropertySource<Map<String, Obje
 		super(name, source);
 	}
 
-
+	/**
+	 * Returns the value associated with the given property name.
+	 * <p>
+	 * First, this method checks for an exact match in the underlying {@code source} map.
+	 * If not found, it attempts to reconstruct a {@link List} from sequentially indexed keys
+	 * (e.g. {@code name[0]}, {@code name[1]}, ...), stopping at the first missing index.
+	 * <p>
+	 * Values that implement {@link CharSequence} are converted to plain {@link String} instances.
+	 *
+	 * @param name the property name to resolve
+	 * @return the resolved value, or {@code null} if not found
+	 */
 	@Override
 	public @Nullable Object getProperty(String name) {
-		return this.source.get(name);
+		Object directMatch = this.source.get(name);
+
+		if (directMatch != null) {
+			return directMatch;
+		}
+
+		List<Object> collectedValues = new ArrayList<>();
+		for (int index = 0; ; index++) {
+			String indexedKey = name + "[" + index + "]";
+			if (!this.source.containsKey(indexedKey)) {
+				break;
+			}
+
+			Object rawIndexedValue = this.source.get(indexedKey);
+
+			if (rawIndexedValue instanceof CharSequence cs) {
+				collectedValues.add(cs.toString());
+			} else {
+				collectedValues.add(rawIndexedValue);
+			}
+		}
+
+		return collectedValues.isEmpty() ? null : collectedValues;
 	}
 
 	@Override

spring-test/src/test/java/org/springframework/test/context/support/TestPropertySourceUtilsTests.java

@@ -16,11 +16,7 @@
 
 package org.springframework.test.context.support;
 
-import java.lang.annotation.Retention;
-import java.lang.annotation.RetentionPolicy;
-import java.util.List;
-import java.util.stream.Stream;
-
+import org.assertj.core.api.InstanceOfAssertFactories;
 import org.assertj.core.api.SoftAssertions;
 import org.junit.jupiter.api.Test;
 
@@ -37,11 +33,16 @@ import org.springframework.mock.env.MockEnvironment;
 import org.springframework.mock.env.MockPropertySource;
 import org.springframework.test.context.TestPropertySource;
 
-import static org.assertj.core.api.Assertions.assertThat;
-import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
-import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
-import static org.assertj.core.api.Assertions.assertThatIllegalStateException;
-import static org.assertj.core.api.Assertions.entry;
+import java.io.Serial;
+import java.lang.annotation.Retention;
+import java.lang.annotation.RetentionPolicy;
+import java.util.Collections;
+import java.util.HashMap;
+import java.util.List;
+import java.util.Map;
+import java.util.stream.Stream;
+
+import static org.assertj.core.api.Assertions.*;
 import static org.mockito.ArgumentMatchers.anyString;
 import static org.mockito.BDDMockito.given;
 import static org.mockito.Mockito.mock;
@@ -306,6 +307,84 @@ class TestPropertySourceUtilsTests {
 			.withMessageContaining("'inlinedProperties' must not be null");
 	}
 
+	@Test
+	void returnsListOfStringsFromIndexedKeys() {
+		Map<String, Object> source = Collections.unmodifiableMap(new HashMap<>() {
+			@Serial
+			private static final long serialVersionUID = 5698617178562090885L;
+
+			{
+				put("first.second[0]", "i");
+				put("first.second[1]", "love");
+				put("first.second[2]", "spring");
+			}
+		});
+
+		PropertySource<?> propertySource = new MapPropertySource("test", source);
+
+		Object result = propertySource.getProperty("first.second");
+
+		assertThat(result)
+				.isInstanceOf(List.class)
+				.asInstanceOf(InstanceOfAssertFactories.LIST)
+				.containsExactly("i", "love", "spring");
+	}
+
+	@Test
+	void returnsListOfMixedTypesFromIndexedKeys() {
+		Map<String, Object> source = Collections.unmodifiableMap(new HashMap<>() {
+			@Serial
+			private static final long serialVersionUID = 5698617178562090885L;
+
+			{
+				put("first.second[0]", "i");
+				put("first.second[1]", "love");
+				put("first.second[2]", "spring");
+				put("first.second[3]", 7);
+			}
+		});
+
+		PropertySource<?> propertySource = new MapPropertySource("test", source);
+
+		Object result = propertySource.getProperty("first.second");
+
+		assertThat(result)
+				.isInstanceOf(List.class)
+				.asInstanceOf(InstanceOfAssertFactories.LIST)
+				.containsExactly("i", "love", "spring", 7);
+	}
+
+	@Test
+	void returnsListOfIntegersFromIndexedKeys() {
+		Map<String, Object> source = Collections.unmodifiableMap(new HashMap<>() {
+			@Serial
+			private static final long serialVersionUID = 5698617178562090885L;
+
+			{
+				put("first.second[0]", 1);
+				put("first.second[1]", 2);
+				put("first.second[2]", 3);
+			}
+		});
+
+		PropertySource<?> propertySource = new MapPropertySource("test", source);
+
+		Object result = propertySource.getProperty("first.second");
+
+		assertThat(result)
+				.isInstanceOf(List.class)
+				.asInstanceOf(InstanceOfAssertFactories.LIST)
+				.containsExactly(1, 2, 3);
+	}
+
+	@Test
+	void returnsNullWhenNoDirectMatchAndNoIndexedKeys() {
+		Map<String, Object> sourceMap = new HashMap<>();
+		PropertySource<?> ps = new MapPropertySource("test", sourceMap);
+		Object result = ps.getProperty("first.second");
+
+		assertThat(result).isNull();
+	}
 
 	private static void assertMergedTestPropertySources(Class<?> testClass, String[] expectedLocations,
 			String[] expectedProperties) {