/*
 * Copyright 2004-present the original author or authors.
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 *      https://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

package org.springframework.security.web;

import java.io.IOException;
import java.util.Arrays;
import java.util.Collections;
import java.util.Iterator;
import java.util.List;

import io.micrometer.observation.Observation;
import io.micrometer.observation.ObservationHandler;
import io.micrometer.observation.ObservationRegistry;
import jakarta.servlet.Filter;
import jakarta.servlet.FilterChain;
import jakarta.servlet.ServletException;
import jakarta.servlet.ServletRequest;
import jakarta.servlet.ServletResponse;
import jakarta.servlet.http.HttpServletRequest;
import jakarta.servlet.http.HttpServletRequestWrapper;
import jakarta.servlet.http.HttpServletResponse;
import org.junit.jupiter.api.AfterEach;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.mockito.ArgumentCaptor;
import org.mockito.stubbing.Answer;

import org.springframework.mock.web.MockHttpServletRequest;
import org.springframework.mock.web.MockHttpServletResponse;
import org.springframework.security.authentication.TestingAuthenticationToken;
import org.springframework.security.core.context.SecurityContextHolder;
import org.springframework.security.core.context.SecurityContextHolderStrategy;
import org.springframework.security.web.firewall.FirewalledRequest;
import org.springframework.security.web.firewall.HttpFirewall;
import org.springframework.security.web.firewall.RequestRejectedException;
import org.springframework.security.web.firewall.RequestRejectedHandler;
import org.springframework.security.web.servlet.TestMockHttpServletMappings;
import org.springframework.security.web.util.matcher.RequestMatcher;

import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
import static org.assertj.core.api.Assertions.assertThatIllegalArgumentException;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.ArgumentMatchers.eq;
import static org.mockito.BDDMockito.given;
import static org.mockito.BDDMockito.willAnswer;
import static org.mockito.BDDMockito.willThrow;
import static org.mockito.Mockito.atLeastOnce;
import static org.mockito.Mockito.mock;
import static org.mockito.Mockito.times;
import static org.mockito.Mockito.verify;
import static org.mockito.Mockito.verifyNoMoreInteractions;
import static org.springframework.security.web.servlet.TestMockHttpServletRequests.get;

/**
 * @author Luke Taylor
 * @author Rob Winch
 */
public class FilterChainProxyTests {

	private FilterChainProxy fcp;

	private RequestMatcher matcher;

	private MockHttpServletRequest request;

	private MockHttpServletResponse response;

	private FilterChain chain;

	private Filter filter;

	@BeforeEach
	public void setup() throws Exception {
		this.matcher = mock(RequestMatcher.class);
		this.filter = mock(Filter.class);
		willAnswer((Answer<Object>) (inv) -> {
			Object[] args = inv.getArguments();
			FilterChain fc = (FilterChain) args[2];
			HttpServletRequestWrapper extraWrapper = new HttpServletRequestWrapper((HttpServletRequest) args[0]);
			fc.doFilter(extraWrapper, (HttpServletResponse) args[1]);
			return null;
		}).given(this.filter).doFilter(any(), any(), any());
		this.fcp = new FilterChainProxy(new DefaultSecurityFilterChain(this.matcher, Arrays.asList(this.filter)));
		this.fcp.setFilterChainValidator(mock(FilterChainProxy.FilterChainValidator.class));
		this.request = get("/path").build();
		this.response = new MockHttpServletResponse();
		this.chain = mock(FilterChain.class);
	}

	@AfterEach
	public void teardown() {
		SecurityContextHolder.clearContext();
	}

	@Test
	public void toStringCallSucceeds() {
		this.fcp.afterPropertiesSet();
		this.fcp.toString();
	}

	@Test
	public void securityFilterChainIsNotInvokedIfMatchFails() throws Exception {
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(false);
		this.fcp.doFilter(this.request, this.response, this.chain);
		assertThat(this.fcp.getFilterChains()).hasSize(1);
		assertThat(this.fcp.getFilterChains().get(0).getFilters().get(0)).isSameAs(this.filter);
		verifyNoMoreInteractions(this.filter);
		// The actual filter chain should be invoked though
		verify(this.chain).doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class));
	}

	@Test
	public void originalChainIsInvokedAfterSecurityChainIfMatchSucceeds() throws Exception {
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(true);
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(this.filter).doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class),
				any(FilterChain.class));
		verify(this.chain).doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class));
	}

	@Test
	public void originalFilterChainIsInvokedIfMatchingSecurityChainIsEmpty() throws Exception {
		List<Filter> noFilters = Collections.emptyList();
		this.fcp = new FilterChainProxy(new DefaultSecurityFilterChain(this.matcher, noFilters));
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(true);
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(this.chain).doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class));
	}

	@Test
	public void requestIsWrappedForMatchingAndFilteringWhenMatchIsFound() throws Exception {
		given(this.matcher.matches(any())).willReturn(true);
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(this.matcher).matches(any(FirewalledRequest.class));
		verify(this.filter).doFilter(any(FirewalledRequest.class), any(HttpServletResponse.class),
				any(FilterChain.class));
		verify(this.chain).doFilter(any(), any(HttpServletResponse.class));
	}

	@Test
	public void requestIsWrappedForMatchingAndFilteringWhenMatchIsNotFound() throws Exception {
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(false);
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(this.matcher).matches(any(FirewalledRequest.class));
		verifyNoMoreInteractions(this.filter);
		verify(this.chain).doFilter(any(FirewalledRequest.class), any(HttpServletResponse.class));
	}

	@Test
	public void wrapperIsResetWhenNoMatchingFilters() throws Exception {
		HttpFirewall fw = mock(HttpFirewall.class);
		FirewalledRequest fwr = mock(FirewalledRequest.class);
		given(fwr.getRequestURI()).willReturn("/");
		given(fwr.getContextPath()).willReturn("");
		given(fwr.getHttpServletMapping()).willReturn(TestMockHttpServletMappings.defaultMapping());
		this.fcp.setFirewall(fw);
		given(fw.getFirewalledRequest(this.request)).willReturn(fwr);
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(false);
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(fwr).reset();
	}

	// SEC-1639
	@Test
	public void bothWrappersAreResetWithNestedFcps() throws Exception {
		HttpFirewall fw = mock(HttpFirewall.class);
		FilterChainProxy firstFcp = new FilterChainProxy(new DefaultSecurityFilterChain(this.matcher, this.fcp));
		firstFcp.setFirewall(fw);
		this.fcp.setFirewall(fw);
		FirewalledRequest firstFwr = mock(FirewalledRequest.class, "firstFwr");
		given(firstFwr.getRequestURI()).willReturn("/");
		given(firstFwr.getContextPath()).willReturn("");
		given(firstFwr.getHttpServletMapping()).willReturn(TestMockHttpServletMappings.defaultMapping());
		FirewalledRequest fwr = mock(FirewalledRequest.class, "fwr");
		given(fwr.getRequestURI()).willReturn("/");
		given(fwr.getContextPath()).willReturn("");
		given(fwr.getHttpServletMapping()).willReturn(TestMockHttpServletMappings.defaultMapping());
		given(fw.getFirewalledRequest(this.request)).willReturn(firstFwr);
		given(fw.getFirewalledRequest(firstFwr)).willReturn(fwr);
		given(fwr.getRequest()).willReturn(firstFwr);
		given(firstFwr.getRequest()).willReturn(this.request);
		given(this.matcher.matches(any())).willReturn(true);
		firstFcp.doFilter(this.request, this.response, this.chain);
		verify(firstFwr).reset();
		verify(fwr).reset();
	}

	@Test
	public void doFilterClearsSecurityContextHolder() throws Exception {
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(true);
		willAnswer((Answer<Object>) (inv) -> {
			SecurityContextHolder.getContext()
				.setAuthentication(new TestingAuthenticationToken("username", "password"));
			return null;
		}).given(this.filter)
			.doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class), any(FilterChain.class));
		this.fcp.doFilter(this.request, this.response, this.chain);
		assertThat(SecurityContextHolder.getContext().getAuthentication()).isNull();
	}

	@Test
	public void doFilterWhenCustomSecurityContextHolderStrategyClearsSecurityContext() throws Exception {
		SecurityContextHolderStrategy strategy = mock(SecurityContextHolderStrategy.class);
		this.fcp.setSecurityContextHolderStrategy(strategy);
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(true);
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(strategy).clearContext();
	}

	@Test
	public void doFilterClearsSecurityContextHolderWithException() throws Exception {
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(true);
		willAnswer((Answer<Object>) (inv) -> {
			SecurityContextHolder.getContext()
				.setAuthentication(new TestingAuthenticationToken("username", "password"));
			throw new ServletException("oops");
		}).given(this.filter)
			.doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class), any(FilterChain.class));
		assertThatExceptionOfType(ServletException.class)
			.isThrownBy(() -> this.fcp.doFilter(this.request, this.response, this.chain));
		assertThat(SecurityContextHolder.getContext().getAuthentication()).isNull();
	}

	// SEC-2027
	@Test
	public void doFilterClearsSecurityContextHolderOnceOnForwards() throws Exception {
		final FilterChain innerChain = mock(FilterChain.class);
		given(this.matcher.matches(any(HttpServletRequest.class))).willReturn(true);
		willAnswer((Answer<Object>) (inv) -> {
			TestingAuthenticationToken expected = new TestingAuthenticationToken("username", "password");
			SecurityContextHolder.getContext().setAuthentication(expected);
			willAnswer((Answer<Object>) (inv1) -> {
				innerChain.doFilter(this.request, this.response);
				return null;
			}).given(this.filter)
				.doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class), any(FilterChain.class));
			this.fcp.doFilter(this.request, this.response, innerChain);
			assertThat(SecurityContextHolder.getContext().getAuthentication()).isSameAs(expected);
			return null;
		}).given(this.filter)
			.doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class), any(FilterChain.class));
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(innerChain).doFilter(any(HttpServletRequest.class), any(HttpServletResponse.class));
		assertThat(SecurityContextHolder.getContext().getAuthentication()).isNull();
	}

	@Test
	public void setRequestRejectedHandlerDoesNotAcceptNull() {
		assertThatIllegalArgumentException().isThrownBy(() -> this.fcp.setRequestRejectedHandler(null));
	}

	@Test
	public void requestRejectedHandlerIsCalledIfFirewallThrowsRequestRejectedException() throws Exception {
		HttpFirewall fw = mock(HttpFirewall.class);
		RequestRejectedHandler rjh = mock(RequestRejectedHandler.class);
		this.fcp.setFirewall(fw);
		this.fcp.setRequestRejectedHandler(rjh);
		RequestRejectedException requestRejectedException = new RequestRejectedException("Contains illegal chars");
		given(fw.getFirewalledRequest(this.request)).willThrow(requestRejectedException);
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(rjh).handle(eq(this.request), eq(this.response), eq((requestRejectedException)));
	}

	@Test
	public void requestRejectedHandlerIsCalledIfFirewallThrowsWrappedRequestRejectedException() throws Exception {
		HttpFirewall fw = mock(HttpFirewall.class);
		RequestRejectedHandler rjh = mock(RequestRejectedHandler.class);
		this.fcp.setFirewall(fw);
		this.fcp.setRequestRejectedHandler(rjh);
		RequestRejectedException requestRejectedException = new RequestRejectedException("Contains illegal chars");
		ServletException servletException = new ServletException(requestRejectedException);
		given(fw.getFirewalledRequest(this.request)).willReturn(new MockFirewalledRequest(this.request));
		willThrow(servletException).given(this.chain).doFilter(any(), any());
		this.fcp.doFilter(this.request, this.response, this.chain);
		verify(rjh).handle(eq(this.request), eq(this.response), eq((requestRejectedException)));
	}

	@Test
	public void doFilterWhenMatchesThenObservationRegistryObserves() throws Exception {
		ObservationHandler<Observation.Context> handler = mock(ObservationHandler.class);
		given(handler.supportsContext(any())).willReturn(true);
		ObservationRegistry registry = ObservationRegistry.create();
		registry.observationConfig().observationHandler(handler);
		given(this.matcher.matches(any())).willReturn(true);
		SecurityFilterChain sec = new DefaultSecurityFilterChain(this.matcher, Arrays.asList(this.filter));
		FilterChainProxy fcp = new FilterChainProxy(sec);
		fcp.setFilterChainDecorator(new ObservationFilterChainDecorator(registry));
		Filter filter = ObservationFilterChainDecorator.FilterObservation
			.create(Observation.createNotStarted("wrap", registry))
			.wrap(fcp);
		filter.doFilter(this.request, this.response, this.chain);
		ArgumentCaptor<Observation.Context> captor = ArgumentCaptor.forClass(Observation.Context.class);
		verify(handler, times(4)).onStart(captor.capture());
		verify(handler, times(4)).onStop(any());
		Iterator<Observation.Context> contexts = captor.getAllValues().iterator();
		assertThat(contexts.next().getName()).isEqualTo("wrap");
		assertFilterChainObservation(contexts.next(), "before", 1);
		assertThat(contexts.next().getName()).isEqualTo(ObservationFilterChainDecorator.SECURED_OBSERVATION_NAME);
		assertFilterChainObservation(contexts.next(), "after", 1);
	}

	// gh-12610
	@Test
	void parentObservationIsTakenIntoAccountDuringDispatchError() throws Exception {
		ObservationHandler<Observation.Context> handler = mock(ObservationHandler.class);
		given(handler.supportsContext(any())).willReturn(true);
		ObservationRegistry registry = ObservationRegistry.create();
		registry.observationConfig().observationHandler(handler);

		given(this.matcher.matches(any())).willReturn(true);
		SecurityFilterChain sec = new DefaultSecurityFilterChain(this.matcher, Arrays.asList(this.filter));
		FilterChainProxy fcp = new FilterChainProxy(sec);
		fcp.setFilterChainDecorator(new ObservationFilterChainDecorator(registry));
		Filter initialFilter = ObservationFilterChainDecorator.FilterObservation
			.create(Observation.createNotStarted("wrap", registry))
			.wrap(fcp);

		ServletRequest initialRequest = new MockHttpServletRequest("GET", "/");
		initialFilter.doFilter(initialRequest, new MockHttpServletResponse(), this.chain);

		// simulate request attribute copying in case dispatching to ERROR
		ObservationFilterChainDecorator.AroundFilterObservation parentObservation = (ObservationFilterChainDecorator.AroundFilterObservation) initialRequest
			.getAttribute(ObservationFilterChainDecorator.ATTRIBUTE);
		assertThat(parentObservation).isNotNull();

		// simulate dispatching error-related request
		Filter errorRelatedFilter = ObservationFilterChainDecorator.FilterObservation
			.create(Observation.createNotStarted("wrap", registry))
			.wrap(fcp);
		ServletRequest errorRelatedRequest = new MockHttpServletRequest("GET", "/error");
		errorRelatedRequest.setAttribute(ObservationFilterChainDecorator.ATTRIBUTE, parentObservation);
		errorRelatedFilter.doFilter(errorRelatedRequest, new MockHttpServletResponse(), this.chain);

		ArgumentCaptor<Observation.Context> captor = ArgumentCaptor.forClass(Observation.Context.class);
		verify(handler, times(8)).onStart(captor.capture());
		verify(handler, times(8)).onStop(any());
		List<Observation.Context> contexts = captor.getAllValues();

		Observation.Context initialRequestObservationContextBefore = contexts.get(1);
		Observation.Context initialRequestObservationContextAfter = contexts.get(3);
		assertFilterChainObservation(initialRequestObservationContextBefore, "before", 1);
		assertFilterChainObservation(initialRequestObservationContextAfter, "after", 1);

		assertThat(initialRequestObservationContextBefore.getParentObservation()).isNotNull();
		assertThat(initialRequestObservationContextBefore.getParentObservation())
			.isSameAs(initialRequestObservationContextAfter.getParentObservation());

		Observation.Context errorRelatedRequestObservationContextBefore = contexts.get(5);
		Observation.Context errorRelatedRequestObservationContextAfter = contexts.get(7);
		assertFilterChainObservation(errorRelatedRequestObservationContextBefore, "before", 1);
		assertFilterChainObservation(errorRelatedRequestObservationContextAfter, "after", 1);

		assertThat(errorRelatedRequestObservationContextBefore.getParentObservation()).isNotNull();
		assertThat(errorRelatedRequestObservationContextBefore.getParentObservation())
			.isSameAs(initialRequestObservationContextBefore.getParentObservation());
		assertThat(errorRelatedRequestObservationContextAfter.getParentObservation()).isNotNull();
		assertThat(errorRelatedRequestObservationContextAfter.getParentObservation())
			.isSameAs(initialRequestObservationContextBefore.getParentObservation());
	}

	@Test
	public void doFilterWhenMultipleFiltersThenObservationRegistryObserves() throws Exception {
		ObservationHandler<Observation.Context> handler = mock(ObservationHandler.class);
		given(handler.supportsContext(any())).willReturn(true);
		ObservationRegistry registry = ObservationRegistry.create();
		registry.observationConfig().observationHandler(handler);
		given(this.matcher.matches(any())).willReturn(true);
		Filter one = mockFilter();
		Filter two = mockFilter();
		Filter three = mockFilter();
		SecurityFilterChain sec = new DefaultSecurityFilterChain(this.matcher, one, two, three);
		FilterChainProxy fcp = new FilterChainProxy(sec);
		fcp.setFilterChainDecorator(new ObservationFilterChainDecorator(registry));
		Filter filter = ObservationFilterChainDecorator.FilterObservation
			.create(Observation.createNotStarted("wrap", registry))
			.wrap(fcp);
		filter.doFilter(this.request, this.response, this.chain);
		ArgumentCaptor<Observation.Context> captor = ArgumentCaptor.forClass(Observation.Context.class);
		verify(handler, times(4)).onStart(captor.capture());
		verify(handler, times(4)).onStop(any());
		Iterator<Observation.Context> contexts = captor.getAllValues().iterator();
		assertThat(contexts.next().getName()).isEqualTo("wrap");
		assertFilterChainObservation(contexts.next(), "before", 3);
		assertThat(contexts.next().getName()).isEqualTo(ObservationFilterChainDecorator.SECURED_OBSERVATION_NAME);
		assertFilterChainObservation(contexts.next(), "after", 3);
	}

	@Test
	public void doFilterWhenMismatchesThenObservationRegistryObserves() throws Exception {
		ObservationHandler<Observation.Context> handler = mock(ObservationHandler.class);
		given(handler.supportsContext(any())).willReturn(true);
		ObservationRegistry registry = ObservationRegistry.create();
		registry.observationConfig().observationHandler(handler);
		SecurityFilterChain sec = new DefaultSecurityFilterChain(this.matcher, Arrays.asList(this.filter));
		FilterChainProxy fcp = new FilterChainProxy(sec);
		fcp.setFilterChainDecorator(new ObservationFilterChainDecorator(registry));
		Filter filter = ObservationFilterChainDecorator.FilterObservation
			.create(Observation.createNotStarted("wrap", registry))
			.wrap(fcp);
		filter.doFilter(this.request, this.response, this.chain);
		ArgumentCaptor<Observation.Context> captor = ArgumentCaptor.forClass(Observation.Context.class);
		verify(handler, times(2)).onStart(captor.capture());
		verify(handler, times(2)).onStop(any());
		Iterator<Observation.Context> contexts = captor.getAllValues().iterator();
		assertThat(contexts.next().getName()).isEqualTo("wrap");
		assertThat(contexts.next().getName()).isEqualTo(ObservationFilterChainDecorator.UNSECURED_OBSERVATION_NAME);
	}

	@Test
	public void doFilterWhenFilterExceptionThenObservationRegistryObserves() throws Exception {
		ObservationHandler<Observation.Context> handler = mock(ObservationHandler.class);
		given(handler.supportsContext(any())).willReturn(true);
		ObservationRegistry registry = ObservationRegistry.create();
		registry.observationConfig().observationHandler(handler);
		willThrow(IllegalStateException.class).given(this.filter).doFilter(any(), any(), any());
		given(this.matcher.matches(any())).willReturn(true);
		SecurityFilterChain sec = new DefaultSecurityFilterChain(this.matcher, Arrays.asList(this.filter));
		FilterChainProxy fcp = new FilterChainProxy(sec);
		fcp.setFilterChainDecorator(new ObservationFilterChainDecorator(registry));
		Filter filter = ObservationFilterChainDecorator.FilterObservation
			.create(Observation.createNotStarted("wrap", registry))
			.wrap(fcp);
		assertThatExceptionOfType(IllegalStateException.class)
			.isThrownBy(() -> filter.doFilter(this.request, this.response, this.chain));
		ArgumentCaptor<Observation.Context> captor = ArgumentCaptor.forClass(Observation.Context.class);
		verify(handler, times(2)).onStart(captor.capture());
		verify(handler, times(2)).onStop(any());
		verify(handler, atLeastOnce()).onError(any());
		Iterator<Observation.Context> contexts = captor.getAllValues().iterator();
		assertThat(contexts.next().getName()).isEqualTo("wrap");
		assertFilterChainObservation(contexts.next(), "before", 1);
	}

	@Test
	public void doFilterWhenExceptionWithMultipleFiltersThenObservationRegistryObserves() throws Exception {
		ObservationHandler<Observation.Context> handler = mock(ObservationHandler.class);
		given(handler.supportsContext(any())).willReturn(true);
		ObservationRegistry registry = ObservationRegistry.create();
		registry.observationConfig().observationHandler(handler);
		given(this.matcher.matches(any())).willReturn(true);
		Filter one = mockFilter();
		Filter two = mock(Filter.class);
		willThrow(IllegalStateException.class).given(two).doFilter(any(), any(), any());
		Filter three = mockFilter();
		SecurityFilterChain sec = new DefaultSecurityFilterChain(this.matcher, one, two, three);
		FilterChainProxy fcp = new FilterChainProxy(sec);
		fcp.setFilterChainDecorator(new ObservationFilterChainDecorator(registry));
		Filter filter = ObservationFilterChainDecorator.FilterObservation
			.create(Observation.createNotStarted("wrap", registry))
			.wrap(fcp);
		assertThatExceptionOfType(IllegalStateException.class)
			.isThrownBy(() -> filter.doFilter(this.request, this.response, this.chain));
		ArgumentCaptor<Observation.Context> captor = ArgumentCaptor.forClass(Observation.Context.class);
		verify(handler, times(2)).onStart(captor.capture());
		verify(handler, times(2)).onStop(any());
		Iterator<Observation.Context> contexts = captor.getAllValues().iterator();
		assertThat(contexts.next().getName()).isEqualTo("wrap");
		assertFilterChainObservation(contexts.next(), "before", 2);
	}

	@Test
	public void doFilterWhenOneFilterDoesNotProceedThenObservationRegistryObserves() throws Exception {
		ObservationHandler<Observation.Context> handler = mock(ObservationHandler.class);
		given(handler.supportsContext(any())).willReturn(true);
		ObservationRegistry registry = ObservationRegistry.create();
		registry.observationConfig().observationHandler(handler);
		given(this.matcher.matches(any())).willReturn(true);
		Filter one = mockFilter();
		Filter two = mock(Filter.class);
		Filter three = mockFilter();
		SecurityFilterChain sec = new DefaultSecurityFilterChain(this.matcher, one, two, three);
		FilterChainProxy fcp = new FilterChainProxy(sec);
		fcp.setFilterChainDecorator(new ObservationFilterChainDecorator(registry));
		Filter filter = ObservationFilterChainDecorator.FilterObservation
			.create(Observation.createNotStarted("wrap", registry))
			.wrap(fcp);
		filter.doFilter(this.request, this.response, this.chain);
		ArgumentCaptor<Observation.Context> captor = ArgumentCaptor.forClass(Observation.Context.class);
		verify(handler, times(3)).onStart(captor.capture());
		verify(handler, times(3)).onStop(any());
		Iterator<Observation.Context> contexts = captor.getAllValues().iterator();
		assertThat(contexts.next().getName()).isEqualTo("wrap");
		assertFilterChainObservation(contexts.next(), "before", 2);
		assertFilterChainObservation(contexts.next(), "after", 3);
	}

	static void assertFilterChainObservation(Observation.Context context, String filterSection, int chainPosition) {
		assertThat(context).isInstanceOf(ObservationFilterChainDecorator.FilterChainObservationContext.class);
		ObservationFilterChainDecorator.FilterChainObservationContext filterChainObservationContext = (ObservationFilterChainDecorator.FilterChainObservationContext) context;
		assertThat(context.getName())
			.isEqualTo(ObservationFilterChainDecorator.FilterChainObservationConvention.CHAIN_OBSERVATION_NAME);
		assertThat(context.getContextualName()).endsWith(filterSection);
		assertThat(filterChainObservationContext.getChainPosition()).isEqualTo(chainPosition);
	}

	static Filter mockFilter() throws Exception {
		Filter filter = mock(Filter.class);
		willAnswer((invocation) -> {
			HttpServletRequest request = invocation.getArgument(0, HttpServletRequest.class);
			HttpServletResponse response = invocation.getArgument(1, HttpServletResponse.class);
			FilterChain chain = invocation.getArgument(2, FilterChain.class);
			chain.doFilter(request, response);
			return null;
		}).given(filter).doFilter(any(), any(), any());
		return filter;
	}

	private static class MockFirewalledRequest extends FirewalledRequest {

		MockFirewalledRequest(HttpServletRequest request) {
			super(request);
		}

		@Override
		public void reset() {

		}

	}

	private static class MockFilter implements Filter {

		@Override
		public void doFilter(ServletRequest request, ServletResponse response, FilterChain chain)
				throws IOException, ServletException {
			chain.doFilter(request, response);
		}

	}

}
