root
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Actions 21 Packages Projects Releases Wiki Activity
spring-security/etc/checkstyle/checkstyle.xml

50 lines
3.1 KiB
XML
Raw Permalink Normal View History

Add Checkstyle Fixes gh-3746
2016-03-14 13:02:07 +08:00
<?xml version="1.0"?>
Add Spring Checkstyle with all checks disabled Introduce checkstyle rules from spring-javaformat, but keep them disabled so that fixes can be introduced one commit at a time. Issue gh-8945
2020-07-25 02:37:53 +08:00
<!DOCTYPE module PUBLIC
"-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
"https://checkstyle.org/dtds/configuration_1_3.dtd">
<module name="com.puppycrawl.tools.checkstyle.Checker">
Add Checkstyle Fixes gh-3746
2016-03-14 13:02:07 +08:00
<module name="SuppressionFilter">
Add Spring Checkstyle with all checks disabled Introduce checkstyle rules from spring-javaformat, but keep them disabled so that fixes can be introduced one commit at a time. Issue gh-8945
2020-07-25 02:37:53 +08:00
<property name="file"
value="${config_loc}/checkstyle-suppressions.xml" />
Add Checkstyle Fixes gh-3746
2016-03-14 13:02:07 +08:00
</module>
Enforce checkstyle header rule Enforce the checkstyle header rule and fix a few classes that had malformed headers. Issue gh-8945
2020-07-30 05:14:23 +08:00
<module name="com.puppycrawl.tools.checkstyle.checks.header.RegexpHeaderCheck">
<property name="headerFile" value="${config_loc}/header.txt" />
<property name="fileExtensions" value="java" />
Add Checkstyle Fixes gh-3746
2016-03-14 13:02:07 +08:00
</module>
Enforce checkstyle header rule Enforce the checkstyle header rule and fix a few classes that had malformed headers. Issue gh-8945
2020-07-30 05:14:23 +08:00
<module name="io.spring.javaformat.checkstyle.SpringChecks">
<property name="excludes" value="io.spring.javaformat.checkstyle.check.SpringHeaderCheck" />
Exclude JavadocPackageCheck from Spring Checks Issue gh-11422
2022-07-16 01:00:22 +08:00
<property name="excludes" value="com.puppycrawl.tools.checkstyle.checks.javadoc.JavadocPackageCheck" />
Merge Formatting Changes Issue gh-8945
2020-08-25 05:38:12 +08:00
<property name="avoidStaticImportExcludes" value="org.springframework.security.test.web.reactive.server.SecurityMockServerConfigurers.*" />
Propagate TestSecurityContextHolder to SecurityContextHolder Create SecurityMockMvcResultHandlers to define security related MockMvc ResultHandlers Create a method to allow copying the SecurityContext from the TestSecurityContextHolder to SecurityContextHolder Closes gh-9565
2021-05-11 00:45:04 +08:00
<property name="avoidStaticImportExcludes" value="org.springframework.security.test.web.servlet.response.SecurityMockMvcResultHandlers.*" />
Add SecurityContextHolderStrategy to Default Components Issue gh-11060
2022-05-27 04:14:10 +08:00
<property name="avoidStaticImportExcludes" value="org.springframework.security.config.annotation.SecurityContextChangedListenerArgumentMatchers.*" />
CsrfTokenRequestAttributeHandler -> CsrfTokenRequestHandler This renames CsrfTokenRequestAttributeHandler to CsrfTokenRequestHandler and moves usage from CsrfFilter into CsrfTokenRequestHandler. Closes gh-11892
2022-09-22 22:26:53 +08:00
<property name="avoidStaticImportExcludes" value="org.springframework.security.web.csrf.CsrfTokenAssert.*" />
Add static factory method to AntPathRequestMather and RegexRequestMatcher Closes gh-11938
2022-10-06 20:53:54 +08:00
<property name="avoidStaticImportExcludes" value="org.springframework.security.web.util.matcher.AntPathRequestMatcher.*" />
<property name="avoidStaticImportExcludes" value="org.springframework.security.web.util.matcher.RegexRequestMatcher.*" />
Pick MvcRequestMatcher for MockMvc requests Closes gh-13849
2024-06-06 06:58:11 +08:00
<property name="avoidStaticImportExcludes" value="org.assertj.core.api.InstanceOfAssertFactories.*"/>
Enforce checkstyle header rule Enforce the checkstyle header rule and fix a few classes that had malformed headers. Issue gh-8945
2020-07-30 05:14:23 +08:00
</module>
Migrate to assertThatExceptionOfType Consistently use `assertThatExceptionOfType(...).isThrownBy(...)` rather than `assertThatCode` or `assertThatThrownBy`. This aligns with Spring Boot and Spring Cloud. It also allows the convenience `assertThatIllegalArgument` and `assertThatIllegalState` methods to be used. Issue gh-8945
2020-08-05 05:20:45 +08:00
<module name="com.puppycrawl.tools.checkstyle.TreeWalker">
<module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">
<property name="maximum" value="0"/>
<property name="format" value="org\.assertj\.core\.api\.Assertions\.(catchThrowable|catchThrowableOfType|assertThatThrownBy|assertThatCode)" />
<property name="message" value="Please use assertThatExceptionOfType." />
<property name="ignoreComments" value="true" />
Add Checkstyle Fixes gh-3746
2016-03-14 13:02:07 +08:00
</module>
Require Locale argument for toLower/toUpperCase usage
2024-10-28 19:38:45 +08:00
<module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">
<property name="id" value="toLowerCaseWithoutLocale"/>
<property name="format" value="\.toLowerCase\(\)"/>
<property name="maximum" value="0"/>
<property name="message"
value="String.toLowerCase() should be String.toLowerCase(Locale.ROOT) or String.toLowerCase(Locale.ENGLISH)"/>
<property name="ignoreComments" value="true"/>
</module>
<module name="com.puppycrawl.tools.checkstyle.checks.regexp.RegexpSinglelineJavaCheck">
<property name="id" value="toUpperCaseWithoutLocale"/>
<property name="format" value="\.toUpperCase\(\)"/>
<property name="maximum" value="0"/>
<property name="message"
value="String.toUpperCase() should be String.toUpperCase(Locale.ROOT) or String.toUpperCase(Locale.ENGLISH)"/>
<property name="ignoreComments" value="true"/>
</module>
Add Checkstyle Fixes gh-3746
2016-03-14 13:02:07 +08:00
</module>
</module>