root
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Actions 9 Packages Projects Releases Wiki Activity

Improve GC for OnCommittedResponseWrapper 

Only track content length if disableOnCommitted is false. This improves object creation and thus GC.

Fixes gh-3842
This commit is contained in:
bartolom 2016-05-02 23:19:21 +02:00 committed by Rob Winch
parent 2bdb0231c2
commit 3ca8273a95
1 changed files with 33 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
web/src/main/java/org/springframework/security/web/util/OnCommittedResponseWrapper.java
View File

@ -42,7 +42,8 @@ public abstract class OnCommittedResponseWrapper extends HttpServletResponseWrap
private long contentLength; private long contentLength;
/** /**
* The size of data written to the response body. * The size of data written to the response body. The field will only be updated when
* {@link #disableOnCommitted} is false.
*/ */
private long contentWritten; private long contentWritten;
@ -158,44 +159,64 @@ public abstract class OnCommittedResponseWrapper extends HttpServletResponseWrap
} }
private void trackContentLength(boolean content) { private void trackContentLength(boolean content) {
checkContentLength(content ? 4 : 5); // TODO Localization if (!this.disableOnCommitted) {
checkContentLength(content ? 4 : 5); // TODO Localization
}
} }
private void trackContentLength(char content) { private void trackContentLength(char content) {
checkContentLength(1); if (!this.disableOnCommitted) {
checkContentLength(1);
}
} }
private void trackContentLength(Object content) { private void trackContentLength(Object content) {
trackContentLength(String.valueOf(content)); if (!this.disableOnCommitted) {
trackContentLength(String.valueOf(content));
}
} }
private void trackContentLength(byte[] content) { private void trackContentLength(byte[] content) {
checkContentLength(content == null ? 0 : content.length); if (!this.disableOnCommitted) {
checkContentLength(content == null ? 0 : content.length);
}
} }
private void trackContentLength(char[] content) { private void trackContentLength(char[] content) {
checkContentLength(content == null ? 0 : content.length); if (!this.disableOnCommitted) {
checkContentLength(content == null ? 0 : content.length);
}
} }
private void trackContentLength(int content) { private void trackContentLength(int content) {
trackContentLength(String.valueOf(content)); if (!this.disableOnCommitted) {
trackContentLength(String.valueOf(content));
}
} }
private void trackContentLength(float content) { private void trackContentLength(float content) {
trackContentLength(String.valueOf(content)); if (!this.disableOnCommitted) {
trackContentLength(String.valueOf(content));
}
} }
private void trackContentLength(double content) { private void trackContentLength(double content) {
trackContentLength(String.valueOf(content)); if (!this.disableOnCommitted) {
trackContentLength(String.valueOf(content));
}
} }
private void trackContentLengthLn() { private void trackContentLengthLn() {
trackContentLength("\r\n"); if (!this.disableOnCommitted) {
trackContentLength("\r\n");
}
} }
private void trackContentLength(String content) { private void trackContentLength(String content) {
int contentLength = content == null ? 4 : content.length(); if (!this.disableOnCommitted) {
checkContentLength(contentLength); int contentLength = content == null ? 4 : content.length();
checkContentLength(contentLength);
}
} }
/** /**