From f631a0fcd548418730b45ba48b7e82bf19cda8bd Mon Sep 17 00:00:00 2001 From: Josh Cummings <3627351+jzheaux@users.noreply.github.com> Date: Tue, 29 Apr 2025 14:02:46 -0600 Subject: [PATCH] Polish ClientRegistrationsTests Simplified the assertion so that it is focused on the core behavior being verified. This will likely also make the test more stable when updating Spring Framework versions. Issue gh-16860 --- .../client/registration/ClientRegistrationsTests.java | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/oauth2/oauth2-client/src/test/java/org/springframework/security/oauth2/client/registration/ClientRegistrationsTests.java b/oauth2/oauth2-client/src/test/java/org/springframework/security/oauth2/client/registration/ClientRegistrationsTests.java index 62954a2599..7e59d2595b 100644 --- a/oauth2/oauth2-client/src/test/java/org/springframework/security/oauth2/client/registration/ClientRegistrationsTests.java +++ b/oauth2/oauth2-client/src/test/java/org/springframework/security/oauth2/client/registration/ClientRegistrationsTests.java @@ -471,15 +471,11 @@ public class ClientRegistrationsTests { return new MockResponse().setResponseCode(responseCode); } }); - String message = """ - Unable to resolve Configuration with the provided Issuer of "%s", errors: [\ - 405 Client Error: [no body], \ - 400 Client Error: [no body], \ - 404 Client Error: [no body]]\ - """.formatted(this.issuer); assertThatExceptionOfType(IllegalArgumentException.class) .isThrownBy(() -> ClientRegistrations.fromIssuerLocation(this.issuer).build()) - .withMessage(message); + .withMessageContaining("405") + .withMessageContaining("400") + .withMessageContaining("404"); } private ClientRegistration.Builder registration(String path) throws Exception {