From a6d47203dba7ad80f8fc7a66150bd45dc6be576b Mon Sep 17 00:00:00 2001 From: Luke Taylor Date: Sun, 3 Oct 2010 22:54:21 +0100 Subject: [PATCH] FilterInvocation should set queryString on dummy request. --- .../org/springframework/security/web/FilterInvocation.java | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/web/src/main/java/org/springframework/security/web/FilterInvocation.java b/web/src/main/java/org/springframework/security/web/FilterInvocation.java index 8bda36a9d5..7c7fe37847 100644 --- a/web/src/main/java/org/springframework/security/web/FilterInvocation.java +++ b/web/src/main/java/org/springframework/security/web/FilterInvocation.java @@ -49,6 +49,7 @@ import org.springframework.security.web.util.UrlUtils; * * @author Ben Alex * @author colin sampaleanu + * @author Luke Taylor */ public class FilterInvocation { //~ Static fields ================================================================================================== @@ -58,8 +59,6 @@ public class FilterInvocation { } }; - static final HttpServletResponse DUMMY_RESPONSE = new DummyResponse(); - //~ Instance fields ================================================================================================ private FilterChain chain; @@ -94,6 +93,7 @@ public class FilterInvocation { request.setContextPath(contextPath); request.setServletPath(servletPath); request.setPathInfo(pathInfo); + request.setQueryString(query); request.setMethod(method); this.request = request; } @@ -146,7 +146,7 @@ public class FilterInvocation { } } -@SuppressWarnings("unchecked") +@SuppressWarnings({"unchecked", "deprecation"}) class DummyRequest implements HttpServletRequest { private String requestURI; private String contextPath = ""; @@ -398,6 +398,7 @@ class DummyRequest implements HttpServletRequest { } } +@SuppressWarnings({"deprecation"}) class DummyResponse implements HttpServletResponse { public void addCookie(Cookie cookie) { throw new UnsupportedOperationException();