From dc9f9b140f6b5d2b8730655ed773da27c31f032c Mon Sep 17 00:00:00 2001
From: Rob Winch <rwinch@gopivotal.com>
Date: Mon, 24 Oct 2016 11:24:05 -0500
Subject: [PATCH] Polish PasswordEncoderUtilsTests

* Add more tests
* Smaller tests
* Follow new naming convention
---
 .../encoding/PasswordEncoderUtilsTests.java   | 23 +++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/core/src/test/java/org/springframework/security/authentication/encoding/PasswordEncoderUtilsTests.java b/core/src/test/java/org/springframework/security/authentication/encoding/PasswordEncoderUtilsTests.java
index a713a81559..7aa900068f 100644
--- a/core/src/test/java/org/springframework/security/authentication/encoding/PasswordEncoderUtilsTests.java
+++ b/core/src/test/java/org/springframework/security/authentication/encoding/PasswordEncoderUtilsTests.java
@@ -25,25 +25,40 @@ import org.junit.Test;
 public class PasswordEncoderUtilsTests {
 
 	@Test
-	public void differentLength() {
+	public void equalsWhenDifferentLengthThenFalse() {
 		assertThat(PasswordEncoderUtils.equals("abc", "a")).isFalse();
 		assertThat(PasswordEncoderUtils.equals("a", "abc")).isFalse();
 	}
 
 	@Test
-	public void equalsNull() {
+	public void equalsWhenNullAndNotEmtpyThenFalse() {
 		assertThat(PasswordEncoderUtils.equals(null, "a")).isFalse();
 		assertThat(PasswordEncoderUtils.equals("a", null)).isFalse();
+	}
+
+	@Test
+	public void equalsWhenNullAndNullThenTrue() {
 		assertThat(PasswordEncoderUtils.equals(null, null)).isTrue();
 	}
 
 	@Test
-	public void equalsCaseSensitive() {
+	public void equalsWhenNullAndEmptyThenFalse() {
+		assertThat(PasswordEncoderUtils.equals(null, "")).isFalse();
+		assertThat(PasswordEncoderUtils.equals("", null)).isFalse();
+	}
+
+	@Test
+	public void equalsWhenEmtpyAndEmptyThenTrue() {
+		assertThat(PasswordEncoderUtils.equals("", "")).isTrue();
+	}
+
+	@Test
+	public void equalsWhenDifferentCaseThenFalse() {
 		assertThat(PasswordEncoderUtils.equals("aBc", "abc")).isFalse();
 	}
 
 	@Test
-	public void equalsSuccess() {
+	public void equalsWhenSameThenTrue() {
 		assertThat(PasswordEncoderUtils.equals("abcdef", "abcdef")).isTrue();
 	}
 }