root
/
spring-security
mirror of https://github.com/spring-projects/spring-security.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

Add Test 

Issue gh-13660
This commit is contained in:
Josh Cummings 2023-10-30 17:24:20 -06:00
parent 4d6ff49b9d
commit ed6ff670d1
2 changed files with 8 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
web/src/main/java/org/springframework/security/web/ObservationFilterChainDecorator.java
View File

@ -141,7 +141,7 @@ public final class ObservationFilterChainDecorator implements FilterChainProxy.F
static final class ObservationFilter implements Filter {
private static final Map<String, String> OBSERVATION_NAMES = new HashMap<>();
static final Map<String, String> OBSERVATION_NAMES = new HashMap<>();
static {
OBSERVATION_NAMES.put("DisableEncodeUrlFilter", "session.urlencoding");

7
web/src/test/java/org/springframework/security/web/ObservationFilterChainDecoratorTests.java
View File

@ -150,6 +150,13 @@ public class ObservationFilterChainDecoratorTests {
.isEqualTo(expectedFilterNameTag);
}
// gh-13660
@Test
void observationNamesDoNotContainDashes() {
ObservationFilterChainDecorator.ObservationFilter.OBSERVATION_NAMES.values()
.forEach((name) -> assertThat(name).doesNotContain("-"));
}
static Stream<Arguments> decorateFiltersWhenCompletesThenHasSpringSecurityReachedFilterNameTag() {
Filter filterWithName = new BasicAuthenticationFilter();