diff --git a/acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java b/acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java index 48050cab48..1726048015 100644 --- a/acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java +++ b/acl/src/main/java/org/springframework/security/acls/jdbc/AclClassIdUtils.java @@ -41,14 +41,14 @@ class AclClassIdUtils { private ConversionService conversionService; - public AclClassIdUtils() { + AclClassIdUtils() { GenericConversionService genericConversionService = new GenericConversionService(); genericConversionService.addConverter(String.class, Long.class, new StringToLongConverter()); genericConversionService.addConverter(String.class, UUID.class, new StringToUUIDConverter()); this.conversionService = genericConversionService; } - public AclClassIdUtils(ConversionService conversionService) { + AclClassIdUtils(ConversionService conversionService) { Assert.notNull(conversionService, "conversionService must not be null"); this.conversionService = conversionService; } diff --git a/acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java b/acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java index 153ba2492e..ebd32632a7 100644 --- a/acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java +++ b/acl/src/main/java/org/springframework/security/acls/jdbc/BasicLookupStrategy.java @@ -559,7 +559,7 @@ public class BasicLookupStrategy implements LookupStrategy { private final Map acls; private final List sids; - public ProcessResultSet(Map acls, List sids) { + ProcessResultSet(Map acls, List sids) { Assert.notNull(acls, "ACLs cannot be null"); this.acls = acls; this.sids = sids; // can be null @@ -683,7 +683,7 @@ public class BasicLookupStrategy implements LookupStrategy { private static class StubAclParent implements Acl { private final Long id; - public StubAclParent(Long id) { + StubAclParent(Long id) { this.id = id; } diff --git a/cas/src/main/java/org/springframework/security/cas/jackson2/AssertionImplMixin.java b/cas/src/main/java/org/springframework/security/cas/jackson2/AssertionImplMixin.java index f5fba44dca..3085f92d95 100644 --- a/cas/src/main/java/org/springframework/security/cas/jackson2/AssertionImplMixin.java +++ b/cas/src/main/java/org/springframework/security/cas/jackson2/AssertionImplMixin.java @@ -55,8 +55,8 @@ class AssertionImplMixin { * @param attributes the key/value pairs for this attribute. */ @JsonCreator - public AssertionImplMixin(@JsonProperty("principal") AttributePrincipal principal, + AssertionImplMixin(@JsonProperty("principal") AttributePrincipal principal, @JsonProperty("validFromDate") Date validFromDate, @JsonProperty("validUntilDate") Date validUntilDate, @JsonProperty("authenticationDate") Date authenticationDate, @JsonProperty("attributes") Map attributes){ } -} \ No newline at end of file +} diff --git a/cas/src/main/java/org/springframework/security/cas/jackson2/AttributePrincipalImplMixin.java b/cas/src/main/java/org/springframework/security/cas/jackson2/AttributePrincipalImplMixin.java index ffb7ec4b6e..ddc326704f 100644 --- a/cas/src/main/java/org/springframework/security/cas/jackson2/AttributePrincipalImplMixin.java +++ b/cas/src/main/java/org/springframework/security/cas/jackson2/AttributePrincipalImplMixin.java @@ -51,8 +51,8 @@ class AttributePrincipalImplMixin { * @param proxyRetriever the ProxyRetriever implementation to call back to the CAS server. */ @JsonCreator - public AttributePrincipalImplMixin(@JsonProperty("name") String name, @JsonProperty("attributes") Map attributes, + AttributePrincipalImplMixin(@JsonProperty("name") String name, @JsonProperty("attributes") Map attributes, @JsonProperty("proxyGrantingTicket") String proxyGrantingTicket, @JsonProperty("proxyRetriever") ProxyRetriever proxyRetriever) { } -} \ No newline at end of file +} diff --git a/cas/src/main/java/org/springframework/security/cas/jackson2/CasAuthenticationTokenMixin.java b/cas/src/main/java/org/springframework/security/cas/jackson2/CasAuthenticationTokenMixin.java index da909d9116..dba9e0521e 100644 --- a/cas/src/main/java/org/springframework/security/cas/jackson2/CasAuthenticationTokenMixin.java +++ b/cas/src/main/java/org/springframework/security/cas/jackson2/CasAuthenticationTokenMixin.java @@ -69,7 +69,7 @@ class CasAuthenticationTokenMixin { * principal and how to obtain a proxy ticket for the user. */ @JsonCreator - public CasAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal, + CasAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal, @JsonProperty("credentials") Object credentials, @JsonProperty("authorities") Collection authorities, @JsonProperty("userDetails") UserDetails userDetails, @JsonProperty("assertion") Assertion assertion) { diff --git a/cas/src/main/java/org/springframework/security/cas/web/CasAuthenticationFilter.java b/cas/src/main/java/org/springframework/security/cas/web/CasAuthenticationFilter.java index cd91b84954..7ff21e2480 100644 --- a/cas/src/main/java/org/springframework/security/cas/web/CasAuthenticationFilter.java +++ b/cas/src/main/java/org/springframework/security/cas/web/CasAuthenticationFilter.java @@ -415,7 +415,7 @@ public class CasAuthenticationFilter extends AbstractAuthenticationProcessingFil private class CasAuthenticationFailureHandler implements AuthenticationFailureHandler { private final AuthenticationFailureHandler serviceTicketFailureHandler; - public CasAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) { + CasAuthenticationFailureHandler(AuthenticationFailureHandler failureHandler) { Assert.notNull(failureHandler, "failureHandler"); this.serviceTicketFailureHandler = failureHandler; } @@ -432,4 +432,4 @@ public class CasAuthenticationFilter extends AbstractAuthenticationProcessingFil } } } -} \ No newline at end of file +} diff --git a/cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java b/cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java index 37ff45557d..230a29c031 100644 --- a/cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java +++ b/cas/src/test/java/org/springframework/security/cas/authentication/CasAuthenticationProviderTests.java @@ -414,7 +414,7 @@ public class CasAuthenticationProviderTests { private class MockTicketValidator implements TicketValidator { private boolean returnTicket; - public MockTicketValidator(boolean returnTicket) { + MockTicketValidator(boolean returnTicket) { this.returnTicket = returnTicket; } diff --git a/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java b/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java index 56e0ecfd67..17937f4402 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java +++ b/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/AuthenticationConfiguration.java @@ -193,7 +193,7 @@ public class AuthenticationConfiguration { private static final Log logger = LogFactory .getLog(EnableGlobalAuthenticationAutowiredConfigurer.class); - public EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) { + EnableGlobalAuthenticationAutowiredConfigurer(ApplicationContext context) { this.context = context; } diff --git a/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java b/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java index 555ba61ad9..c24aa3ea24 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java +++ b/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeAuthenticationProviderBeanManagerConfigurer.java @@ -42,7 +42,7 @@ class InitializeAuthenticationProviderBeanManagerConfigurer /** * @param context the ApplicationContext to look up beans. */ - public InitializeAuthenticationProviderBeanManagerConfigurer( + InitializeAuthenticationProviderBeanManagerConfigurer( ApplicationContext context) { this.context = context; } @@ -83,4 +83,4 @@ class InitializeAuthenticationProviderBeanManagerConfigurer .getBean(userDetailsBeanNames[0], type); } } -} \ No newline at end of file +} diff --git a/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java b/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java index 941ee9b202..7266fbfa77 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java +++ b/config/src/main/java/org/springframework/security/config/annotation/authentication/configuration/InitializeUserDetailsBeanManagerConfigurer.java @@ -43,7 +43,7 @@ class InitializeUserDetailsBeanManagerConfigurer /** * @param context */ - public InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) { + InitializeUserDetailsBeanManagerConfigurer(ApplicationContext context) { this.context = context; } diff --git a/config/src/main/java/org/springframework/security/config/annotation/configuration/AutowireBeanFactoryObjectPostProcessor.java b/config/src/main/java/org/springframework/security/config/annotation/configuration/AutowireBeanFactoryObjectPostProcessor.java index 67e512fad4..a4c193b4a5 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/configuration/AutowireBeanFactoryObjectPostProcessor.java +++ b/config/src/main/java/org/springframework/security/config/annotation/configuration/AutowireBeanFactoryObjectPostProcessor.java @@ -44,7 +44,7 @@ final class AutowireBeanFactoryObjectPostProcessor private final List disposableBeans = new ArrayList<>(); private final List smartSingletons = new ArrayList<>(); - public AutowireBeanFactoryObjectPostProcessor( + AutowireBeanFactoryObjectPostProcessor( AutowireCapableBeanFactory autowireBeanFactory) { Assert.notNull(autowireBeanFactory, "autowireBeanFactory cannot be null"); this.autowireBeanFactory = autowireBeanFactory; diff --git a/config/src/main/java/org/springframework/security/config/annotation/method/configuration/GlobalMethodSecuritySelector.java b/config/src/main/java/org/springframework/security/config/annotation/method/configuration/GlobalMethodSecuritySelector.java index 70c3f7c8fb..1ffa8256a2 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/method/configuration/GlobalMethodSecuritySelector.java +++ b/config/src/main/java/org/springframework/security/config/annotation/method/configuration/GlobalMethodSecuritySelector.java @@ -36,7 +36,7 @@ import org.springframework.util.ClassUtils; */ final class GlobalMethodSecuritySelector implements ImportSelector { - public final String[] selectImports(AnnotationMetadata importingClassMetadata) { + public String[] selectImports(AnnotationMetadata importingClassMetadata) { Class annoType = EnableGlobalMethodSecurity.class; Map annotationAttributes = importingClassMetadata .getAnnotationAttributes(annoType.getName(), false); diff --git a/config/src/main/java/org/springframework/security/config/annotation/web/configuration/AutowiredWebSecurityConfigurersIgnoreParents.java b/config/src/main/java/org/springframework/security/config/annotation/web/configuration/AutowiredWebSecurityConfigurersIgnoreParents.java index 2e404968c2..9195060ef1 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/web/configuration/AutowiredWebSecurityConfigurersIgnoreParents.java +++ b/config/src/main/java/org/springframework/security/config/annotation/web/configuration/AutowiredWebSecurityConfigurersIgnoreParents.java @@ -40,7 +40,7 @@ final class AutowiredWebSecurityConfigurersIgnoreParents { private final ConfigurableListableBeanFactory beanFactory; - public AutowiredWebSecurityConfigurersIgnoreParents( + AutowiredWebSecurityConfigurersIgnoreParents( ConfigurableListableBeanFactory beanFactory) { Assert.notNull(beanFactory, "beanFactory cannot be null"); this.beanFactory = beanFactory; diff --git a/config/src/main/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java b/config/src/main/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java index 51bcd1da7d..d1df31e7f5 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java +++ b/config/src/main/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurer.java @@ -183,7 +183,7 @@ public final class ExpressionUrlAuthorizationConfigurer> getDecisionVoters(H http) { + List> getDecisionVoters(H http) { List> decisionVoters = new ArrayList<>(); WebExpressionVoter expressionVoter = new WebExpressionVoter(); expressionVoter.setExpressionHandler(getExpressionHandler(http)); @@ -192,7 +192,7 @@ public final class ExpressionUrlAuthorizationConfigurer> requestMap = REGISTRY .createRequestMap(); diff --git a/config/src/main/java/org/springframework/security/config/annotation/web/configurers/UrlAuthorizationConfigurer.java b/config/src/main/java/org/springframework/security/config/annotation/web/configurers/UrlAuthorizationConfigurer.java index b546b5b742..ec653cb5fb 100644 --- a/config/src/main/java/org/springframework/security/config/annotation/web/configurers/UrlAuthorizationConfigurer.java +++ b/config/src/main/java/org/springframework/security/config/annotation/web/configurers/UrlAuthorizationConfigurer.java @@ -172,7 +172,7 @@ public final class UrlAuthorizationConfigurer> */ @Override @SuppressWarnings("rawtypes") - final List> getDecisionVoters(H http) { + List> getDecisionVoters(H http) { List> decisionVoters = new ArrayList<>(); decisionVoters.add(new RoleVoter()); decisionVoters.add(new AuthenticatedVoter()); diff --git a/config/src/main/java/org/springframework/security/config/crypto/RsaKeyConversionServicePostProcessor.java b/config/src/main/java/org/springframework/security/config/crypto/RsaKeyConversionServicePostProcessor.java index c28d8db346..b3cd7df87c 100644 --- a/config/src/main/java/org/springframework/security/config/crypto/RsaKeyConversionServicePostProcessor.java +++ b/config/src/main/java/org/springframework/security/config/crypto/RsaKeyConversionServicePostProcessor.java @@ -133,7 +133,7 @@ public class RsaKeyConversionServicePostProcessor implements BeanFactoryPostProc private static class ConverterPropertyEditorAdapter extends PropertyEditorSupport { private final Converter converter; - public ConverterPropertyEditorAdapter(Converter converter) { + ConverterPropertyEditorAdapter(Converter converter) { this.converter = converter; } diff --git a/config/src/main/java/org/springframework/security/config/http/AuthenticationConfigBuilder.java b/config/src/main/java/org/springframework/security/config/http/AuthenticationConfigBuilder.java index 15734b8e5e..8489553f8f 100644 --- a/config/src/main/java/org/springframework/security/config/http/AuthenticationConfigBuilder.java +++ b/config/src/main/java/org/springframework/security/config/http/AuthenticationConfigBuilder.java @@ -138,7 +138,7 @@ final class AuthenticationConfigBuilder { private String openIDLoginPage; - public AuthenticationConfigBuilder(Element element, boolean forceAutoConfig, + AuthenticationConfigBuilder(Element element, boolean forceAutoConfig, ParserContext pc, SessionCreationPolicy sessionPolicy, BeanReference requestCache, BeanReference authenticationManager, BeanReference sessionStrategy, BeanReference portMapper, diff --git a/config/src/main/java/org/springframework/security/config/http/HttpConfigurationBuilder.java b/config/src/main/java/org/springframework/security/config/http/HttpConfigurationBuilder.java index cdaf09b7bd..24eb66974e 100644 --- a/config/src/main/java/org/springframework/security/config/http/HttpConfigurationBuilder.java +++ b/config/src/main/java/org/springframework/security/config/http/HttpConfigurationBuilder.java @@ -152,7 +152,7 @@ class HttpConfigurationBuilder { private BeanDefinition invalidSession; private boolean addAllAuth; - public HttpConfigurationBuilder(Element element, boolean addAllAuth, + HttpConfigurationBuilder(Element element, boolean addAllAuth, ParserContext pc, BeanReference portMapper, BeanReference portResolver, BeanReference authenticationManager) { this.httpElt = element; diff --git a/config/src/main/java/org/springframework/security/config/http/HttpSecurityBeanDefinitionParser.java b/config/src/main/java/org/springframework/security/config/http/HttpSecurityBeanDefinitionParser.java index 9506d3089b..fc3c4bbd76 100644 --- a/config/src/main/java/org/springframework/security/config/http/HttpSecurityBeanDefinitionParser.java +++ b/config/src/main/java/org/springframework/security/config/http/HttpSecurityBeanDefinitionParser.java @@ -415,12 +415,12 @@ class OrderDecorator implements Ordered { final BeanMetadataElement bean; final int order; - public OrderDecorator(BeanMetadataElement bean, SecurityFilters filterOrder) { + OrderDecorator(BeanMetadataElement bean, SecurityFilters filterOrder) { this.bean = bean; this.order = filterOrder.getOrder(); } - public OrderDecorator(BeanMetadataElement bean, int order) { + OrderDecorator(BeanMetadataElement bean, int order) { this.bean = bean; this.order = order; } diff --git a/config/src/main/java/org/springframework/security/config/http/LogoutBeanDefinitionParser.java b/config/src/main/java/org/springframework/security/config/http/LogoutBeanDefinitionParser.java index 3f070267a1..f694d6f361 100644 --- a/config/src/main/java/org/springframework/security/config/http/LogoutBeanDefinitionParser.java +++ b/config/src/main/java/org/springframework/security/config/http/LogoutBeanDefinitionParser.java @@ -48,7 +48,7 @@ class LogoutBeanDefinitionParser implements BeanDefinitionParser { private ManagedList logoutHandlers = new ManagedList<>(); private boolean csrfEnabled; - public LogoutBeanDefinitionParser(String loginPageUrl, String rememberMeServices, + LogoutBeanDefinitionParser(String loginPageUrl, String rememberMeServices, BeanMetadataElement csrfLogoutHandler) { this.defaultLogoutUrl = loginPageUrl + "?logout"; this.rememberMeServices = rememberMeServices; diff --git a/config/src/main/java/org/springframework/security/config/method/ProtectPointcutPostProcessor.java b/config/src/main/java/org/springframework/security/config/method/ProtectPointcutPostProcessor.java index 454d6835f0..1164a9682a 100644 --- a/config/src/main/java/org/springframework/security/config/method/ProtectPointcutPostProcessor.java +++ b/config/src/main/java/org/springframework/security/config/method/ProtectPointcutPostProcessor.java @@ -68,7 +68,7 @@ final class ProtectPointcutPostProcessor implements BeanPostProcessor { private final PointcutParser parser; private final Set processedBeans = new HashSet<>(); - public ProtectPointcutPostProcessor( + ProtectPointcutPostProcessor( MapBasedMethodSecurityMetadataSource mapBasedMethodSecurityMetadataSource) { Assert.notNull(mapBasedMethodSecurityMetadataSource, "MapBasedMethodSecurityMetadataSource to populate is required"); diff --git a/config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java b/config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java index d708855cac..40caf32841 100644 --- a/config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java +++ b/config/src/main/java/org/springframework/security/config/web/server/ServerHttpSecurity.java @@ -3645,7 +3645,7 @@ public class ServerHttpSecurity { private final WebFilter webFilter; private final int order; - public OrderedWebFilter(WebFilter webFilter, int order) { + OrderedWebFilter(WebFilter webFilter, int order) { this.webFilter = webFilter; this.order = order; } diff --git a/config/src/main/java/org/springframework/security/config/websocket/WebSocketMessageBrokerSecurityBeanDefinitionParser.java b/config/src/main/java/org/springframework/security/config/websocket/WebSocketMessageBrokerSecurityBeanDefinitionParser.java index e0006ab3d8..24fe2003dc 100644 --- a/config/src/main/java/org/springframework/security/config/websocket/WebSocketMessageBrokerSecurityBeanDefinitionParser.java +++ b/config/src/main/java/org/springframework/security/config/websocket/WebSocketMessageBrokerSecurityBeanDefinitionParser.java @@ -243,8 +243,7 @@ public final class WebSocketMessageBrokerSecurityBeanDefinitionParser implements private final boolean sameOriginDisabled; - public MessageSecurityPostProcessor(String inboundSecurityInterceptorId, - boolean sameOriginDisabled) { + MessageSecurityPostProcessor(String inboundSecurityInterceptorId, boolean sameOriginDisabled) { this.inboundSecurityInterceptorId = inboundSecurityInterceptorId; this.sameOriginDisabled = sameOriginDisabled; } diff --git a/config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java b/config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java index d28b24a5ec..2b01f0137f 100644 --- a/config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java +++ b/config/src/test/java/org/springframework/security/config/annotation/SecurityConfigurerAdapterTests.java @@ -41,7 +41,7 @@ public class SecurityConfigurerAdapterTests { static class OrderedObjectPostProcessor implements ObjectPostProcessor, Ordered { private final int order; - public OrderedObjectPostProcessor(int order) { + OrderedObjectPostProcessor(int order) { this.order = order; } diff --git a/config/src/test/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurerTests.java b/config/src/test/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurerTests.java index cda09431f1..4f7844ca69 100644 --- a/config/src/test/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurerTests.java +++ b/config/src/test/java/org/springframework/security/config/annotation/web/configurers/ExpressionUrlAuthorizationConfigurerTests.java @@ -847,7 +847,7 @@ public class ExpressionUrlAuthorizationConfigurerTests { static class CustomExpressionRoot extends WebSecurityExpressionRoot { - public CustomExpressionRoot(Authentication a, FilterInvocation fi) { + CustomExpressionRoot(Authentication a, FilterInvocation fi) { super(a, fi); } diff --git a/config/src/test/java/org/springframework/security/config/annotation/web/configurers/NamespaceHttpExpressionHandlerTests.java b/config/src/test/java/org/springframework/security/config/annotation/web/configurers/NamespaceHttpExpressionHandlerTests.java index f4868cca3c..c031809554 100644 --- a/config/src/test/java/org/springframework/security/config/annotation/web/configurers/NamespaceHttpExpressionHandlerTests.java +++ b/config/src/test/java/org/springframework/security/config/annotation/web/configurers/NamespaceHttpExpressionHandlerTests.java @@ -73,7 +73,7 @@ public class NamespaceHttpExpressionHandlerTests { @EnableWebMvc @EnableWebSecurity private static class ExpressionHandlerConfig extends WebSecurityConfigurerAdapter { - public ExpressionHandlerConfig() {} + ExpressionHandlerConfig() {} @Override protected void configure(AuthenticationManagerBuilder auth) throws Exception { diff --git a/config/src/test/java/org/springframework/security/config/annotation/web/configurers/SecurityContextConfigurerTests.java b/config/src/test/java/org/springframework/security/config/annotation/web/configurers/SecurityContextConfigurerTests.java index 142f4009a4..6d2b21c65e 100644 --- a/config/src/test/java/org/springframework/security/config/annotation/web/configurers/SecurityContextConfigurerTests.java +++ b/config/src/test/java/org/springframework/security/config/annotation/web/configurers/SecurityContextConfigurerTests.java @@ -129,7 +129,7 @@ public class SecurityContextConfigurerTests { @Configuration @EnableWebSecurity static class SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig extends WebSecurityConfigurerAdapter { - public SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig() { + SecurityContextRepositoryDefaultsSecurityContextRepositoryConfig() { super(true); } diff --git a/config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java b/config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java index ccf8e67897..ee1e10997d 100644 --- a/config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java +++ b/config/src/test/java/org/springframework/security/config/annotation/web/configurers/oauth2/server/resource/OAuth2ResourceServerConfigurerTests.java @@ -2133,7 +2133,7 @@ public class OAuth2ResourceServerConfigurerTests { private class MockWebServerPropertySource extends PropertySource { - public MockWebServerPropertySource() { + MockWebServerPropertySource() { super("mockwebserver"); } @@ -2178,7 +2178,7 @@ public class OAuth2ResourceServerConfigurerTests { private String token; - public BearerTokenRequestPostProcessor(String token) { + BearerTokenRequestPostProcessor(String token) { this.token = token; } diff --git a/config/src/test/java/org/springframework/security/config/http/CsrfConfigTests.java b/config/src/test/java/org/springframework/security/config/http/CsrfConfigTests.java index d7ff34c481..d98f89227f 100644 --- a/config/src/test/java/org/springframework/security/config/http/CsrfConfigTests.java +++ b/config/src/test/java/org/springframework/security/config/http/CsrfConfigTests.java @@ -631,7 +631,7 @@ public class CsrfConfigTests { static class CsrfReturnedResultMatcher implements ResultMatcher { ExceptionalFunction token; - public CsrfReturnedResultMatcher(ExceptionalFunction token) { + CsrfReturnedResultMatcher(ExceptionalFunction token) { this.token = token; } diff --git a/config/src/test/java/org/springframework/security/config/http/HttpConfigTests.java b/config/src/test/java/org/springframework/security/config/http/HttpConfigTests.java index 7f5de78206..f0da65eac7 100644 --- a/config/src/test/java/org/springframework/security/config/http/HttpConfigTests.java +++ b/config/src/test/java/org/springframework/security/config/http/HttpConfigTests.java @@ -83,7 +83,7 @@ public class HttpConfigTests { private static class EncodeUrlDenyingHttpServletResponseWrapper extends HttpServletResponseWrapper { - public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) { + EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) { super(response); } diff --git a/config/src/test/java/org/springframework/security/config/http/MiscHttpConfigTests.java b/config/src/test/java/org/springframework/security/config/http/MiscHttpConfigTests.java index 44b1da6261..d42c37f15b 100644 --- a/config/src/test/java/org/springframework/security/config/http/MiscHttpConfigTests.java +++ b/config/src/test/java/org/springframework/security/config/http/MiscHttpConfigTests.java @@ -907,7 +907,7 @@ public class MiscHttpConfigTests { static class EncodeUrlDenyingHttpServletResponseWrapper extends HttpServletResponseWrapper { - public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) { + EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) { super(response); } diff --git a/config/src/test/java/org/springframework/security/config/http/SessionManagementConfigTests.java b/config/src/test/java/org/springframework/security/config/http/SessionManagementConfigTests.java index 0756f5edf7..0adc2d66d9 100644 --- a/config/src/test/java/org/springframework/security/config/http/SessionManagementConfigTests.java +++ b/config/src/test/java/org/springframework/security/config/http/SessionManagementConfigTests.java @@ -610,7 +610,7 @@ public class SessionManagementConfigTests { private static class EncodeUrlDenyingHttpServletResponseWrapper extends HttpServletResponseWrapper { - public EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) { + EncodeUrlDenyingHttpServletResponseWrapper(HttpServletResponse response) { super(response); } diff --git a/config/src/test/java/org/springframework/security/htmlunit/server/HtmlUnitWebTestClient.java b/config/src/test/java/org/springframework/security/htmlunit/server/HtmlUnitWebTestClient.java index 8798b9b68c..4543deaae4 100644 --- a/config/src/test/java/org/springframework/security/htmlunit/server/HtmlUnitWebTestClient.java +++ b/config/src/test/java/org/springframework/security/htmlunit/server/HtmlUnitWebTestClient.java @@ -51,7 +51,7 @@ final class HtmlUnitWebTestClient { private final WebTestClient webTestClient; - public HtmlUnitWebTestClient(WebClient webClient, WebTestClient webTestClient) { + HtmlUnitWebTestClient(WebClient webClient, WebTestClient webTestClient) { Assert.notNull(webClient, "WebClient must not be null"); Assert.notNull(webTestClient, "WebTestClient must not be null"); this.webClient = webClient; diff --git a/config/src/test/java/org/springframework/security/htmlunit/server/MockWebResponseBuilder.java b/config/src/test/java/org/springframework/security/htmlunit/server/MockWebResponseBuilder.java index 4b1078a8a0..e2c37fe390 100644 --- a/config/src/test/java/org/springframework/security/htmlunit/server/MockWebResponseBuilder.java +++ b/config/src/test/java/org/springframework/security/htmlunit/server/MockWebResponseBuilder.java @@ -42,7 +42,7 @@ final class MockWebResponseBuilder { private final FluxExchangeResult exchangeResult; - public MockWebResponseBuilder(long startTime, WebRequest webRequest, FluxExchangeResult exchangeResult) { + MockWebResponseBuilder(long startTime, WebRequest webRequest, FluxExchangeResult exchangeResult) { Assert.notNull(webRequest, "WebRequest must not be null"); Assert.notNull(exchangeResult, "FluxExchangeResult must not be null"); this.startTime = startTime; diff --git a/core/src/main/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContext.java b/core/src/main/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContext.java index 791af548ae..c28845a296 100644 --- a/core/src/main/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContext.java +++ b/core/src/main/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContext.java @@ -48,11 +48,11 @@ class MethodSecurityEvaluationContext extends StandardEvaluationContext { * for each instance. Use the constructor which takes the resolver, as an argument * thus allowing for caching. */ - public MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi) { + MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi) { this(user, mi, new DefaultSecurityParameterNameDiscoverer()); } - public MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi, + MethodSecurityEvaluationContext(Authentication user, MethodInvocation mi, ParameterNameDiscoverer parameterNameDiscoverer) { this.mi = mi; this.parameterNameDiscoverer = parameterNameDiscoverer; diff --git a/core/src/main/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSource.java b/core/src/main/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSource.java index a006cc3e1b..9d85983e33 100644 --- a/core/src/main/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSource.java +++ b/core/src/main/java/org/springframework/security/access/method/DelegatingMethodSecurityMetadataSource.java @@ -116,7 +116,7 @@ public final class DelegatingMethodSecurityMetadataSource extends private final Method method; private final Class targetClass; - public DefaultCacheKey(Method method, Class targetClass) { + DefaultCacheKey(Method method, Class targetClass) { this.method = method; this.targetClass = targetClass; } diff --git a/core/src/main/java/org/springframework/security/access/method/MapBasedMethodSecurityMetadataSource.java b/core/src/main/java/org/springframework/security/access/method/MapBasedMethodSecurityMetadataSource.java index 7a67fd002d..df79e47b1e 100644 --- a/core/src/main/java/org/springframework/security/access/method/MapBasedMethodSecurityMetadataSource.java +++ b/core/src/main/java/org/springframework/security/access/method/MapBasedMethodSecurityMetadataSource.java @@ -287,7 +287,7 @@ public class MapBasedMethodSecurityMetadataSource extends private final Method method; private final Class registeredJavaType; - public RegisteredMethod(Method method, Class registeredJavaType) { + RegisteredMethod(Method method, Class registeredJavaType) { Assert.notNull(method, "Method required"); Assert.notNull(registeredJavaType, "Registered Java Type required"); this.method = method; diff --git a/core/src/main/java/org/springframework/security/authentication/jaas/AbstractJaasAuthenticationProvider.java b/core/src/main/java/org/springframework/security/authentication/jaas/AbstractJaasAuthenticationProvider.java index 1b92dceb28..54552a1e0f 100644 --- a/core/src/main/java/org/springframework/security/authentication/jaas/AbstractJaasAuthenticationProvider.java +++ b/core/src/main/java/org/springframework/security/authentication/jaas/AbstractJaasAuthenticationProvider.java @@ -402,7 +402,7 @@ public abstract class AbstractJaasAuthenticationProvider private class InternalCallbackHandler implements CallbackHandler { private final Authentication authentication; - public InternalCallbackHandler(Authentication authentication) { + InternalCallbackHandler(Authentication authentication) { this.authentication = authentication; } diff --git a/core/src/main/java/org/springframework/security/concurrent/DelegatingSecurityContextScheduledExecutorService.java b/core/src/main/java/org/springframework/security/concurrent/DelegatingSecurityContextScheduledExecutorService.java index 02afea9cb9..f58fc68989 100644 --- a/core/src/main/java/org/springframework/security/concurrent/DelegatingSecurityContextScheduledExecutorService.java +++ b/core/src/main/java/org/springframework/security/concurrent/DelegatingSecurityContextScheduledExecutorService.java @@ -61,24 +61,24 @@ public final class DelegatingSecurityContextScheduledExecutorService extends this(delegate, null); } - public final ScheduledFuture schedule(Runnable command, long delay, TimeUnit unit) { + public ScheduledFuture schedule(Runnable command, long delay, TimeUnit unit) { command = wrap(command); return getDelegate().schedule(command, delay, unit); } - public final ScheduledFuture schedule(Callable callable, long delay, + public ScheduledFuture schedule(Callable callable, long delay, TimeUnit unit) { callable = wrap(callable); return getDelegate().schedule(callable, delay, unit); } - public final ScheduledFuture scheduleAtFixedRate(Runnable command, + public ScheduledFuture scheduleAtFixedRate(Runnable command, long initialDelay, long period, TimeUnit unit) { command = wrap(command); return getDelegate().scheduleAtFixedRate(command, initialDelay, period, unit); } - public final ScheduledFuture scheduleWithFixedDelay(Runnable command, + public ScheduledFuture scheduleWithFixedDelay(Runnable command, long initialDelay, long delay, TimeUnit unit) { command = wrap(command); return getDelegate().scheduleWithFixedDelay(command, initialDelay, delay, unit); @@ -87,4 +87,4 @@ public final class DelegatingSecurityContextScheduledExecutorService extends private ScheduledExecutorService getDelegate() { return (ScheduledExecutorService) getDelegateExecutor(); } -} \ No newline at end of file +} diff --git a/core/src/main/java/org/springframework/security/core/ComparableVersion.java b/core/src/main/java/org/springframework/security/core/ComparableVersion.java index a55c511c17..e5b6f247c2 100644 --- a/core/src/main/java/org/springframework/security/core/ComparableVersion.java +++ b/core/src/main/java/org/springframework/security/core/ComparableVersion.java @@ -117,7 +117,7 @@ class ComparableVersion implements Comparable { this.value = BigInteger_ZERO; } - public IntegerItem(String str) { + IntegerItem(String str) { this.value = new BigInteger(str); } @@ -184,7 +184,7 @@ class ComparableVersion implements Comparable { private String value; - public StringItem(String value, boolean followedByDigit) { + StringItem(String value, boolean followedByDigit) { if (followedByDigit && value.length() == 1) { // a1 = alpha-1, b1 = beta-1, m1 = milestone-1 switch (value.charAt(0)) { @@ -341,7 +341,7 @@ class ComparableVersion implements Comparable { } } - public ComparableVersion(String version) { + ComparableVersion(String version) { parseVersion(version); } diff --git a/core/src/main/java/org/springframework/security/jackson2/AnonymousAuthenticationTokenMixin.java b/core/src/main/java/org/springframework/security/jackson2/AnonymousAuthenticationTokenMixin.java index e0620d2717..02ad8851f4 100644 --- a/core/src/main/java/org/springframework/security/jackson2/AnonymousAuthenticationTokenMixin.java +++ b/core/src/main/java/org/springframework/security/jackson2/AnonymousAuthenticationTokenMixin.java @@ -53,7 +53,7 @@ class AnonymousAuthenticationTokenMixin { * @param authorities the authorities granted to the principal */ @JsonCreator - public AnonymousAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal, + AnonymousAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal, @JsonProperty("authorities") Collection authorities) { } } diff --git a/core/src/main/java/org/springframework/security/jackson2/RememberMeAuthenticationTokenMixin.java b/core/src/main/java/org/springframework/security/jackson2/RememberMeAuthenticationTokenMixin.java index 98ff3558ce..3274a2c779 100644 --- a/core/src/main/java/org/springframework/security/jackson2/RememberMeAuthenticationTokenMixin.java +++ b/core/src/main/java/org/springframework/security/jackson2/RememberMeAuthenticationTokenMixin.java @@ -59,7 +59,7 @@ class RememberMeAuthenticationTokenMixin { * @param authorities the authorities granted to the principal */ @JsonCreator - public RememberMeAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, + RememberMeAuthenticationTokenMixin(@JsonProperty("keyHash") Integer keyHash, @JsonProperty("principal") Object principal, @JsonProperty("authorities") Collection authorities) { } diff --git a/core/src/main/java/org/springframework/security/jackson2/SecurityJackson2Modules.java b/core/src/main/java/org/springframework/security/jackson2/SecurityJackson2Modules.java index c847b11f4b..ef59d0a53e 100644 --- a/core/src/main/java/org/springframework/security/jackson2/SecurityJackson2Modules.java +++ b/core/src/main/java/org/springframework/security/jackson2/SecurityJackson2Modules.java @@ -152,7 +152,7 @@ public final class SecurityJackson2Modules { */ static class WhitelistTypeResolverBuilder extends ObjectMapper.DefaultTypeResolverBuilder { - public WhitelistTypeResolverBuilder(ObjectMapper.DefaultTyping defaultTyping) { + WhitelistTypeResolverBuilder(ObjectMapper.DefaultTyping defaultTyping) { super(defaultTyping); } diff --git a/core/src/main/java/org/springframework/security/provisioning/MutableUser.java b/core/src/main/java/org/springframework/security/provisioning/MutableUser.java index d8d823202c..04d62b42fc 100644 --- a/core/src/main/java/org/springframework/security/provisioning/MutableUser.java +++ b/core/src/main/java/org/springframework/security/provisioning/MutableUser.java @@ -33,7 +33,7 @@ class MutableUser implements MutableUserDetails { private String password; private final UserDetails delegate; - public MutableUser(UserDetails user) { + MutableUser(UserDetails user) { this.delegate = user; this.password = user.getPassword(); } diff --git a/core/src/test/java/org/springframework/security/access/SecurityConfigTests.java b/core/src/test/java/org/springframework/security/access/SecurityConfigTests.java index 736b3ffb24..0d44a8b576 100644 --- a/core/src/test/java/org/springframework/security/access/SecurityConfigTests.java +++ b/core/src/test/java/org/springframework/security/access/SecurityConfigTests.java @@ -92,7 +92,7 @@ public class SecurityConfigTests { private class MockConfigAttribute implements ConfigAttribute { private String attribute; - public MockConfigAttribute(String configuration) { + MockConfigAttribute(String configuration) { this.attribute = configuration; } diff --git a/core/src/test/java/org/springframework/security/access/annotation/BusinessService.java b/core/src/test/java/org/springframework/security/access/annotation/BusinessService.java index b26b20a7b9..2494083b2e 100644 --- a/core/src/test/java/org/springframework/security/access/annotation/BusinessService.java +++ b/core/src/test/java/org/springframework/security/access/annotation/BusinessService.java @@ -35,31 +35,31 @@ public interface BusinessService extends Serializable { @Secured({ "ROLE_ADMIN" }) @RolesAllowed({ "ROLE_ADMIN" }) @PreAuthorize("hasRole('ROLE_ADMIN')") - public void someAdminMethod(); + void someAdminMethod(); @Secured({ "ROLE_USER", "ROLE_ADMIN" }) @RolesAllowed({ "ROLE_USER", "ROLE_ADMIN" }) - public void someUserAndAdminMethod(); + void someUserAndAdminMethod(); @Secured({ "ROLE_USER" }) @RolesAllowed({ "ROLE_USER" }) - public void someUserMethod1(); + void someUserMethod1(); @Secured({ "ROLE_USER" }) @RolesAllowed({ "ROLE_USER" }) - public void someUserMethod2(); + void someUserMethod2(); @RolesAllowed({ "USER" }) - public void rolesAllowedUser(); + void rolesAllowedUser(); - public int someOther(String s); + int someOther(String s); - public int someOther(int input); + int someOther(int input); - public List methodReturningAList(List someList); + List methodReturningAList(List someList); - public Object[] methodReturningAnArray(Object[] someArray); + Object[] methodReturningAnArray(Object[] someArray); - public List methodReturningAList(String userName, String extraParam); + List methodReturningAList(String userName, String extraParam); } diff --git a/core/src/test/java/org/springframework/security/access/annotation/SecuredAnnotationSecurityMetadataSourceTests.java b/core/src/test/java/org/springframework/security/access/annotation/SecuredAnnotationSecurityMetadataSourceTests.java index a54c7f0f6e..d8cd444d34 100644 --- a/core/src/test/java/org/springframework/security/access/annotation/SecuredAnnotationSecurityMetadataSourceTests.java +++ b/core/src/test/java/org/springframework/security/access/annotation/SecuredAnnotationSecurityMetadataSourceTests.java @@ -218,7 +218,7 @@ public class SecuredAnnotationSecurityMetadataSourceTests { // Inner classes class Department extends Entity { - public Department(String name) { + Department(String name) { super(name); } } @@ -285,15 +285,15 @@ public class SecuredAnnotationSecurityMetadataSourceTests { public @interface AnnotatedAnnotation { } - public static interface ReturnVoid { + public interface ReturnVoid { - public void doSomething(List param); + void doSomething(List param); } @AnnotatedAnnotation - public static interface ReturnVoid2 { + public interface ReturnVoid2 { - public void doSomething(List param); + void doSomething(List param); } @AnnotatedAnnotation diff --git a/core/src/test/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContextTests.java b/core/src/test/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContextTests.java index dd4e5a382f..18d7e9f787 100644 --- a/core/src/test/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContextTests.java +++ b/core/src/test/java/org/springframework/security/access/expression/method/MethodSecurityEvaluationContextTests.java @@ -58,7 +58,7 @@ public class MethodSecurityEvaluationContextTests { private static class NotNullVariableMethodSecurityEvaluationContext extends MethodSecurityEvaluationContext { - public NotNullVariableMethodSecurityEvaluationContext(Authentication auth, MethodInvocation mi, + NotNullVariableMethodSecurityEvaluationContext(Authentication auth, MethodInvocation mi, ParameterNameDiscoverer parameterNameDiscoverer) { super(auth, mi, parameterNameDiscoverer); } diff --git a/core/src/test/java/org/springframework/security/access/expression/method/PrePostAnnotationSecurityMetadataSourceTests.java b/core/src/test/java/org/springframework/security/access/expression/method/PrePostAnnotationSecurityMetadataSourceTests.java index 38a1d33e32..27eed45a8d 100644 --- a/core/src/test/java/org/springframework/security/access/expression/method/PrePostAnnotationSecurityMetadataSourceTests.java +++ b/core/src/test/java/org/springframework/security/access/expression/method/PrePostAnnotationSecurityMetadataSourceTests.java @@ -203,19 +203,19 @@ public class PrePostAnnotationSecurityMetadataSourceTests { // ~ Inner Classes // ================================================================================================== - public static interface ReturnVoid { - public void doSomething(List param); + public interface ReturnVoid { + void doSomething(List param); } - public static interface ReturnAList { - public List doSomething(List param); + public interface ReturnAList { + List doSomething(List param); } @PreAuthorize("interfaceAuthzExpression") - public static interface ReturnAnotherList { + public interface ReturnAnotherList { @PreAuthorize("interfaceMethodAuthzExpression") @PreFilter(filterTarget = "param", value = "interfacePreFilterExpression") - public List doSomething(List param); + List doSomething(List param); } @PreAuthorize("someExpression") @@ -275,8 +275,8 @@ public class PrePostAnnotationSecurityMetadataSourceTests { } @CustomAnnotation - public static interface ReturnVoid2 { - public void doSomething(List param); + public interface ReturnVoid2 { + void doSomething(List param); } @CustomAnnotation diff --git a/core/src/test/java/org/springframework/security/access/intercept/AfterInvocationProviderManagerTests.java b/core/src/test/java/org/springframework/security/access/intercept/AfterInvocationProviderManagerTests.java index 9e045b97ad..90ce27038c 100644 --- a/core/src/test/java/org/springframework/security/access/intercept/AfterInvocationProviderManagerTests.java +++ b/core/src/test/java/org/springframework/security/access/intercept/AfterInvocationProviderManagerTests.java @@ -179,8 +179,7 @@ public class AfterInvocationProviderManagerTests { private Object forceReturnObject; - public MockAfterInvocationProvider(Object forceReturnObject, Class secureObject, - ConfigAttribute configAttribute) { + MockAfterInvocationProvider(Object forceReturnObject, Class secureObject, ConfigAttribute configAttribute) { this.forceReturnObject = forceReturnObject; this.secureObject = secureObject; this.configAttribute = configAttribute; diff --git a/core/src/test/java/org/springframework/security/authentication/AbstractAuthenticationTokenTests.java b/core/src/test/java/org/springframework/security/authentication/AbstractAuthenticationTokenTests.java index dc84fcb3d2..dc6b6db183 100644 --- a/core/src/test/java/org/springframework/security/authentication/AbstractAuthenticationTokenTests.java +++ b/core/src/test/java/org/springframework/security/authentication/AbstractAuthenticationTokenTests.java @@ -156,8 +156,7 @@ public class AbstractAuthenticationTokenTests { private Object credentials; private Object principal; - public MockAuthenticationImpl(Object principal, Object credentials, - List authorities) { + MockAuthenticationImpl(Object principal, Object credentials, List authorities) { super(authorities); this.principal = principal; this.credentials = credentials; diff --git a/core/src/test/java/org/springframework/security/authentication/DefaultAuthenticationEventPublisherTests.java b/core/src/test/java/org/springframework/security/authentication/DefaultAuthenticationEventPublisherTests.java index ce7d2cd29c..fc7866e15c 100644 --- a/core/src/test/java/org/springframework/security/authentication/DefaultAuthenticationEventPublisherTests.java +++ b/core/src/test/java/org/springframework/security/authentication/DefaultAuthenticationEventPublisherTests.java @@ -139,7 +139,7 @@ public class DefaultAuthenticationEventPublisherTests { private static final class MockAuthenticationException extends AuthenticationException { - public MockAuthenticationException(String msg) { + MockAuthenticationException(String msg) { super(msg); } } diff --git a/core/src/test/java/org/springframework/security/authentication/jaas/JaasAuthenticationProviderTests.java b/core/src/test/java/org/springframework/security/authentication/jaas/JaasAuthenticationProviderTests.java index eb44e0b057..ad1ff88ebc 100644 --- a/core/src/test/java/org/springframework/security/authentication/jaas/JaasAuthenticationProviderTests.java +++ b/core/src/test/java/org/springframework/security/authentication/jaas/JaasAuthenticationProviderTests.java @@ -290,7 +290,7 @@ public class JaasAuthenticationProviderTests { private static class MockLoginContext extends LoginContext { boolean loggedOut = false; - public MockLoginContext(String loginModule) throws LoginException { + MockLoginContext(String loginModule) throws LoginException { super(loginModule); } diff --git a/core/src/test/java/org/springframework/security/authentication/rcp/RemoteAuthenticationProviderTests.java b/core/src/test/java/org/springframework/security/authentication/rcp/RemoteAuthenticationProviderTests.java index 2d3efd1c41..c66f3b503f 100644 --- a/core/src/test/java/org/springframework/security/authentication/rcp/RemoteAuthenticationProviderTests.java +++ b/core/src/test/java/org/springframework/security/authentication/rcp/RemoteAuthenticationProviderTests.java @@ -119,7 +119,7 @@ public class RemoteAuthenticationProviderTests { private class MockRemoteAuthenticationManager implements RemoteAuthenticationManager { private boolean grantAccess; - public MockRemoteAuthenticationManager(boolean grantAccess) { + MockRemoteAuthenticationManager(boolean grantAccess) { this.grantAccess = grantAccess; } diff --git a/core/src/test/java/org/springframework/security/concurrent/DelegatingSecurityContextSupportTests.java b/core/src/test/java/org/springframework/security/concurrent/DelegatingSecurityContextSupportTests.java index a3260ab340..f18ecb1c9c 100644 --- a/core/src/test/java/org/springframework/security/concurrent/DelegatingSecurityContextSupportTests.java +++ b/core/src/test/java/org/springframework/security/concurrent/DelegatingSecurityContextSupportTests.java @@ -62,8 +62,8 @@ public class DelegatingSecurityContextSupportTests extends private static class ConcreteDelegatingSecurityContextSupport extends AbstractDelegatingSecurityContextSupport { - public ConcreteDelegatingSecurityContextSupport(SecurityContext securityContext) { + ConcreteDelegatingSecurityContextSupport(SecurityContext securityContext) { super(securityContext); } } -} \ No newline at end of file +} diff --git a/core/src/test/java/org/springframework/security/core/parameters/AnnotationParameterNameDiscovererTests.java b/core/src/test/java/org/springframework/security/core/parameters/AnnotationParameterNameDiscovererTests.java index 81d435eb11..5f5834b748 100644 --- a/core/src/test/java/org/springframework/security/core/parameters/AnnotationParameterNameDiscovererTests.java +++ b/core/src/test/java/org/springframework/security/core/parameters/AnnotationParameterNameDiscovererTests.java @@ -148,10 +148,10 @@ public class AnnotationParameterNameDiscovererTests { } static class Impl { - public Impl(Long dataSourceId) { + Impl(Long dataSourceId) { } - public Impl(@P("id") String dataSourceId) { + Impl(@P("id") String dataSourceId) { } String findMessageByTo(@P("to") String to) { diff --git a/crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCrypt.java b/crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCrypt.java index d38d4d6f12..59ea9bb059 100644 --- a/crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCrypt.java +++ b/crypto/src/main/java/org/springframework/security/crypto/bcrypt/BCrypt.java @@ -485,7 +485,7 @@ public class BCrypt { * @param lr an array containing the two 32-bit half blocks * @param off the position in the array of the blocks */ - private final void encipher(int lr[], int off) { + private void encipher(int lr[], int off) { int i, n, l = lr[off], r = lr[off + 1]; l ^= P[0]; diff --git a/crypto/src/main/java/org/springframework/security/crypto/encrypt/HexEncodingTextEncryptor.java b/crypto/src/main/java/org/springframework/security/crypto/encrypt/HexEncodingTextEncryptor.java index 150572500c..a4ed4c8699 100644 --- a/crypto/src/main/java/org/springframework/security/crypto/encrypt/HexEncodingTextEncryptor.java +++ b/crypto/src/main/java/org/springframework/security/crypto/encrypt/HexEncodingTextEncryptor.java @@ -28,7 +28,7 @@ final class HexEncodingTextEncryptor implements TextEncryptor { private final BytesEncryptor encryptor; - public HexEncodingTextEncryptor(BytesEncryptor encryptor) { + HexEncodingTextEncryptor(BytesEncryptor encryptor) { this.encryptor = encryptor; } diff --git a/crypto/src/main/java/org/springframework/security/crypto/keygen/HexEncodingStringKeyGenerator.java b/crypto/src/main/java/org/springframework/security/crypto/keygen/HexEncodingStringKeyGenerator.java index bbe47b6961..005a8e6e63 100644 --- a/crypto/src/main/java/org/springframework/security/crypto/keygen/HexEncodingStringKeyGenerator.java +++ b/crypto/src/main/java/org/springframework/security/crypto/keygen/HexEncodingStringKeyGenerator.java @@ -26,7 +26,7 @@ final class HexEncodingStringKeyGenerator implements StringKeyGenerator { private final BytesKeyGenerator keyGenerator; - public HexEncodingStringKeyGenerator(BytesKeyGenerator keyGenerator) { + HexEncodingStringKeyGenerator(BytesKeyGenerator keyGenerator) { this.keyGenerator = keyGenerator; } diff --git a/crypto/src/main/java/org/springframework/security/crypto/keygen/SecureRandomBytesKeyGenerator.java b/crypto/src/main/java/org/springframework/security/crypto/keygen/SecureRandomBytesKeyGenerator.java index 8194bfa17d..f04577802d 100644 --- a/crypto/src/main/java/org/springframework/security/crypto/keygen/SecureRandomBytesKeyGenerator.java +++ b/crypto/src/main/java/org/springframework/security/crypto/keygen/SecureRandomBytesKeyGenerator.java @@ -34,14 +34,14 @@ final class SecureRandomBytesKeyGenerator implements BytesKeyGenerator { /** * Creates a secure random key generator using the defaults. */ - public SecureRandomBytesKeyGenerator() { + SecureRandomBytesKeyGenerator() { this(DEFAULT_KEY_LENGTH); } /** * Creates a secure random key generator with a custom key length. */ - public SecureRandomBytesKeyGenerator(int keyLength) { + SecureRandomBytesKeyGenerator(int keyLength) { this.random = new SecureRandom(); this.keyLength = keyLength; } diff --git a/crypto/src/main/java/org/springframework/security/crypto/keygen/SharedKeyGenerator.java b/crypto/src/main/java/org/springframework/security/crypto/keygen/SharedKeyGenerator.java index 93329a33ea..5b9e7f5638 100644 --- a/crypto/src/main/java/org/springframework/security/crypto/keygen/SharedKeyGenerator.java +++ b/crypto/src/main/java/org/springframework/security/crypto/keygen/SharedKeyGenerator.java @@ -26,7 +26,7 @@ final class SharedKeyGenerator implements BytesKeyGenerator { private byte[] sharedKey; - public SharedKeyGenerator(byte[] sharedKey) { + SharedKeyGenerator(byte[] sharedKey) { this.sharedKey = sharedKey; } @@ -38,4 +38,4 @@ final class SharedKeyGenerator implements BytesKeyGenerator { return sharedKey; } -} \ No newline at end of file +} diff --git a/crypto/src/main/java/org/springframework/security/crypto/password/Digester.java b/crypto/src/main/java/org/springframework/security/crypto/password/Digester.java index df2add7e81..b0b57bc4b4 100644 --- a/crypto/src/main/java/org/springframework/security/crypto/password/Digester.java +++ b/crypto/src/main/java/org/springframework/security/crypto/password/Digester.java @@ -38,7 +38,7 @@ final class Digester { * @param algorithm the digest algorithm; for example, "SHA-1" or "SHA-256". * @param iterations the number of times to apply the digest algorithm to the input */ - public Digester(String algorithm, int iterations) { + Digester(String algorithm, int iterations) { // eagerly validate the algorithm createDigest(algorithm); this.algorithm = algorithm; @@ -53,7 +53,7 @@ final class Digester { return value; } - final void setIterations(int iterations) { + void setIterations(int iterations) { if (iterations <= 0) { throw new IllegalArgumentException("Iterations value must be greater than zero"); } diff --git a/crypto/src/test/java/org/springframework/security/crypto/encrypt/BouncyCastleAesBytesEncryptorEquivalencyTest.java b/crypto/src/test/java/org/springframework/security/crypto/encrypt/BouncyCastleAesBytesEncryptorEquivalencyTest.java index e32d30aa79..cb6e12a052 100644 --- a/crypto/src/test/java/org/springframework/security/crypto/encrypt/BouncyCastleAesBytesEncryptorEquivalencyTest.java +++ b/crypto/src/test/java/org/springframework/security/crypto/encrypt/BouncyCastleAesBytesEncryptorEquivalencyTest.java @@ -126,7 +126,7 @@ public class BouncyCastleAesBytesEncryptorEquivalencyTest { private final int keyLength; - public PredictableRandomBytesKeyGenerator(int keyLength) { + PredictableRandomBytesKeyGenerator(int keyLength) { this.random = new Random(1); this.keyLength = keyLength; } diff --git a/ldap/src/integration-test/java/org/springframework/security/ldap/DefaultSpringSecurityContextSourceTests.java b/ldap/src/integration-test/java/org/springframework/security/ldap/DefaultSpringSecurityContextSourceTests.java index c275565530..cab242ab9d 100644 --- a/ldap/src/integration-test/java/org/springframework/security/ldap/DefaultSpringSecurityContextSourceTests.java +++ b/ldap/src/integration-test/java/org/springframework/security/ldap/DefaultSpringSecurityContextSourceTests.java @@ -151,7 +151,7 @@ public class DefaultSpringSecurityContextSourceTests extends AbstractLdapIntegra static class EnvExposingDefaultSpringSecurityContextSource extends DefaultSpringSecurityContextSource { - public EnvExposingDefaultSpringSecurityContextSource(String providerUrl) { + EnvExposingDefaultSpringSecurityContextSource(String providerUrl) { super(providerUrl); } diff --git a/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java index 626a06ac19..73074f1f59 100644 --- a/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java +++ b/ldap/src/main/java/org/springframework/security/ldap/userdetails/LdapUserDetailsManager.java @@ -493,7 +493,7 @@ public class LdapUserDetailsManager implements UserDetailsManager { private final ByteArrayOutputStream value = new ByteArrayOutputStream(); - public PasswordModifyRequest(String userIdentity, String oldPassword, String newPassword) { + PasswordModifyRequest(String userIdentity, String oldPassword, String newPassword) { ByteArrayOutputStream elements = new ByteArrayOutputStream(); if (userIdentity != null) { diff --git a/ldap/src/test/java/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProviderTests.java b/ldap/src/test/java/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProviderTests.java index 774341e413..0241f08b15 100644 --- a/ldap/src/test/java/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProviderTests.java +++ b/ldap/src/test/java/org/springframework/security/ldap/authentication/ad/ActiveDirectoryLdapAuthenticationProviderTests.java @@ -468,7 +468,7 @@ public class ActiveDirectoryLdapAuthenticationProviderTests { static class MockNamingEnumeration implements NamingEnumeration { private SearchResult sr; - public MockNamingEnumeration(SearchResult sr) { + MockNamingEnumeration(SearchResult sr) { this.sr = sr; } diff --git a/messaging/src/main/java/org/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java b/messaging/src/main/java/org/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java index 5552583bf6..51a599c7f0 100644 --- a/messaging/src/main/java/org/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java +++ b/messaging/src/main/java/org/springframework/security/messaging/access/expression/MessageExpressionConfigAttribute.java @@ -44,7 +44,7 @@ class MessageExpressionConfigAttribute implements ConfigAttribute, EvaluationCon * @param authorizeExpression the {@link Expression} to use. Cannot be null * @param matcher the {@link MessageMatcher} used to match the messages. */ - public MessageExpressionConfigAttribute(Expression authorizeExpression, MessageMatcher matcher) { + MessageExpressionConfigAttribute(Expression authorizeExpression, MessageMatcher matcher) { Assert.notNull(authorizeExpression, "authorizeExpression cannot be null"); Assert.notNull(matcher, "matcher cannot be null"); this.authorizeExpression = authorizeExpression; diff --git a/messaging/src/main/java/org/springframework/security/messaging/util/matcher/AbstractMessageMatcherComposite.java b/messaging/src/main/java/org/springframework/security/messaging/util/matcher/AbstractMessageMatcherComposite.java index 5bc71db632..7f13a639ba 100644 --- a/messaging/src/main/java/org/springframework/security/messaging/util/matcher/AbstractMessageMatcherComposite.java +++ b/messaging/src/main/java/org/springframework/security/messaging/util/matcher/AbstractMessageMatcherComposite.java @@ -38,7 +38,7 @@ abstract class AbstractMessageMatcherComposite implements MessageMatcher { * * @param messageMatchers the {@link MessageMatcher} instances to try */ - public AbstractMessageMatcherComposite(List> messageMatchers) { + AbstractMessageMatcherComposite(List> messageMatchers) { notEmpty(messageMatchers, "messageMatchers must contain a value"); if (messageMatchers.contains(null)) { throw new IllegalArgumentException( @@ -54,7 +54,7 @@ abstract class AbstractMessageMatcherComposite implements MessageMatcher { * @param messageMatchers the {@link MessageMatcher} instances to try */ @SafeVarargs - public AbstractMessageMatcherComposite(MessageMatcher... messageMatchers) { + AbstractMessageMatcherComposite(MessageMatcher... messageMatchers) { this(asList(messageMatchers)); } diff --git a/messaging/src/test/java/org/springframework/security/messaging/context/AuthenticationPrincipalArgumentResolverTests.java b/messaging/src/test/java/org/springframework/security/messaging/context/AuthenticationPrincipalArgumentResolverTests.java index f1d89a6569..baf5707b05 100644 --- a/messaging/src/test/java/org/springframework/security/messaging/context/AuthenticationPrincipalArgumentResolverTests.java +++ b/messaging/src/test/java/org/springframework/security/messaging/context/AuthenticationPrincipalArgumentResolverTests.java @@ -265,7 +265,7 @@ public class AuthenticationPrincipalArgumentResolverTests { this.property = property; } - public CopyUserPrincipal(CopyUserPrincipal toCopy) { + CopyUserPrincipal(CopyUserPrincipal toCopy) { this.property = toCopy.property; } diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenDecoderFactory.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenDecoderFactory.java index c2f7b33039..0ca4312ebe 100644 --- a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenDecoderFactory.java +++ b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenDecoderFactory.java @@ -194,7 +194,7 @@ public final class OidcIdTokenDecoderFactory implements JwtDecoderFactory> jwtValidatorFactory) { + public void setJwtValidatorFactory(Function> jwtValidatorFactory) { Assert.notNull(jwtValidatorFactory, "jwtValidatorFactory cannot be null"); this.jwtValidatorFactory = jwtValidatorFactory; } @@ -207,7 +207,7 @@ public final class OidcIdTokenDecoderFactory implements JwtDecoderFactory jwsAlgorithmResolver) { + public void setJwsAlgorithmResolver(Function jwsAlgorithmResolver) { Assert.notNull(jwsAlgorithmResolver, "jwsAlgorithmResolver cannot be null"); this.jwsAlgorithmResolver = jwsAlgorithmResolver; } @@ -219,7 +219,7 @@ public final class OidcIdTokenDecoderFactory implements JwtDecoderFactory, Map>> claimTypeConverterFactory) { + public void setClaimTypeConverterFactory(Function, Map>> claimTypeConverterFactory) { Assert.notNull(claimTypeConverterFactory, "claimTypeConverterFactory cannot be null"); this.claimTypeConverterFactory = claimTypeConverterFactory; } diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenValidator.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenValidator.java index 8d086a0d92..4cd9e3f90d 100644 --- a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenValidator.java +++ b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/OidcIdTokenValidator.java @@ -130,7 +130,7 @@ public final class OidcIdTokenValidator implements OAuth2TokenValidator { * @since 5.2 * @param clockSkew the maximum acceptable clock skew */ - public final void setClockSkew(Duration clockSkew) { + public void setClockSkew(Duration clockSkew) { Assert.notNull(clockSkew, "clockSkew cannot be null"); Assert.isTrue(clockSkew.getSeconds() >= 0, "clockSkew must be >= 0"); this.clockSkew = clockSkew; diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java index 8912564260..adc6dea19c 100644 --- a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java +++ b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/oidc/authentication/ReactiveOidcIdTokenDecoderFactory.java @@ -194,7 +194,7 @@ public final class ReactiveOidcIdTokenDecoderFactory implements ReactiveJwtDecod * * @param jwtValidatorFactory the factory that provides an {@link OAuth2TokenValidator} */ - public final void setJwtValidatorFactory(Function> jwtValidatorFactory) { + public void setJwtValidatorFactory(Function> jwtValidatorFactory) { Assert.notNull(jwtValidatorFactory, "jwtValidatorFactory cannot be null"); this.jwtValidatorFactory = jwtValidatorFactory; } @@ -207,7 +207,7 @@ public final class ReactiveOidcIdTokenDecoderFactory implements ReactiveJwtDecod * @param jwsAlgorithmResolver the resolver that provides the expected {@link JwsAlgorithm JWS algorithm} * for a specific {@link ClientRegistration client} */ - public final void setJwsAlgorithmResolver(Function jwsAlgorithmResolver) { + public void setJwsAlgorithmResolver(Function jwsAlgorithmResolver) { Assert.notNull(jwsAlgorithmResolver, "jwsAlgorithmResolver cannot be null"); this.jwsAlgorithmResolver = jwsAlgorithmResolver; } @@ -219,7 +219,7 @@ public final class ReactiveOidcIdTokenDecoderFactory implements ReactiveJwtDecod * @param claimTypeConverterFactory the factory that provides a {@link Converter} used for type conversion * of claim values for a specific {@link ClientRegistration client} */ - public final void setClaimTypeConverterFactory(Function, Map>> claimTypeConverterFactory) { + public void setClaimTypeConverterFactory(Function, Map>> claimTypeConverterFactory) { Assert.notNull(claimTypeConverterFactory, "claimTypeConverterFactory cannot be null"); this.claimTypeConverterFactory = claimTypeConverterFactory; } diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/AuthenticatedPrincipalOAuth2AuthorizedClientRepository.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/AuthenticatedPrincipalOAuth2AuthorizedClientRepository.java index c2d4209c50..fef8ffac71 100644 --- a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/AuthenticatedPrincipalOAuth2AuthorizedClientRepository.java +++ b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/AuthenticatedPrincipalOAuth2AuthorizedClientRepository.java @@ -61,7 +61,7 @@ public final class AuthenticatedPrincipalOAuth2AuthorizedClientRepository implem * * @param anonymousAuthorizedClientRepository the repository used for requests that are unauthenticated (or anonymous) */ - public final void setAnonymousAuthorizedClientRepository(OAuth2AuthorizedClientRepository anonymousAuthorizedClientRepository) { + public void setAnonymousAuthorizedClientRepository(OAuth2AuthorizedClientRepository anonymousAuthorizedClientRepository) { Assert.notNull(anonymousAuthorizedClientRepository, "anonymousAuthorizedClientRepository cannot be null"); this.anonymousAuthorizedClientRepository = anonymousAuthorizedClientRepository; } diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java index de931ba521..b88f2ecad6 100644 --- a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java +++ b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/method/annotation/OAuth2AuthorizedClientArgumentResolver.java @@ -177,7 +177,7 @@ public final class OAuth2AuthorizedClientArgumentResolver implements HandlerMeth * @param clientCredentialsTokenResponseClient the client used when requesting an access token credential at the Token Endpoint for the {@code client_credentials} grant */ @Deprecated - public final void setClientCredentialsTokenResponseClient( + public void setClientCredentialsTokenResponseClient( OAuth2AccessTokenResponseClient clientCredentialsTokenResponseClient) { Assert.notNull(clientCredentialsTokenResponseClient, "clientCredentialsTokenResponseClient cannot be null"); Assert.state(this.defaultAuthorizedClientManager, "The client cannot be set when the constructor used is \"OAuth2AuthorizedClientArgumentResolver(OAuth2AuthorizedClientManager)\". " + diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/function/client/OAuth2AuthorizedClientResolver.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/function/client/OAuth2AuthorizedClientResolver.java index bf13f5ca0d..114e2e68c8 100644 --- a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/function/client/OAuth2AuthorizedClientResolver.java +++ b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/function/client/OAuth2AuthorizedClientResolver.java @@ -57,7 +57,7 @@ class OAuth2AuthorizedClientResolver { private String defaultClientRegistrationId; - public OAuth2AuthorizedClientResolver( + OAuth2AuthorizedClientResolver( ReactiveClientRegistrationRepository clientRegistrationRepository, ServerOAuth2AuthorizedClientRepository authorizedClientRepository) { Assert.notNull(clientRegistrationRepository, "clientRegistrationRepository cannot be null"); @@ -175,7 +175,7 @@ class OAuth2AuthorizedClientResolver { private final Authentication authentication; private final ServerWebExchange exchange; - public Request(String clientRegistrationId, Authentication authentication, + Request(String clientRegistrationId, Authentication authentication, ServerWebExchange exchange) { this.clientRegistrationId = clientRegistrationId; this.authentication = authentication; diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/result/method/annotation/OAuth2AuthorizedClientResolver.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/result/method/annotation/OAuth2AuthorizedClientResolver.java index f9ad2d12c9..8e402b4854 100644 --- a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/result/method/annotation/OAuth2AuthorizedClientResolver.java +++ b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/reactive/result/method/annotation/OAuth2AuthorizedClientResolver.java @@ -57,7 +57,7 @@ class OAuth2AuthorizedClientResolver { private String defaultClientRegistrationId; - public OAuth2AuthorizedClientResolver( + OAuth2AuthorizedClientResolver( ReactiveClientRegistrationRepository clientRegistrationRepository, ServerOAuth2AuthorizedClientRepository authorizedClientRepository) { Assert.notNull(clientRegistrationRepository, "clientRegistrationRepository cannot be null"); @@ -176,7 +176,7 @@ class OAuth2AuthorizedClientResolver { private final Authentication authentication; private final ServerWebExchange exchange; - public Request(String clientRegistrationId, Authentication authentication, + Request(String clientRegistrationId, Authentication authentication, ServerWebExchange exchange) { this.clientRegistrationId = clientRegistrationId; this.authentication = authentication; diff --git a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/server/AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository.java b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/server/AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository.java index fc43527f7e..6357dc38c9 100644 --- a/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/server/AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository.java +++ b/oauth2/oauth2-client/src/main/java/org/springframework/security/oauth2/client/web/server/AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository.java @@ -65,7 +65,7 @@ public final class AuthenticatedPrincipalServerOAuth2AuthorizedClientRepository * * @param anonymousAuthorizedClientRepository the repository used for requests that are unauthenticated (or anonymous) */ - public final void setAnonymousAuthorizedClientRepository( + public void setAnonymousAuthorizedClientRepository( ServerOAuth2AuthorizedClientRepository anonymousAuthorizedClientRepository) { Assert.notNull(anonymousAuthorizedClientRepository, "anonymousAuthorizedClientRepository cannot be null"); this.anonymousAuthorizedClientRepository = anonymousAuthorizedClientRepository; diff --git a/oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoderJwkSupport.java b/oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoderJwkSupport.java index 0f51c879eb..8d698d01ae 100644 --- a/oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoderJwkSupport.java +++ b/oauth2/oauth2-jose/src/main/java/org/springframework/security/oauth2/jwt/NimbusJwtDecoderJwkSupport.java @@ -108,7 +108,7 @@ public final class NimbusJwtDecoderJwkSupport implements JwtDecoder { * * @param claimSetConverter the {@link Converter} to use */ - public final void setClaimSetConverter(Converter, Map> claimSetConverter) { + public void setClaimSetConverter(Converter, Map> claimSetConverter) { Assert.notNull(claimSetConverter, "claimSetConverter cannot be null"); this.claimSetConverter = claimSetConverter; this.delegate.setClaimSetConverter(claimSetConverter); @@ -120,7 +120,7 @@ public final class NimbusJwtDecoderJwkSupport implements JwtDecoder { * @since 5.1 * @param restOperations the {@link RestOperations} used when requesting the JSON Web Key (JWK) Set */ - public final void setRestOperations(RestOperations restOperations) { + public void setRestOperations(RestOperations restOperations) { Assert.notNull(restOperations, "restOperations cannot be null"); this.jwtDecoderBuilder = this.jwtDecoderBuilder.restOperations(restOperations); this.delegate = makeDelegate(); diff --git a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationEntryPoint.java b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationEntryPoint.java index e80f0710f4..c083201a68 100644 --- a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationEntryPoint.java +++ b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationEntryPoint.java @@ -107,7 +107,7 @@ public final class BearerTokenAuthenticationEntryPoint implements Authentication * * @param realmName */ - public final void setRealmName(String realmName) { + public void setRealmName(String realmName) { this.realmName = realmName; } diff --git a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationFilter.java b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationFilter.java index f34d153c9b..c96ab90fd5 100644 --- a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationFilter.java +++ b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/BearerTokenAuthenticationFilter.java @@ -143,7 +143,7 @@ public final class BearerTokenAuthenticationFilter extends OncePerRequestFilter * Set the {@link BearerTokenResolver} to use. Defaults to {@link DefaultBearerTokenResolver}. * @param bearerTokenResolver the {@code BearerTokenResolver} to use */ - public final void setBearerTokenResolver(BearerTokenResolver bearerTokenResolver) { + public void setBearerTokenResolver(BearerTokenResolver bearerTokenResolver) { Assert.notNull(bearerTokenResolver, "bearerTokenResolver cannot be null"); this.bearerTokenResolver = bearerTokenResolver; } @@ -152,7 +152,7 @@ public final class BearerTokenAuthenticationFilter extends OncePerRequestFilter * Set the {@link AuthenticationEntryPoint} to use. Defaults to {@link BearerTokenAuthenticationEntryPoint}. * @param authenticationEntryPoint the {@code AuthenticationEntryPoint} to use */ - public final void setAuthenticationEntryPoint(final AuthenticationEntryPoint authenticationEntryPoint) { + public void setAuthenticationEntryPoint(final AuthenticationEntryPoint authenticationEntryPoint) { Assert.notNull(authenticationEntryPoint, "authenticationEntryPoint cannot be null"); this.authenticationEntryPoint = authenticationEntryPoint; } @@ -162,7 +162,7 @@ public final class BearerTokenAuthenticationFilter extends OncePerRequestFilter * @param authenticationFailureHandler the {@code AuthenticationFailureHandler} to use * @since 5.2 */ - public final void setAuthenticationFailureHandler(final AuthenticationFailureHandler authenticationFailureHandler) { + public void setAuthenticationFailureHandler(final AuthenticationFailureHandler authenticationFailureHandler) { Assert.notNull(authenticationFailureHandler, "authenticationFailureHandler cannot be null"); this.authenticationFailureHandler = authenticationFailureHandler; } diff --git a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandler.java b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandler.java index 2ac06bdb84..c2b489218f 100644 --- a/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandler.java +++ b/oauth2/oauth2-resource-server/src/main/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandler.java @@ -85,7 +85,7 @@ public final class BearerTokenAccessDeniedHandler implements AccessDeniedHandler * * @param realmName */ - public final void setRealmName(String realmName) { + public void setRealmName(String realmName) { this.realmName = realmName; } diff --git a/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandlerTests.java b/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandlerTests.java index 6e3f7ba5e9..3799e77c4d 100644 --- a/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandlerTests.java +++ b/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/BearerTokenAccessDeniedHandlerTests.java @@ -117,7 +117,7 @@ public class BearerTokenAccessDeniedHandlerTests { } static class TestingOAuth2Token extends AbstractOAuth2Token { - public TestingOAuth2Token(String tokenValue) { + TestingOAuth2Token(String tokenValue) { super(tokenValue); } } diff --git a/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/server/BearerTokenServerAccessDeniedHandlerTests.java b/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/server/BearerTokenServerAccessDeniedHandlerTests.java index 04721e7538..c4fb17ee65 100644 --- a/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/server/BearerTokenServerAccessDeniedHandlerTests.java +++ b/oauth2/oauth2-resource-server/src/test/java/org/springframework/security/oauth2/server/resource/web/access/server/BearerTokenServerAccessDeniedHandlerTests.java @@ -114,7 +114,7 @@ public class BearerTokenServerAccessDeniedHandlerTests { } static class TestingOAuth2Token extends AbstractOAuth2Token { - public TestingOAuth2Token(String tokenValue) { + TestingOAuth2Token(String tokenValue) { super(tokenValue); } } diff --git a/remoting/src/test/java/org/springframework/security/remoting/httpinvoker/AuthenticationSimpleHttpInvokerRequestExecutorTests.java b/remoting/src/test/java/org/springframework/security/remoting/httpinvoker/AuthenticationSimpleHttpInvokerRequestExecutorTests.java index 75ff09c916..cff51e1d3c 100644 --- a/remoting/src/test/java/org/springframework/security/remoting/httpinvoker/AuthenticationSimpleHttpInvokerRequestExecutorTests.java +++ b/remoting/src/test/java/org/springframework/security/remoting/httpinvoker/AuthenticationSimpleHttpInvokerRequestExecutorTests.java @@ -105,7 +105,7 @@ public class AuthenticationSimpleHttpInvokerRequestExecutorTests { private Map requestProperties = new HashMap<>(); - public MockHttpURLConnection(URL u) { + MockHttpURLConnection(URL u) { super(u); } diff --git a/samples/boot/oauth2authorizationserver/src/main/java/sample/AuthorizationServerConfiguration.java b/samples/boot/oauth2authorizationserver/src/main/java/sample/AuthorizationServerConfiguration.java index 80cbbe4e6d..62d4f61504 100644 --- a/samples/boot/oauth2authorizationserver/src/main/java/sample/AuthorizationServerConfiguration.java +++ b/samples/boot/oauth2authorizationserver/src/main/java/sample/AuthorizationServerConfiguration.java @@ -191,7 +191,7 @@ class UserConfig extends WebSecurityConfigurerAdapter { class IntrospectEndpoint { TokenStore tokenStore; - public IntrospectEndpoint(TokenStore tokenStore) { + IntrospectEndpoint(TokenStore tokenStore) { this.tokenStore = tokenStore; } @@ -226,7 +226,7 @@ class IntrospectEndpoint { class JwkSetEndpoint { KeyPair keyPair; - public JwkSetEndpoint(KeyPair keyPair) { + JwkSetEndpoint(KeyPair keyPair) { this.keyPair = keyPair; } diff --git a/samples/boot/oauth2resourceserver-jwe/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java b/samples/boot/oauth2resourceserver-jwe/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java index a004009c60..b10249a255 100644 --- a/samples/boot/oauth2resourceserver-jwe/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java +++ b/samples/boot/oauth2resourceserver-jwe/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java @@ -84,7 +84,7 @@ public class OAuth2ResourceServerApplicationITests { private static class BearerTokenRequestPostProcessor implements RequestPostProcessor { private String token; - public BearerTokenRequestPostProcessor(String token) { + BearerTokenRequestPostProcessor(String token) { this.token = token; } diff --git a/samples/boot/oauth2resourceserver-multitenancy/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java b/samples/boot/oauth2resourceserver-multitenancy/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java index e747f3c6df..2bca10f1ea 100644 --- a/samples/boot/oauth2resourceserver-multitenancy/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java +++ b/samples/boot/oauth2resourceserver-multitenancy/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java @@ -132,7 +132,7 @@ public class OAuth2ResourceServerApplicationITests { private static class BearerTokenRequestPostProcessor implements RequestPostProcessor { private String token; - public BearerTokenRequestPostProcessor(String token) { + BearerTokenRequestPostProcessor(String token) { this.token = token; } diff --git a/samples/boot/oauth2resourceserver-opaque/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java b/samples/boot/oauth2resourceserver-opaque/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java index 8e5dd5a5b8..cbeeb8ebda 100644 --- a/samples/boot/oauth2resourceserver-opaque/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java +++ b/samples/boot/oauth2resourceserver-opaque/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java @@ -84,7 +84,7 @@ public class OAuth2ResourceServerApplicationITests { private static class BearerTokenRequestPostProcessor implements RequestPostProcessor { private String token; - public BearerTokenRequestPostProcessor(String token) { + BearerTokenRequestPostProcessor(String token) { this.token = token; } diff --git a/samples/boot/oauth2resourceserver-static/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java b/samples/boot/oauth2resourceserver-static/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java index 238cc83b07..a5d644662a 100644 --- a/samples/boot/oauth2resourceserver-static/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java +++ b/samples/boot/oauth2resourceserver-static/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java @@ -84,7 +84,7 @@ public class OAuth2ResourceServerApplicationITests { private static class BearerTokenRequestPostProcessor implements RequestPostProcessor { private String token; - public BearerTokenRequestPostProcessor(String token) { + BearerTokenRequestPostProcessor(String token) { this.token = token; } diff --git a/samples/boot/oauth2resourceserver/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java b/samples/boot/oauth2resourceserver/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java index e2629f55a4..6479417499 100644 --- a/samples/boot/oauth2resourceserver/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java +++ b/samples/boot/oauth2resourceserver/src/integration-test/java/sample/OAuth2ResourceServerApplicationITests.java @@ -107,7 +107,7 @@ public class OAuth2ResourceServerApplicationITests { private static class BearerTokenRequestPostProcessor implements RequestPostProcessor { private String token; - public BearerTokenRequestPostProcessor(String token) { + BearerTokenRequestPostProcessor(String token) { this.token = token; } diff --git a/samples/xml/jaas/src/main/java/samples/jaas/UsernameEqualsPasswordLoginModule.java b/samples/xml/jaas/src/main/java/samples/jaas/UsernameEqualsPasswordLoginModule.java index 28e3207caf..d4d039414d 100644 --- a/samples/xml/jaas/src/main/java/samples/jaas/UsernameEqualsPasswordLoginModule.java +++ b/samples/xml/jaas/src/main/java/samples/jaas/UsernameEqualsPasswordLoginModule.java @@ -94,7 +94,7 @@ public class UsernameEqualsPasswordLoginModule implements LoginModule { private static class UsernamePrincipal implements Principal, Serializable { private final String username; - public UsernamePrincipal(String username) { + UsernamePrincipal(String username) { this.username = username; } diff --git a/test/src/main/java/org/springframework/security/test/context/support/DelegatingTestExecutionListener.java b/test/src/main/java/org/springframework/security/test/context/support/DelegatingTestExecutionListener.java index 76cc1e5b86..3b34dda6bf 100644 --- a/test/src/main/java/org/springframework/security/test/context/support/DelegatingTestExecutionListener.java +++ b/test/src/main/java/org/springframework/security/test/context/support/DelegatingTestExecutionListener.java @@ -30,7 +30,7 @@ class DelegatingTestExecutionListener private final TestExecutionListener delegate; - public DelegatingTestExecutionListener(TestExecutionListener delegate) { + DelegatingTestExecutionListener(TestExecutionListener delegate) { Assert.notNull(delegate, "delegate cannot be null"); this.delegate = delegate; } diff --git a/test/src/main/java/org/springframework/security/test/context/support/WithUserDetailsSecurityContextFactory.java b/test/src/main/java/org/springframework/security/test/context/support/WithUserDetailsSecurityContextFactory.java index f837e8a97c..caa8dc6351 100644 --- a/test/src/main/java/org/springframework/security/test/context/support/WithUserDetailsSecurityContextFactory.java +++ b/test/src/main/java/org/springframework/security/test/context/support/WithUserDetailsSecurityContextFactory.java @@ -49,7 +49,7 @@ final class WithUserDetailsSecurityContextFactory implements private BeanFactory beans; @Autowired - public WithUserDetailsSecurityContextFactory(BeanFactory beans) { + WithUserDetailsSecurityContextFactory(BeanFactory beans) { this.beans = beans; } diff --git a/test/src/main/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessors.java b/test/src/main/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessors.java index f869e26284..2d3bf57a10 100644 --- a/test/src/main/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessors.java +++ b/test/src/main/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessors.java @@ -826,7 +826,7 @@ public final class SecurityMockMvcRequestPostProcessors { implements RequestPostProcessor { private final RequestPostProcessor delegate; - public UserDetailsRequestPostProcessor(UserDetails user) { + UserDetailsRequestPostProcessor(UserDetails user) { Authentication token = new UsernamePasswordAuthenticationToken(user, user.getPassword(), user.getAuthorities()); diff --git a/test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsCsrfTests.java b/test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsCsrfTests.java index 7f4e8aed59..6f85c3b11b 100644 --- a/test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsCsrfTests.java +++ b/test/src/test/java/org/springframework/security/test/web/servlet/request/SecurityMockMvcRequestPostProcessorsCsrfTests.java @@ -205,7 +205,7 @@ public class SecurityMockMvcRequestPostProcessorsCsrfTests { static class SessionRequestWrapper extends HttpServletRequestWrapper { HttpSession session = new MockHttpSession(); - public SessionRequestWrapper(HttpServletRequest request) { + SessionRequestWrapper(HttpServletRequest request) { super(request); } diff --git a/web/src/main/java/org/springframework/security/web/FilterInvocation.java b/web/src/main/java/org/springframework/security/web/FilterInvocation.java index 46c9e0486f..7a52973f4d 100644 --- a/web/src/main/java/org/springframework/security/web/FilterInvocation.java +++ b/web/src/main/java/org/springframework/security/web/FilterInvocation.java @@ -158,7 +158,7 @@ class DummyRequest extends HttpServletRequestWrapper { private String queryString; private String method; - public DummyRequest() { + DummyRequest() { super(UNSUPPORTED_REQUEST); } diff --git a/web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java b/web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java index 2afd19390c..f855a21a01 100644 --- a/web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java +++ b/web/src/main/java/org/springframework/security/web/access/expression/DelegatingEvaluationContext.java @@ -38,7 +38,7 @@ import org.springframework.expression.TypedValue; class DelegatingEvaluationContext implements EvaluationContext { private final EvaluationContext delegate; - public DelegatingEvaluationContext(EvaluationContext delegate) { + DelegatingEvaluationContext(EvaluationContext delegate) { this.delegate = delegate; } diff --git a/web/src/main/java/org/springframework/security/web/access/expression/ExpressionBasedFilterInvocationSecurityMetadataSource.java b/web/src/main/java/org/springframework/security/web/access/expression/ExpressionBasedFilterInvocationSecurityMetadataSource.java index 02b2183d12..a7ec8291e7 100644 --- a/web/src/main/java/org/springframework/security/web/access/expression/ExpressionBasedFilterInvocationSecurityMetadataSource.java +++ b/web/src/main/java/org/springframework/security/web/access/expression/ExpressionBasedFilterInvocationSecurityMetadataSource.java @@ -99,7 +99,7 @@ public final class ExpressionBasedFilterInvocationSecurityMetadataSource extends AbstractVariableEvaluationContextPostProcessor { private final AntPathRequestMatcher matcher; - public AntPathMatcherEvaluationContextPostProcessor( + AntPathMatcherEvaluationContextPostProcessor( AntPathRequestMatcher matcher) { this.matcher = matcher; } @@ -114,7 +114,7 @@ public final class ExpressionBasedFilterInvocationSecurityMetadataSource extends AbstractVariableEvaluationContextPostProcessor { private final RequestMatcher matcher; - public RequestVariablesExtractorEvaluationContextPostProcessor( + RequestVariablesExtractorEvaluationContextPostProcessor( RequestMatcher matcher) { this.matcher = matcher; } diff --git a/web/src/main/java/org/springframework/security/web/access/expression/WebExpressionConfigAttribute.java b/web/src/main/java/org/springframework/security/web/access/expression/WebExpressionConfigAttribute.java index 636b3b8690..7e3856f70f 100644 --- a/web/src/main/java/org/springframework/security/web/access/expression/WebExpressionConfigAttribute.java +++ b/web/src/main/java/org/springframework/security/web/access/expression/WebExpressionConfigAttribute.java @@ -31,7 +31,7 @@ class WebExpressionConfigAttribute implements ConfigAttribute, private final Expression authorizeExpression; private final EvaluationContextPostProcessor postProcessor; - public WebExpressionConfigAttribute(Expression authorizeExpression, + WebExpressionConfigAttribute(Expression authorizeExpression, EvaluationContextPostProcessor postProcessor) { this.authorizeExpression = authorizeExpression; this.postProcessor = postProcessor; diff --git a/web/src/main/java/org/springframework/security/web/authentication/preauth/websphere/DefaultWASUsernameAndGroupsExtractor.java b/web/src/main/java/org/springframework/security/web/authentication/preauth/websphere/DefaultWASUsernameAndGroupsExtractor.java index b254440831..6d38ceee91 100755 --- a/web/src/main/java/org/springframework/security/web/authentication/preauth/websphere/DefaultWASUsernameAndGroupsExtractor.java +++ b/web/src/main/java/org/springframework/security/web/authentication/preauth/websphere/DefaultWASUsernameAndGroupsExtractor.java @@ -58,11 +58,11 @@ final class DefaultWASUsernameAndGroupsExtractor implements WASUsernameAndGroups // SEC-803 private static Class wsCredentialClass = null; - public final List getGroupsForCurrentUser() { + public List getGroupsForCurrentUser() { return getWebSphereGroups(getRunAsSubject()); } - public final String getCurrentUserName() { + public String getCurrentUserName() { return getSecurityName(getRunAsSubject()); } diff --git a/web/src/main/java/org/springframework/security/web/context/AbstractSecurityWebApplicationInitializer.java b/web/src/main/java/org/springframework/security/web/context/AbstractSecurityWebApplicationInitializer.java index b08ad8c1af..f7bf77b885 100644 --- a/web/src/main/java/org/springframework/security/web/context/AbstractSecurityWebApplicationInitializer.java +++ b/web/src/main/java/org/springframework/security/web/context/AbstractSecurityWebApplicationInitializer.java @@ -210,8 +210,8 @@ public abstract class AbstractSecurityWebApplicationInitializer * @param filterName * @param filter */ - private final void registerFilter(ServletContext servletContext, - boolean insertBeforeOtherFilters, String filterName, Filter filter) { + private void registerFilter(ServletContext servletContext, + boolean insertBeforeOtherFilters, String filterName, Filter filter) { Dynamic registration = servletContext.addFilter(filterName, filter); if (registration == null) { throw new IllegalStateException( diff --git a/web/src/main/java/org/springframework/security/web/context/HttpSessionSecurityContextRepository.java b/web/src/main/java/org/springframework/security/web/context/HttpSessionSecurityContextRepository.java index 35282074d1..85f90e3f59 100644 --- a/web/src/main/java/org/springframework/security/web/context/HttpSessionSecurityContextRepository.java +++ b/web/src/main/java/org/springframework/security/web/context/HttpSessionSecurityContextRepository.java @@ -269,7 +269,7 @@ public class HttpSessionSecurityContextRepository implements SecurityContextRepo HttpServletRequestWrapper { private final SaveContextOnUpdateOrErrorResponseWrapper response; - public SaveToSessionRequestWrapper(HttpServletRequest request, + SaveToSessionRequestWrapper(HttpServletRequest request, SaveContextOnUpdateOrErrorResponseWrapper response) { super(request); this.response = response; diff --git a/web/src/main/java/org/springframework/security/web/debug/DebugFilter.java b/web/src/main/java/org/springframework/security/web/debug/DebugFilter.java index b841186504..e0a53d3090 100644 --- a/web/src/main/java/org/springframework/security/web/debug/DebugFilter.java +++ b/web/src/main/java/org/springframework/security/web/debug/DebugFilter.java @@ -55,7 +55,7 @@ public final class DebugFilter implements Filter { this.fcp = fcp; } - public final void doFilter(ServletRequest srvltRequest, + public void doFilter(ServletRequest srvltRequest, ServletResponse srvltResponse, FilterChain filterChain) throws ServletException, IOException { @@ -153,7 +153,7 @@ public final class DebugFilter implements Filter { class DebugRequestWrapper extends HttpServletRequestWrapper { private static final Logger logger = new Logger(); - public DebugRequestWrapper(HttpServletRequest request) { + DebugRequestWrapper(HttpServletRequest request) { super(request); } diff --git a/web/src/main/java/org/springframework/security/web/firewall/FirewalledResponse.java b/web/src/main/java/org/springframework/security/web/firewall/FirewalledResponse.java index 6d7c386563..afe0a58b0b 100644 --- a/web/src/main/java/org/springframework/security/web/firewall/FirewalledResponse.java +++ b/web/src/main/java/org/springframework/security/web/firewall/FirewalledResponse.java @@ -31,7 +31,7 @@ class FirewalledResponse extends HttpServletResponseWrapper { private static final String LOCATION_HEADER = "Location"; private static final String SET_COOKIE_HEADER = "Set-Cookie"; - public FirewalledResponse(HttpServletResponse response) { + FirewalledResponse(HttpServletResponse response) { super(response); } diff --git a/web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java b/web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java index a5a1d76b35..5e3b2e08f9 100644 --- a/web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java +++ b/web/src/main/java/org/springframework/security/web/firewall/RequestWrapper.java @@ -48,7 +48,7 @@ final class RequestWrapper extends FirewalledRequest { private final String strippedPathInfo; private boolean stripPaths = true; - public RequestWrapper(HttpServletRequest request) { + RequestWrapper(HttpServletRequest request) { super(request); strippedServletPath = strip(request.getServletPath()); String pathInfo = strip(request.getPathInfo()); @@ -144,7 +144,7 @@ final class RequestWrapper extends FirewalledRequest { * @param path the {@code path} that will be used to obtain the delegate * {@link RequestDispatcher} from the original {@link HttpServletRequest}. */ - public FirewalledRequestAwareRequestDispatcher(String path) { + FirewalledRequestAwareRequestDispatcher(String path) { this.path = path; } diff --git a/web/src/main/java/org/springframework/security/web/jackson2/DefaultCsrfTokenMixin.java b/web/src/main/java/org/springframework/security/web/jackson2/DefaultCsrfTokenMixin.java index d9071f02d6..d8cbdc5077 100644 --- a/web/src/main/java/org/springframework/security/web/jackson2/DefaultCsrfTokenMixin.java +++ b/web/src/main/java/org/springframework/security/web/jackson2/DefaultCsrfTokenMixin.java @@ -48,7 +48,7 @@ class DefaultCsrfTokenMixin { * @param token the CSRF token value */ @JsonCreator - public DefaultCsrfTokenMixin(@JsonProperty("headerName") String headerName, + DefaultCsrfTokenMixin(@JsonProperty("headerName") String headerName, @JsonProperty("parameterName") String parameterName, @JsonProperty("token") String token) { } } diff --git a/web/src/main/java/org/springframework/security/web/jackson2/SavedCookieMixin.java b/web/src/main/java/org/springframework/security/web/jackson2/SavedCookieMixin.java index de580018c4..3083e0278f 100644 --- a/web/src/main/java/org/springframework/security/web/jackson2/SavedCookieMixin.java +++ b/web/src/main/java/org/springframework/security/web/jackson2/SavedCookieMixin.java @@ -39,7 +39,7 @@ import com.fasterxml.jackson.annotation.*; abstract class SavedCookieMixin { @JsonCreator - public SavedCookieMixin(@JsonProperty("name") String name, @JsonProperty("value") String value, + SavedCookieMixin(@JsonProperty("name") String name, @JsonProperty("value") String value, @JsonProperty("comment") String comment, @JsonProperty("domain") String domain, @JsonProperty("maxAge") int maxAge, @JsonProperty("path") String path, @JsonProperty("secure") boolean secure, @JsonProperty("version") int version) { diff --git a/web/src/main/java/org/springframework/security/web/savedrequest/SavedRequestAwareWrapper.java b/web/src/main/java/org/springframework/security/web/savedrequest/SavedRequestAwareWrapper.java index ea6d429642..66b6004c82 100644 --- a/web/src/main/java/org/springframework/security/web/savedrequest/SavedRequestAwareWrapper.java +++ b/web/src/main/java/org/springframework/security/web/savedrequest/SavedRequestAwareWrapper.java @@ -77,7 +77,7 @@ class SavedRequestAwareWrapper extends HttpServletRequestWrapper { // ~ Constructors // =================================================================================================== - public SavedRequestAwareWrapper(SavedRequest saved, HttpServletRequest request) { + SavedRequestAwareWrapper(SavedRequest saved, HttpServletRequest request) { super(request); savedRequest = saved; diff --git a/web/src/main/java/org/springframework/security/web/server/jackson2/DefaultCsrfServerTokenMixin.java b/web/src/main/java/org/springframework/security/web/server/jackson2/DefaultCsrfServerTokenMixin.java index 2ccce59417..e0e82c1252 100644 --- a/web/src/main/java/org/springframework/security/web/server/jackson2/DefaultCsrfServerTokenMixin.java +++ b/web/src/main/java/org/springframework/security/web/server/jackson2/DefaultCsrfServerTokenMixin.java @@ -47,7 +47,7 @@ class DefaultCsrfServerTokenMixin { * @param token the CSRF token value */ @JsonCreator - public DefaultCsrfServerTokenMixin(@JsonProperty("headerName") String headerName, + DefaultCsrfServerTokenMixin(@JsonProperty("headerName") String headerName, @JsonProperty("parameterName") String parameterName, @JsonProperty("token") String token) { } } diff --git a/web/src/main/java/org/springframework/security/web/servletapi/HttpServlet3RequestFactory.java b/web/src/main/java/org/springframework/security/web/servletapi/HttpServlet3RequestFactory.java index e6aad71aa1..1812e637f4 100644 --- a/web/src/main/java/org/springframework/security/web/servletapi/HttpServlet3RequestFactory.java +++ b/web/src/main/java/org/springframework/security/web/servletapi/HttpServlet3RequestFactory.java @@ -170,7 +170,7 @@ final class HttpServlet3RequestFactory implements HttpServletRequestFactory { extends SecurityContextHolderAwareRequestWrapper { private final HttpServletResponse response; - public Servlet3SecurityContextHolderAwareRequestWrapper( + Servlet3SecurityContextHolderAwareRequestWrapper( HttpServletRequest request, String rolePrefix, HttpServletResponse response) { super(request, HttpServlet3RequestFactory.this.trustResolver, rolePrefix); @@ -265,7 +265,7 @@ final class HttpServlet3RequestFactory implements HttpServletRequestFactory { private static class SecurityContextAsyncContext implements AsyncContext { private final AsyncContext asyncContext; - public SecurityContextAsyncContext(AsyncContext asyncContext) { + SecurityContextAsyncContext(AsyncContext asyncContext) { this.asyncContext = asyncContext; } diff --git a/web/src/main/java/org/springframework/security/web/util/OnCommittedResponseWrapper.java b/web/src/main/java/org/springframework/security/web/util/OnCommittedResponseWrapper.java index 2002f78657..e177fb5472 100644 --- a/web/src/main/java/org/springframework/security/web/util/OnCommittedResponseWrapper.java +++ b/web/src/main/java/org/springframework/security/web/util/OnCommittedResponseWrapper.java @@ -258,7 +258,7 @@ public abstract class OnCommittedResponseWrapper extends HttpServletResponseWrap private class SaveContextPrintWriter extends PrintWriter { private final PrintWriter delegate; - public SaveContextPrintWriter(PrintWriter delegate) { + SaveContextPrintWriter(PrintWriter delegate) { super(delegate); this.delegate = delegate; } @@ -498,7 +498,7 @@ public abstract class OnCommittedResponseWrapper extends HttpServletResponseWrap private class SaveContextServletOutputStream extends ServletOutputStream { private final ServletOutputStream delegate; - public SaveContextServletOutputStream(ServletOutputStream delegate) { + SaveContextServletOutputStream(ServletOutputStream delegate) { this.delegate = delegate; } @@ -652,4 +652,4 @@ public abstract class OnCommittedResponseWrapper extends HttpServletResponseWrap return getClass().getName() + "[delegate=" + this.delegate.toString() + "]"; } } -} \ No newline at end of file +} diff --git a/web/src/main/java/org/springframework/security/web/util/matcher/ELRequestMatcherContext.java b/web/src/main/java/org/springframework/security/web/util/matcher/ELRequestMatcherContext.java index 9440a0b759..a4e216c6c5 100644 --- a/web/src/main/java/org/springframework/security/web/util/matcher/ELRequestMatcherContext.java +++ b/web/src/main/java/org/springframework/security/web/util/matcher/ELRequestMatcherContext.java @@ -23,7 +23,7 @@ class ELRequestMatcherContext { private final HttpServletRequest request; - public ELRequestMatcherContext(HttpServletRequest request) { + ELRequestMatcherContext(HttpServletRequest request) { this.request = request; } diff --git a/web/src/test/java/org/springframework/security/web/access/channel/ChannelDecisionManagerImplTests.java b/web/src/test/java/org/springframework/security/web/access/channel/ChannelDecisionManagerImplTests.java index e95d1d2171..13726a03bf 100644 --- a/web/src/test/java/org/springframework/security/web/access/channel/ChannelDecisionManagerImplTests.java +++ b/web/src/test/java/org/springframework/security/web/access/channel/ChannelDecisionManagerImplTests.java @@ -204,7 +204,7 @@ public class ChannelDecisionManagerImplTests { private String configAttribute; private boolean failIfCalled; - public MockChannelProcessor(String configAttribute, boolean failIfCalled) { + MockChannelProcessor(String configAttribute, boolean failIfCalled) { this.configAttribute = configAttribute; this.failIfCalled = failIfCalled; } diff --git a/web/src/test/java/org/springframework/security/web/access/channel/ChannelProcessingFilterTests.java b/web/src/test/java/org/springframework/security/web/access/channel/ChannelProcessingFilterTests.java index 52b2eac342..06647a7de3 100644 --- a/web/src/test/java/org/springframework/security/web/access/channel/ChannelProcessingFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/access/channel/ChannelProcessingFilterTests.java @@ -169,7 +169,7 @@ public class ChannelProcessingFilterTests { private String supportAttribute; private boolean commitAResponse; - public MockChannelDecisionManager(boolean commitAResponse, String supportAttribute) { + MockChannelDecisionManager(boolean commitAResponse, String supportAttribute) { this.commitAResponse = commitAResponse; this.supportAttribute = supportAttribute; } @@ -197,7 +197,7 @@ public class ChannelProcessingFilterTests { private String servletPath; private boolean provideIterator; - public MockFilterInvocationDefinitionMap(String servletPath, + MockFilterInvocationDefinitionMap(String servletPath, boolean provideIterator, String... toReturn) { this.servletPath = servletPath; this.toReturn = SecurityConfig.createList(toReturn); diff --git a/web/src/test/java/org/springframework/security/web/access/expression/WebExpressionVoterTests.java b/web/src/test/java/org/springframework/security/web/access/expression/WebExpressionVoterTests.java index 9145712ba5..01488e192b 100644 --- a/web/src/test/java/org/springframework/security/web/access/expression/WebExpressionVoterTests.java +++ b/web/src/test/java/org/springframework/security/web/access/expression/WebExpressionVoterTests.java @@ -101,7 +101,7 @@ public class WebExpressionVoterTests { private static class FilterInvocationChild extends FilterInvocation { - public FilterInvocationChild(ServletRequest request, ServletResponse response, + FilterInvocationChild(ServletRequest request, ServletResponse response, FilterChain chain) { super(request, response, chain); } diff --git a/web/src/test/java/org/springframework/security/web/authentication/AbstractAuthenticationProcessingFilterTests.java b/web/src/test/java/org/springframework/security/web/authentication/AbstractAuthenticationProcessingFilterTests.java index 9411f65988..24e2836247 100644 --- a/web/src/test/java/org/springframework/security/web/authentication/AbstractAuthenticationProcessingFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/authentication/AbstractAuthenticationProcessingFilterTests.java @@ -437,7 +437,7 @@ public class AbstractAuthenticationProcessingFilterTests { private boolean grantAccess; - public MockAuthenticationFilter(boolean grantAccess) { + MockAuthenticationFilter(boolean grantAccess) { this(); setRememberMeServices(new NullRememberMeServices()); this.grantAccess = grantAccess; @@ -465,7 +465,7 @@ public class AbstractAuthenticationProcessingFilterTests { private boolean expectToProceed; - public MockFilterChain(boolean expectToProceed) { + MockFilterChain(boolean expectToProceed) { this.expectToProceed = expectToProceed; } diff --git a/web/src/test/java/org/springframework/security/web/authentication/AnonymousAuthenticationFilterTests.java b/web/src/test/java/org/springframework/security/web/authentication/AnonymousAuthenticationFilterTests.java index 96e1558746..a7205014e0 100644 --- a/web/src/test/java/org/springframework/security/web/authentication/AnonymousAuthenticationFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/authentication/AnonymousAuthenticationFilterTests.java @@ -120,7 +120,7 @@ public class AnonymousAuthenticationFilterTests { private class MockFilterChain implements FilterChain { private boolean expectToProceed; - public MockFilterChain(boolean expectToProceed) { + MockFilterChain(boolean expectToProceed) { this.expectToProceed = expectToProceed; } diff --git a/web/src/test/java/org/springframework/security/web/authentication/preauth/j2ee/J2eePreAuthenticatedProcessingFilterTests.java b/web/src/test/java/org/springframework/security/web/authentication/preauth/j2ee/J2eePreAuthenticatedProcessingFilterTests.java index 607d151d03..8e0c70923f 100644 --- a/web/src/test/java/org/springframework/security/web/authentication/preauth/j2ee/J2eePreAuthenticatedProcessingFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/authentication/preauth/j2ee/J2eePreAuthenticatedProcessingFilterTests.java @@ -48,7 +48,7 @@ public class J2eePreAuthenticatedProcessingFilterTests { getRequest("testUser", new String[] {}))); } - private final HttpServletRequest getRequest(final String aUserName, + private HttpServletRequest getRequest(final String aUserName, final String[] aRoles) { MockHttpServletRequest req = new MockHttpServletRequest() { diff --git a/web/src/test/java/org/springframework/security/web/authentication/rememberme/RememberMeAuthenticationFilterTests.java b/web/src/test/java/org/springframework/security/web/authentication/rememberme/RememberMeAuthenticationFilterTests.java index 6c058a9fce..72282685ab 100644 --- a/web/src/test/java/org/springframework/security/web/authentication/rememberme/RememberMeAuthenticationFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/authentication/rememberme/RememberMeAuthenticationFilterTests.java @@ -168,7 +168,7 @@ public class RememberMeAuthenticationFilterTests { private class MockRememberMeServices implements RememberMeServices { private Authentication authToReturn; - public MockRememberMeServices(Authentication authToReturn) { + MockRememberMeServices(Authentication authToReturn) { this.authToReturn = authToReturn; } diff --git a/web/src/test/java/org/springframework/security/web/context/HttpSessionSecurityContextRepositoryTests.java b/web/src/test/java/org/springframework/security/web/context/HttpSessionSecurityContextRepositoryTests.java index 433a5e046f..8d7893c09c 100644 --- a/web/src/test/java/org/springframework/security/web/context/HttpSessionSecurityContextRepositoryTests.java +++ b/web/src/test/java/org/springframework/security/web/context/HttpSessionSecurityContextRepositoryTests.java @@ -676,7 +676,7 @@ public class HttpSessionSecurityContextRepositoryTests { @Transient private static class SomeTransientAuthentication extends AbstractAuthenticationToken { - public SomeTransientAuthentication() { + SomeTransientAuthentication() { super(null); } @@ -703,7 +703,7 @@ public class HttpSessionSecurityContextRepositoryTests { @TestTransientAuthentication private static class SomeOtherTransientAuthentication extends AbstractAuthenticationToken { - public SomeOtherTransientAuthentication() { + SomeOtherTransientAuthentication() { super(null); } diff --git a/web/src/test/java/org/springframework/security/web/context/SaveContextOnUpdateOrErrorResponseWrapperTests.java b/web/src/test/java/org/springframework/security/web/context/SaveContextOnUpdateOrErrorResponseWrapperTests.java index d6a12766a0..7a48500abf 100644 --- a/web/src/test/java/org/springframework/security/web/context/SaveContextOnUpdateOrErrorResponseWrapperTests.java +++ b/web/src/test/java/org/springframework/security/web/context/SaveContextOnUpdateOrErrorResponseWrapperTests.java @@ -180,7 +180,7 @@ public class SaveContextOnUpdateOrErrorResponseWrapperTests { SaveContextOnUpdateOrErrorResponseWrapper { private SecurityContext securityContext; - public SaveContextOnUpdateOrErrorResponseWrapperStub( + SaveContextOnUpdateOrErrorResponseWrapperStub( HttpServletResponse response, boolean disableUrlRewriting) { super(response, disableUrlRewriting); } diff --git a/web/src/test/java/org/springframework/security/web/csrf/CsrfFilterTests.java b/web/src/test/java/org/springframework/security/web/csrf/CsrfFilterTests.java index cd54c70a08..a8b18f52f9 100644 --- a/web/src/test/java/org/springframework/security/web/csrf/CsrfFilterTests.java +++ b/web/src/test/java/org/springframework/security/web/csrf/CsrfFilterTests.java @@ -400,7 +400,7 @@ public class CsrfFilterTests { this.filter.setAccessDeniedHandler(null); } - private static final CsrfTokenAssert assertToken(Object token) { + private static CsrfTokenAssert assertToken(Object token) { return new CsrfTokenAssert((CsrfToken) token); } diff --git a/web/src/test/java/org/springframework/security/web/method/annotation/AuthenticationPrincipalArgumentResolverTests.java b/web/src/test/java/org/springframework/security/web/method/annotation/AuthenticationPrincipalArgumentResolverTests.java index 7598a9b012..9a4ac218c4 100644 --- a/web/src/test/java/org/springframework/security/web/method/annotation/AuthenticationPrincipalArgumentResolverTests.java +++ b/web/src/test/java/org/springframework/security/web/method/annotation/AuthenticationPrincipalArgumentResolverTests.java @@ -271,7 +271,7 @@ public class AuthenticationPrincipalArgumentResolverTests { this.property = property; } - public CopyUserPrincipal(CopyUserPrincipal toCopy) { + CopyUserPrincipal(CopyUserPrincipal toCopy) { this.property = toCopy.property; } diff --git a/web/src/test/java/org/springframework/security/web/reactive/result/method/annotation/CurrentSecurityContextArgumentResolverTests.java b/web/src/test/java/org/springframework/security/web/reactive/result/method/annotation/CurrentSecurityContextArgumentResolverTests.java index 81df04336f..8f3e6b7fc4 100644 --- a/web/src/test/java/org/springframework/security/web/reactive/result/method/annotation/CurrentSecurityContextArgumentResolverTests.java +++ b/web/src/test/java/org/springframework/security/web/reactive/result/method/annotation/CurrentSecurityContextArgumentResolverTests.java @@ -314,7 +314,7 @@ public class CurrentSecurityContextArgumentResolverTests { static class CustomSecurityContext implements SecurityContext { private Authentication authentication; - public CustomSecurityContext(Authentication authentication) { + CustomSecurityContext(Authentication authentication) { this.authentication = authentication; } @Override