Compare commits

...

9 Commits

Author SHA1 Message Date
Ferenc Hammerl 7b24f92e45
Update proxy.test.ts 2023-03-02 14:51:56 +01:00
Ferenc Hammerl 4fefed4466 Fix linting 2023-03-02 13:48:37 +00:00
Ferenc Hammerl b511bc151f Better ipv6 definitions 2023-03-02 11:36:03 +00:00
Ferenc Hammerl 5d8e1ee68b
Update proxy.ts 2023-03-02 11:38:57 +01:00
Ferenc Hammerl e4ae385d1a Fix linting 2023-03-01 16:29:38 +00:00
Ferenc Hammerl b708d5ba60 Fix formatting 2023-03-01 15:30:55 +00:00
Ferenc Hammerl 4557cd07bb Restore accidentally deleted test 2023-03-01 15:25:23 +00:00
Ferenc Hammerl c285ab1ccd Expect empty array instead of undefined 2023-03-01 15:09:48 +00:00
Ferenc Hammerl 833d5cadab Bypass proxy on loopback IPs 2023-03-01 13:52:48 +00:00
2 changed files with 40 additions and 0 deletions

View File

@ -237,6 +237,31 @@ describe('proxy', () => {
expect(_proxyConnects).toHaveLength(0)
})
it('HttpClient bypasses proxy for loopback addresses (localhost, ::1, 127.*)', async () => {
// setup a server listening on localhost:8091
const server = http.createServer((request, response) => {
response.writeHead(200)
request.pipe(response)
})
server.listen(8091)
try {
process.env['http_proxy'] = _proxyUrl
const httpClient = new httpm.HttpClient()
let res = await httpClient.get('http://localhost:8091')
expect(res.message.statusCode).toBe(200)
res = await httpClient.get('http://127.0.0.1:8091')
expect(res.message.statusCode).toBe(200)
// no support for ipv6 for now
expect(httpClient.get('http://[::1]:8091')).rejects.toThrow()
// proxy at _proxyUrl was ignored
expect(_proxyConnects).toEqual([])
} finally {
server.close()
}
})
it('proxyAuth not set in tunnel agent when authentication is not provided', async () => {
process.env['https_proxy'] = 'http://127.0.0.1:8080'
const httpClient = new httpm.HttpClient()

View File

@ -25,6 +25,11 @@ export function checkBypass(reqUrl: URL): boolean {
return false
}
const reqHost = reqUrl.hostname
if (isLoopbackAddress(reqHost)) {
return true
}
const noProxy = process.env['no_proxy'] || process.env['NO_PROXY'] || ''
if (!noProxy) {
return false
@ -66,3 +71,13 @@ export function checkBypass(reqUrl: URL): boolean {
return false
}
function isLoopbackAddress(host: string): boolean {
const hostLower = host.toLowerCase()
return (
hostLower === 'localhost' ||
hostLower.startsWith('127.') ||
hostLower.startsWith('[::1]') ||
hostLower.startsWith('[0:0:0:0:0:0:0:1]')
)
}