root
/
vue3-core
mirror of https://github.com/vuejs/core.git
1
0
Fork 0
Code Issues Actions 11 Packages Projects Releases Wiki Activity

docs(type): remove unmount parameters (#2601)

This commit is contained in:
hiroki 2021-02-03 13:09:59 -05:00 committed by GitHub
parent 60e05eff23
commit 18b0c9a011
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
packages/runtime-core/__tests__/apiCreateApp.spec.ts
View File

@ -60,12 +60,12 @@ describe('api: createApp', () => {
const app = createApp(Comp) const app = createApp(Comp)
// warning // warning
app.unmount(root) app.unmount()
expect(`that is not mounted`).toHaveBeenWarned() expect(`that is not mounted`).toHaveBeenWarned()
app.mount(root) app.mount(root)
app.unmount(root) app.unmount()
expect(serializeInner(root)).toBe(``) expect(serializeInner(root)).toBe(``)
}) })

2
packages/runtime-core/src/apiCreateApp.ts
View File

@ -29,7 +29,7 @@ export interface App<HostElement = any> {
rootContainer: HostElement | string, rootContainer: HostElement | string,
isHydrate?: boolean isHydrate?: boolean
): ComponentPublicInstance ): ComponentPublicInstance
unmount(rootContainer: HostElement | string): void unmount(): void
provide<T>(key: InjectionKey<T> | string, value: T): this provide<T>(key: InjectionKey<T> | string, value: T): this
// internal, but we need to expose these for the server-renderer and devtools // internal, but we need to expose these for the server-renderer and devtools