root
/
vue3-core
mirror of https://github.com/vuejs/core.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

fix(runtime-core): should allow empty string and 0 as valid vnode key (#807)

This commit is contained in:
djy0 2020-03-10 04:03:57 +08:00 committed by GitHub
parent b13886b1ba
commit 54a0e93c27
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
packages/runtime-core/__tests__/vnode.spec.ts
View File

@ -38,6 +38,14 @@ describe('vnode', () => {
expect(vnode.props).toBe(null) expect(vnode.props).toBe(null)
}) })
test('valid vnode keys', () => {
let vnode
for (const key in ['', '1', -1, 0, 1, null]) {
vnode = createVNode('div', { key })
expect(vnode.key).toBe(key)
}
})
describe('class normalization', () => { describe('class normalization', () => {
test('string', () => { test('string', () => {
const vnode = createVNode('p', { class: 'foo baz' }) const vnode = createVNode('p', { class: 'foo baz' })

2
packages/runtime-core/src/vnode.ts
View File

@ -251,7 +251,7 @@ export function createVNode(
_isVNode: true, _isVNode: true,
type, type,
props, props,
key: (props !== null && props.key) || null, key: props !== null && props.key !== undefined ? props.key : null,
ref: (props !== null && props.ref) || null, ref: (props !== null && props.ref) || null,
scopeId: currentScopeId, scopeId: currentScopeId,
children: null, children: null,