From 957d3a0547e43ecf81169f5dd9663cf754ea7167 Mon Sep 17 00:00:00 2001 From: Evan You Date: Mon, 4 Nov 2019 14:42:47 -0500 Subject: [PATCH] refactor: portal should not expect ref target --- packages/runtime-core/__tests__/rendererPortal.spec.ts | 2 +- packages/runtime-core/src/renderer.ts | 6 +----- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/packages/runtime-core/__tests__/rendererPortal.spec.ts b/packages/runtime-core/__tests__/rendererPortal.spec.ts index b6fb23b03..c8f82a528 100644 --- a/packages/runtime-core/__tests__/rendererPortal.spec.ts +++ b/packages/runtime-core/__tests__/rendererPortal.spec.ts @@ -39,7 +39,7 @@ describe('renderer: portal', () => { const Comp = createComponent(() => () => h(Fragment, [ - h(Portal, { target }, h('div', 'teleported')), + h(Portal, { target: target.value }, h('div', 'teleported')), h('div', 'root') ]) ) diff --git a/packages/runtime-core/src/renderer.ts b/packages/runtime-core/src/renderer.ts index a6999e437..4185b7d45 100644 --- a/packages/runtime-core/src/renderer.ts +++ b/packages/runtime-core/src/renderer.ts @@ -680,11 +680,7 @@ export function createRenderer< isSVG: boolean, optimized: boolean ) { - let targetSelector = n2.props && n2.props.target - if (isRef(targetSelector)) { - targetSelector = targetSelector.value - } - + const targetSelector = n2.props && n2.props.target const { patchFlag, shapeFlag, children } = n2 if (n1 == null) { const target = (n2.target = isString(targetSelector)