root
/
vue3-core
mirror of https://github.com/vuejs/core.git
1
0
Fork 0
Code Issues Actions 12 Packages Projects Releases Wiki Activity

chore: optimize widht/height element check

This commit is contained in:
Evan You 2023-11-30 17:59:27 +08:00
parent 38aaa8c886
commit 9845f1d2a1
1 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
packages/runtime-dom/src/patchProp.ts
View File

@ -13,8 +13,6 @@ const isNativeOn = (key: string) =>
key.charCodeAt(2) > 96 &&
key.charCodeAt(2) < 123
const embeddedTags = ['IMG', 'VIDEO', 'CANVAS', 'SOURCE']
type DOMRendererOptions = RendererOptions<Node, Element>
export const patchProp: DOMRendererOptions['patchProp'] = (
@ -113,11 +111,11 @@ function shouldSetAsProp(
}
// #8780 the width or heigth of embedded tags must be set as attribute
if (
(key === 'width' || key === 'height') &&
embeddedTags.includes(el.tagName)
) {
return false
if (key === 'width' || key === 'height') {
const tag = el.tagName
return (
tag === 'IMG' || tag === 'VIDEO' || tag === 'CANVAS' || tag === 'SOURCE'
)
}
// native onclick with string value, must be set as attribute