mirror of https://github.com/vuejs/core.git
fix(runtime-dom): ensure only symbols are explicitly stringified during attribute patching (#11182)
close #11177
This commit is contained in:
parent
7936daebce
commit
a2e35d682d
|
@ -69,4 +69,23 @@ describe('runtime-dom: attrs patching', () => {
|
|||
patchProp(el, 'value', null, symbol)
|
||||
expect(el.value).toBe(symbol.toString())
|
||||
})
|
||||
|
||||
// #11177
|
||||
test('should allow setting value to object, leaving stringification to the element/browser', () => {
|
||||
// normal behavior
|
||||
const el = document.createElement('div')
|
||||
const obj = { toString: () => 'foo' }
|
||||
patchProp(el, 'data-test', null, obj)
|
||||
expect(el.dataset.test).toBe('foo')
|
||||
|
||||
const el2 = document.createElement('div')
|
||||
let testvalue: null | typeof obj = null
|
||||
// simulating a web component that implements its own setAttribute handler
|
||||
el2.setAttribute = (name, value) => {
|
||||
testvalue = value
|
||||
}
|
||||
patchProp(el2, 'data-test', null, obj)
|
||||
expect(el2.dataset.test).toBe(undefined)
|
||||
expect(testvalue).toBe(obj)
|
||||
})
|
||||
})
|
||||
|
|
|
@ -2,6 +2,7 @@ import {
|
|||
NOOP,
|
||||
includeBooleanAttr,
|
||||
isSpecialBooleanAttr,
|
||||
isSymbol,
|
||||
makeMap,
|
||||
} from '@vue/shared'
|
||||
import {
|
||||
|
@ -37,7 +38,10 @@ export function patchAttr(
|
|||
el.removeAttribute(key)
|
||||
} else {
|
||||
// attribute value is a string https://html.spec.whatwg.org/multipage/dom.html#attributes
|
||||
el.setAttribute(key, isBoolean ? '' : String(value))
|
||||
el.setAttribute(
|
||||
key,
|
||||
isBoolean ? '' : isSymbol(value) ? String(value) : value,
|
||||
)
|
||||
}
|
||||
}
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue