diff --git a/packages/runtime-dom/package.json b/packages/runtime-dom/package.json
index 4d71206e2..729406f7a 100644
--- a/packages/runtime-dom/package.json
+++ b/packages/runtime-dom/package.json
@@ -1,6 +1,6 @@
{
"name": "@vue/runtime-dom",
- "version": "3.5.17",
+ "version": "3.5.18",
"description": "@vue/runtime-dom",
"main": "index.js",
"module": "dist/runtime-dom.esm-bundler.js",
diff --git a/packages/server-renderer/__tests__/ssrSlot.spec.ts b/packages/server-renderer/__tests__/ssrSlot.spec.ts
index 4cc7fd97e..214e6ee84 100644
--- a/packages/server-renderer/__tests__/ssrSlot.spec.ts
+++ b/packages/server-renderer/__tests__/ssrSlot.spec.ts
@@ -111,26 +111,106 @@ describe('ssr: slot', () => {
})
test('transition slot', async () => {
+ const ReusableTransition = {
+ template: ``,
+ }
+
+ const ReusableTransitionWithAppear = {
+ template: ``,
+ }
+
expect(
await renderToString(
createApp({
components: {
- one: {
- template: ``,
- },
+ one: ReusableTransition,
},
template: `foo
`,
}),
),
).toBe(``)
+ expect(await renderToString(createApp(ReusableTransition))).toBe(``)
+
+ expect(await renderToString(createApp(ReusableTransitionWithAppear))).toBe(
+ ``,
+ )
+
+ expect(
+ await renderToString(
+ createApp({
+ components: {
+ one: ReusableTransition,
+ },
+ template: ``,
+ }),
+ ),
+ ).toBe(``)
+
expect(
await renderToString(
createApp({
components: {
- one: {
- template: ``,
- },
+ one: ReusableTransitionWithAppear,
+ },
+ template: ``,
+ }),
+ ),
+ ).toBe(``)
+
+ expect(
+ await renderToString(
+ createApp({
+ render() {
+ return h(ReusableTransition, null, {
+ default: () => null,
+ })
+ },
+ }),
+ ),
+ ).toBe(``)
+
+ expect(
+ await renderToString(
+ createApp({
+ render() {
+ return h(ReusableTransitionWithAppear, null, {
+ default: () => null,
+ })
+ },
+ }),
+ ),
+ ).toBe(``)
+
+ expect(
+ await renderToString(
+ createApp({
+ render() {
+ return h(ReusableTransitionWithAppear, null, {
+ default: () => [],
+ })
+ },
+ }),
+ ),
+ ).toBe(``)
+
+ expect(
+ await renderToString(
+ createApp({
+ render() {
+ return h(ReusableTransition, null, {
+ default: () => [],
+ })
+ },
+ }),
+ ),
+ ).toBe(``)
+
+ expect(
+ await renderToString(
+ createApp({
+ components: {
+ one: ReusableTransition,
},
template: `foo
`,
}),
diff --git a/packages/server-renderer/package.json b/packages/server-renderer/package.json
index 18ede1625..0fe43c72c 100644
--- a/packages/server-renderer/package.json
+++ b/packages/server-renderer/package.json
@@ -1,6 +1,6 @@
{
"name": "@vue/server-renderer",
- "version": "3.5.17",
+ "version": "3.5.18",
"description": "@vue/server-renderer",
"main": "index.js",
"module": "dist/server-renderer.esm-bundler.js",
diff --git a/packages/server-renderer/src/helpers/ssrRenderSlot.ts b/packages/server-renderer/src/helpers/ssrRenderSlot.ts
index 19aa4ce63..2f93a12de 100644
--- a/packages/server-renderer/src/helpers/ssrRenderSlot.ts
+++ b/packages/server-renderer/src/helpers/ssrRenderSlot.ts
@@ -74,6 +74,8 @@ export function ssrRenderSlotInner(
)
} else if (fallbackRenderFn) {
fallbackRenderFn()
+ } else if (transition) {
+ push(``)
}
} else {
// ssr slot.
@@ -110,13 +112,19 @@ export function ssrRenderSlotInner(
end--
}
- for (let i = start; i < end; i++) {
- push(slotBuffer[i])
+ if (start < end) {
+ for (let i = start; i < end; i++) {
+ push(slotBuffer[i])
+ }
+ } else if (transition) {
+ push(``)
}
}
}
} else if (fallbackRenderFn) {
fallbackRenderFn()
+ } else if (transition) {
+ push(``)
}
}
diff --git a/packages/shared/package.json b/packages/shared/package.json
index 648179768..63a10598c 100644
--- a/packages/shared/package.json
+++ b/packages/shared/package.json
@@ -1,6 +1,6 @@
{
"name": "@vue/shared",
- "version": "3.5.17",
+ "version": "3.5.18",
"description": "internal utils shared across @vue packages",
"main": "index.js",
"module": "dist/shared.esm-bundler.js",
diff --git a/packages/vue-compat/package.json b/packages/vue-compat/package.json
index 091dc1030..dbb356958 100644
--- a/packages/vue-compat/package.json
+++ b/packages/vue-compat/package.json
@@ -1,6 +1,6 @@
{
"name": "@vue/compat",
- "version": "3.5.17",
+ "version": "3.5.18",
"description": "Vue 3 compatibility build for Vue 2",
"main": "index.js",
"module": "dist/vue.runtime.esm-bundler.js",
diff --git a/packages/vue/__tests__/e2e/memory-leak.spec.ts b/packages/vue/__tests__/e2e/memory-leak.spec.ts
new file mode 100644
index 000000000..2412cea2b
--- /dev/null
+++ b/packages/vue/__tests__/e2e/memory-leak.spec.ts
@@ -0,0 +1,85 @@
+import { E2E_TIMEOUT, setupPuppeteer } from './e2eUtils'
+import path from 'node:path'
+
+const { page, html, click } = setupPuppeteer()
+
+beforeEach(async () => {
+ await page().setContent(``)
+ await page().addScriptTag({
+ path: path.resolve(__dirname, '../../dist/vue.global.js'),
+ })
+})
+
+describe('not leaking', async () => {
+ // #13661
+ test(
+ 'cached text vnodes should not retaining detached DOM nodes',
+ async () => {
+ const client = await page().createCDPSession()
+ await page().evaluate(async () => {
+ const { createApp, ref } = (window as any).Vue
+ createApp({
+ components: {
+ Comp1: {
+ template: `
+
+ {{ test.length }}
+ `,
+ setup() {
+ const test = ref([...Array(3000)].map((_, i) => ({ i })))
+ // @ts-expect-error
+ window.__REF__ = new WeakRef(test)
+
+ return { test }
+ },
+ },
+ Comp2: {
+ template: `comp2
`,
+ },
+ },
+ template: `
+
+
+
+
+ text node
+
+
+ `,
+ setup() {
+ const toggle = ref(true)
+ const click = () => (toggle.value = !toggle.value)
+ return { toggle, click }
+ },
+ }).mount('#app')
+ })
+
+ expect(await html('#app')).toBe(
+ `` +
+ `` +
+ `
` +
+ `
comp2
` +
+ ` text node ` +
+ `` +
+ `` +
+ `3000
`,
+ )
+
+ await click('#toggleBtn')
+ expect(await html('#app')).toBe(
+ ``,
+ )
+
+ const isCollected = async () =>
+ // @ts-expect-error
+ await page().evaluate(() => window.__REF__.deref() === undefined)
+
+ while ((await isCollected()) === false) {
+ await client.send('HeapProfiler.collectGarbage')
+ }
+
+ expect(await isCollected()).toBe(true)
+ },
+ E2E_TIMEOUT,
+ )
+})
diff --git a/packages/vue/package.json b/packages/vue/package.json
index 5d5704cb3..897bdec9e 100644
--- a/packages/vue/package.json
+++ b/packages/vue/package.json
@@ -1,6 +1,6 @@
{
"name": "vue",
- "version": "3.5.17",
+ "version": "3.5.18",
"description": "The progressive JavaScript framework for building modern web UI.",
"main": "index.js",
"module": "dist/vue.runtime.esm-bundler.js",