root
/
vue3-core
mirror of https://github.com/vuejs/core.git
1
0
Fork 0
Code Issues Actions 4 Packages Projects Releases Wiki Activity

fix(runtime-core): avoid rendering plain object as VNode (#12038) 

close #12035
close vitejs/vite-plugin-vue#353
This commit is contained in:
edison 2024-09-26 17:08:48 +08:00 committed by GitHub
parent faf55a15d7
commit cb34b28a4a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 10 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
packages/runtime-core/__tests__/rendererChildren.spec.ts
View File

@ -65,6 +65,15 @@ test('array children -> text children', () => {
expect(inner(root)).toBe('<div>hello</div>') expect(inner(root)).toBe('<div>hello</div>')
}) })
test('plain object child', () => {
const root = nodeOps.createElement('div')
const foo = { foo: '1' }
// @ts-expect-error
render(h('div', null, [foo]), root)
expect('Invalid VNode type').not.toHaveBeenWarned()
expect(inner(root)).toBe('<div>[object Object]</div>')
})
describe('renderer: keyed children', () => { describe('renderer: keyed children', () => {
let root: TestElement let root: TestElement
let elm: TestElement let elm: TestElement

2
packages/runtime-core/src/vnode.ts
View File

@ -793,7 +793,7 @@ export function normalizeVNode(child: VNodeChild): VNode {
// #3666, avoid reference pollution when reusing vnode // #3666, avoid reference pollution when reusing vnode
child.slice(), child.slice(),
) )
} else if (typeof child === 'object') { } else if (isVNode(child)) {
// already vnode, this should be the most common since compiled templates // already vnode, this should be the most common since compiled templates
// always produce all-vnode children arrays // always produce all-vnode children arrays
return cloneIfMounted(child) return cloneIfMounted(child)