mirror of https://github.com/vuejs/core.git
fix(custom-element): correctly handle number type props in prod (#8989)
Co-authored-by: autofix-ci[bot] <114827586+autofix-ci[bot]@users.noreply.github.com>
This commit is contained in:
parent
af5df91e95
commit
d74d364d62
|
@ -18,6 +18,66 @@ return { props, bar }
|
|||
}"
|
||||
`;
|
||||
|
||||
exports[`defineProps > custom element retains the props type & default value & production mode 1`] = `
|
||||
"import { defineComponent as _defineComponent } from 'vue'
|
||||
interface Props {
|
||||
foo?: number;
|
||||
}
|
||||
|
||||
export default /*#__PURE__*/_defineComponent({
|
||||
__name: 'app.ce',
|
||||
props: {
|
||||
foo: { default: 5.5, type: Number }
|
||||
},
|
||||
setup(__props: any, { expose: __expose }) {
|
||||
__expose();
|
||||
|
||||
const props = __props;
|
||||
|
||||
return { props }
|
||||
}
|
||||
|
||||
})"
|
||||
`;
|
||||
|
||||
exports[`defineProps > custom element retains the props type & production mode 1`] = `
|
||||
"import { defineComponent as _defineComponent } from 'vue'
|
||||
|
||||
export default /*#__PURE__*/_defineComponent({
|
||||
__name: 'app.ce',
|
||||
props: {
|
||||
foo: {type: Number}
|
||||
},
|
||||
setup(__props: any, { expose: __expose }) {
|
||||
__expose();
|
||||
|
||||
const props = __props
|
||||
|
||||
return { props }
|
||||
}
|
||||
|
||||
})"
|
||||
`;
|
||||
|
||||
exports[`defineProps > custom element retains the props type w/ production mode 1`] = `
|
||||
"import { defineComponent as _defineComponent } from 'vue'
|
||||
|
||||
export default /*#__PURE__*/_defineComponent({
|
||||
__name: 'app.ce',
|
||||
props: {
|
||||
foo: {type: Number}
|
||||
},
|
||||
setup(__props: any, { expose: __expose }) {
|
||||
__expose();
|
||||
|
||||
const props = __props
|
||||
|
||||
return { props }
|
||||
}
|
||||
|
||||
})"
|
||||
`;
|
||||
|
||||
exports[`defineProps > defineProps w/ runtime options 1`] = `
|
||||
"import { defineComponent as _defineComponent } from 'vue'
|
||||
|
||||
|
|
|
@ -710,4 +710,35 @@ const props = defineProps({ foo: String })
|
|||
'da-sh': BindingTypes.PROPS
|
||||
})
|
||||
})
|
||||
|
||||
// #8989
|
||||
test('custom element retains the props type & production mode', () => {
|
||||
const { content } = compile(
|
||||
`<script setup lang="ts">
|
||||
const props = defineProps<{ foo: number}>()
|
||||
</script>`,
|
||||
{ isProd: true, customElement: filename => /\.ce\.vue$/.test(filename) },
|
||||
{ filename: 'app.ce.vue' }
|
||||
)
|
||||
|
||||
expect(content).toMatch(`foo: {type: Number}`)
|
||||
assertCode(content)
|
||||
})
|
||||
|
||||
test('custom element retains the props type & default value & production mode', () => {
|
||||
const { content } = compile(
|
||||
`<script setup lang="ts">
|
||||
interface Props {
|
||||
foo?: number;
|
||||
}
|
||||
const props = withDefaults(defineProps<Props>(), {
|
||||
foo: 5.5,
|
||||
});
|
||||
</script>`,
|
||||
{ isProd: true, customElement: filename => /\.ce\.vue$/.test(filename) },
|
||||
{ filename: 'app.ce.vue' }
|
||||
)
|
||||
expect(content).toMatch(`foo: { default: 5.5, type: Number }`)
|
||||
assertCode(content)
|
||||
})
|
||||
})
|
||||
|
|
|
@ -130,6 +130,10 @@ export interface SFCScriptCompileOptions {
|
|||
* using it, disable this and switch to the [Vue Macros implementation](https://vue-macros.sxzz.moe/features/reactivity-transform.html).
|
||||
*/
|
||||
reactivityTransform?: boolean
|
||||
/**
|
||||
* Transform Vue SFCs into custom elements.
|
||||
*/
|
||||
customElement?: boolean | ((filename: string) => boolean)
|
||||
}
|
||||
|
||||
export interface ImportBinding {
|
||||
|
|
|
@ -12,6 +12,7 @@ import { TypeScope } from './resolveType'
|
|||
export class ScriptCompileContext {
|
||||
isJS: boolean
|
||||
isTS: boolean
|
||||
isCE = false
|
||||
|
||||
scriptAst: Program | null
|
||||
scriptSetupAst: Program | null
|
||||
|
@ -95,6 +96,14 @@ export class ScriptCompileContext {
|
|||
scriptSetupLang === 'ts' ||
|
||||
scriptSetupLang === 'tsx'
|
||||
|
||||
const customElement = options.customElement
|
||||
const filename = this.descriptor.filename
|
||||
if (customElement) {
|
||||
this.isCE =
|
||||
typeof customElement === 'boolean'
|
||||
? customElement
|
||||
: customElement(filename)
|
||||
}
|
||||
// resolve parser plugins
|
||||
const plugins: ParserPlugin[] = resolveParserPlugins(
|
||||
(scriptLang || scriptSetupLang)!,
|
||||
|
|
|
@ -276,6 +276,17 @@ function genRuntimePropFromType(
|
|||
defaultString
|
||||
])} }`
|
||||
} else {
|
||||
// #8989 for custom element, should keep the type
|
||||
if (ctx.isCE) {
|
||||
if (defaultString) {
|
||||
return `${finalKey}: ${`{ ${defaultString}, type: ${toRuntimeTypeString(
|
||||
type
|
||||
)} }`}`
|
||||
} else {
|
||||
return `${finalKey}: {type: ${toRuntimeTypeString(type)}}`
|
||||
}
|
||||
}
|
||||
|
||||
// production: checks are useless
|
||||
return `${finalKey}: ${defaultString ? `{ ${defaultString} }` : `{}`}`
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue