From d9de6caecdada62b29ad6836c0580b119f47523c Mon Sep 17 00:00:00 2001
From: Evan You <yyx990803@gmail.com>
Date: Wed, 26 Oct 2022 15:17:25 +0800
Subject: [PATCH] refactor: move toNumber call out of loop

---
 packages/reactivity/src/effect.ts | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/packages/reactivity/src/effect.ts b/packages/reactivity/src/effect.ts
index 8a54372cd..f1799a62d 100644
--- a/packages/reactivity/src/effect.ts
+++ b/packages/reactivity/src/effect.ts
@@ -276,8 +276,9 @@ export function trigger(
     // trigger all effects for target
     deps = [...depsMap.values()]
   } else if (key === 'length' && isArray(target)) {
+    const newLength = toNumber(newValue)
     depsMap.forEach((dep, key) => {
-      if (key === 'length' || key >= toNumber(newValue)) {
+      if (key === 'length' || key >= newLength) {
         deps.push(dep)
       }
     })