mirror of https://github.com/vuejs/core.git
fix(custom-element): properly set kebab-case props on Vue custom elements
close #12030 close #12032
This commit is contained in:
parent
a77b95992a
commit
ea3efa09e0
|
@ -223,6 +223,21 @@ describe('defineCustomElement', () => {
|
||||||
expect(e.getAttribute('baz-qux')).toBe('four')
|
expect(e.getAttribute('baz-qux')).toBe('four')
|
||||||
})
|
})
|
||||||
|
|
||||||
|
test('props via hyphen property', async () => {
|
||||||
|
const Comp = defineCustomElement({
|
||||||
|
props: {
|
||||||
|
fooBar: Boolean,
|
||||||
|
},
|
||||||
|
render() {
|
||||||
|
return 'Comp'
|
||||||
|
},
|
||||||
|
})
|
||||||
|
customElements.define('my-el-comp', Comp)
|
||||||
|
render(h('my-el-comp', { 'foo-bar': true }), container)
|
||||||
|
const el = container.children[0]
|
||||||
|
expect((el as any).outerHTML).toBe('<my-el-comp foo-bar=""></my-el-comp>')
|
||||||
|
})
|
||||||
|
|
||||||
test('attribute -> prop type casting', async () => {
|
test('attribute -> prop type casting', async () => {
|
||||||
const E = defineCustomElement({
|
const E = defineCustomElement({
|
||||||
props: {
|
props: {
|
||||||
|
|
|
@ -3,7 +3,13 @@ import { patchStyle } from './modules/style'
|
||||||
import { patchAttr } from './modules/attrs'
|
import { patchAttr } from './modules/attrs'
|
||||||
import { patchDOMProp } from './modules/props'
|
import { patchDOMProp } from './modules/props'
|
||||||
import { patchEvent } from './modules/events'
|
import { patchEvent } from './modules/events'
|
||||||
import { isFunction, isModelListener, isOn, isString } from '@vue/shared'
|
import {
|
||||||
|
camelize,
|
||||||
|
isFunction,
|
||||||
|
isModelListener,
|
||||||
|
isOn,
|
||||||
|
isString,
|
||||||
|
} from '@vue/shared'
|
||||||
import type { RendererOptions } from '@vue/runtime-core'
|
import type { RendererOptions } from '@vue/runtime-core'
|
||||||
import type { VueElement } from './apiCustomElement'
|
import type { VueElement } from './apiCustomElement'
|
||||||
|
|
||||||
|
@ -51,6 +57,12 @@ export const patchProp: DOMRendererOptions['patchProp'] = (
|
||||||
) {
|
) {
|
||||||
patchAttr(el, key, nextValue, isSVG, parentComponent, key !== 'value')
|
patchAttr(el, key, nextValue, isSVG, parentComponent, key !== 'value')
|
||||||
}
|
}
|
||||||
|
} else if (
|
||||||
|
// #11081 force set props for possible async custom element
|
||||||
|
(el as VueElement)._isVueCE &&
|
||||||
|
(/[A-Z]/.test(key) || !isString(nextValue))
|
||||||
|
) {
|
||||||
|
patchDOMProp(el, camelize(key), nextValue, parentComponent)
|
||||||
} else {
|
} else {
|
||||||
// special case for <input v-model type="checkbox"> with
|
// special case for <input v-model type="checkbox"> with
|
||||||
// :true-value & :false-value
|
// :true-value & :false-value
|
||||||
|
@ -128,14 +140,5 @@ function shouldSetAsProp(
|
||||||
return false
|
return false
|
||||||
}
|
}
|
||||||
|
|
||||||
if (key in el) {
|
return key in el
|
||||||
return true
|
|
||||||
}
|
|
||||||
|
|
||||||
// #11081 force set props for possible async custom element
|
|
||||||
if ((el as VueElement)._isVueCE && (/[A-Z]/.test(key) || !isString(value))) {
|
|
||||||
return true
|
|
||||||
}
|
|
||||||
|
|
||||||
return false
|
|
||||||
}
|
}
|
||||||
|
|
Loading…
Reference in New Issue