root
/
vue3-core
mirror of https://github.com/vuejs/core.git
1
0
Fork 0
Code Issues Actions 6 Packages Projects Releases Wiki Activity

chore: improve event value validation message

This commit is contained in:
Evan You 2024-04-15 23:39:59 +08:00
parent 9da34d7af8
commit f26d56601c
No known key found for this signature in database
GPG Key ID: B9D421896CA450FB
2 changed files with 5 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
packages/runtime-dom/__tests__/patchEvents.spec.ts
View File

@ -198,9 +198,8 @@ describe(`runtime-dom: events patching`, () => {
patchProp(el, 'onClick', null, 'test') patchProp(el, 'onClick', null, 'test')
el.dispatchEvent(new Event('click')) el.dispatchEvent(new Event('click'))
expect( expect(
'[Vue warn]: Wrong type passed to the event invoker, ' + `Wrong type passed as event handler to onClick - did you forget @ or : ` +
'did you maybe forget @ or : in front of your prop?' + `in front of your prop?\nExpected function or array of functions, received type string.`,
'\nReceived onClick="test"',
).toHaveBeenWarned() ).toHaveBeenWarned()
}) })
}) })

7
packages/runtime-dom/src/modules/events.ts
View File

@ -1,4 +1,4 @@
import { NOOP, hyphenate, isArray, isFunction, isString } from '@vue/shared' import { NOOP, hyphenate, isArray, isFunction } from '@vue/shared'
import { import {
type ComponentInternalInstance, type ComponentInternalInstance,
ErrorCodes, ErrorCodes,
@ -129,9 +129,8 @@ function sanitizeEventValue(value: unknown, propName: string): EventValue {
return value as EventValue return value as EventValue
} }
warn( warn(
`Wrong type passed to the event invoker, did you maybe forget @ or : ` + `Wrong type passed as event handler to ${propName} - did you forget @ or : ` +
`in front of your prop?\nReceived ` + `in front of your prop?\nExpected function or array of functions, received type ${typeof value}.`,
`${propName}=${isString(value) ? JSON.stringify(value) : `[${typeof value}]`}`,
) )
return NOOP return NOOP
} }