root
/
vue3-core
mirror of https://github.com/vuejs/core.git
1
0
Fork 0
Code Issues Actions 3 Packages Projects Releases Wiki Activity

fix(watch): remove instance unmounted short circuit in getter of `watchEffect` (#9948)

This commit is contained in:
Yang Mingshan 2024-01-03 18:09:53 +08:00 committed by GitHub
parent 6de0c55661
commit f300a4001e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 1 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
packages/runtime-core/src/apiWatch.ts
View File

@ -5,7 +5,6 @@ import {
ReactiveEffect, ReactiveEffect,
ReactiveFlags, ReactiveFlags,
type Ref, type Ref,
getCurrentScope,
isReactive, isReactive,
isRef, isRef,
isShallow, isShallow,
@ -220,8 +219,7 @@ function doWatch(
) )
} }
const instance = const instance = currentInstance
getCurrentScope() === currentInstance?.scope ? currentInstance : null
const reactiveGetter = (source: object) => const reactiveGetter = (source: object) =>
deep === true deep === true
? source // traverse will happen in wrapped getter below ? source // traverse will happen in wrapped getter below
@ -261,9 +259,6 @@ function doWatch(
} else { } else {
// no cb -> simple effect // no cb -> simple effect
getter = () => { getter = () => {
if (instance && instance.isUnmounted) {
return
}
if (cleanup) { if (cleanup) {
cleanup() cleanup()
} }