From 23e9ba32e10bb47f0c493f880fe5028d4ea30666 Mon Sep 17 00:00:00 2001 From: Thomas Faller Date: Sun, 16 Mar 2025 17:00:16 +0100 Subject: [PATCH] fix: excessive calls of getAllReferences --- lib/javascript/JavascriptModulesPlugin.js | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/lib/javascript/JavascriptModulesPlugin.js b/lib/javascript/JavascriptModulesPlugin.js index 89defcf0a..1481b12a4 100644 --- a/lib/javascript/JavascriptModulesPlugin.js +++ b/lib/javascript/JavascriptModulesPlugin.js @@ -1606,12 +1606,6 @@ class JavascriptModulesPlugin { } for (const variable of info.variables) { - allUsedNames.add(variable.name); - const references = getAllReferences(variable); - const allIdentifiers = new Set( - references.map(r => r.identifier).concat(variable.identifiers) - ); - const usedNamesInScopeInfo = new Map(); const ignoredScopes = new Set(); @@ -1624,6 +1618,9 @@ class JavascriptModulesPlugin { if (allUsedNames.has(name) || usedNames.has(name)) { const references = getAllReferences(variable); + const allIdentifiers = new Set( + references.map(r => r.identifier).concat(variable.identifiers) + ); for (const ref of references) { addScopeSymbols( ref.from, @@ -1658,9 +1655,8 @@ class JavascriptModulesPlugin { } source.replace(r[0], r[1] - 1, newName); } - } else { - allUsedNames.add(name); } + allUsedNames.add(name); } renamedInlinedModules.set(m, source);