root
/
webpack
mirror of https://github.com/webpack/webpack.git
1
0
Fork 0
Code Issues Actions 1 Packages Projects Releases Wiki Activity

(fix): rmdir with node 10

This commit is contained in:
Sergey Melyukov 2020-10-01 10:59:28 +03:00
parent 5934075f36
commit 07add52bf1
1 changed files with 34 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

45
lib/CleanPlugin.js
View File

@ -10,6 +10,7 @@ const validateOptions = require("schema-utils");
const schema = require("../schemas/plugins/CleanPlugin.json");
/** @typedef {import("../declarations/plugins/CleanPlugin").CleanPluginArgument} CleanPluginArgument */
/** @typedef {import("./Compiler")} Compiler */
/**
@ -49,6 +50,29 @@ function readDir(outputFS, from) {
};
}
/**
* @param {import("./util/fs").OutputFileSystem} outputFS output fs
* @param {string} directory from directory
*/
const deleteFolderRecursive = (outputFS, directory) => {
// webpack supports node 10, but node 10 does not support fs.rmdir recursive option
if (!outputFS.existsSync(directory)) {
return;
}
for (const item of outputFS.readdirSync(directory)) {
const curPath = path.join(directory, item);
if (outputFS.statSync(curPath).isDirectory()) {
deleteFolderRecursive(outputFS, curPath);
} else {
outputFS.unlinkSync(curPath);
}
}
outputFS.rmdirSync(directory);
};
class CleanPlugin {
/**
* @param {CleanPluginArgument} [options] options
@ -70,25 +94,24 @@ class CleanPlugin {
*/
apply(compiler) {
let emittedOnce = false;
let outputPath;
const logger = compiler.getInfrastructureLogger("webpack.Clean");
const handleDir = (outputPath, directory) => {
const handleDir = directory => {
if (this.options.dry) {
logger.info(`Directory [${directory}] will be removed in non-dry mode`);
} else {
const abs = path.join(outputPath, directory);
if (compiler.outputFileSystem.existsSync(abs)) {
compiler.outputFileSystem.rmdirSync(abs, {
recursive: true
});
}
deleteFolderRecursive(compiler.outputFileSystem, abs);
}
};
const handleFile = (outputPath, file) => {
const handleFile = file => {
if (this.options.dry) {
logger.info(`Asset [${file}] will be removed in non-dry mode`);
} else {
const abs = path.join(outputPath, file);
compiler.outputFileSystem.unlinkSync(abs);
if (compiler.outputFileSystem.existsSync(abs)) {
compiler.outputFileSystem.unlinkSync(abs);
}
}
};
@ -103,7 +126,7 @@ class CleanPlugin {
return;
}
const outputPath = compilation.getPath(compiler.outputPath, {});
outputPath = compilation.getPath(compiler.outputPath, {});
if (
!compiler.outputFileSystem ||
@ -128,13 +151,13 @@ class CleanPlugin {
for (const file of collected.files) {
if (!(file in compilation.assets)) {
handleFile(outputPath, file);
handleFile(file);
}
}
for (const directory of collected.directories) {
if (!assetsDirectories.has(directory)) {
handleDir(outputPath, directory);
handleDir(directory);
}
}