From 2740fda412ca23d4d632ab226fd75adae3809c69 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Wed, 8 Jan 2020 23:26:54 +0530 Subject: [PATCH 1/5] refactor: make use of destructuring possibilities --- lib/DelegatedModuleFactoryPlugin.js | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/DelegatedModuleFactoryPlugin.js b/lib/DelegatedModuleFactoryPlugin.js index 16760b770..034c1b17d 100644 --- a/lib/DelegatedModuleFactoryPlugin.js +++ b/lib/DelegatedModuleFactoryPlugin.js @@ -32,8 +32,8 @@ class DelegatedModuleFactoryPlugin { normalModuleFactory.hooks.factorize.tapAsync( "DelegatedModuleFactoryPlugin", (data, callback) => { - const dependency = data.dependencies[0]; - const request = dependency.request; + const [dependency] = data.dependencies; + const {request} = dependency.request; if (request && request.indexOf(scope + "/") === 0) { const innerRequest = "." + request.substr(scope.length); let resolved; From 00c0091afedc1460073b257ec67e92abbdb1b0fd Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Wed, 8 Jan 2020 23:32:44 +0530 Subject: [PATCH 2/5] fix: lint --- lib/DelegatedModuleFactoryPlugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DelegatedModuleFactoryPlugin.js b/lib/DelegatedModuleFactoryPlugin.js index 034c1b17d..42845f072 100644 --- a/lib/DelegatedModuleFactoryPlugin.js +++ b/lib/DelegatedModuleFactoryPlugin.js @@ -33,7 +33,7 @@ class DelegatedModuleFactoryPlugin { "DelegatedModuleFactoryPlugin", (data, callback) => { const [dependency] = data.dependencies; - const {request} = dependency.request; + const { request } = dependency.request; if (request && request.indexOf(scope + "/") === 0) { const innerRequest = "." + request.substr(scope.length); let resolved; From f3e3e394e344d61fe4c5e3123c8a509b4d16df09 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Wed, 8 Jan 2020 23:33:04 +0530 Subject: [PATCH 3/5] fix: minor tweak --- lib/DelegatedModuleFactoryPlugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DelegatedModuleFactoryPlugin.js b/lib/DelegatedModuleFactoryPlugin.js index 42845f072..693c90846 100644 --- a/lib/DelegatedModuleFactoryPlugin.js +++ b/lib/DelegatedModuleFactoryPlugin.js @@ -33,7 +33,7 @@ class DelegatedModuleFactoryPlugin { "DelegatedModuleFactoryPlugin", (data, callback) => { const [dependency] = data.dependencies; - const { request } = dependency.request; + const { request } = dependency; if (request && request.indexOf(scope + "/") === 0) { const innerRequest = "." + request.substr(scope.length); let resolved; From b399c00bf5435244bec6c951bb83c4c502d64075 Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Wed, 8 Jan 2020 23:33:36 +0530 Subject: [PATCH 4/5] refactor: use startsWith --- lib/DelegatedModuleFactoryPlugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DelegatedModuleFactoryPlugin.js b/lib/DelegatedModuleFactoryPlugin.js index 693c90846..af79121b3 100644 --- a/lib/DelegatedModuleFactoryPlugin.js +++ b/lib/DelegatedModuleFactoryPlugin.js @@ -34,7 +34,7 @@ class DelegatedModuleFactoryPlugin { (data, callback) => { const [dependency] = data.dependencies; const { request } = dependency; - if (request && request.indexOf(scope + "/") === 0) { + if (request && request.startsWith(scope + "/")) { const innerRequest = "." + request.substr(scope.length); let resolved; if (innerRequest in this.options.content) { From 2b0af7c4e721bde1a26718e21ab1724bc2438a1f Mon Sep 17 00:00:00 2001 From: jamesgeorge007 Date: Wed, 8 Jan 2020 23:34:41 +0530 Subject: [PATCH 5/5] refactor: use template literals --- lib/DelegatedModuleFactoryPlugin.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/DelegatedModuleFactoryPlugin.js b/lib/DelegatedModuleFactoryPlugin.js index af79121b3..3c899c454 100644 --- a/lib/DelegatedModuleFactoryPlugin.js +++ b/lib/DelegatedModuleFactoryPlugin.js @@ -34,7 +34,7 @@ class DelegatedModuleFactoryPlugin { (data, callback) => { const [dependency] = data.dependencies; const { request } = dependency; - if (request && request.startsWith(scope + "/")) { + if (request && request.startsWith(`${scope}/`)) { const innerRequest = "." + request.substr(scope.length); let resolved; if (innerRequest in this.options.content) {