From 33d9f7bdbf3546c811d91f14ad4a125bce0cb91d Mon Sep 17 00:00:00 2001
From: Tobias Koppers <tobias.koppers@googlemail.com>
Date: Tue, 17 Dec 2019 11:24:23 +0100
Subject: [PATCH] bugfix: candiates should only be added when adding was
 successful

---
 lib/optimize/ModuleConcatenationPlugin.js | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/lib/optimize/ModuleConcatenationPlugin.js b/lib/optimize/ModuleConcatenationPlugin.js
index 94ce1a965..12d6f662b 100644
--- a/lib/optimize/ModuleConcatenationPlugin.js
+++ b/lib/optimize/ModuleConcatenationPlugin.js
@@ -315,12 +315,13 @@ class ModuleConcatenationPlugin {
 								// _tryToAdd modifies the config even if it fails
 								// so make sure to only accept changes when it succeed
 								const backup = currentConfiguration.snapshot();
+								const impCandiates = new Set();
 								const problem = this._tryToAdd(
 									compilation,
 									currentConfiguration,
 									imp,
 									possibleInners,
-									candidates,
+									impCandiates,
 									failureCache
 								);
 								if (problem) {
@@ -329,6 +330,10 @@ class ModuleConcatenationPlugin {
 
 									// roll back
 									currentConfiguration.rollback(backup);
+								} else {
+									for (const c of impCandiates) {
+										candidates.add(c);
+									}
 								}
 							}
 							if (!currentConfiguration.isEmpty()) {